[PATCH] D32480: clang-format: Add CompactNamespaces option

Typz updated this revision to Diff 102528. Typz marked an inline comment as done. Typz added a comment. Move tests that add or fix namespace end comments to NamespaceEndCommentsFixerTest.cpp https://reviews.llvm.org/D32480 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Fo

[PATCH] D32480: clang-format: Add CompactNamespaces option

This revision was automatically updated to reflect the committed changes. Closed by commit rL305384: clang-format: Add CompactNamespaces option (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D32480?vs=102528&id=102531#toc Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. @krasimir : ping https://reviews.llvm.org/D33589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz created this revision. Herald added a subscriber: klimek. This patch tries to avoid binpacking when initializing lists/arrays, to allow things like: static int types[] = { registerType1(), registerType2(), registerType3(), }; std::map x = { { 0, "foo fjakfjaklf

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz added a comment. This patch is probably not complete, though it works fine in all situations I could think of: nested initializers, "short" statement (properly merged), column layout is still performed when needed... static int types[] = { SourcePrivate::registerTypes(), regi

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz added a comment. In https://reviews.llvm.org/D34238#781224, @malcolm.parsons wrote: > Some people write > > auto x = std::map{ >{ 0, "foo fjakfjaklf kljj" }, >{ 1, "bar fjakfjaklf kljj" }, >{ 2, "stuff fjakfjaklf kljj" }, >}; This case (and other way `std::map

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 102672. Typz added a comment. fix unit tests https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp unittests/Format/FormatTestComments.cpp Index: unittests/Format/FormatTestComments.cpp ==

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

Typz updated this revision to Diff 102803. Typz added a comment. Fix incorrect labelling as ObjCMethodExpr https://reviews.llvm.org/D33491 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 102808. Typz marked an inline comment as done. Typz added a comment. remove special case after assignment https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 102809. Typz added a comment. fix indent https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

[PATCH] D33823: [clang-format] Support sorting using declarations

Typz added inline comments. Comment at: lib/Format/UsingDeclarationsSorter.cpp:66 + } + return HasIdentifier && Tok && Tok->isOneOf(tok::semi, tok::comma); +} could also be followed by an assignment, in case of type alias: using foo = bar::foo; https://rev

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. @krasimir, @alexfh : can I get some feedback? This patch solves a practical problem, i.e. allowing the comment to overflow a bit without triggering a reflow [according to the priorities which are in config, obviously]. It may not always provide the "best" wrapping, but as

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

Typz added a comment. ping https://reviews.llvm.org/D33491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

Typz updated this revision to Diff 103018. Typz marked 2 inline comments as done. Typz edited the summary of this revision. Typz added a comment. Fix review comments https://reviews.llvm.org/D33491 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotat

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

Typz added inline comments. Comment at: unittests/Format/FormatTest.cpp:1526 + verifyFormat("const struct A a = {[0] = 1, [1] = 2};"); + verifyFormat("const struct A a = {[1] = a,\n" + "[2] = b,\n" djasper wrote

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

This revision was automatically updated to reflect the committed changes. Closed by commit rL305696: clang-format: Fix C99 designated initializers corner cases (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D33491?vs=103018&id=103041#toc Repository: rL LLVM https://re

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 103056. Typz added a comment. Fix case where the content fits on a line, by wrapping after each comma, like this: static int types[] = { 0, 1, 2, }; https://reviews.llvm.org/D34238 Files: lib/Format/C

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 103057. Typz added a comment. Fix indentation https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp unittests/Format/FormatTestJava.cpp Index: unittests/Format/FormatTestJava.cpp

[PATCH] D34395: clang-format: add options to merge empty record body

Typz created this revision. Herald added a subscriber: klimek. This patch introduces a few extra BraceWrapping options, similar to `SplitEmptyFunction`, to allow merging empty 'record' bodies (e.g. class, struct, union and namespace): - SplitEmptyClass - SplitEmptyStruct - SplitEmptyUnion - Split

[PATCH] D34399: clang-format: introduce InlineOnly short function style

Typz created this revision. Herald added subscribers: rengolin, klimek. This is the same as Inline, except it does not imply all empty functions are merged: with this style, empty functions are merged only if they also match the 'inline' criteria (i.e. defined in a class). This is helpful to avoi

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz marked 7 inline comments as done. Typz added a comment. This style is used in the Skia project. https://reviews.llvm.org/D32478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz updated this revision to Diff 103195. Typz added a comment. Rebase & fix indentation when newline is inserted after return or equal. https://reviews.llvm.org/D32478 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/Format

[PATCH] D34395: clang-format: add options to merge empty record body

Typz updated this revision to Diff 103202. Typz added a comment. Enable merging records for Mozilla style https://reviews.llvm.org/D34395 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTe

[PATCH] D34399: clang-format: introduce InlineOnly short function style

Typz marked 3 inline comments as done. Typz added inline comments. Comment at: include/clang/Format/Format.h:234 + bool allowEmptyFunctionsOnASingleLine() const { + return AllowShortFunctionsOnASingleLine >= ShortFunctionStyle::SFS_Empty; djasper wrote: >

[PATCH] D34399: clang-format: introduce InlineOnly short function style

Typz updated this revision to Diff 103357. Typz marked an inline comment as done. Typz added a comment. Fix according to review comments https://reviews.llvm.org/D34399 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineForma

[PATCH] D34399: clang-format: introduce InlineOnly short function style

This revision was automatically updated to reflect the committed changes. Closed by commit rL305912: clang-format: introduce InlineOnly short function style (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D34399?vs=103357&id=103370#toc Repository: rL LLVM https://revie

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz added a comment. ping? https://reviews.llvm.org/D34238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz added a comment. ping? https://reviews.llvm.org/D32478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34395: clang-format: add options to merge empty record body

Typz added a comment. ping? https://reviews.llvm.org/D34395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. In https://reviews.llvm.org/D33589#789002, @alexfh wrote: > why do we want to make an exception for comments and not for regular code? This is not an exception for comments: the `PenaltyExcessCharacter` is used whenever the code is longer than the `ColumnLimit`, and used

[PATCH] D34395: clang-format: add options to merge empty record body

Typz added a comment. I don't know if some style would want different styles, and I agree with you on principle; but since the brace wrapping is already configured for each kind of record, I choose to keep things consistent and have flags for each kind of record. But I can merge the options, an

[PATCH] D33440: clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION

Typz updated this revision to Diff 103935. Typz added a comment. Complete refactor to make the processing much more generic https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenLexer.cpp lib/Format/Fo

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz updated this revision to Diff 103937. Typz added a comment. Fix typo https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenLexer.cpp lib/Format/FormatTokenLexer.h lib/Format/NamespaceEndComments

[PATCH] D34395: clang-format: add options to merge empty record body

Typz updated this revision to Diff 103939. Typz added a comment. Merge `SplitEmptyClass/Struct/Union` options into a single `SplitEmptyRecord` option. https://reviews.llvm.org/D34395 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/Unwrappe

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. ping? https://reviews.llvm.org/D37813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33440: clang-format: better handle statement macros

Typz added a comment. ping? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. OK. So you mean a solution like the one discussed earlier would be the way to go? > I mean that we can configure macros in the format style, like "define A(X) > class X {". I'm not 100% sure whether we would just try to use the > Preprocessor for this, or whether we'd wan

[PATCH] D43114: clang-format: fix formatting of ObjC @synchronized blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL326191: clang-format: fix formatting of ObjC @synchronized blocks (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43114?vs=

[PATCH] D43232: clang-format: use AfterControlStatement to format ObjC control blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL326192: clang-format: use AfterControlStatement to format ObjC control blocks (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D4

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz added a comment. >> Tweaking the penalty handling would still be needed in any case, since the >> problem happens also when Cpp11BracedListStyle is true (though the effect is >> more subtle) > > I don't understand this. Which style do you actually care about? With > Cpp11BracedListStyle=t

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz updated this revision to Diff 136081. Typz added a comment. Prevent breaking between = and { when Cpp11BracedListStyle=false. Repository: rC Clang https://reviews.llvm.org/D43290 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTes

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2183 return 0; +if (Left.Previous && Left.Previous->is(tok::equal) && +!Style.Cpp11BracedListStyle) djasper wrote: > Why is this necessary? Otherwise the `PenaltyBreakBeforeF

[PATCH] D43183: clang-format: introduce `CaseBlockIndent` to control indent in switch

Typz added a comment. > I don't agree that that's the same thing. The closing brace is still neatly > aligned with the line of the opening brace (which happens to be just the > opening brace). This invariant is not really applicable to switch statements, where code of each "branch" is already

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. In https://reviews.llvm.org/D42787#994781, @djasper wrote: > What I mean is, users will find it surprising if whether or not a parameter > gets wrapped leads to a different indentation internal to that parameter. I > have not heard of a single user that would be surprised

[PATCH] D42729: clang-format: Fix formatting of function body followed by semicolon

Typz added a comment. In https://reviews.llvm.org/D42729#994841, @djasper wrote: > - Of course you find all sorts of errors while testing clang-format on a > large-enough codebase. That doesn't mean that users run into them much. > - We have had about 10k clang-format users internally for severa

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz added a comment. In https://reviews.llvm.org/D42684#1013005, @djasper wrote: > Please given an explanation of what you are trying to achieve with this > change. Do you intend to set the penalty high so that clang-format does other > things first before falling back to wrapping template dec

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. > Some initial design work has been done, and Krasimir said that he's > interested. No timeline though :( any update or progress maybe? https://reviews.llvm.org/D37813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

Typz added a comment. ping? https://reviews.llvm.org/D32525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz added a comment. The problem I have is really related to the current `AlwaysBreakTemplateDeclarations` behavior, which does not apply to functions. I set it to false, and I get this: template<> void ( const bb

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

Typz updated this revision to Diff 136299. Typz marked 2 inline comments as done. Typz added a comment. Address review comments. Repository: rC Clang https://reviews.llvm.org/D32525 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz updated this revision to Diff 136300. Typz marked an inline comment as done. Typz added a comment. Address review comments, and rebase on https://reviews.llvm.org/D32525 Repository: rC Clang https://reviews.llvm.org/D43015 Files: docs/ClangFormatStyleOptions.rst include/clang/Format

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

Typz updated this revision to Diff 136305. Typz marked 2 inline comments as done. Typz added a comment. Address review comments Repository: rC Clang https://reviews.llvm.org/D32525 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

Typz added inline comments. Comment at: unittests/Format/FormatTest.cpp:8969 + "barr(1) {}", CtorInitializerStyle); + CtorInitializerStyle.BreakConstructorInitializers = FormatStyle::BCIS_BeforeComma; + verifyFormat("Fooo::Fooo()\n

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz updated this revision to Diff 136306. Typz added a comment. Address review comments of https://reviews.llvm.org/D32525 Repository: rC Clang https://reviews.llvm.org/D43015 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp l

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz added a comment. Indeed, seems to apply to classes as well. Maybe I was mislead by my testing, where I did not get the case (possibly because we use `ConstructorInitializerAllOnOneLineOrOnePerLine=true`, so the continuation indenter only sees "short" class declarations unless breaking the

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. In https://reviews.llvm.org/D42787#1022081, @djasper wrote: > But you *do* want extra indentation in the case of: > > function(a, >b + >cc); > > > I understand you argument, but I don't agree at the moment. As is (without > getting

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

This revision was automatically updated to reflect the committed changes. Closed by commit rC326426: [clang-format] Add SpaceBeforeColon option (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D32525?vs=136305&id=136483#toc Repository: rC Clang https://re

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

This revision was automatically updated to reflect the committed changes. Closed by commit rL326426: [clang-format] Add SpaceBeforeColon option (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D32525 Files: cfe/trunk/do

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz updated this revision to Diff 136557. Typz added a comment. Change options values to No/MultiLine/Yes. Repository: rC Clang https://reviews.llvm.org/D42684 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cp

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. If people don't care about this case, we might as well merge this :-) Just kidding. The tweak matches both our expectation, the auto-indent behaviour of IDE (not to be trusted, but still probably of 'default' behaviour for many people, esp. when you don't yet use a format

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. > Also double-checked with Richard Smith and he agrees that the current > behavior is preferable. For comma and plus this doesn't seem overly > important, but making it: > > aa(b + ccc * > d); > > > seems real

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D42684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D42684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D37813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. Would it be acceptable to introduce an option to allow enabling this behavior? I mean would it have a chance of being integrated, or must I keep maintaining a fork of clang-format... Repository: rC Clang https://reviews.llvm.org/D42787 ___

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz updated this revision to Diff 150755. Typz added a comment. rebase Repository: rC Clang https://reviews.llvm.org/D43015 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

This revision was automatically updated to reflect the committed changes. Closed by commit rC334408: clang-format: Introduce BreakInheritanceList option (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D43015?vs=150755&id=150756#toc Repository: rC Clang h

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Typz added a comment. In https://reviews.llvm.org/D42787#1127790, @djasper wrote: > The normal rule for formatting options apply. If you can dig up a public > style guide and a project of reasonable size where it is used, we can add an > option. I don't want to be rude, but it seems to me tha

[PATCH] D48161: Fix documentation generation

Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. It seems that the changes done to `ClangFormatStyleOptions.rst` @334408 are causing the generation of the documentation to fail, with the following error: Warning, treated as error: /llvm/tools/clang/docs/Clan

[PATCH] D48161: clang-format: Fix documentation generation

Typz updated this revision to Diff 151313. Typz added a comment. Add missing block, for consistency Repository: rC Clang https://reviews.llvm.org/D48161 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h ===

[PATCH] D48161: clang-format: Fix documentation generation

Typz updated this revision to Diff 151342. Typz added a comment. rebase Repository: rC Clang https://reviews.llvm.org/D48161 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h ===

[PATCH] D48161: clang-format: Fix documentation generation

This revision was automatically updated to reflect the committed changes. Closed by commit rL334709: clang-format: Fix documentation generation (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48161 Files: cfe/trunk/do

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In https://reviews.llvm.org/D50147#1272742, @sammccall wrote: > The idea here does seem to be a natural extension of -style, at least for the > case when the arg is a filename directly. I'm not opposed, happy to review > this. > > I do want to probe the use case a bit thou

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In https://reviews.llvm.org/D50147#1272742, @sammccall wrote: > Being able to discover the right style from the filesystem is powerful, and > if I was going to use this flag, I'd consider symlinking the style-file to > `subproject/.clang_format` instead. That way the setti

[PATCH] D50147: clang-format: support external styles

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50147/new/ https://reviews.llvm.org/D50147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37813/new/ https://reviews.llvm.org/D37813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. ping ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In https://reviews.llvm.org/D50147#1244237, @krasimir wrote: > I don't understand the use-case this patch is realizing. Suppose I have a > bunch of projects that have to share a format style. Then I can checkout them > under a common root directory and put an appropriate .

[PATCH] D33440: clang-format: better handle statement macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL343602: clang-format: better handle statement macros (authored by Typz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D33440?vs=158308&id=167

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. In https://reviews.llvm.org/D37813#1184051, @klimek wrote: > The problem here is that we have different opinions on how the formatting on > namespace macros should behave in the first place- I think they should behave > like namespaces, you want them to be formatted differ

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. In https://reviews.llvm.org/D37813#1254865, @klimek wrote: > In https://reviews.llvm.org/D37813#1253813, @Typz wrote: > > > In https://reviews.llvm.org/D37813#1184051, @klimek wrote: > > > > > The problem here is that we have different opinions on how the formatting > > > o

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. ping? https://reviews.llvm.org/D33589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz added a comment. ping? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz added a comment. ping? https://reviews.llvm.org/D32478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz updated this revision to Diff 114783. Typz added a comment. Rebase to master to fix merge issue https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenLexer.cpp lib/Format/FormatTokenLexer.h lib/

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1339 +unsigned ContinuationIndenter::breakProtrudingToken(const FormatToken &Current, +LineState &State, djasper wrote: > Can you cre

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz updated this revision to Diff 115051. Typz added a comment. Reorder the functions to minimize diff. https://reviews.llvm.org/D33589 Files: lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp In

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz marked 8 inline comments as done. Typz added inline comments. Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:155 const FormatToken *NamespaceTok = AnnotatedLines[StartLineIndex]->First; - // Detect "(inline)? namespace" in the beginning of a line. - if (NamespaceT

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz updated this revision to Diff 115054. Typz marked 2 inline comments as done. Typz added a comment. Fix review comments, before splitting the commit. https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/Format

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz updated this revision to Diff 115057. Typz added a comment. Split diff: handle only statements in here, namespace macros will be moved to another one. https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/For

[PATCH] D37813: clang-format: better handle namespace macros

Typz created this revision. Other macros are used to declare namespaces, and should thus be handled similarly. This is the case for crpcut's TESTSUITE macro, or for unittest-cpp's SUITE macro: TESTSUITE(Foo) { TEST(MyFirstTest) { assert(0); } } // TESTSUITE(Foo) This patch deals with

[PATCH] D33440: clang-format: better handle statement macros

Typz added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:642 tok::pp_define) && -std::find(ForEachMacros.begin(), ForEachMacros.end(), - FormatTok->Tok.getIdentifierInfo()) != ForEachMacros.end()) { - FormatTok->Type = T

<    1   2   3   4   >