[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. In D137517#4045337 , @jrtc27 wrote: > In D137517#4045315 , @fpetrogalli > wrote: > >> In D137517#4045299 , @jrtc27 wrote: >> >>> In D137517#4

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli created this revision. fpetrogalli added a reviewer: jrtc27. Herald added subscribers: luismarques, s.egerton, kadircet, PkmX, arphaman, simoncook, arichardson. Herald added a project: All. fpetrogalli requested review of this revision. Herald added subscribers: cfe-commits, pcwang-the

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a subscriber: craig.topper. fpetrogalli added a comment. @jrtc27, @thakis, @craig.topper - is this a better solution to the issue raised in https://reviews.llvm.org/D137517? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/ne

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/include/llvm/TargetParser/CMakeLists.txt:3 +tablegen(LLVM RISCVTargetParserDef.inc -gen-riscv-target-def -I ${CMAKE_SOURCE_DIR}/lib/Target/RISCV/) +add_public_tablegen_target(RISCVT

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a subscriber: mgorny. fpetrogalli added a comment. FWIW, the change in this patch solves the issue with standalone build of `clang` reported in https://reviews.llvm.org/rGac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf. (FYI, @mgorny ) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. @jrtc27, @thakis, @craig.topper - gentle ping, it would be great if I could unlock @mgorny with this patch for the issue they are seeing at https://reviews.llvm.org/rGac1ffd3caca12c254e0b8c847aa8ce8e51b6cfbf Francesco Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056464 , @lebedev.ri wrote: > Why is it not sufficient to link to `RISCVTargetParserTableGen`, but is > sufficient to link to `LLVMTargetParser`? This is because the sources of clangBasic and clangDriver might

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056492 , @tschuett wrote: > I though Clang Basic is a leaf library and must not depend on anything. I wasn't aware of this requirement. As of https://reviews.llvm.org/D137517 it depends on some auto-generated ta

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056612 , @barannikov88 wrote: > In D141581#4056503 , @fpetrogalli > wrote: > >> This is because the sources of clangBasic and clangDriver might be compiled >> before LLV

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. @barannikov88 - Imam stuck with an incomplete explanation: The issue raised by @mgorny is about stand-alone builds. In this build configuration, clang is built separately from LLVM, which is first build

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4056825 , @barannikov88 wrote: > clangBasic and clangDriver already have a dependency on TargetParser (see > LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not > enough? > Will it build if

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. Hi -has anybody any more concern on this change? I'd like to submit it as soon as possible to unlock @mgorny . Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069053 , @tstellar wrote: > [...] > It's still not clear to me why LLVM_LINK_COMPONENTS does not work. Is > LLVMTargetParser a library? Yes, `LLVMTargetParser` is a library built located in `llvm/lib/TargetParse

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069078 , @tstellar wrote: > So, what's the actual dependency here? Do libBasic and libDriver just need > the header to be generated or does it actually need to link to the library? Just the header. Repository:

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli added a comment. In D141581#4069123 , @tstellar wrote: > I don't think this is the correct way to specify dependencies if it's just an > issue of the header being included before a generated file it needs has been > generated. Are there oth

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

fpetrogalli updated this revision to Diff 491320. fpetrogalli added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. @mgorny, I have updated the patch according to the suggestions from @tstellar in https://reviews.llvm.

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:113 omp_gen - RISCVTargetParserTableGen ) tstellar wrote: > Doesn't this break the monorepo (non-standalone) build? If the monorepo > build still works with this, then you don

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. In D141581#4074312 , @tstellar wrote: > I tested this patch and it works, so I'll give it an LGTM. However, I think > the LLVMConfig.cmake.in changes are now unnecessary since the > RISCVTargetParserTableGen has been dropp

[PATCH] D141581: [build] Fix stand-alone builds of clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52bcdac3b842: [build] Fix stand-alone builds of clang. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. Ah - there you go. Without a proper chained dependency of LLVMTargetParser -> clangBasic we end up with failures if clangBasic is compiled before LLVMTargetParser is (even on non stand-alone builds). https://lab.llvm.org/buildbot/#/builders/193/builds/25362 : cca

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. Reverted in https://reviews.llvm.org/rG20ffb9aaf982 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581 ___ cfe-commits mailing list cf

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

fpetrogalli created this revision. fpetrogalli added reviewers: mgorny, tstellar. Herald added subscribers: luismarques, s.egerton, kadircet, PkmX, simoncook, arichardson. Herald added a project: All. fpetrogalli requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thea

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

fpetrogalli added a comment. In D142403#4074885 , @tstellar wrote: > This is still the wrong change IMO. I don't know, maybe I'm not being clear, > but I don't 'think you ever actually tried my suggestion in D141581 >

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

fpetrogalli updated this revision to Diff 491506. fpetrogalli added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D142403: [build] Fix stand-alone builds of clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d02e38f56df: [build] Fix stand-alone builds of clang. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142403: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. In D142403#4075215 , @tstellar wrote: > LGTM. I tested and this fixes the build. Thank you @tstellar, I landed it. I am going offline for until tomorrow morning - feel free to revert it if the world of bots collapses :) @m

[PATCH] D142403: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. In D142403#4075215 , @tstellar wrote: > LGTM. I tested and this fixes the build. @tstellar , I wonder how your build (and mine too, in fact) didn't complain about the typo... luckily the bots cover this functionality! Anywa

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, wh

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli added inline comments. Comment at: llvm/unittests/Support/Host.cpp:33 -class HostTest : public testing::Test { - Triple Host; - -protected: - bool isSupportedArchAndOS() { -// Initially this is only testing detection of the number of -// physical cores, wh

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fpetrogalli accepted this revision. fpetrogalli added a comment. LGTM. Thank you @lenary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 ___ cfe-commits mailing

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. Thank you for working on this @lenary - LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

fpetrogalli added a comment. Hi @jdoerfert , thank you for working on this. I have a couple of high level comments. 1. I am not familiar with `OpenMP technical report 8 (TR8)`. Could you please provide a link in the description? Same for PR42061, PR42798, PR42799. It would be useful to get an

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118 +#pragma omp declare simd notinbranch linear(i) +double constlinear(const int i); + Shouldn't you check that the `_ZGV *` name is generated? Repository: rG LLVM Gith

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli added inline comments. Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:327 +// CHECK-DAG: "_ZGVbN2l__Z11constlineari" +// CHECK-DAG: "_ZGVcN4l__Z11constlineari" I think we should add the same checks in the AArch64 test: `OpenMP/declare_simd_

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli accepted this revision. fpetrogalli added a comment. LGTM, thank you @huntergr ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/ https://reviews.llvm.org/D75350 ___ cfe-commits mai

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

fpetrogalli added a comment. Hi @jdoerfert , thank you for working on this! I have added some minor comments. Francesco Comment at: clang/lib/CodeGen/CodeGenModule.h:593 + llvm::OpenMPIRBuilder &getOpenMPIRBuilder() { +assert(OMPBuilder != nullptr); +return *OMPBuild

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:23 /// OpenMP directives. -enum OpenMPDirectiveKind { -#define OPENMP_DIRECTIVE(Name) \ - OMPD_##Name, -#define OPENMP_DIRECTIVE_EXT(Name, Str) \ - OMPD_##Name, -#include "clang/Basic/OpenMP

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli created this revision. fpetrogalli added a reviewer: mizvekov. Herald added a project: All. fpetrogalli requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful for retriving crash reports of LIT runs when the temporary fo

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

This revision was automatically updated to reflect the committed changes. Closed by commit rG029212617ca8: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147209

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli added a comment. In D147209#4244615 , @leonardchan wrote: > Hi. I think this led to some test failures on our builder at > https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview: Hi @l

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli added a comment. In D147209#4246622 , @leonardchan wrote: > In D147209#4245229 , @fpetrogalli > wrote: > >> In D147209#4244615 , @leonardchan >> wrote: >> >

[PATCH] D137838: [Support] Move TargetParsers to new component

fpetrogalli accepted this revision. fpetrogalli added a comment. In D137838#4000959 , @lenary wrote: > [...] I think this is ready to land on Monday? SGTM - thank you again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. Gentle ping. Thanks, Francesco https://reviews.llvm.org/D30739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:6821 + ISADataTy ISAData[] = { + {'n', 64}, // double-word Advanced SIMD + {'n', 128}, // quad-word Advanced SIMD rengolin wrote: > No f32? Sorry, I am not sure

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. In https://reviews.llvm.org/D30739#706292, @Hahnfeld wrote: > In principal looks good to me although I'm not really familiar with this > part. Does that work for you if you have the `declare simd` in a header file > and the implementation in another file? On x86_64

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. Thanks, I do not have commit rights, can anyone commit this? https://reviews.llvm.org/D30739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli planned changes to this revision. fpetrogalli added a comment. Dear all, thank you for reviewing this patch. We found out an error in the spec and would like to fix it before things are used. I will soon update this patch. Thanks, Francesco https://reviews.llvm.org/D30739 ___

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

fpetrogalli added a comment. Hi Graham, thank you for working on this. I understand that you are gonna take care of the CodeGen side of things for the new `-fopenmp-simd` option in a separate patch? I am asking because I expect that the tests in `test/OpenMP/declare_simd_*` will give the same

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli added a comment. Alexey, thank you for reviewing this. If you don't mind, I will wait applying the changes you requested, Unfortunately I am not ready yet to send out an update as I am still working on the vector ABI. I will ping you when ready. Francesco https://reviews.llvm.org

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli created this revision. Herald added subscribers: rengolin, aemerson. This patch enables the code generation of vector function names that are described by attaching a "#pragma omp declare simd" directive to the scalar function definition/declaration, for the Advanced SIMD (NEON) vector

[PATCH] D30739: [OpenMP] "declare simd" for AArch64 Advanced SIMD.

fpetrogalli updated this revision to Diff 91035. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Changes: - fixed formatting; - added two tests that were missing. https://reviews.llvm.org/D30739 Files: lib/Basic/Targets.cpp lib/CodeGen/CGOpenMPRuntime.cpp test/

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli created this revision. fpetrogalli added a reviewer: cfe-commits. This patch generates a list of global external variables that are passed to the llvm::TargetLibraryInfo (TLI) to enable the vectorization of loops containing calls to function that are marked with a #pragma omp declare s

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli updated this revision to Diff 79734. fpetrogalli added a comment. Rebase plus apply clang format. https://reviews.llvm.org/D27250 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h test/OpenMP/declare_sim

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli marked 5 inline comments as done. fpetrogalli added a comment. I updated the comments related to code formatting. https://reviews.llvm.org/D27250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli added a comment. In https://reviews.llvm.org/D27250#609006, @ABataev wrote: > Hi! Thanks for your review! > 1. Please provide full context for your changes (check this document how to > do this http://llvm.org/docs/Phabricator.html). I missed that out, should be done now. > 2. U

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli added a comment. In https://reviews.llvm.org/D27250#609063, @ABataev wrote: > You did just some minor changes. The main questions are still unanswered. Hopefully now they are! :) Francesco https://reviews.llvm.org/D27250 ___ cfe-comm

<    1   2   3