fpetrogalli added a comment. In D141581#4074312 <https://reviews.llvm.org/D141581#4074312>, @tstellar wrote:
> I tested this patch and it works, so I'll give it an LGTM. However, I think > the LLVMConfig.cmake.in changes are now unnecessary since the > RISCVTargetParserTableGen has been dropped from all clang targets. I am tempted to submit it as it is and create a new patch that removes the bits in `llvm/cmake/modules/LLVMConfig.cmake.in`. As far s I can tell, if we specify the library dependency only in `LLVM_LINK_COMPONENTS`, there are issue when building non stand-alone clang, as building the clang components might start before the actual header file is generated. I'll submit this tomorrow (if I don't get negative feedback), and then create a new patch that removes the bits in `llvm/cmake/modules/LLVMConfig.cmake.in`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
