[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:556-557 + // -fld-path= takes precedence over -fuse-ld= and specifies the executable + // name. PATH is consulted if the value does not contain /. -B is + // int

[PATCH] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

MaskRay updated this revision to Diff 275830. MaskRay retitled this revision from "[Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path" to "[Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path". MaskRay edited the summary of this revision. Mask

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

MaskRay added a comment. The description appears to be wrapped at a very small column number. Can you please fix it? Comment at: clang/test/Driver/program-path-priority.c:34 +/// isolated as we expected. +// NO_NOTREAL_GCC-NOT: {{\/gcc[^\/]*"}} `\` can be re

[PATCH] D83154: clang: Add -fcoverage-prefix-map

MaskRay added a comment. GCC obtained -fdebug-prefix-map first, then r256847 added both -fmacro-prefix-map and -ffile-prefix-map. GCC doesn't have -fcoverage-prefix-map and I saw your https://github.com/apple/swift/pull/32416 However, do we really need one new -f*-prefix-map for every feature?

[PATCH] D83154: clang: Add -fcoverage-prefix-map

MaskRay added a comment. -fdebug-prefix-map does not make sense to me because coverage is not debug info. I am on the fence whether we need -fcoverage-prefix-map. I created https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96092 (Should --coverage respect -ffile-prefix-map?) Comme

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay marked 6 inline comments as done. MaskRay added inline comments. Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush"); - if (gcov_flush1 == NULL) { -fprint

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay updated this revision to Diff 276173. MaskRay marked 6 inline comments as done. MaskRay added a comment. Test __gcov_dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://reviews.llvm.org/D83149 Files: clang/lib/Driver/To

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay added a comment. `compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c.gcov` is clumsy to update. The filename is also wrong: gcov has nothing to do with instrprof. I'll update the tests separately like my fba8523fb55c8e3bc853df7a250845cf51e5fc99

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:289 +; CHECK-NEXT: Branch Probability Analysis +; CHECK-NEXT: Block Frequency Analysis ; CHECK-NEXT: FunctionPass Manager zequanwu wrote: > zequanwu wrote: > > niki

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

MaskRay accepted this revision. MaskRay added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added a comment. I still haven't seen a strong argument keeping a command line option `-enable-npm-call-graph-profile`. Asked in D62627 . `Opts.getProfileUse() != CodeGenOptions::ProfileNone ` in Opts.CallGraphProfile = Opts.getProfileUse() != CodeGen

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

MaskRay added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 // RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix +// RUN: mv %t/%target_triple-gcc %t/prefix // RUN: touch %t/notreal-none-elf-gcc && chmod +x %t/notreal-none-elf-gcc If $DEFAUL

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added a comment. In D83013#2139882 , @zequanwu wrote: > > The alternative of using LazyBlockFrequencyInfoPass and checking > > PSI->hasProfileSummary() first would also work I guess. If you think that's > > cleaner, maybe that's the better way to

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. Received Cary's response and I am authorized to share this > In retrospect, I regret not naming the option -fsplit-dwarf, which clearly > would not have implied -g, and would have fit in with a few other > dwarf-related -f options. (I don't know whether Richard's object

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks like a good cleanup. Hope someone with more CMake-fu to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83454/new/ https://review

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

MaskRay accepted this revision. MaskRay added a comment. LG with some nits Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3287 + if (Args.hasArg(OPT_fexperimental_strict_floating_point)) { +Opts.ExpStrictFP = true; + } Delete redundant braces ===

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added a comment. In D83013#2143470 , @hans wrote: > Still lgtm. For what it's worth, I think you could have just re-committed > with the fixes rather than uploading for review again. This may be a difference of habits but I usually upload the la

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

MaskRay added a subscriber: mehdi_amini. MaskRay added a comment. In D82477#2145967 , @clayborg wrote: > In D82477#2145565 , @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop >

[PATCH] D83154: clang: Add -fcoverage-prefix-map

MaskRay added a comment. In D83154#2146085 , @phosek wrote: > In D83154#2134984 , @MaskRay wrote: > > > -fdebug-prefix-map does not make sense to me because coverage is not debug > > info. > > I am on the fence wh

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added a comment. In D83648#2146472 , @pzheng wrote: > Actually, this patch won't change --help because it just reduced some > duplication by extracting the common part (" the integrated assembler") of > the help message into the "help" of "OptOut

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added inline comments. Comment at: clang/test/Driver/integrated-as.c:10 +// RUN: %clang -### -fintegrated-as %s 2>&1 | FileCheck %s -check-prefix FIAS-LINK + MaskRay wrote: > This test is incorrect. You need a specific target triple to select > bare-m

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added a comment. Actually, the way we tag options recognized by GCC is wrong. We should use a more specific group instead of `DriverOption`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648 __

[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

MaskRay added a comment. Created http://lists.llvm.org/pipermail/cfe-dev/2020-July/066245.html [cfe-dev] Usage of clang::driver::options::DriverOption (-Xarch_ & gcc toolchain) to ask about the use case. When I get time, I'll work on a patch fixing the whole class of options instead of just -fi

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

MaskRay added a comment. @eduucaldas Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differentia

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2244 HelpText<"Disable control-flow mitigations for Load Value Injection (LVI)">; +def m_seses : Flag<["-"], "mseses">, Group, Flags<[CoreOption, DriverOption]>, + HelpText<"Enable speculative e

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay created this revision. MaskRay added reviewers: echristo, mehdi_amini, morehouse. Herald added subscribers: Sanitizers, cfe-commits, aaron.ballman. Herald added projects: clang, Sanitizers. MaskRay updated this revision to Diff 272193. MaskRay added a comment. Update more files Repositor

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272193. MaskRay added a comment. Update more files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangCommandLineReference.rst clang/docs/Saniti

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272200. MaskRay edited the summary of this revision. MaskRay edited reviewers, added: pcc; removed: HAPPY. MaskRay added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add aliases Repository: rG LLVM Github Mono

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272201. MaskRay added a comment. Fix documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangCommandLineReference.rst clang/docs/Saniti

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay marked 6 inline comments as done. MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272209. MaskRay marked an inline comment as done. MaskRay added a comment. Fix more words Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangComma

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272237. MaskRay marked 4 inline comments as done. MaskRay added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangCom

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones echristo wrote: >

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a4317bfb319: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:36 +static const char *BugReportMsg = +"PLEASE submit a bug report to " BUG_REPORT_URL This variable is mutable. Please use `const char BugReportMsg[]` CHANGES SINCE LAST ACT

[PATCH] D81963: [HIP] Move HIP Linking Logic into HIP ToolChain

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reproducer is specified? The user requests to generate a reproduce fil

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

MaskRay added inline comments. Comment at: llvm/lib/Support/Triple.cpp:220 case Win32: return "windows"; + case ZOS: +return "zos"; Follow the local style by deleting the newline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https:/

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

MaskRay accepted this revision. MaskRay added a comment. > This patch changes types of some integer function arguments or return values > from si_int to the default int type (typedefed to native_int to make it > obvious this is intentional) to make it more compatible with libgcc. Please drop `n

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

MaskRay added a comment. +@rsmith for clang side changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

MaskRay added subscribers: NoQ, MaskRay. MaskRay added a comment. +@NoQ on comments whether clang static analyzer can catch these cases. `clang++ --analyze a.cc` does not warn on `a.size()-2` AFAICT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D70603: Change while to do-while

MaskRay added a comment. In D70603#2114361 , @pi1024e wrote: > @MaskRay it's been months yet this hasn't landed yet. Why? It is usually assumed that the patch author pushes this commit. In this case, it seems that you don't have commit access. You'll ne

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } john.brawn wrote: > MaskRay wrote: > > Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reproducer is > > specified? Th

[PATCH] D82604: No nested namespaces in Clang-Tidy checkers

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. As the warnings suggest, nested name definitions can't be used because llvm-project is still using C++14. `llvm.org` as a reviewer doesn't work. You can use `git log` and find acti

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

MaskRay added a comment. In D82548#2124549 , @lh123 wrote: > In D82548#2124546 , @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop > > `Reviewers:` `Subscribers:` `Tags:` and t

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Support/TimeProfiler.cpp:222 +J.attribute("pid", Pid); +J.attribute("tid", int64_t(Tid)); +J.attribute("ts", 0); --

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

MaskRay added a comment. > btw, do you know why FileCheck seems intentionally allows the case when > --check-prefixes=KNOWN,UNKNOWN? I've mentioned in the description of D78110 > that there are about 1000 tests that have > this. but is it a feature or a somethi

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

MaskRay added a comment. In D75153#1942336 , @aganea wrote: > In D75153#1906580 , @MaskRay wrote: > > > Does `taskset -c 0-3 lld -flavor ...` restrict the number of cores? > > > > cpu_set_t cpu; > > sched_getaff

[PATCH] D76452: Use LLD by default for Android.

MaskRay accepted this revision. MaskRay added a comment. LGTM. But hope @ruiu or @int3 can clarify that we can't get rid of the `__APPLE__` special case in: // lld/tools/lld/lld.cpp static Flavor parseProgname(StringRef progname) { #if __APPLE__ // Use Darwin driver for "ld" on Darwin

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, jfb, nickdesaulniers, rsmith, scanon, xbolva00, ziangwan. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Currently, both `warn_impcast_integer_float_precision_constant` and `warn_impcast_inte

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

MaskRay updated this revision to Diff 259370. MaskRay added a comment. Fixed a typo noticed by @bmoses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm.org/D78661 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

MaskRay updated this revision to Diff 259398. MaskRay marked an inline comment as done. MaskRay added a comment. Change RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm.org/D78661 Files: clang/include/clang

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

MaskRay added a comment. In D73845#2000455 , @sthibaul wrote: > Thanks! I don't have commit access, could somebody commit this for me? Can you provide your `name `? I need this information to run `git c --amend --author=` CHANGES SINCE LAST ACTION h

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rG14aaf4457c64: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

This revision was automatically updated to reflect the committed changes. Closed by commit rG63959803702c: [Driver] Move GCC multilib/multiarch paths support from Linux.cpp to Gnu.cpp (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76452: Use LLD by default for Android.

MaskRay added a comment. In D76452#2002875 , @danalbert wrote: > In D76452#2002856 , @int3 wrote: > > > Yes, I was referring to that question too :) I'm working on the new > > lld-macho implementation, under the `D

[PATCH] D61756: Add a __FILE_NAME__ macro.

MaskRay added a comment. > @rmisth wrote: "Clang should drive the standard, not diverge from it", and we > should at least try to push for standardizing this if we think it's > worthwhile as an alternative to __FILE__. In D61756#1505296 , @kristina wro

[PATCH] D61756: Add a __FILE_NAME__ macro.

MaskRay added a comment. In D61756#2003847 , @kristina wrote: > In D61756#2003836 , @MaskRay wrote: > > > > @rmisth wrote: "Clang should drive the standard, not diverge from it", > > > and we should at least try to

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

MaskRay closed this revision. MaskRay added a comment. @browneee Hi, it seems that you did not attach `Differential Revision: ` to the commit dda3c19a3618dce9492687f8e880e7a73486ee98 so the differential was not closed automat

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

MaskRay added a comment. I guess this fixes https://bugs.llvm.org/show_bug.cgi?id=45289 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 ___ cfe-commits

[PATCH] D78903: [Driver] Add option -fproc-stat-report

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:786 + + $ clang -fproc-stat-report=- foo.c + clang-11: output=/tmp/foo-123456.o, total=84000, user=76000, mem=87496 aganea wrote: > Why not just `-fproc-stat-report` in this case? It can sa

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

MaskRay added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:403 switch (Linkage) { case GlobalValue::CommonLinkage: case GlobalValue::LinkOnceAnyLinkage: hubert.reinterpretcast wrote: > I have my doubts that `CommonLinkage` shou

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay closed this revision. MaskRay added a comment. Relanded as 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d @yamauchi For a reland, you still need to include `Differential Revision: ` so that the differential can be closed au

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay added a comment. It is also a convention to explain what has changed compared with the initial land. As a hindsight, the option `-pgo-instr-old-cfg-hashing` should probably have been mentioned in the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D84987: Pass bugreport URL to standalone clang build

MaskRay added a comment. I am not familiar with the standalone clang build. Can you share a command? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84987/new/ https://reviews.llvm.org/D84987 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D84987: Pass bugreport URL to standalone clang build

MaskRay added a comment. In D84987#2186639 , @mgorny wrote: > In D84987#2186113 , @MaskRay wrote: > >> I am not familiar with the standalone clang build. Can you share a command? > > You install LLVM first, then run

[PATCH] D84987: Pass bugreport URL to standalone clang build

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Verified. I added `CMAKE_PREFIX_PATH` to my `/tmp/RelA/CMakeCache.txt` and invoked `ninja install` (this installed a bunch of unrelated files. I don't know know how to just install-cmake-exp

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay added a subscriber: hans. MaskRay added a comment. @yamauchi Do we need cd890944ad344b1b8cac58332ab11c9eec6b61e9 and 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

MaskRay added a comment. #clang does not have many people. You might need to add people explicitly.. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:633 +static const char *getAsNeededOption(const ToolChain &TC, bool ignore) { +

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

MaskRay added a comment. This file is auto generated. The real documentation should go to `clang/include/clang/Driver/Options.td` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85239/new/ https://reviews.llvm.org/D85239 ___ cfe-commits mailin

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

MaskRay added a comment. I can optimize getImpliedDisabledFeatures & getImpliedEnabledFeatures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits mai

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

MaskRay added a comment. Sent D85257 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D85324: [z/OS] Add z/OS Target and define macros

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:745 +if (this->PointerWidth == 64) { + Builder.defineMacro("__64BIT__"); +} anirudhp wrote: > abhina.sreeskantharajan wrote: > > anirudhp wrote: > > > What about the `__LP

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 __

[PATCH] D85309: [WIP][clang][Driver] Support GNU ld on Solaris

MaskRay added a comment. Please find a suitable test file (clang/test/Driver/solaris-*.c) and add some tests there (for example, solaris-ld.c) The challenge is that CLANG_ENABLE_GLD is not a default configuration, so leaving out tests may be fine. Comment at: clang/CMakeLists

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay created this revision. MaskRay added reviewers: jyknight, pcc, phosek. Herald added subscribers: llvm-commits, cfe-commits, dang, steven.zhang, atanasyan, hiraditya, arichardson, sdardis. Herald added a reviewer: rengolin. Herald added projects: clang, LLVM. MaskRay requested review of thi

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

MaskRay added a comment. The file is auto-generated by: `path/to/clang-tblgen -gen-opt-docs -I clang/include/clang/Driver -I llvm/include/ clang/include/clang/Driver/ClangOptionDocs.td > clang/docs/ClangCommandLineReference.rst` The description is retrieved from `DocBrief`. It `DocBrief` does n

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

MaskRay added a comment. Added the tie breaker when progress cannot be made:) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 284234. MaskRay added a comment. Add binutilsIsAtleast() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 Files: clang/include/clang/Basic/CodeGenOptions.h clang/inc

[PATCH] D85692: python bindings: fix DeprecationWarning

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85692/new/ https://reviews.llvm.org/D85692

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

MaskRay abandoned this revision. MaskRay added a comment. Herald added subscribers: aaron.ballman, sstefan1. Landed with a change that only changes the explicit -fno-semantic-interposition behavior, so there was very little test change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

MaskRay added a comment. Mostly looks good. Comment at: llvm/utils/UpdateTestChecks/common.py:309 + +nameless_values = [] +# Description of the different "unnamed" values we match in the IR, e.g., ```lang=python nameless_values = [ NamelessValue(r'TMP', r'

[PATCH] D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+"

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. I don't have further comments. Worth waiting for other opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85099/new/ https://review

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Preprocessor/init-arm.c:19 +// ARM:#define __CHAR16_TYPE__ unsigned short +// ARM:#define __CHAR32_TYPE__ unsigned int +// ARM:#define __CHAR_BIT

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:573 +const char *DefaultLinker = getDefaultLinker(); +if (!llvm::sys::path::is_absolute(DefaultLinker)) + return GetProgramPath(DefaultLinker); swap then and else branches to a

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642 +int Num; +if (V == "future") + A->render(Args, CmdArgs); phosek wrote: > Another option would be `unstable`. I picked `future` because there is an precedent: `-mcp

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

MaskRay added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:299 + /// This overrides the default ABI used by the target. + TargetCXXABI::Kind CXXABIOverride; + bool HasCXXABIOverride = false; This is usually represented with llvm::Option

[PATCH] D85810: [clang] Pass-through remarks options to lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:71 + + bool isLLD = llvm::sys::path::filename(LinkerPath) == "ld.lld" || + llvm::sys::path::stem(LinkerPath) != "ld.lld"; Checking the path is brittle. Consider

[PATCH] D85810: [clang] Pass-through remarks options to lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:81 +CmdArgs.push_back("-mllvm"); +std::string Passes = std::string("-pass-remarks=") + A->getValue(); +CmdArgs.push_back(Args.MakeArgString(Passes)); Delete such one

[PATCH] D85798: Split Preprocessor/init.c test. NFC.

MaskRay added inline comments. Comment at: clang/test/Preprocessor/init-ppc.c:390 +// PPC:#define __ppc__ 1 +// +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc-ibm-aix7.1.0.0 -fno-signed-char < /dev/null | FileCheck -match-full-lines -check-prefix PPC-AIX %s -

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:3307-3310 +def fbinutils_version_EQ : Joined<["-"], "fbinutils-version=">, Group, + HelpText<"Produced object files can use ELF features only supported by l

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. In D85474#2217598 , @jhenderson wrote: > Looks like there's only an `llc` test, but the option is in clang too? Should > we have a test there? There are generally some dotted edges in the testing of such MC level options. For op

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 285681. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a subscriber: kristof.beyls. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.

<    1   2   3   4   5   6   7   8   9   10   >