MaskRay added a comment. In D83013#2139882 <https://reviews.llvm.org/D83013#2139882>, @zequanwu wrote:
> > The alternative of using LazyBlockFrequencyInfoPass and checking > > PSI->hasProfileSummary() first would also work I guess. If you think that's > > cleaner, maybe that's the better way to go. > > Since `PSI->hasProfileSummary()` is not necessary for this pass, it relies on > function entry count. So, I check for `F.getEntryCount()` before getting BFI. Thanks. The last update looks good to me. I'll defer the approval to @nikic and folks who have expressed concerns about deleting legacy PM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
