[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay updated this revision to Diff 208289. MaskRay added a comment. Simplify Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64294/new/ https://reviews.llvm.org/D64294 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c test/Driver/frame-point

[PATCH] D64276: [ItaniumMangle] Replace useFloat128ManglingForLongDouble() with getManglingForLongDouble() and getManglingForFloat128()

MaskRay updated this revision to Diff 208294. MaskRay edited the summary of this revision. MaskRay removed a subscriber: wuzish. MaskRay added a comment. "U10__float128" -> "u9__ieee128" This is the new mangled type in gcc>8.1 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

MaskRay updated this revision to Diff 208313. MaskRay retitled this revision from "[ItaniumMangle] Replace useFloat128ManglingForLongDouble() with getManglingForLongDouble() and getManglingForFloat128()" to "[ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code". Mask

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay updated this revision to Diff 208314. MaskRay added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/Options.td lib/Basic/TargetInfo.cpp lib/Basic/Targets/PPC.cpp

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay updated this revision to Diff 208315. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: krytarowski, emaste. Update description. Fix the mangled code: U10__float128 -> u9__ieee128 Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D63793: Treat the range of representable values of floating-point types as [-inf, +inf] not as [-max, +max].

MaskRay added a comment. In D63793#1572977 , @ostannard wrote: > There are a number of buildbot failures which look related to this, e.g. > > - > http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/6730/steps/ninja%20check%201/logs/FAIL%3A%20U

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208378. MaskRay retitled this revision from "[ubsan] Delete the FloatDivideByZero ErrorType" to "[Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272". MaskRay edited the summary of this revision. MaskRay added a comment. Heral

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208382. MaskRay added a comment. Remove a stray : Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 Files: lib/Driver/ToolChain.cpp test/Driver/fsanitize.c Index: test/Driver/fsan

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208395. MaskRay edited the summary of this revision. MaskRay added a comment. make various sanitizer features work Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 Files: lib/Driver/

[PATCH] D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

MaskRay updated this revision to Diff 208399. MaskRay edited the summary of this revision. MaskRay added a comment. getMangledTypeOfLongDouble -> getLongDoubleMangling as erichkeane suggested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64276/new/ https://revie

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay updated this revision to Diff 208402. MaskRay added a comment. Rebase after getMangledCodeOfLongDouble -> getLongDoubleMangling rename Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208410. MaskRay added a comment. Fix sanitizer-ld.c test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 Files: lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChain.cpp test/Driver

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay added a comment. In D64317#1574007 , @vitalybuka wrote: > is the patch description still correct? Yes. > Also, add SanitizerMask::FloatDivideByZero to a few other masks to make > -fsanitize-trap, -fsanitize-recover, -fsanitize-minimal-runtime a

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

This revision was automatically updated to reflect the committed changes. Closed by commit rL365412: [X86][PPC] Support -mlong-double-64 (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208565. MaskRay added a comment. Fix getPPTransparentSanitizers (test/Modules/check-for-sanitizer-feature.cpp) & ubsan_blacklist.txt Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 F

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: lib/Driver/SanitizerArgs.cpp:27-30 static const SanitizerMask NeedsUbsanRt = SanitizerKind::Undefined | SanitizerKind::Integer | SanitizerKind::ImplicitConversion | SanitizerKind::Null

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: test/Driver/fsanitize-blacklist.c:32 // RUN: %clang -target x86_64-linux-gnu -fsanitize=undefined -resource-dir=%S/Inputs/resource_dir %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-DEFAULT-

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay updated this revision to Diff 208615. MaskRay edited the summary of this revision. MaskRay added a comment. Implement the GCC behavior: -fomit-frame-pointer wins over -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer loses out to -momit-leaf-frame-pointer Repository: rC Clang

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay updated this revision to Diff 208616. MaskRay added a comment. Simplify and add another test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64294/new/ https://reviews.llvm.org/D64294 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c te

[PATCH] D64276: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled code

This revision was automatically updated to reflect the committed changes. Closed by commit rL365480: [ItaniumMangle] Refactor long double/__float128 mangling and fix the mangled… (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repositor

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay updated this revision to Diff 208704. MaskRay added a comment. Rebase The openmp issue was fixed by r365485 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/Options.td lib/Basic/Tar

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

MaskRay created this revision. MaskRay added a reviewer: ABataev. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D64423 Files: lib/AST/ASTContext.cpp Index: lib/AST/ASTContext.cpp

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay added a comment. @ychen The GCC behavior ("omit" wins over "no-omit") makes sense because: in the 4 states: - 00) leaf retained, non-leaf retained - 01) leaf retained, non-leaf omitted - 10) leaf omitted, non-leaf retained - 11) leaf omitted, non-leaf omitted State 10) doesn't make sens

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

MaskRay updated this revision to Diff 208780. MaskRay edited the summary of this revision. MaskRay added a comment. Update description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64423/new/ https://reviews.llvm.org/D64423 Files: lib/AST/ASTContext.cpp Inde

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

This revision was automatically updated to reflect the committed changes. Closed by commit rL365545: [OpenMP] Simplify getFloatTypeSemantics (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTIO

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

This revision was automatically updated to reflect the committed changes. Closed by commit rL365587: [Driver] Add float-divide-by-zero back to supported sanitizers after… (authored by MaskRay, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1825 + // that don't use the altivec abi. + if (!SeenOther) +ABIName = A->getValue(); hfinkel wrote: > This seems like an uninte

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay updated this revision to Diff 208875. MaskRay edited the summary of this revision. MaskRay added a comment. Add another test: -mabi=elfv2 -mabi=elfv1 -mabi=ibmlongdouble -mabi=ieeelongdouble Try fixing the markdown in the description Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:585 + (A && A->getOption().matches(options::OPT_fno_omit_frame_pointer)) || + (!(A && A->getOption().matches(options::OPT_fomit_frame_pointer)) && +

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

MaskRay added a comment. > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE for > C++ only, while clang has long been doing it for all languages Can you explain more about the hack https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0f97ccfdccc033f543ccbcb220697e62e84bf01f

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay updated this revision to Diff 209112. MaskRay added a comment. Improve readability Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64294/new/ https://reviews.llvm.org/D64294 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c test/Driver/

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

MaskRay marked 5 inline comments as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:579 -static bool shouldUseFramePointer(const ArgList &Args, - const llvm::Triple &Triple) { - if (Arg *A = Args.getLastArg(opti

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay updated this revision to Diff 209114. MaskRay added a comment. Make -mabi=ieeelongdouble a pure CC1 option so that we can simplify the -mabi= loop Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64283/new/ https://reviews.llvm.org/D64283 Files: include/

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay added a comment. Ping:) It'll be great to have D64277 (-mlong-double-128) D64282 (libcall) D64283 (-mabi=ieeelongdouble) before 9.0.0 is branched. Repository: rC Clang CHANGES SINC

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

MaskRay added a comment. In D64482#1578376 , @ro wrote: > In D64482#1578245 , @MaskRay wrote: > > > > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE > > > for C++ only, while clang has lo

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

MaskRay updated this revision to Diff 198970. MaskRay edited the summary of this revision. MaskRay added a comment. Update release notes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61689/new/ https://reviews.llvm.org/D61689 Files: docs/ReleaseNotes.rst lib

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

This revision was automatically updated to reflect the committed changes. Closed by commit rL360403: Change -gz and -Wa,--compress-debug-sections to use gABI compression… (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D61777: [cc1as] Change -compress-debug-sections= to use --

MaskRay created this revision. MaskRay added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. The double dash form is documented by GNU as, used by gcc, and accepted by llvm-mc. Repository: rC Clang https://reviews.llvm.org/D61777 Files: include

[PATCH] D61777: [cc1as] Change -compress-debug-sections= to use --

MaskRay added a comment. If you feel strong about it, I can add back `-compress-debug-sections=`, but it is not used by anyone. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61777/new/ https://reviews.llvm.org/D61777 __

[PATCH] D61777: [cc1as] Change -compress-debug-sections= to use --

MaskRay abandoned this revision. MaskRay added a comment. Sorry, I have to commit this rC360495 now to unbreak our internal builds. Not sure whether the single dash form is necessary, but rC360495 keeps it. Repository: r

[PATCH] D61804: Support building shared and static libraries simultaneously

MaskRay added a comment. @winksaville I asked why on Arch Linux, extra/clang is built with `-DBUILD_SHARED_LIBS=ON` while extra/llvm extra/lldb are built with `-DBUILD_SHARED_LIBS=ON` https://bugs.archlinux.org/task/60512 . I think `extra/clang` is just not suitable for development. If you real

[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

MaskRay created this revision. MaskRay added reviewers: danalbert, pirama, rprichard, srhines. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. See D61825 for the temporary lld option --android-tls. Repository:

[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

MaskRay updated this revision to Diff 199574. MaskRay added a comment. Use Args.MakeArgString(ToolChain.GetLinkerPath()); Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61931/new/ https://reviews.llvm.org/D61931 Files: lib/Driver/ToolChains/Gnu.cpp test/Drive

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:382 resetDataLayout("e-m:e-i64:64-n32:64"); - ABI = "elfv2"; } else { Have you researched how GNU as chooses the default ABI? I think the change may break some Linux ppc64l

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/PPC.h:382 resetDataLayout("e-m:e-i64:64-n32:64"); - ABI = "elfv2"; } else { MaskRay wrote: > Have

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:217 case Triple::ppc64: -return PPCTargetMachine::PPC_ABI_ELFv1; +// if ELFv2 on target triple i.e. powerpc64-unknown-freebsd12.0-elfv2 +if (TT.getEnvironment() == llvm::Triple:

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. Will FreeBSD 13 or future releases support ELFv1? If not, it may be cleaner to not invent `-elfv2` `-elfv1` triples, but rather dispatch on the major version, e.g. `powerpc64-unknown-freebsd13.0` could mean ELFv2. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay accepted this revision. MaskRay added a comment. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 ___ cfe-commits mailing lis

[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

MaskRay abandoned this revision. MaskRay added a comment. Abandon in favor of D62055 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61931/new/ https://reviews.llvm.org/D61931 ___ cfe-

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

This revision was automatically updated to reflect the committed changes. Closed by commit rL361112: [clangd] Respect clang-tidy suppression comments (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rL361113: [clangd] Respect WarningsAsErrors configuration for clang-tidy (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. Reordered the code a bit and committed for you... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 ___ cfe-commits mailing list cfe-comm

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

This revision was automatically updated to reflect the committed changes. Closed by commit rL361355: [PPC64] Parse -elfv1 -elfv2 when specified on target triple (authored by MaskRay, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D61950?vs

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. @adalava You need to run both `check-llvm` and `check-clang`, but it was my fault that I hadn't done this before committing... Two clang tests failed (http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/24521) It should have been fixed by rC361365

[PATCH] D62509: [Driver] Render -fuse-init-array for -fembed-bitcode

MaskRay created this revision. MaskRay added reviewers: compnerd, rsmith, t.p.northover. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modern ELF platforms use -fuse-init-array to emit .init_array instead of .ctors . ld.bfd and gold merge .init_array and .ctors into .init

[PATCH] D62509: [Driver] Render -fuse-init-array for -fembed-bitcode

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3675 +// Render target options such as -fuse-init-array on modern ELF platforms. +TC.addClangTargetOptions(Args, CmdArgs, JA.getOffloadingDeviceKind()); +

[PATCH] D62606: [Driver] -static-pie: add -z text

MaskRay created this revision. MaskRay added reviewers: saugustine, sivachandra. Herald added a project: clang. Herald added a subscriber: cfe-commits. gcc -static-pie adds -z text. In ld.bfd and gold, default/-z text/-z notext are tri-state. By default, text relocations (and DF_TEXTREL) are emit

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay created this revision. MaskRay added reviewers: emaste, brooks, dim. Herald added subscribers: cfe-commits, atanasyan, fedor.sergeev, arichardson, sdardis. rtld started to support DT_GNU_HASH since rS234841 (2013). libexec/rtld-elf/rtld.c:symlook_obj uses DT_GNU_HASH when it is present an

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/FreeBSD.cpp:160 +if (ToolChain.getTriple().getOSMajorVersion() >= 9) + CmdArgs.push_back("--hash-style=gnu"); CmdArgs.push_back("--enable-new-dtags");

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay updated this revision to Diff 178836. MaskRay added a comment. . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 Files: lib/Driver/ToolChains/FreeBSD.cpp test/Driver/freebsd.c Index: test/Driver/freebsd.c ==

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay updated this revision to Diff 178908. MaskRay edited the summary of this revision. MaskRay added a comment. Bring back MIPS special case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 Files: lib/Driver/ToolChai

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay added a comment. In D55878#1339098 , @emaste wrote: > I think the arch-change (switching from a whitelist to a MIPS blacklist) is > reasonable. What is the motivation for dropping `DT_HASH`, just binary size > reduction? Yes. It saves a few hun

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

This revision was automatically updated to reflect the committed changes. Closed by commit rL371586: [CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage… (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:387 + +void riscv::addGoldOptions(const ToolChain &ToolChain, + const llvm::opt::ArgList &Args, gold doesn't support RISC-V, does it? CHANGES SINCE L

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:414 + +CmdArgs.push_back(Args.MakeArgString(Twine("-plugin-opt=--" + "mattr=") + The single-dash form of `mattr`: `-plugin-opt=

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

MaskRay added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } calculateAttributeSpellingListIndex is defined in clangSema. This can

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. It'd be nice to see this land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68009: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

MaskRay created this revision. MaskRay added reviewers: jakehehrlich, mcgrathr, phosek. Herald added a project: clang. Herald added a subscriber: cfe-commits. The option was added to lld in D67481 /372807. Repository: rC Clang https://reviews.llvm.org/D68009

[PATCH] D68009: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL372814: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:439 +// Empty '!' implies no more functions. +if (S.size() == 1 && S[0] == '!') + break; ``` if (S.consume_front("!")) { if (S.empty()) ... else ... } ``` ===

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:120 + std::string BasicBlockSections; + Comment its allowed values ("all", "labels", "none") Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1103 + dy

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:631 +if (A->getOption().matches(options::OPT_fpropeller_optimize_EQ)) { + if (!Args.getLastArgValue(options::OPT_fuse_ld_EQ).equals_lower("lld")) +D.Diag(clang::diag::err_drv_unsupport

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

MaskRay accepted this revision. MaskRay added a comment. This will make it much easier to test clang's compatibility with GCC, especially in projects that heavily use `__GNUC__` or its friends, e.g. glibc :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

MaskRay added a comment. Why "inactive region", not "skipped ranges"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

MaskRay added inline comments. Comment at: clangd/index/Index.h:32 +// Character offset on a line in a document (zero-based). +int Character = 0; + }; hokein wrote: > sammccall wrote: > > sammccall wrote: > > > Column? > > > > > > LSP calls this "charac

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

MaskRay added a comment. Just my 2 cents. Calculation of line/character for each occurrence may not take a lot of computation. cquery/ccls computes the Comment at: clangd/index/Index.h:39 // using half-open range, [StartOffset, EndOffset). + // FIXME(hokein): remove these

[PATCH] D45805: [libcxx] Remove redundant specializations in type_traits.

MaskRay created this revision. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, christof. Repository: rCXX libc++ https://reviews.llvm.org/D45805 Files: include/type_traits Index: include/type_traits ===

[PATCH] D45807: [libclang] Fix test LibclangReparseTest.FileName when TMPDIR is set to a symbolic link

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang https://reviews.llvm.org/D45807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D48894: [AST] Rename some Redeclarable functions to reduce confusion

MaskRay created this revision. MaskRay added reviewers: rsmith, akyrtzi, Eugene.Zelenko. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48894 Files: include/clang/AST/Redeclarable.h Index: include/clang/AST/Redeclarable.h =

[PATCH] D48894: [AST] Rename some Redeclarable functions to reduce confusion

MaskRay updated this revision to Diff 154044. MaskRay added a comment. Rename `Next` to `Link` as per rsmith Repository: rC Clang https://reviews.llvm.org/D48894 Files: include/clang/AST/Redeclarable.h Index: include/clang/AST/Redeclarable.h ===

[PATCH] D49002: [Index] Add index::IndexingOptions::IndexImplicitInstantiation

MaskRay created this revision. MaskRay added reviewers: akyrtzi, arphaman. Herald added a subscriber: cfe-commits. With IndexImplicitInstantiation=true, the following case records an occurrence of B::bar in A::foo, which will benefit cross reference tools. template struct B { void bar() {}}; te

[PATCH] D48894: [AST] Rename some Redeclarable functions to reduce confusion

This revision was automatically updated to reflect the committed changes. Closed by commit rC336605: [AST] Rename some Redeclarable functions to reduce confusion (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D48894?vs=154044&id=154698#toc Repository:

[PATCH] D49002: [Index] Add index::IndexingOptions::IndexImplicitInstantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rL336606: [Index] Add index::IndexingOptions::IndexImplicitInstantiation (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D45805: [libcxx] Remove redundant specializations in type_traits.

MaskRay added a comment. Herald added a subscriber: ldionne. Ping :) Repository: rCXX libc++ https://reviews.llvm.org/D45805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; MaskRay wrote: > This is obvious. The comment can be removed. Not do

[PATCH] D68884: Add support to -Wa,-W in clang

MaskRay added inline comments. Comment at: clang/test/Driver/as-w-option.c:1 +// RUN: %clang -### %s -c -o tmp.o -fno-integrated-as -Wa,-W 2>&1 | FileCheck -check-prefix=CHECK-NOIAS %s +// RUN: %clang -### %s -c -o tmp.o -integrated-as -Wa,-W 2>&1 | FileCheck -check-prefix=CHEC

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

MaskRay added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:43 ArgumentsAdjuster getClangStripOutputAdjuster() { - return [](const CommandLineArguments &Args, StringRef /*unused*/) { + return [](const CommandLineArguments &Args, StringRef /*unused*/, St

[PATCH] D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal.

MaskRay added inline comments. Comment at: lib/Driver/ToolChains/BareMetal.cpp:159 ArgStringList &CmdArgs) const { CmdArgs.push_back(Args.MakeArgString("-lclang_rt.builtins-" + + getTriple().getArchName()

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay added inline comments. Comment at: lld/ELF/Driver.cpp:357 + + // default + return GnuStackKind::NoExec; mgorny wrote: > MaskRay wrote: > > MaskRay wrote: > > > This is obvious. The comment can be removed. > > Not done. `// default` can be deleted I thin

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay added inline comments. Comment at: clang/test/Driver/lto.c:81 + +/// -flto passes along an explicit branch align argument. +/// Test -malign-branch-boundary= This piece of logic is closer to x86. The test can be added to `x86-malign-branch.c` instead R

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:501 + // Handle options for branch align + if (Args.hasArg(options::OPT_mbranches_within_32B_boundaries)) { +CmdArgs.push_back("-plugin-opt=-x86-branches-within-32B-boundaries"); -

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay added a comment. In D80225#2046154 , @theraven wrote: > I'm a bit nervous about this. I'm aware of at least one out-of-tree > toolchain that uses this mechanism to select their proprietary linker. I'd > expect an RFC and for this to be highligh

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay created this revision. MaskRay added reviewers: aprantl, dblaikie, echristo, JDevlieghere, jhenderson, probinson, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. RFC: http://lists.llvm.org/pipermail/cfe-dev/2020-May/065430.html Agreement from GCC: https://s

[PATCH] D80454: [Clang][test] fix tests when using external assembler

MaskRay added a comment. In D80454#2051527 , @ychen wrote: > In D80454#2051524 , @aganea wrote: > > > Could you please attach a test to demonstrate the issue? > > > When a toolchain is not using integrated-as, the t

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay added a comment. In D80289#2051947 , @skan wrote: > Ping. `https://reviews.llvm.org/D80168#2046093` "Unless something is urgent, the usual practice is to ping after a week rather than 24 hours, as many people have big piles on their review plat

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:754 + if (OnlyLibstdcxxStatic) +CmdArgs.push_back("-Bstatic"); TC.AddCXXStdlibLibArgs(Args, CmdArgs); This is correct. If GNU ld<2.25 compatibility is not ne

[PATCH] D79961: [PGO] Fix computation of fuction Hash

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D80647: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be

MaskRay created this revision. MaskRay added reviewers: nickdesaulniers, kcc, pcc. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to lan

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

MaskRay added inline comments. Herald added a subscriber: arphaman. Comment at: cfe/trunk/test/Driver/sanitizer-ld.c:563 +// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-X86-64 %s +// CHECK-SHADOWCALLSTACK-LINUX-X86-64-NOT: error: + sanitizer-ld.

[PATCH] D80647: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2a3e9f0a6e9: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D80647?vs=266594&id=266601#toc Repository: rG LLVM G

<    1   2   3   4   5   6   7   8   9   10   >