Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

Eugene.Zelenko updated this revision to Diff 68921. Eugene.Zelenko added a comment. Address review comments. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-global-names-

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:9 @@ -8,3 +8,3 @@ are out of bounds (for ``std::array``). For out-of-bounds checking of static -arrays, see the clang-diagnostic-array-bounds check. +ar

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

Eugene.Zelenko updated this revision to Diff 68933. Eugene.Zelenko added a comment. Address review comment. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-global-names-i

[clang-tools-extra] r279494 - Fix style in some Clang-tidy checks documentation.

Author: eugenezelenko Date: Mon Aug 22 19:19:43 2016 New Revision: 279494 URL: http://llvm.org/viewvc/llvm-project?rev=279494&view=rev Log: Fix style in some Clang-tidy checks documentation. Differential revision: https://reviews.llvm.org/D23728 Modified: clang-tools-extra/trunk/docs/clang-

[clang-tools-extra] r279541 - [Documentation] Fix style of Clang-tidy readability-non-const-parameter.

Author: eugenezelenko Date: Tue Aug 23 12:57:24 2016 New Revision: 279541 URL: http://llvm.org/viewvc/llvm-project?rev=279541&view=rev Log: [Documentation] Fix style of Clang-tidy readability-non-const-parameter. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-non-const-

[PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: alexfh. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D23815 Files: docs/clang-tidy/checks/google-readability-

Re: [PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

Eugene.Zelenko updated this revision to Diff 69138. Eugene.Zelenko added a comment. Links are already there. Sorry for not uploading full diff at beginning. Repository: rL LLVM https://reviews.llvm.org/D23815 Files: docs/clang-tidy/checks/google-readability-namespace-comments.rst docs/cl

[clang-tools-extra] r279659 - Clang-tidy documentation style. Two Google checks are aliases.

Author: eugenezelenko Date: Wed Aug 24 15:05:36 2016 New Revision: 279659 URL: http://llvm.org/viewvc/llvm-project?rev=279659&view=rev Log: Clang-tidy documentation style. Two Google checks are aliases. Differential revision: https://reviews.llvm.org/D23815 Modified: clang-tools-extra/trunk

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:79 @@ +78,3 @@ +} + + Unnecessary empty line. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:93 @@ +92,3 @@ +{ + +}

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

Eugene.Zelenko added a comment. I think will be good idea to mention this plugin in docs/ReleaseNotes.rst. https://reviews.llvm.org/D23848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D23894: [Clang-tidy] Fix some checks documentation style

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: alexfh. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: nemanjai. Repository: rL LLVM https://reviews.llvm.org/D23894 Files: docs/

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

Eugene.Zelenko added a comment. General comments: - I think //default is XYZ// is better then //XYZ by default//. - There are discrepancies: option represent//ing// and option represent//s//. I think will be good idea to involve native English speaker in review. Comment at: d

[clang-tools-extra] r279846 - [Clang-tidy] Fix some checks documentation style.

Author: eugenezelenko Date: Fri Aug 26 12:46:51 2016 New Revision: 279846 URL: http://llvm.org/viewvc/llvm-project?rev=279846&view=rev Log: [Clang-tidy] Fix some checks documentation style. Differential revision: https://reviews.llvm.org/D23894 Modified: clang-tools-extra/trunk/docs/clang-ti

Re: [PATCH] D23595: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings

Eugene.Zelenko added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:103 @@ -95,1 +102,3 @@ +return getLength() == StrLen-1 && + memcmp(getNameStart(), Str, StrLen-1) == 0; } mehdi_amini wrote: > Eugene.Zelenko wrote: > > memcpy

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/google-runtime-int.rst:27 @@ +26,2 @@ + + A string represents type suffix. Default is empty. I think empty string will be better. Same for other occurrences. https://reviews.llvm.org/D239

[clang-tools-extra] r280119 - [Release notes] Fix highlighting.

Author: eugenezelenko Date: Tue Aug 30 12:47:07 2016 New Revision: 280119 URL: http://llvm.org/viewvc/llvm-project?rev=280119&view=rev Log: [Release notes] Fix highlighting. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

Eugene.Zelenko added a subscriber: aaron.ballman. Eugene.Zelenko added a comment. I don't have further comments, but as non-English speaker and mediocre writer, I would like see other people comments. May be @aaron.ballman could help if Alexander is busy? https://reviews.llvm.org/D23918 ___

[PATCH] D24115: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

[PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: sfantao, compnerd, mehdi_amini. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository:

[PATCH] D24178: [clang-rename] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: omtcyf0. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D24178 Files: clang-rename/USRFinder.h Index: clang-re

[PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hokein. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM https://review

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like clang-refactor idea should finally go live. Repository: rL LLVM https://reviews.llvm.org/D24183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24201: [Clang-tools-extra] Fix links in release notes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D24201 Files: docs/ReleaseNotes.rst Index: docs/

Re: [PATCH] D24201: [Clang-tools-extra] Fix links in release notes

Eugene.Zelenko updated this revision to Diff 70229. Eugene.Zelenko added a comment. Update to trunk. Repository: rL LLVM https://reviews.llvm.org/D24201 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/R

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-move/ClangMove.h:33 @@ +32,3 @@ +clang::SourceManager *SM; +MovedDecl() : Decl(nullptr), SM(nullptr) {} +MovedDecl(const clang::Decl *Decl, clang::SourceManager *SM) Please add empty

[clang-tools-extra] r280725 - [Release notes] Fix links.

Author: eugenezelenko Date: Tue Sep 6 12:52:44 2016 New Revision: 280725 URL: http://llvm.org/viewvc/llvm-project?rev=280725&view=rev Log: [Release notes] Fix links. Differential revision: https://reviews.llvm.org/D24201 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: cla

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added inline comments. Comment at: clang-move/ClangMove.h:13 @@ +12,3 @@ + +#include +#include Isn't C++ headers should be after Clang headers? https://reviews.llvm.org/D24243 ___ cfe-commits mailin

Re: [PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

Eugene.Zelenko added a comment. Probably old_source/new_source will be better, because different extensions are used for C++ files. https://reviews.llvm.org/D24243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[clang-tools-extra] r280741 - [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes.

Author: eugenezelenko Date: Tue Sep 6 14:53:26 2016 New Revision: 280741 URL: http://llvm.org/viewvc/llvm-project?rev=280741&view=rev Log: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes. Differential revision: https://reviews.llvm

r280828 - [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes.

Author: eugenezelenko Date: Wed Sep 7 12:37:28 2016 New Revision: 280828 URL: http://llvm.org/viewvc/llvm-project?rev=280828&view=rev Log: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes. Differential revision: https://revi

r280870 - Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes.

Author: eugenezelenko Date: Wed Sep 7 16:53:17 2016 New Revision: 280870 URL: http://llvm.org/viewvc/llvm-project?rev=280870&view=rev Log: Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes. Differential revision: https://reviews.llvm.org/D24115 Modifi

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

Eugene.Zelenko added a comment. Probably check should have options to extend list of containers and also to assume all classes with integer type size() const and bool empty() const as containers. It may be not trivial to find out all custom containers and last option will be helpful to assemble

Re: [PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to add cases when member is initialized in declaration and constructor, with same and different values. Comment at: docs/clang-tidy/checks/readability-redundant-member-i

Re: [PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:36 @@ +35,3 @@ + + using std::begin; + using std::end; begin() and end() are not used extensively. Why not to use std::? Repository: rL LLVM https://review

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

Eugene.Zelenko added a comment. Should we also check for absence of parameters in size() and empty() as well as const? https://reviews.llvm.org/D24349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

Eugene.Zelenko added a comment. If size() and empty() change object's state, it may be not equivalent replacement. Repository: rL LLVM https://reviews.llvm.org/D24349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to await clang-refactor and merge code there. Please run Include What You Use. Code use a lot of containers and will be good to include them explicitly. Comment at: mig

[PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

Re: [PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

Eugene.Zelenko marked 3 inline comments as done. Eugene.Zelenko added a comment. Repository: rL LLVM https://reviews.llvm.org/D24439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 71063. Eugene.Zelenko added a comment. Implement Saleem suggestions. Repository: rL LLVM https://reviews.llvm.org/D24439 Files: lib/Analysis/PrintfFormatString.cpp lib/Basic/Diagnostic.cpp lib/Basic/SourceManager.cpp lib/Index/IndexDecl.cp

[PATCH] D24487: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings in AST; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd, Prazek. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. I checked this patch on my own build on RHEL 6. Re

[PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, omtcyfz. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D24526 Files: docs/ReleaseNotes.rst Index: docs

Re: [PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:94 @@ +93,3 @@ + `_ check + supports arbitrary containers with ``empty()`` and ``size()`` methods. + al

[clang-tools-extra] r281510 - [Release notes] Mention readability-container-size-empty improvements.

Author: eugenezelenko Date: Wed Sep 14 12:41:51 2016 New Revision: 281510 URL: http://llvm.org/viewvc/llvm-project?rev=281510&view=rev Log: [Release notes] Mention readability-container-size-empty improvements. Differential revision: https://reviews.llvm.org/D24526 Modified: clang-tools-extr

Re: [PATCH] D24656: [clang-tidy] Add check readability-redundant-declaration

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Will be good idea to detect redundant function prototypes. However, I think this check should be part of Clang diagnostics. GCC has -Wre

Re: [PATCH] D24656: [clang-tidy] Add check readability-redundant-declaration

Eugene.Zelenko added inline comments. Comment at: test/clang-tidy/readability-redundant-declaration.cpp:9 @@ +8,3 @@ +extern int A; +extern int A,B; +// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: redundant variable A declaration Please run Clang-format over test.

[clang-tools-extra] r293234 - [Clang-tidy documentation] Consistency (fix-it); 80 characters per line.

Author: eugenezelenko Date: Thu Jan 26 17:58:21 2017 New Revision: 293234 URL: http://llvm.org/viewvc/llvm-project?rev=293234&view=rev Log: [Clang-tidy documentation] Consistency (fix-it); 80 characters per line. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-no-m

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D26649#595213, @mehdi_amini wrote: > Make sense to me, but I don't think it is enough: LLVM_ENABLE_LLD should be > passed to stage-2, and it also should be set to the absolute path of the > stage-1 lld build. What is search directori

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

Eugene.Zelenko added a comment. I think this should be handled in higher level script (utils/release/test-release.sh or similar), not in CMake. CMake compiler tests just need to fail when LLVM_ENABLE_LLD is used without actually having them. Repository: rL LLVM https://reviews.llvm.org/D266

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

Eugene.Zelenko added a comment. I meant that multi-stage build is processed by higher level script. So it should take care about consistency of source code srt versus later stages build options. Repository: rL LLVM https://reviews.llvm.org/D26649 _

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

Eugene.Zelenko added a comment. Yes, you are correct, I meant later. Repository: rL LLVM https://reviews.llvm.org/D26649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-default-member-init.rst:7 +This check converts a default constructor's member initializers into default +member initializers. Other member initializers that match the default +member initializ

[clang-tools-extra] r288175 - Fix some Clang-tidy modernize-use-default and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Nov 29 12:24:01 2016 New Revision: 288175 URL: http://llvm.org/viewvc/llvm-project?rev=288175&view=rev Log: Fix some Clang-tidy modernize-use-default and Include What You Use warnings; other minor fixes (NFC). This preparation to remove SetVector.h dependency on S

r288213 - Fix some Clang-tidy and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Nov 29 16:44:24 2016 New Revision: 288213 URL: http://llvm.org/viewvc/llvm-project?rev=288213&view=rev Log: Fix some Clang-tidy and Include What You Use warnings; other minor fixes (NFC). This preparation to remove SetVector.h dependency on SmallSet.h. Modified:

r289160 - [AST, ASTMatchers, Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Thu Dec 8 18:11:53 2016 New Revision: 289160 URL: http://llvm.org/viewvc/llvm-project?rev=289160&view=rev Log: [AST, ASTMatchers, Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AS

[clang-tools-extra] r284894 - [Release notes] Mention removed Clang-tidy misc-pointer-and-integral-operation check

Author: eugenezelenko Date: Fri Oct 21 17:35:58 2016 New Revision: 284894 URL: http://llvm.org/viewvc/llvm-project?rev=284894&view=rev Log: [Release notes] Mention removed Clang-tidy misc-pointer-and-integral-operation check Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

Re: [clang-tools-extra] r284894 - [Release notes] Mention removed Clang-tidy misc-pointer-and-integral-operation check

> > On Sat, Oct 22, 2016 at 12:35 AM, Eugene Zelenko via cfe-commits > wrote: >> Author: eugenezelenko >> Date: Fri Oct 21 17:35:58 2016 >> New Revision: 284894 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=284894&view=rev >> Log: >>

[PATCH] D25657: include-fixer: Don't overwrite buffer changes

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL285060. Please specify "Differential revision: " as last line of commit message. https://reviews.llvm.org/D25657 ___ cfe-commits mailing li

[PATCH] D26138: [clang-tidy] Add modernize-use-delete check

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). https://reviews.llvm.org/D26138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D26138: [clang-tidy] Add modernize-use-equals-delete check

Eugene.Zelenko added a comment. It'll be good idea to rename //modernize-use-default// in similar fashion, since both checks are closely relate and in both cases keywords are ambiguous. https://reviews.llvm.org/D26138 ___ cfe-commits mailing list c

[clang-tools-extra] r285645 - [Release notes] Highlight reset() as language/library artifact.

Author: eugenezelenko Date: Mon Oct 31 17:05:45 2016 New Revision: 285645 URL: http://llvm.org/viewvc/llvm-project?rev=285645&view=rev Log: [Release notes] Highlight reset() as language/library artifact. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trun

[PATCH] D26176: [Clang-tidy] Fix copy-paste error in misc-redundant-expression detected by PVS-Studio

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman, hokein, etienneb. Eugene.Zelenko added subscribers: cfe-commits, Prazek. Eugene.Zelenko set the repository for this revision to rL LLVM. Unfortunately, misc-redundant-expression didn't detect problem in ow

[clang-tools-extra] r285721 - [Clang-tidy] Fix copy-paste error in misc-redundant-expression detected by PVS-Studio

Author: eugenezelenko Date: Tue Nov 1 13:33:50 2016 New Revision: 285721 URL: http://llvm.org/viewvc/llvm-project?rev=285721&view=rev Log: [Clang-tidy] Fix copy-paste error in misc-redundant-expression detected by PVS-Studio Also fix some Include What You Use and modernize-use-bool-literals war

Re: [clang-tools-extra] r285721 - [Clang-tidy] Fix copy-paste error in misc-redundant-expression detected by PVS-Studio

Hi, Aaron! I don't think that it worth to split such trivial changes in three. Eugene. On Tue, Nov 1, 2016 at 11:51 AM, Aaron Ballman wrote: > On Tue, Nov 1, 2016 at 2:33 PM, Eugene Zelenko via cfe-commits > wrote: >> Author: eugenezelenko >> Date: Tue Nov 1 13:33:

[clang-tools-extra] r285778 - [Documentation] Clang-tidy readability-redundant-declaration consistency.

Author: eugenezelenko Date: Tue Nov 1 19:43:23 2016 New Revision: 285778 URL: http://llvm.org/viewvc/llvm-project?rev=285778&view=rev Log: [Documentation] Clang-tidy readability-redundant-declaration consistency. Release notes checks order and consistent Clang-tidy readability-redundant-declara

[clang-tools-extra] r285848 - [Documentation] Fix Clang-tidy misc-use-after-move and cert-msc50-cpp style and misspelling.

Author: eugenezelenko Date: Wed Nov 2 13:23:52 2016 New Revision: 285848 URL: http://llvm.org/viewvc/llvm-project?rev=285848&view=rev Log: [Documentation] Fix Clang-tidy misc-use-after-move and cert-msc50-cpp style and misspelling. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/ce

[PATCH] D21298: [Clang-tidy] delete null check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/misc-delete-null-pointer.rst:10 +.. code:: c++ +int *p; + if (p) Please indent variable declaration. https://reviews.llvm.org/D21298 ___ cfe

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

Eugene.Zelenko added a comment. I think will be good idea to mention this in documentation and release notes. https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D26354: Use -fsanitize-recover instead of -mllvm -msan-keep-going: clang.

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL286148. https://reviews.llvm.org/D26354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D25522: Remove warnings from google-benchmarks in libcxx

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL284179. https://reviews.llvm.org/D25522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D26282: [PowerPC] Implement plain VSX load/store builtins.

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL286455. See http://llvm.org/docs/Phabricator.html#committing-a-change for review automatic closing. https://reviews.llvm.org/D26282 ___ cf

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

Eugene.Zelenko added a comment. On my understanding share contains architecture-independent files. clang-format files installation is also part of CMake build only. http://reviews.llvm.org/D12700 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

Eugene.Zelenko added a comment. I'm sorry for making trouble. I don't have access to GCC 4.7. 4.8 build looks OK (not completed yet, but LLVM part didn't cause problems). Repository: rL LLVM http://reviews.llvm.org/D12741 ___ cfe-commits mailin

[PATCH] D12919: [clang-format] Make configure installation consistent with CMake

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. During D12700 review I was asked to make configure installation consistent with CMake. Since I modeled imple

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

Eugene.Zelenko set the repository for this revision to rL LLVM. Eugene.Zelenko updated this revision to Diff 34953. Eugene.Zelenko added a comment. I added installation in configure. See also http://reviews.llvm.org/D12919 for further configure improvements idea. Repository: rL LLVM http://r

[PATCH] D13187: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Also fixed Clang-tidy readability-simplify-boolean-expr in tools/libclang/CIndex.cpp. I checked this patch

[PATCH] D13406: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Please check it in if it's OK, because

Re: [PATCH] D13444: [clang-tidy] Clocky module and multiple check from my repository

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Will be good idea to review checks one by one. Checks should be named after function, not after author. If existing categories too wide, new one could be introduced, like performance (clocky-inefficient-container

Re: [PATCH] D13510: [PATCH] Support C++ Core Guidelines copy assignment restrictions

Eugene.Zelenko added a comment. I think it'll be fine to rename check without leaving traces of misc. Same thing happened with modernize-shrink-to-fit. http://reviews.llvm.org/D13510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D12473: [clang-tidy] Add old style function check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think extern "C" functions should be kept with (void). I may be mistaken, but looks like code doesn't check for in C++ mode. http://reviews.llvm.org/D12473 ___ cfe

Re: [PATCH] D12473: [clang-tidy] Add old style function check

Eugene.Zelenko added a comment. Just for reference: - Previous attempt: http://reviews.llvm.org/D7639. - Bugzilla request . http://reviews.llvm.org/D12473 ___ cfe-commits mailing list cfe-commits@lists.

Re: [PATCH] D12473: [clang-tidy] Add old style function check

Eugene.Zelenko added a comment. Sorry, I was mislead by check name. http://reviews.llvm.org/D12473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12619: [Static Analyzer] Minor cleanups for the nullability checker.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Why static was removed from getMostNullable() and getNullabilityString()? If these functions are not intended to be used outside this source file, it's good idea to limit their scope. Same should be done for Error

Re: [PATCH] D7639: Add readability-redundant-void-arg check to clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. What is preventing to add this check to Clang-tidy? Just found another piece of fresh C++ code in LLDB with (void) as argument list... http://reviews.llvm.org/D7639

[PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. I checked this patch on my own build on RHEL 6. Regressions were OK. Plea

Re: [PATCH] D13871: Add modernize-use-default check to clang-tidy.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Will be good idea to add handling of cases where default constructor is empty and only call base class(es) default constructor/members default constructors (see http://en.cppreference.com/w/cpp/language/default_co

[PATCH] D14311: [Clang] Fix some Clang-tidy modernize warnings, other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hans. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added subscribers: dschuff, jfb. Fixed warnings are: modernize-use-override, modernize-use-nullptr and

r252081 - Fix some Clang-tidy modernize warnings, other minor fixes.

Author: eugenezelenko Date: Wed Nov 4 15:37:17 2015 New Revision: 252081 URL: http://llvm.org/viewvc/llvm-project?rev=252081&view=rev Log: Fix some Clang-tidy modernize warnings, other minor fixes. Differential revision: http://reviews.llvm.org/D14311 Modified: cfe/trunk/lib/AST/ASTContext.

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko updated the summary for this revision. Eugene.Zelenko added a reviewer: aaron.ballman. Eugene.Zelenko updated this revision to Diff 39778. Eugene.Zelenko added a comment. Synchronize with current code. Repository: rL LLVM http://reviews.llvm.org/D13759 Files: include/clang/A

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

Eugene.Zelenko added inline comments. Comment at: include/clang/AST/ASTVector.h:385 @@ -383,3 +384,3 @@ // Allocate the memory from the ASTContext. - T *NewElts = new (C, llvm::alignOf()) T[NewCapacity]; + auto *NewElts = new (C, llvm::alignOf()) T[NewCapacity]; ---

[PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM ht

Re: [PATCH] D14560: [Clang] Fix Clang-tidy modernize-use-auto in some files in lib/AST; other minor cleanups.

Eugene.Zelenko added a comment. I'm adept of consistency :-) It's also easier to fix all similar patterns in code then do such cleanups selectively. Actually, similar fixes were made recently in Decl.cpp when casts were involved, but not new. Comment at: lib/AST/ASTContext.cpp

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst. See pre-4.0 branch versions as example. Comment at: docs/clang-tidy/checks/cppcoreguidelines-rule-of-five-and-zero.rst:15 @@ +14,3 @@ + +Note

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst. See pre-4.0 branch versions as example. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:116 @@ +115,3 @@ +} +// if there is only one not power-

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

Eugene.Zelenko added a comment. Will be good idea to introduce similar check for C++98/03. Repository: rL LLVM https://reviews.llvm.org/D22513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, mehdi_amini. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Build was broken because of missing climits where PATH_MAX is defined. Repository: rL LLVM ht

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

Eugene.Zelenko added a comment. But all of them are used in code. I don't see a reason to save lines :-) Repository: rL LLVM https://reviews.llvm.org/D22555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D22605: [Clang-tool-extra] Restructure release notes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, etienneb. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. There is no need for section of Clang-tidy changes version back anymore. Mention include-fixer.

[PATCH] D22654: [Clang-rename] Remove custom version, fix extra space in error message

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: omtcyfz, vmiklos, klimek. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I also fixed some Include What You Use Warnings. Repository: rL LLVM https://reviews.l

[PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: alexfh. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM https://review

<    1   2   3   4   5   6   >