Eugene.Zelenko added a subscriber: Eugene.Zelenko.
================
Comment at: clang-move/ClangMove.h:33
@@ +32,3 @@
+ clang::SourceManager *SM;
+ MovedDecl() : Decl(nullptr), SM(nullptr) {}
+ MovedDecl(const clang::Decl *Decl, clang::SourceManager *SM)
----------------
Please add empty line before. Why don't use C++11 members initialization and =
default?
================
Comment at: clang-move/ClangMove.h:83
@@ +82,3 @@
+public:
+ explicit ClangMoveAction(
+ const ClangMoveTool::MoveDefinitionSpec &spec,
----------------
Is explicit necessary?
================
Comment at: clang-move/ClangMove.h:106
@@ +105,3 @@
+ : Spec(Spec), FileToReplacements(FileToReplacements) {}
+ clang::FrontendAction *create() override {
+ return new ClangMoveAction(Spec, FileToReplacements);
----------------
Please add empty line before.
https://reviews.llvm.org/D24243
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
