Author: ioeric
Date: Tue Sep 18 03:30:44 2018
New Revision: 342460
URL: http://llvm.org/viewvc/llvm-project?rev=342460&view=rev
Log:
[clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.
Summary:
FileIndex now provides explicit interfaces for preamble and main file updates.
This avoids g
Author: ioeric
Date: Tue Sep 18 06:35:16 2018
New Revision: 342473
URL: http://llvm.org/viewvc/llvm-project?rev=342473&view=rev
Log:
[clangd] Get rid of Decls parameter in indexMainDecls. NFC
It's already available in ParsedAST.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
c
Author: ioeric
Date: Wed Sep 19 02:34:55 2018
New Revision: 342528
URL: http://llvm.org/viewvc/llvm-project?rev=342528&view=rev
Log:
[Sema] Do not load macros from preamble when LoadExternal is false.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: cfe-commits
Differential Rev
Author: ioeric
Date: Wed Sep 19 02:35:04 2018
New Revision: 342529
URL: http://llvm.org/viewvc/llvm-project?rev=342529&view=rev
Log:
[clangd] Store preamble macros in dynamic index.
Summary:
Pros:
o Loading macros from preamble for every completion is slow (see profile).
o Calculating macro USR i
Author: ioeric
Date: Fri Sep 21 06:04:57 2018
New Revision: 342730
URL: http://llvm.org/viewvc/llvm-project?rev=342730&view=rev
Log:
[clangd] Remember to serialize symbol origin in YAML.
Modified:
clang-tools-extra/trunk/clangd/index/SymbolYAML.cpp
clang-tools-extra/trunk/unittests/clangd
Author: ioeric
Date: Mon Sep 24 07:52:11 2018
New Revision: 342889
URL: http://llvm.org/viewvc/llvm-project?rev=342889&view=rev
Log:
[VFS] Use llvm::StringMap instead of std::map. NFC
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp
URL:
g static
index, but that doesn't seem to work in general.
I checked this in without review as I thought this was a trivial fix. The
binary serialization also serializes the Origin field.
>
> Am I missing something?
>
> On Fri, Sep 21, 2018 at 3:06 PM Eric Liu via cfe-commits &
Author: ioeric
Date: Tue Sep 25 01:24:07 2018
New Revision: 342951
URL: http://llvm.org/viewvc/llvm-project?rev=342951&view=rev
Log:
Deduplicate replacements from diagnostics.
Summary:
After r329813, clang-apply-replacements stopped deduplicating identical
replacements; however, tools like clang-
I wasn't aware of the bug. I have just replied to the issue. Thanks for
letting me know!
On Tue, Sep 25, 2018 at 10:44 AM Stephen Kelly via Phabricator <
revi...@reviews.llvm.org> wrote:
> steveire added a comment.
>
> Was this motivated by https://bugs.llvm.org/show_bug.cgi?id=38910 ?
>
>
> Repo
Author: ioeric
Date: Tue Sep 25 03:47:46 2018
New Revision: 342961
URL: http://llvm.org/viewvc/llvm-project?rev=342961&view=rev
Log:
[clangd] Check that scheme is valid when parsing URI.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet
Author: ioeric
Date: Tue Sep 25 04:47:14 2018
New Revision: 342964
URL: http://llvm.org/viewvc/llvm-project?rev=342964&view=rev
Log:
[clangd] Fix build bot after r342961
Use llvm::isAlpha instead of std::isalpha etc. This should fix bot failure:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x8
Author: ioeric
Date: Tue Sep 25 07:02:01 2018
New Revision: 342976
URL: http://llvm.org/viewvc/llvm-project?rev=342976&view=rev
Log:
[VFS] Add a proxy FS that delegates calls to underlying FS by default.
Summary:
This is useful when derived file systems want to override some calls
and still proxy
alization also serializes the Origin field.
>>
> LG to be consistent with binary serialization, the same question applies
> to binary serialization.
>
> Again, the change itself seems fine, just nitpicking on whether putting
> origin into a symbol at that level makes sense.
>
Author: ioeric
Date: Thu Sep 27 07:27:02 2018
New Revision: 343223
URL: http://llvm.org/viewvc/llvm-project?rev=343223&view=rev
Log:
[clangd] Make IncludeInserter less slow. NFC
Modified:
clang-tools-extra/trunk/clangd/Headers.cpp
clang-tools-extra/trunk/clangd/Headers.h
Modified: clang-
Author: ioeric
Date: Thu Sep 27 07:50:24 2018
New Revision: 343224
URL: http://llvm.org/viewvc/llvm-project?rev=343224&view=rev
Log:
[Tooling] Get rid of uses of llvm::Twine::str which is slow. NFC
Modified:
cfe/trunk/lib/Tooling/Inclusions/HeaderIncludes.cpp
Modified: cfe/trunk/lib/Tooling/
Author: ioeric
Date: Thu Sep 27 11:23:23 2018
New Revision: 343247
URL: http://llvm.org/viewvc/llvm-project?rev=343247&view=rev
Log:
[clangd] Add more tracing to index queries. NFC
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Differential Re
Author: ioeric
Date: Thu Sep 27 11:46:00 2018
New Revision: 343248
URL: http://llvm.org/viewvc/llvm-project?rev=343248&view=rev
Log:
[clangd] Initial supoprt for cross-namespace global code completion.
Summary:
When no scope qualifier is specified, allow completing index symbols
from any scope an
On Mon, Jul 30, 2018 at 5:19 PM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Mon Jul 30 08:19:05 2018
> New Revision: 338255
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338255&view=rev
> Log:
> [CodeComplete] Fix the crash in code completion o
n SemaCodeComplete. Thanks again!
>>
>> On Mon, Jul 30, 2018 at 5:22 PM Ilya Biryukov
>> wrote:
>>
>>> Prtially reverted the commit in r338255 to fix a very frequent crash.
>>> The code seemed obviously wrong there (calling accessibility checking,
>>
t; On Mon, Jul 30, 2018 at 5:22 PM Ilya Biryukov
>>> wrote:
>>>
>>>> Prtially reverted the commit in r338255 to fix a very frequent crash.
>>>> The code seemed obviously wrong there (calling accessibility checking,
>>>> passing a possibly unrelate
Author: ioeric
Date: Mon Oct 1 01:50:49 2018
New Revision: 343448
URL: http://llvm.org/viewvc/llvm-project?rev=343448&view=rev
Log:
[clangd] Fix header mapping for std::string. NFC
Some implementation has std::string declared in .
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncl
Author: ioeric
Date: Tue Oct 2 03:28:54 2018
New Revision: 343574
URL: http://llvm.org/viewvc/llvm-project?rev=343574&view=rev
Log:
Revert untintentionally commited changes
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
Modified:
cfe/trunk/lib/St
Author: ioeric
Date: Tue Oct 2 03:28:50 2018
New Revision: 343573
URL: http://llvm.org/viewvc/llvm-project?rev=343573&view=rev
Log:
[Lex] TokenConcatenation now takes const Preprocessor
Differential Revision: https://reviews.llvm.org/D52502
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/U
Author: ioeric
Date: Tue Oct 2 03:29:00 2018
New Revision: 343575
URL: http://llvm.org/viewvc/llvm-project?rev=343575&view=rev
Log:
[CodeComplete] Re-fix accessibilty of protected members from base class.
Summary:
The initial fix (r337453) had bug and was partially reverted (r338255).
This simpl
Sorry, I messed up my svn rebase somehow and committed and reverted this
again (r343574) when landing r343575.
On Tue, Oct 2, 2018 at 12:30 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Tue Oct 2 03:28:50 2018
> New Revision: 34357
Author: ioeric
Date: Tue Oct 2 03:43:55 2018
New Revision: 343576
URL: http://llvm.org/viewvc/llvm-project?rev=343576&view=rev
Log:
[clangd] Cache FS stat() calls when building preamble.
Summary:
The file stats can be reused when preamble is reused (e.g. code
completion). It's safe to assume tha
Author: ioeric
Date: Tue Oct 2 13:00:32 2018
New Revision: 343623
URL: http://llvm.org/viewvc/llvm-project?rev=343623&view=rev
Log:
[clangd] Try to fix windows buildbot after r343576
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20347/steps/test/logs/s
from Index, 0 matched, 1 returned.
>
>
>
> Can you please take a look?
>
> Douglas Yung
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> > Of Eric Liu via cfe-commits
> >
Author: ioeric
Date: Tue Oct 2 14:47:41 2018
New Revision: 343637
URL: http://llvm.org/viewvc/llvm-project?rev=343637&view=rev
Log:
[clangd] Temporarily disable VFS stats cache test for windows.
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp
Modified: clang-tools-extra/t
lld-x86_64-scei-ps4-windows10pro-fast\llvm.obj\tools\clang\tools\extra\unittests\clangd\..\lib\clang\8.0.0
>>
>> Preamble for file C:\clangd-test\foo.cpp cannot be reused. Attempting to
>> rebuild it.
>>
>> Built preamble of size 185492 for file C:\clangd-test\foo.cpp
Author: ioeric
Date: Mon Oct 8 10:22:50 2018
New Revision: 343982
URL: http://llvm.org/viewvc/llvm-project?rev=343982&view=rev
Log:
[clang-move] Dump whether a declaration is templated.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
clang-tools-extra/trunk/clang-move/ClangMov
Author: ioeric
Date: Tue Oct 9 01:27:31 2018
New Revision: 344024
URL: http://llvm.org/viewvc/llvm-project?rev=344024&view=rev
Log:
[clangd] Avoid cache main file status in preamble.
Summary: Main file can certainly change when reusing preamble.
Reviewers: sammccall
Subscribers: ilya-biryukov,
Author: ioeric
Date: Fri Feb 1 03:36:23 2019
New Revision: 352865
URL: http://llvm.org/viewvc/llvm-project?rev=352865&view=rev
Log:
[CUDA] Relax lit test condition after r352798.
Clang executable doesn't match clang.* in all test environment.
Modified:
cfe/trunk/test/Driver/cuda-detect.cu
Author: ioeric
Date: Sat Feb 2 02:35:39 2019
New Revision: 352957
URL: http://llvm.org/viewvc/llvm-project?rev=352957&view=rev
Log:
[clangd] Fix heap-use-after-free after r352868
Modified:
clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp
Modified: clang-tools-extra/trunk/unittests/
Author: ioeric
Date: Wed Feb 6 07:36:23 2019
New Revision: 353310
URL: http://llvm.org/viewvc/llvm-project?rev=353310&view=rev
Log:
[clangd] Add type boost to fuzzy find in Dex.
Summary:
No noticeable impact on code completions overall except some improvement on
cross-namespace completion.
Revi
Author: ioeric
Date: Thu Feb 7 01:23:22 2019
New Revision: 353380
URL: http://llvm.org/viewvc/llvm-project?rev=353380&view=rev
Log:
[clangd] Suggest adding missing includes for typos (like include-fixer).
Summary:
This adds include-fixer feature into clangd based on D56903. Clangd now captures
d
Author: ioeric
Date: Thu Feb 7 07:34:37 2019
New Revision: 353413
URL: http://llvm.org/viewvc/llvm-project?rev=353413&view=rev
Log:
[clangd] Use Dex for dynamic index by default.
Summary:
Memory usage for a sample TU:
Without Dex: 17.9M
WithDex: 24.4M
The memory increase is considerable
Author: ioeric
Date: Fri Feb 8 05:27:47 2019
New Revision: 353514
URL: http://llvm.org/viewvc/llvm-project?rev=353514&view=rev
Log:
[clangd] Fix an assertion in TypoCorrection.
Summary: https://github.com/clangd/clangd/issues/7
Reviewers: sammccall, hokein
Subscribers: ilya-biryukov, MaskRay,
Author: ioeric
Date: Mon Feb 11 07:05:29 2019
New Revision: 353708
URL: http://llvm.org/viewvc/llvm-project?rev=353708&view=rev
Log:
[clangd] Prefer location from codegen files when merging symbols.
Summary:
For example, if an index symbol has location in a .proto file and an AST symbol
has locat
Author: ioeric
Date: Wed Feb 13 00:58:54 2019
New Revision: 353926
URL: http://llvm.org/viewvc/llvm-project?rev=353926&view=rev
Log:
[clangd] Handle a few more diag kinds in include fixer.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #
Author: ioeric
Date: Mon Feb 18 05:12:10 2019
New Revision: 354268
URL: http://llvm.org/viewvc/llvm-project?rev=354268&view=rev
Log:
[clangd] Cache include fixes for diagnostics caused by the same unresolved name
or incomplete type.
Summary:
Multiple diagnostics can be caused by the same unresol
Author: ioeric
Date: Tue Feb 19 06:32:22 2019
New Revision: 354330
URL: http://llvm.org/viewvc/llvm-project?rev=354330&view=rev
Log:
[clangd] Handle unresolved scope specifier when fixing includes.
Summary:
In the following examples, "clangd" is unresolved, and the fixer will try to fix
include f
Author: ioeric
Date: Thu Feb 21 01:33:49 2019
New Revision: 354558
URL: http://llvm.org/viewvc/llvm-project?rev=354558&view=rev
Log:
[clangd] Handle another incomplete-type diagnostic case in IncludeFixer.
Modified:
clang-tools-extra/trunk/clangd/IncludeFixer.cpp
clang-tools-extra/trunk/u
Author: ioeric
Date: Thu Feb 21 03:22:58 2019
New Revision: 354570
URL: http://llvm.org/viewvc/llvm-project?rev=354570&view=rev
Log:
[CodeComplete] Collect visited contexts when scope specifier is invalid.
Summary:
This will allow completion consumers to guess the specified scope by
putting toget
Author: ioeric
Date: Thu Dec 13 07:35:43 2018
New Revision: 349049
URL: http://llvm.org/viewvc/llvm-project?rev=349049&view=rev
Log:
[clangd] Enable cross-namespace completions by default in clangd
Summary:
Code completion will suggest symbols from any scope (incl. inaccessible
scopes) when there
Author: ioeric
Date: Tue Dec 18 07:39:33 2018
New Revision: 349496
URL: http://llvm.org/viewvc/llvm-project?rev=349496&view=rev
Log:
[clangd] BackgroundIndex rebuilds symbol index periodically.
Summary:
Currently, background index rebuilds symbol index on every indexed file,
which can be ineffici
Author: ioeric
Date: Tue Dec 18 08:06:29 2018
New Revision: 349502
URL: http://llvm.org/viewvc/llvm-project?rev=349502&view=rev
Log:
[clangd] Try to fix buildbot failure after r349496
Increase timeout from 10ms to 100ms.
See http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/27959
Modi
Author: ioeric
Date: Wed Apr 25 02:17:05 2018
New Revision: 330803
URL: http://llvm.org/viewvc/llvm-project?rev=330803&view=rev
Log:
[clangd] Minor fixes for C++ standard library header mapping.
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: clang-tools-extra/
Author: ioeric
Date: Fri May 4 10:55:13 2018
New Revision: 331544
URL: http://llvm.org/viewvc/llvm-project?rev=331544&view=rev
Log:
[clang-format] Refactor #include insertion/deletion functionality into a class.
Summary:
The class will be moved into libToolingCore as followup.
The new behaviors
Author: ioeric
Date: Mon Jun 25 04:50:11 2018
New Revision: 335458
URL: http://llvm.org/viewvc/llvm-project?rev=335458&view=rev
Log:
[clangd] Always remove dots before converting paths to URIs in symbol collector.
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: c
Author: ioeric
Date: Mon Jun 25 09:29:19 2018
New Revision: 335492
URL: http://llvm.org/viewvc/llvm-project?rev=335492&view=rev
Log:
[clang-format] Add a default format style that can be used by users of
`getStyle`
Summary:
Tools that reformat code often call `getStyle` to decide the format styl
Author: ioeric
Date: Tue Jun 26 05:49:09 2018
New Revision: 335598
URL: http://llvm.org/viewvc/llvm-project?rev=335598&view=rev
Log:
[clangd] Use default clang-format styles.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modifie
Author: ioeric
Date: Thu Jun 28 09:51:12 2018
New Revision: 335874
URL: http://llvm.org/viewvc/llvm-project?rev=335874&view=rev
Log:
[clangd] Use log10 instead of the natural logrithm for usage boost.
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
clang-tools-extra/trunk/unittests/c
Author: ioeric
Date: Tue Jul 3 07:51:23 2018
New Revision: 336203
URL: http://llvm.org/viewvc/llvm-project?rev=336203&view=rev
Log:
[clangd] Use default format style and fallback style. NFC
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/Co
Author: ioeric
Date: Wed Jul 4 02:08:40 2018
New Revision: 336249
URL: http://llvm.org/viewvc/llvm-project?rev=336249&view=rev
Log:
Try to fix FileDistance test on windows.
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11510/steps/ninja%20check%201/logs/FAIL%3A%20Extra%20Tools%20
Hi Carlos, thanks for letting us know! I sent r336249 to fix the windows
test.
On Wed, Jul 4, 2018 at 9:51 AM Carlos Alberto Enciso via Phabricator <
revi...@reviews.llvm.org> wrote:
> CarlosAlbertoEnciso added a comment.
>
> Hi,
>
> It seems that your patch is causing an error in the tests for
>
Author: ioeric
Date: Wed Jul 4 02:43:35 2018
New Revision: 336252
URL: http://llvm.org/viewvc/llvm-project?rev=336252&view=rev
Log:
[clangd] Avoid collecting symbols from broken TUs in global-symbol-builder.
Summary:
For example, template parameter might not be resolved in a broken TU,
which can
Author: ioeric
Date: Wed Jul 4 02:54:23 2018
New Revision: 336253
URL: http://llvm.org/viewvc/llvm-project?rev=336253&view=rev
Log:
[clangd] Cleanup unittest: URIs. NFC.
Modified:
clang-tools-extra/trunk/unittests/clangd/FileDistanceTests.cpp
Modified: clang-tools-extra/trunk/unittests/clan
Author: ioeric
Date: Wed Jul 4 03:01:18 2018
New Revision: 336255
URL: http://llvm.org/viewvc/llvm-project?rev=336255&view=rev
Log:
[SemaCodeComplete] Make sure visited contexts are passed to completion results
handler.
Reviewers: ilya-biryukov
Subscribers: cfe-commits
Differential Revision:
Author: ioeric
Date: Wed Jul 4 03:39:48 2018
New Revision: 336260
URL: http://llvm.org/viewvc/llvm-project?rev=336260&view=rev
Log:
[clangd] only ignore collected symbols if TU has uncompilable errors.
Modified:
clang-tools-extra/trunk/clangd/global-symbol-builder/GlobalSymbolBuilderMain.cp
Author: ioeric
Date: Thu Jul 5 01:14:04 2018
New Revision: 336318
URL: http://llvm.org/viewvc/llvm-project?rev=336318&view=rev
Log:
[clangd] Treat class constructor as in the same scope as the class in ranking.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits
Diff
Author: ioeric
Date: Thu Jul 5 01:29:33 2018
New Revision: 336321
URL: http://llvm.org/viewvc/llvm-project?rev=336321&view=rev
Log:
[clangd] Log sema completion context kind and query scopes. NFC
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, cfe-commits
Differential Revisi
Author: ioeric
Date: Fri Jul 6 02:43:57 2018
New Revision: 336427
URL: http://llvm.org/viewvc/llvm-project?rev=336427&view=rev
Log:
[SemaCodeComplete] Expose a method to create CodeCompletionString for macros.
Summary:
The method only takes PPreprocessor and don't require structures that
might n
Author: ioeric
Date: Mon Jul 9 01:44:05 2018
New Revision: 336524
URL: http://llvm.org/viewvc/llvm-project?rev=336524&view=rev
Log:
[Index] Add indexing support for MACROs.
Reviewers: akyrtzi, arphaman, sammccall
Reviewed By: sammccall
Subscribers: malaperle, sammccall, cfe-commits
Differenti
Author: ioeric
Date: Mon Jul 9 02:17:25 2018
New Revision: 336532
URL: http://llvm.org/viewvc/llvm-project?rev=336532&view=rev
Log:
Try to fix build bot after r336524
Modified:
cfe/trunk/test/Index/Core/index-macros.c
Modified: cfe/trunk/test/Index/Core/index-macros.c
URL:
http://llvm.org/
Author: ioeric
Date: Mon Jul 9 08:31:07 2018
New Revision: 336553
URL: http://llvm.org/viewvc/llvm-project?rev=336553&view=rev
Log:
[clangd] Support indexing MACROs.
Summary: This is not enabled in the global-symbol-builder or dynamic index yet.
Reviewers: sammccall
Reviewed By: sammccall
Sub
Author: ioeric
Date: Mon Jul 9 11:54:51 2018
New Revision: 336581
URL: http://llvm.org/viewvc/llvm-project?rev=336581&view=rev
Log:
[clangd] Make sure macro information exists before increasing usage count.
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: clang-t
Author: ioeric
Date: Mon Jul 9 12:02:41 2018
New Revision: 336584
URL: http://llvm.org/viewvc/llvm-project?rev=336584&view=rev
Log:
[Index] Ignore noop #undef's when handling macro occurrences.
Modified:
cfe/trunk/lib/Index/IndexingAction.cpp
Modified: cfe/trunk/lib/Index/IndexingAction.cpp
Author: ioeric
Date: Wed Jul 11 06:15:31 2018
New Revision: 336801
URL: http://llvm.org/viewvc/llvm-project?rev=336801&view=rev
Log:
[clangd] Ignore sema code complete callback with recovery context.
Summary:
Sema code complete in the recovery mode is generally useless. For many
cases, sema first
Sounds good. Thanks for the suggestion!
On Wed, Jul 11, 2018 at 3:45 PM Sam McCall wrote:
>
>
> On Wed, Jul 11, 2018, 15:18 Eric Liu via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>> ioeric added a comment.
>>
>> In https://reviews.llvm.org/D49175#1158562, @sammccall wrote:
>>
>> > I lik
Author: ioeric
Date: Wed Jul 11 11:43:07 2018
New Revision: 336831
URL: http://llvm.org/viewvc/llvm-project?rev=336831&view=rev
Log:
Revert "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with
the requested name"
This reverts commit r336807. This breaks users of
ClangTool::mapVi
fyi, I've reverted this commit with r336831 due to some other issues.
On Wed, Jul 11, 2018 at 8:23 PM Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Simon,
>
> This commit added broken tests to one of our builders:
>
> http://lab.llvm.org:8011/builders/llvm-clang-ll
Author: ioeric
Date: Thu Jul 12 07:54:25 2018
New Revision: 336910
URL: http://llvm.org/viewvc/llvm-project?rev=336910&view=rev
Log:
[Tooling] Get working directory properly without assuming real file system.
Modified:
cfe/trunk/lib/Tooling/Tooling.cpp
Modified: cfe/trunk/lib/Tooling/Tooling
Author: ioeric
Date: Thu Jul 12 11:32:11 2018
New Revision: 336928
URL: http://llvm.org/viewvc/llvm-project?rev=336928&view=rev
Log:
[Tooling] Make standalone executor support user-provided vfs.
Modified:
cfe/trunk/include/clang/Tooling/StandaloneExecution.h
cfe/trunk/lib/Tooling/Standalo
Author: ioeric
Date: Wed Jul 18 08:17:52 2018
New Revision: 337394
URL: http://llvm.org/viewvc/llvm-project?rev=337394&view=rev
Log:
[CodeComplete] Allow getDeclaration on RK_Pattern result.
Summary:
RK_Pattern results can also have associated declarations e.g. field
decls in constructor initiali
Author: ioeric
Date: Wed Jul 18 08:31:14 2018
New Revision: 337396
URL: http://llvm.org/viewvc/llvm-project?rev=337396&view=rev
Log:
[clangd] Also get scope for RK_pattern completion results.
For exmaple, clas field candidates in constructor initializers can be
RK_Pattern, but they can still have
ioeric updated this revision to Diff 71729.
ioeric marked an inline comment as done.
ioeric added a comment.
- Use auto.
https://reviews.llvm.org/D24663
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
Index: lib/Tooling/Core/Replacement.cpp
ioeric updated this revision to Diff 71730.
ioeric added a comment.
- Format code properly.
https://reviews.llvm.org/D24663
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
Index: lib/Tooling/Core/Replacement.cpp
=
Author: ioeric
Date: Sat Sep 17 07:26:42 2016
New Revision: 281819
URL: http://llvm.org/viewvc/llvm-project?rev=281819&view=rev
Log:
When replacements have the same offset, make replacements with smaller length
order first in the set.
Summary:
No behavioral change intended. The change makes iter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281819: When replacements have the same offset, make
replacements with smaller length… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24663?vs=71730&id=71731#toc
Repository:
ioeric updated this revision to Diff 71777.
ioeric added a comment.
- Supports adding insertion around non-insertion replacements. Recommit r281457.
- Also add a test case for calculating ranges for replacements with the same
offset.
https://reviews.llvm.org/D24606
Files:
include/clang/Tooli
ioeric added a comment.
This patch now only recommits https://reviews.llvm.org/D24515 with an
additional test case `CalculateRangesOfInsertionAroundReplacement`.
https://reviews.llvm.org/D24606
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: ioeric
Date: Mon Sep 19 03:40:42 2016
New Revision: 281891
URL: http://llvm.org/viewvc/llvm-project?rev=281891&view=rev
Log:
Recommit r281457 "Supports adding insertion around non-insertion replacements".
Summary:
Diff to r281457:
- added a test case `CalculateRangesOfInsertionAroundRepla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281891: Recommit r281457 "Supports adding insertion around
non-insertion replacements". (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24606?vs=71777&id=71779#toc
Repository:
ioeric added inline comments.
Comment at: clang-refactor/driver/ModuleManager.h:14-20
@@ +13,9 @@
+#include "clang/Basic/LLVM.h"
+#include "llvm/ADT/StringRef.h"
+
+#include
+#include
+#include
+
+#include "core/RefactoringModule.h"
+
curdeius wrote:
> I though
ioeric added a comment.
In https://reviews.llvm.org/D24717#546096, @djasper wrote:
> Thinking about this some more, starting to merge deletions now, but only some
> of them is a bit suspect. I think we either want to allow even more or
> continue to be restrictive for now.
>
> I think fundament
ioeric added a comment.
In https://reviews.llvm.org/D24717#546279, @djasper wrote:
> I actually think this is a good example. So lets assume we'd write a tool to
> fully quote binary expressions, e.g. that turns
>
> if (a * b + c * d == 10) ...
>
>
> into
>
> if (((a * b) + (c * d)) == 10
ioeric updated this revision to Diff 71845.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Added MigrationEnvironment class and a dummy migrate-tool binary.
https://reviews.llvm.org/D24380
Files:
CMakeLists.txt
migrate-tool/AffectedFilesFinder.h
migrate-tool/BuildManag
ioeric added a comment.
In https://reviews.llvm.org/D24380#544720, @hokein wrote:
> Sorry for the delay.
> The patch only contains an unittest for `HeaderGenerato`r, which is not
> quite enough. Should we create a fake migrate-tool binary to illustrate APIs
> usage?
Done.
Good idea. I want
Author: ioeric
Date: Mon Sep 19 12:40:32 2016
New Revision: 281918
URL: http://llvm.org/viewvc/llvm-project?rev=281918&view=rev
Log:
A clang tool for changing surrouding namespaces of class/function definitions.
Summary:
A tool for changing surrouding namespaces of class/function definitions whil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281918: A clang tool for changing surrouding namespaces of
class/function definitions. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24183?vs=71689&id=71848#toc
Repository:
Author: ioeric
Date: Mon Sep 19 12:58:59 2016
New Revision: 281920
URL: http://llvm.org/viewvc/llvm-project?rev=281920&view=rev
Log:
Trying to fix name conflict in change-namespace tool.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
clang-tools-extra/trunk/change-
Author: ioeric
Date: Mon Sep 19 15:41:39 2016
New Revision: 281935
URL: http://llvm.org/viewvc/llvm-project?rev=281935&view=rev
Log:
Add missing dependency to change-namespace.
Modified:
clang-tools-extra/trunk/change-namespace/tool/CMakeLists.txt
clang-tools-extra/trunk/change-namespace/
Thanks for the fix!
On Tue, Sep 20, 2016, 02:53 NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date: Mon Sep 19 19:44:45 2016
> New Revision: 281954
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281954&view=rev
> Log:
> clang-change-namespace: Update l
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D24784
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-
ioeric added inline comments.
Comment at: clang-refactor/driver/Driver.cpp:36
@@ +35,3 @@
+argv[1] = (llvm::Twine(argv[0]) + " " +
llvm::Twine(argv[1])).str().c_str();
+Manager.dispatch(Command, argc - 1, argv + 1);
+ } else {
arphaman wrote:
> Is there
ioeric updated this revision to Diff 72018.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24784
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespa
ioeric updated this revision to Diff 72045.
ioeric added a comment.
- Provide order-independent replacements examples in comments.
https://reviews.llvm.org/D24800
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index:
Author: ioeric
Date: Wed Sep 21 10:06:12 2016
New Revision: 282073
URL: http://llvm.org/viewvc/llvm-project?rev=282073&view=rev
Log:
[change-namespace] fix name qualifiers in UsingShadowDecl and
NestedNameSpecifier.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282073: [change-namespace] fix name qualifiers in
UsingShadowDecl and… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24784?vs=72018&id=72046#toc
Repository:
rL LLVM
https:
201 - 300 of 970 matches
Mail list logo
