ioeric added inline comments. ================ Comment at: clang-refactor/driver/Driver.cpp:36 @@ +35,3 @@ + argv[1] = (llvm::Twine(argv[0]) + " " + llvm::Twine(argv[1])).str().c_str(); + Manager.dispatch(Command, argc - 1, argv + 1); + } else { ---------------- arphaman wrote: > Is there a particular reason why you don't return a value that's returned by > Manager.dispatch here? It seems odd to me that Manager.dispatch returns an > integer value that's not actually used here. BTW, isn't `argv[1]` pointing to a temp string above?
https://reviews.llvm.org/D24192 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits