EricWF added a comment.
I should mention that before this patch a GCC compiled dylib had 62 additional
symbols and was missing 105 symbols. Now there are only 20 missing symbols and
62 additional.
https://reviews.llvm.org/D24600
___
cfe-commits ma
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This approach looks great. I don't think we need to split things up into
separate files. This is exactly how `test_macros.h` should be used.
Feel free to convert as many tests as possible. I'v
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
This patch fixes a number of problems with the visibility macros across GCC (on
Unix) and Windows (DLL import/export semantics). All of the visibili
EricWF updated this revision to Diff 71486.
EricWF added a comment.
Fix obvious errors in docs.
https://reviews.llvm.org/D24602
Files:
CMakeLists.txt
docs/DesignDocs/VisibilityMacros.rst
docs/index.rst
include/__config
include/__locale
include/__string
include/experimental/filesys
EricWF added inline comments.
Comment at: include/__config:605
@@ +604,3 @@
+# if __has_attribute(__type_visibility__)
+#define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS __attribute__
((__visibility__("default")))
+# else
Checking `__type_visibility__` and using `__
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the patch.
Comment at: src/cxa_thread_atexit.cpp:70
@@ +69,3 @@
+
+ void run_dtors(void*) {
+while (auto head = dtors) {
Na I thought I
EricWF added a comment.
In https://reviews.llvm.org/D24599#543849, @mclow.lists wrote:
> Any reason we shouldn't just revert r280944, wait for the LLVM bug to be
> fixed, and then re-apply it?
I would like to put some time between fixing the Clang bug and re-introducing
the reproducer into li
EricWF added a comment.
Thanks for working on this. That static initialization bug is ugly.
My only concern with this patch is that adding `constexpr` to unconstrained
constructors is going to result compile errors caused by Clang's eager
instantiation.
Also, unlike @mclow.lists, I think we sh
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
After talking with @rmaprath we have agreed to go in a different direction.
Resigning as reviewer to keep my queue clean.
https://reviews.llvm.org/D23926
___
EricWF abandoned this revision.
EricWF added a comment.
Abandoning. All issues have been addressed by other commits.
Comment at: include/memory:5452-5458
@@ +5451,9 @@
+ {
+return static_cast<_To>(_FromPtrTraits::pointer_to(__e));
+ }
+
+ _LIBCPP_INLINE_VISIBILITY
+ stat
EricWF updated this revision to Diff 71570.
EricWF added a comment.
I'm going to go ahead and commit this w/o review because it's blocking more
important changes. Post-commit comments on the documentation are appreciated.
https://reviews.llvm.org/D24602
Files:
CMakeLists.txt
docs/DesignDoc
Author: ericwf
Date: Thu Sep 15 17:27:07 2016
New Revision: 281673
URL: http://llvm.org/viewvc/llvm-project?rev=281673&view=rev
Log:
[libc++] Fix and document visibility attributes for Clang, GCC and Windows.
Summary:
This patch fixes a number of problems with the visibility macros across GCC (on
EricWF updated this revision to Diff 71574.
EricWF added a comment.
- Update the patch based on r281673.
- Add doc for `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY`
- Move all uses of `_LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY` to the first
declaration in order to support `__attribute__((internal_l
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting to commit. Post commit review is very welcome (but nobody likes
looking at visibility patches).
https://reviews.llvm.org/D24600
_
Author: ericwf
Date: Thu Sep 15 19:00:48 2016
New Revision: 281681
URL: http://llvm.org/viewvc/llvm-project?rev=281681&view=rev
Log:
[libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI
compatibility
Summary:
GCC and Clang handle visibility attributes on the out-of-line defi
Author: ericwf
Date: Thu Sep 15 19:07:16 2016
New Revision: 281683
URL: http://llvm.org/viewvc/llvm-project?rev=281683&view=rev
Log:
Move inline attributes in filesystem to first declaration
Modified:
libcxx/trunk/include/experimental/filesystem
Modified: libcxx/trunk/include/experimental/fi
Author: ericwf
Date: Thu Sep 15 19:13:55 2016
New Revision: 281684
URL: http://llvm.org/viewvc/llvm-project?rev=281684&view=rev
Log:
Use _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY in valarray to support
attribute((internal_linkage)).
The externally instantiated member functions must be declared u
EricWF created this revision.
EricWF added reviewers: mclow.lists, eugenis.
EricWF added subscribers: cfe-commits, eugenis.
This patch has been a long time coming (Thanks @eugenis). It changes
`_LIBCPP_INLINE_VISIBILITY` to use `__attribute__((internal_linkage))` instead
of `__attribute__((visib
EricWF updated this revision to Diff 71579.
EricWF added a comment.
Revert accidental change.
https://reviews.llvm.org/D24642
Files:
include/__config
src/string.cpp
Index: src/string.cpp
===
--- src/string.cpp
+++ src/string.c
Author: ericwf
Date: Thu Sep 15 21:09:26 2016
New Revision: 281691
URL: http://llvm.org/viewvc/llvm-project?rev=281691&view=rev
Log:
Move _LIBCPP_INLINE_VISIBILITY to first declaration in sstream.
Modified:
libcxx/trunk/include/sstream
Modified: libcxx/trunk/include/sstream
URL:
http://llvm
Author: ericwf
Date: Thu Sep 15 21:16:23 2016
New Revision: 281692
URL: http://llvm.org/viewvc/llvm-project?rev=281692&view=rev
Log:
Move _LIBCPP_INLINE_VISIBILITY to first declaration in
Modified:
libcxx/trunk/include/experimental/propagate_const
Modified: libcxx/trunk/include/experimental
EricWF updated this revision to Diff 71590.
EricWF added a comment.
- Add `always_inline` to _LIBCPP_INLINE_VISIBILITY. In future I think only
_LIBCPP_ALWAYS_INLINE should actually apply `always_inline`, but I'll make that
change separately.
- Change `_LIBCPP_ALWAYS_INLINE` to use `internal_link
Author: ericwf
Date: Thu Sep 15 21:51:26 2016
New Revision: 281695
URL: http://llvm.org/viewvc/llvm-project?rev=281695&view=rev
Log:
Update _LIBCPP_EXCEPTION_ABI doc with @mclow's feedback
Modified:
libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst
Modified: libcxx/trunk/docs/DesignDocs/Visi
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
The new overloads taking string_view's need to guard against self-aliasing
string_views. Once that is fixed I would double check that your tests for
`!is_convertible<_Tp const&, const _CharT*>
Author: ericwf
Date: Thu Sep 15 22:47:53 2016
New Revision: 281697
URL: http://llvm.org/viewvc/llvm-project?rev=281697&view=rev
Log:
Attempt to fix Sphinx build
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
libcxx/trunk/docs/Makefile.sphinx
libcxx/trunk/docs/TestingLibcxx.rst
Modifi
EricWF created this revision.
EricWF added reviewers: rnk, delcypher.
EricWF added subscribers: llvm-commits, cfe-commits.
Herald added subscribers: mgorny, beanz.
The actual logic to build http://llvm.org/libcxx/docs does so with "-W" and
"-n" enabled, meaning that the website will not be update
EricWF updated this revision to Diff 71594.
EricWF added a comment.
Use spaces not tabs.
https://reviews.llvm.org/D24646
Files:
cmake/modules/AddSphinxTarget.cmake
Index: cmake/modules/AddSphinxTarget.cmake
===
--- cmake/modules
EricWF added a comment.
I'll commit this change tomorrow barring any objections.
https://reviews.llvm.org/D24642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Fri Sep 16 03:16:07 2016
New Revision: 281709
URL: http://llvm.org/viewvc/llvm-project?rev=281709&view=rev
Log:
Fix side effect in assertion
Modified:
libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp
Modified: libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp
URL:
Author: ericwf
Date: Fri Sep 16 05:04:38 2016
New Revision: 281712
URL: http://llvm.org/viewvc/llvm-project?rev=281712&view=rev
Log:
Touch up [[clang::require_constant_initialization]] docs
* Fix an egregious comma usage.
* Remove the `static` keyword in the example since the variables should hav
EricWF abandoned this revision.
EricWF added a comment.
Abandoning. This option is only needed when using old versions of Sphinx.
https://reviews.llvm.org/D24646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
https://reviews.llvm.org/D24678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: ericwf
Date: Wed Mar 22 17:41:41 2017
New Revision: 298554
URL: http://llvm.org/viewvc/llvm-project?rev=298554&view=rev
Log:
[libc++] Work around C1XX bug which breaks poisoned hash tests.
Summary: This is my attempt to work around the C1XX bug described to me by
@BillyONeal.
Reviewers:
Author: ericwf
Date: Wed Mar 22 19:33:33 2017
New Revision: 298565
URL: http://llvm.org/viewvc/llvm-project?rev=298565&view=rev
Log:
[coroutines] Implement unhandled_exception changes.
Summary:
This patch adopts the recent changes that renamed
`set_exception(exception_pointer)` to `unhandled_exc
Author: ericwf
Date: Wed Mar 22 19:48:59 2017
New Revision: 298566
URL: http://llvm.org/viewvc/llvm-project?rev=298566&view=rev
Log:
Address post-commit review comments regarding test_workarounds.h
Modified:
libcxx/trunk/test/support/test.workarounds/c1xx_broken_nullptr_conversion_operator.p
ces.
> - It causes inlining at -O0, which, without other optimizations, can blow
> up stack size of static_initializers.
> - It overrides the inliner heuristics, which *should* be smarter.
>
> Why can't we get away with just the `inline` keyword and trust the
> compiler (a
; changes to add always_inline to basic_string::__init. Our user had some
> string => enum value map declared statically, like in the attached
> stackoverflow.cpp. At -Os (and higher), there's no difference. But with
> -O0 and -O1, they started getting a stack overflow at launch.
&g
Author: ericwf
Date: Thu Mar 30 14:43:50 2017
New Revision: 299100
URL: http://llvm.org/viewvc/llvm-project?rev=299100&view=rev
Log:
Implement LWG 2842 - optional(U&&) needs to SFINAE on decay_t
Modified:
libcxx/trunk/include/optional
libcxx/trunk/test/std/utilities/optional/optional.obj
Author: ericwf
Date: Thu Mar 30 15:06:52 2017
New Revision: 299105
URL: http://llvm.org/viewvc/llvm-project?rev=299105&view=rev
Log:
Fix LWG 2934 - optional doesn't compare with T
Modified:
libcxx/trunk/include/optional
libcxx/trunk/test/std/utilities/optional/optional.comp_with_t/equal.p
This will be ABI breaking for Objective-C++ users. I'm not objecting to
fixing the bogus configuration, but I just wanted to point it out.
/Eric
On Fri, Mar 31, 2017 at 11:39 AM, Duncan P. N. Exon Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dexonsmith
> Date: Fri Mar 31
On Fri, Mar 31, 2017 at 4:17 PM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
> Thanks. Unfortunately that's one of the ways we figured it out :(.
>
> The status quo, before this commit, was an ABI difference between
> Objective-C++ (-fobjc-arc) and C++/Objective-C++ (-fno-objc-arc), wh
Author: ericwf
Date: Mon Apr 3 14:21:00 2017
New Revision: 299380
URL: http://llvm.org/viewvc/llvm-project?rev=299380&view=rev
Log:
[coroutines] Fix rebuilding of implicit and dependent coroutine statements.
Summary:
Certain implicitly generated coroutine statements, such as the calls to
'retur
Author: ericwf
Date: Mon Apr 3 15:53:15 2017
New Revision: 299385
URL: http://llvm.org/viewvc/llvm-project?rev=299385&view=rev
Log:
suppress GCC warning about noexcept functions changing mangling
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/utils/libcxx/test/config.py
Modified: li
I'll create a reduced reproducer, but it'll take some time because GCC is
quite cryptic about the instantiation stack.
if you want many instances within the libc++ build simply revert this
commit and build with a new GCC.
/Eric
___
cfe-commits mailing l
Here is a reduced version.
void glibc_function() throw() {}
template struct Test {
Test() {} // expected-error {{mangled name for 'Test::Test()' will
change in C++17}}
~Test() {} // expected-error {{mangled name for 'Test::~Test()' will
change in C++17}}
};
Test t;
/Eric
On Mon, Apr 3, 2
Author: ericwf
Date: Mon Apr 3 18:23:44 2017
New Revision: 299401
URL: http://llvm.org/viewvc/llvm-project?rev=299401&view=rev
Log:
Fix C++17 dylib build
Modified:
libcxx/trunk/include/algorithm
Modified: libcxx/trunk/include/algorithm
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/
Author: ericwf
Date: Mon Apr 3 20:05:59 2017
New Revision: 299407
URL: http://llvm.org/viewvc/llvm-project?rev=299407&view=rev
Log:
Work around recent -Wshadow changes in Clang
Modified:
libcxx/trunk/include/experimental/filesystem
libcxx/trunk/include/regex
Modified: libcxx/trunk/inclu
Author: ericwf
Date: Mon Apr 3 21:54:27 2017
New Revision: 299411
URL: http://llvm.org/viewvc/llvm-project?rev=299411&view=rev
Log:
Fix more -Wshadow warnings introduced by recent Clang change
Modified:
libcxx/trunk/test/std/containers/associative/map/map.cons/iter_iter_comp_alloc.pass.cpp
Author: ericwf
Date: Wed Apr 12 17:07:47 2017
New Revision: 300115
URL: http://llvm.org/viewvc/llvm-project?rev=300115&view=rev
Log:
Fix clang-tidy shared link with libc++
Currently the ClangTidyMain.cpp fails to link against shared LLVM/Clang
libraries
due to the missing symbol:
clang::tooli
Author: ericwf
Date: Wed Apr 12 17:12:15 2017
New Revision: 300116
URL: http://llvm.org/viewvc/llvm-project?rev=300116&view=rev
Log:
[Sema] Add __is_aggregate type-trait
Summary:
[LWG 2911](http://cplusplus.github.io/LWG/lwg-defects.html#2911) adds
`std::is_aggregate` to the library, which requi
Author: ericwf
Date: Wed Apr 12 17:43:49 2017
New Revision: 300121
URL: http://llvm.org/viewvc/llvm-project?rev=300121&view=rev
Log:
Fix incorrectly qualified return type from unique_ptr::get_deleter().
For reference deleter types the const qualifier on the return type
of get_deleter() should be
Author: ericwf
Date: Wed Apr 12 18:08:46 2017
New Revision: 300126
URL: http://llvm.org/viewvc/llvm-project?rev=300126&view=rev
Log:
[libc++] Implement LWG 2911 - add an is_aggregate type-trait
Summary:
This patch implements http://cplusplus.github.io/LWG/lwg-defects.html#2911.
I'm putting this
Author: ericwf
Date: Wed Apr 12 18:45:53 2017
New Revision: 300140
URL: http://llvm.org/viewvc/llvm-project?rev=300140&view=rev
Log:
[libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times,
and add constexpr.
Summary:
__compressed_pair takes and passes it's constructor argu
Author: ericwf
Date: Wed Apr 12 18:17:17 2017
New Revision: 300132
URL: http://llvm.org/viewvc/llvm-project?rev=300132&view=rev
Log:
Fix test failures with older Clang versions
Modified:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.observers/get_del
This broke a bunch of bots. Fix incoming. Please don't revert.
On Wed, Apr 12, 2017 at 5:45 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Wed Apr 12 18:45:53 2017
> New Revision: 300140
>
> URL: http://llvm.org/viewvc/ll
Author: ericwf
Date: Wed Apr 12 19:34:24 2017
New Revision: 300148
URL: http://llvm.org/viewvc/llvm-project?rev=300148&view=rev
Log:
Fix most failures caused by r300140
r300140 introduced a bunch of failures by changing the internal
interface provided by __compressed_pair. This patch fixes all of
Author: ericwf
Date: Wed Apr 12 20:03:41 2017
New Revision: 300156
URL: http://llvm.org/viewvc/llvm-project?rev=300156&view=rev
Log:
Update tests -verify error messages after r300140.
Modified:
libcxx/trunk/test/libcxx/containers/unord/unord.set/missing_hash_specialization.fail.cpp
Modified
Author: ericwf
Date: Wed Apr 12 20:02:41 2017
New Revision: 300154
URL: http://llvm.org/viewvc/llvm-project?rev=300154&view=rev
Log:
Fix more bad member swap definitions in unordered_map.
The __unordered_map_equal and __unordered_map_hash wrappers
attempt to swap const qualified predicates whenev
Author: ericwf
Date: Wed Apr 12 20:11:58 2017
New Revision: 300158
URL: http://llvm.org/viewvc/llvm-project?rev=300158&view=rev
Log:
Add tests that std::unique_ptr's default constructor is constexpr.
std::unique_ptr's default constructor must be constexpr in order
to allow constant initialization
Author: ericwf
Date: Wed Apr 12 20:13:58 2017
New Revision: 300159
URL: http://llvm.org/viewvc/llvm-project?rev=300159&view=rev
Log:
Fix C++03 test failures
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/
Author: ericwf
Date: Wed Apr 12 21:54:13 2017
New Revision: 300164
URL: http://llvm.org/viewvc/llvm-project?rev=300164&view=rev
Log:
Diagnose when reverse_iterator is used on path::iterator.
path::iterator isn't a strictly conforming iterator. Specifically
it stashes the current element inside th
Author: ericwf
Date: Wed Apr 12 21:56:03 2017
New Revision: 300165
URL: http://llvm.org/viewvc/llvm-project?rev=300165&view=rev
Log:
Fix template >> within C++03 code
Modified:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default_allows_incompl
Author: ericwf
Date: Wed Apr 12 19:50:45 2017
New Revision: 300152
URL: http://llvm.org/viewvc/llvm-project?rev=300152&view=rev
Log:
Fix the default constructibility of __compressed_pair.
This patch fixes a bug where the =default default ctor for
__compressed_pair was incorrect for const qualifie
Author: ericwf
Date: Thu Apr 13 00:27:55 2017
New Revision: 300175
URL: http://llvm.org/viewvc/llvm-project?rev=300175&view=rev
Log:
Cleanup any_cast failure test
Modified:
libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/reference_types.fail.cpp
Modified:
libcxx/trunk/test/std/
Author: ericwf
Date: Thu Apr 13 05:17:23 2017
New Revision: 300191
URL: http://llvm.org/viewvc/llvm-project?rev=300191&view=rev
Log:
Add TEST_NOEXCEPT_FALSE to support D31738
Modified:
libcxx/trunk/test/support/test_macros.h
Modified: libcxx/trunk/test/support/test_macros.h
URL:
http://llvm
Author: ericwf
Date: Fri Apr 14 21:45:43 2017
New Revision: 300387
URL: http://llvm.org/viewvc/llvm-project?rev=300387&view=rev
Log:
Make clang-format use C++03 syntax
Modified:
libcxx/trunk/.clang-format
Modified: libcxx/trunk/.clang-format
URL:
http://llvm.org/viewvc/llvm-project/libcxx/t
Author: ericwf
Date: Sat Apr 15 00:41:45 2017
New Revision: 300390
URL: http://llvm.org/viewvc/llvm-project?rev=300390&view=rev
Log:
[libcxx] Fix check-cxx-abilist on OS X
Summary:
Recent commits broke the check-cxx-abilist by changing the default OS X to use
`-rexport_library` instead of `-reex
Author: ericwf
Date: Sat Apr 15 01:49:02 2017
New Revision: 300397
URL: http://llvm.org/viewvc/llvm-project?rev=300397&view=rev
Log:
Fix PR32642 - string::insert and string::append don't work with move_iterator.
Modified:
libcxx/trunk/include/string
libcxx/trunk/test/std/strings/basic.st
Author: ericwf
Date: Sat Apr 15 07:05:11 2017
New Revision: 300399
URL: http://llvm.org/viewvc/llvm-project?rev=300399&view=rev
Log:
Simplify test helper
Modified:
libcxx/trunk/test/support/unique_ptr_test_helper.h
Modified: libcxx/trunk/test/support/unique_ptr_test_helper.h
URL:
http://llv
Author: ericwf
Date: Sat Apr 15 14:32:02 2017
New Revision: 300403
URL: http://llvm.org/viewvc/llvm-project?rev=300403&view=rev
Log:
Implement LWG 2857 for variant. Tests from Casey Carter @ Microsoft.
Also mark LWG 2857 as complete, since the changes to optional and
any were completed by Marshal
Author: ericwf
Date: Sat Apr 15 20:51:04 2017
New Revision: 300406
URL: http://llvm.org/viewvc/llvm-project?rev=300406&view=rev
Log:
Overhaul unique_ptr - Implement LWG 2801, 2905, 2520.
This patch overhauls both specializations of unique_ptr while implementing
the following LWG issues:
* LWG 28
Author: ericwf
Date: Sat Apr 15 21:06:25 2017
New Revision: 300407
URL: http://llvm.org/viewvc/llvm-project?rev=300407&view=rev
Log:
Cleanup default_delete specializations
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-project/li
Author: ericwf
Date: Sat Apr 15 21:14:31 2017
New Revision: 300408
URL: http://llvm.org/viewvc/llvm-project?rev=300408&view=rev
Log:
Cleanup and better scope unique_ptr internals
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-pro
Author: ericwf
Date: Sat Apr 15 21:40:45 2017
New Revision: 300410
URL: http://llvm.org/viewvc/llvm-project?rev=300410&view=rev
Log:
Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in vector.
This patch cleans up all usages of the following feature test macros inside
and its tests:
* _LIBCPP_HA
Author: ericwf
Date: Sat Apr 15 21:47:46 2017
New Revision: 300411
URL: http://llvm.org/viewvc/llvm-project?rev=300411&view=rev
Log:
Workaround Clang bug regarding template template parameters
Modified:
libcxx/trunk/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move
Author: ericwf
Date: Sat Apr 15 21:50:40 2017
New Revision: 300412
URL: http://llvm.org/viewvc/llvm-project?rev=300412&view=rev
Log:
Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in
Modified:
libcxx/trunk/include/array
libcxx/trunk/test/std/containers/sequences/array/array.size/size.pa
Author: ericwf
Date: Sat Apr 15 22:17:01 2017
New Revision: 300413
URL: http://llvm.org/viewvc/llvm-project?rev=300413&view=rev
Log:
Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in deque
Modified:
libcxx/trunk/include/deque
libcxx/trunk/test/std/containers/sequences/deque/deque.cons/a
Author: ericwf
Date: Sat Apr 15 22:45:35 2017
New Revision: 300414
URL: http://llvm.org/viewvc/llvm-project?rev=300414&view=rev
Log:
Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in
Modified:
libcxx/trunk/include/list
libcxx/trunk/test/std/containers/sequences/list/list.cons/assign_in
Author: ericwf
Date: Sat Apr 15 23:02:01 2017
New Revision: 300415
URL: http://llvm.org/viewvc/llvm-project?rev=300415&view=rev
Log:
Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in
Modified:
libcxx/trunk/include/forward_list
libcxx/trunk/test/std/containers/sequences/forwardlist/forw
Author: ericwf
Date: Sat Apr 15 23:05:15 2017
New Revision: 300417
URL: http://llvm.org/viewvc/llvm-project?rev=300417&view=rev
Log:
Cleanup one more test
Removed:
libcxx/trunk/test/std/containers/sequences/forwardlist/forwardlist.cons/size.fail.cpp
Modified:
libcxx/trunk/test/std/cont
Author: ericwf
Date: Sun Apr 16 04:19:59 2017
New Revision: 300420
URL: http://llvm.org/viewvc/llvm-project?rev=300420&view=rev
Log:
[coroutines] Fix building of new/delete expressions when
get_return_object_on_allocation_failure() is present.
Summary:
This patch implements [dcl.fct.def.coroutin
Author: ericwf
Date: Sun Apr 16 04:34:28 2017
New Revision: 300421
URL: http://llvm.org/viewvc/llvm-project?rev=300421&view=rev
Log:
Revert r300420 - [coroutines] Fix building of new/delete expressions when
get_return_object_on_allocation_failure() is present
Modified:
cfe/trunk/include/clan
One better, it has already been fixed.
On Apr 16, 2017 12:48 PM, "Nico Weber" wrote:
> Is that bug filed?
>
> On Sat, Apr 15, 2017 at 10:47 PM, Eric Fiselier via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ericwf
>> Date: Sat A
Author: ericwf
Date: Mon Apr 17 15:20:27 2017
New Revision: 300489
URL: http://llvm.org/viewvc/llvm-project?rev=300489&view=rev
Log:
Fix passing incorrectly value-category when constructing unique_ptr's deleter
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilities/smartpt
Author: ericwf
Date: Mon Apr 17 17:06:13 2017
New Revision: 300504
URL: http://llvm.org/viewvc/llvm-project?rev=300504&view=rev
Log:
[coroutines] Fix rebuilding of implicit and dependent coroutine statements.
Summary:
Certain implicitly generated coroutine statements, such as the calls to
'retur
Author: ericwf
Date: Mon Apr 17 17:32:02 2017
New Revision: 300510
URL: http://llvm.org/viewvc/llvm-project?rev=300510&view=rev
Log:
Work around GCC 4.9 bug regarding default initialization of const variables
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
h
Author: ericwf
Date: Mon Apr 17 17:40:44 2017
New Revision: 300511
URL: http://llvm.org/viewvc/llvm-project?rev=300511&view=rev
Log:
Revert r300504 - [coroutines] Fix rebuilding of implicit and dependent
coroutine statements.
I have no idea what's happening here. The tests that fail on all of th
Author: ericwf
Date: Mon Apr 17 18:28:02 2017
New Revision: 300513
URL: http://llvm.org/viewvc/llvm-project?rev=300513&view=rev
Log:
Rename coroutine warning when unhandled_exception() is missing
Modified:
cfe/trunk/include/clang/Basic/DiagnosticGroups.td
cfe/trunk/include/clang/Basic/Dia
Author: ericwf
Date: Mon Apr 17 22:12:48 2017
New Revision: 300524
URL: http://llvm.org/viewvc/llvm-project?rev=300524&view=rev
Log:
[coroutines] Fix building of new/delete expressions when
get_return_object_on_allocation_failure() is present.
Summary:
This patch implements [dcl.fct.def.coroutin
Author: ericwf
Date: Tue Apr 18 00:08:08 2017
New Revision: 300528
URL: http://llvm.org/viewvc/llvm-project?rev=300528&view=rev
Log:
Speculatively attempt to fix bot failures caused by recent coroutine changes.
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
Modified: cfe/trunk/lib/Sema/SemaC
Author: ericwf
Date: Tue Apr 18 00:30:39 2017
New Revision: 300529
URL: http://llvm.org/viewvc/llvm-project?rev=300529&view=rev
Log:
Assert that a valid operator new/delete signature is always found by the
coroutine body
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
Modified: cfe/trunk/lib
Author: ericwf
Date: Tue Apr 18 02:17:20 2017
New Revision: 300530
URL: http://llvm.org/viewvc/llvm-project?rev=300530&view=rev
Log:
Update google benchmark
Added:
libcxx/trunk/utils/google-benchmark/cmake/Config.cmake.in
libcxx/trunk/utils/google-benchmark/docs/
libcxx/trunk/utils/go
Author: ericwf
Date: Tue Apr 18 02:40:22 2017
New Revision: 300533
URL: http://llvm.org/viewvc/llvm-project?rev=300533&view=rev
Log:
Emit benchmark tests into the benchmarks build directory, not lib/
Modified:
libcxx/trunk/benchmarks/CMakeLists.txt
Modified: libcxx/trunk/benchmarks/CMakeList
Sorry I've been meaning to enable `-Wunused-typedef" for a while but I
haven't had a chance to clean up the remaining occurrences
Thanks for the cleanup.
On Tue, Apr 18, 2017 at 12:44 PM, Casey Carter via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: caseycarter
> Date: Tue Apr 18 1
Author: ericwf
Date: Tue Apr 18 15:58:03 2017
New Revision: 300595
URL: http://llvm.org/viewvc/llvm-project?rev=300595&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ for std::set and std::multiset
Modified:
libcxx/trunk/include/set
libcxx/trunk/test/std/containers/associative/multiset/emplace.pass
Author: ericwf
Date: Tue Apr 18 16:08:06 2017
New Revision: 300600
URL: http://llvm.org/viewvc/llvm-project?rev=300600&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macros in std::map and std::multimap
Modified:
libcxx/trunk/include/map
libcxx/trunk/test/std/containers/associative/map/map.access
Author: ericwf
Date: Tue Apr 18 16:16:26 2017
New Revision: 300602
URL: http://llvm.org/viewvc/llvm-project?rev=300602&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macro uses in std::stack.
Modified:
libcxx/trunk/include/stack
libcxx/trunk/test/std/containers/container.adaptors/stack/stack.cons
Author: ericwf
Date: Tue Apr 18 16:23:18 2017
New Revision: 300604
URL: http://llvm.org/viewvc/llvm-project?rev=300604&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ for std::queue and std::priority_queue.
Modified:
libcxx/trunk/include/queue
libcxx/trunk/test/std/containers/container.adaptors/pr
Author: ericwf
Date: Tue Apr 18 17:37:32 2017
New Revision: 300619
URL: http://llvm.org/viewvc/llvm-project?rev=300619&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macros in std::unordered_set and
std::unordered_multiset
Modified:
libcxx/trunk/include/unordered_set
libcxx/trunk/test/std/contain
Author: ericwf
Date: Tue Apr 18 17:50:56 2017
New Revision: 300620
URL: http://llvm.org/viewvc/llvm-project?rev=300620&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ in std::unordered_map and
std::unordered_multimap
This completes the cleanup of the containers, at least within the tests.
Modified:
l
701 - 800 of 2677 matches
Mail list logo
