Re: [PATCH] D24646: [CMake] Allow building Sphinx docs in nit-picky mode

[Eric Fiselier via cfe-commits]

EricWF updated this revision to Diff 71594.
EricWF added a comment.

Use spaces not tabs.


https://reviews.llvm.org/D24646

Files:
  cmake/modules/AddSphinxTarget.cmake

Index: cmake/modules/AddSphinxTarget.cmake
===================================================================
--- cmake/modules/AddSphinxTarget.cmake
+++ cmake/modules/AddSphinxTarget.cmake
@@ -14,13 +14,19 @@
   else()
     set(SPHINX_WARNINGS_AS_ERRORS_FLAG "")
   endif()
+  if (SPHINX_WARN_MISSING_REFERENCES)
+    set(SPHINX_WARN_MISSING_REFERENCES_FLAG "-n")
+  else()
+    set(SPHINX_WARN_MISSING_REFERENCES_FLAG "")
+  endif()
 
   add_custom_target(${SPHINX_TARGET_NAME}
                     COMMAND ${SPHINX_EXECUTABLE}
                             -b ${builder}
                             -d "${SPHINX_DOC_TREE_DIR}"
                             -q # Quiet: no output other than errors and 
warnings.
                             ${SPHINX_WARNINGS_AS_ERRORS_FLAG} # Treat warnings 
as errors if requested
+                            ${SPHINX_WARN_MISSING_REFERENCES_FLAG} # Treat 
missing references as warnings
                             "${CMAKE_CURRENT_SOURCE_DIR}" # Source
                             "${SPHINX_BUILD_DIR}" # Output
                     COMMENT



Index: cmake/modules/AddSphinxTarget.cmake
===================================================================
--- cmake/modules/AddSphinxTarget.cmake
+++ cmake/modules/AddSphinxTarget.cmake
@@ -14,13 +14,19 @@
   else()
     set(SPHINX_WARNINGS_AS_ERRORS_FLAG "")
   endif()
+  if (SPHINX_WARN_MISSING_REFERENCES)
+    set(SPHINX_WARN_MISSING_REFERENCES_FLAG "-n")
+  else()
+    set(SPHINX_WARN_MISSING_REFERENCES_FLAG "")
+  endif()
 
   add_custom_target(${SPHINX_TARGET_NAME}
                     COMMAND ${SPHINX_EXECUTABLE}
                             -b ${builder}
                             -d "${SPHINX_DOC_TREE_DIR}"
                             -q # Quiet: no output other than errors and warnings.
                             ${SPHINX_WARNINGS_AS_ERRORS_FLAG} # Treat warnings as errors if requested
+                            ${SPHINX_WARN_MISSING_REFERENCES_FLAG} # Treat missing references as warnings
                             "${CMAKE_CURRENT_SOURCE_DIR}" # Source
                             "${SPHINX_BUILD_DIR}" # Output
                     COMMENT

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits