EricWF updated this revision to Diff 73704.
EricWF added a comment.
Diagnose a coroutine `main` function in the same way as other invalid contexts.
https://reviews.llvm.org/D25292
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Ind
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
Previously the statement `co_return {42}` would be transformed into
`P.return_void()`, since the type of `{42}` is represented as `void` by Cl
EricWF updated this revision to Diff 73715.
EricWF added a comment.
- Address @majnemer's comment about using `auto`.
https://reviews.llvm.org/D25292
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutines.cp
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov, majnemer.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
When using TreeTransform to rebuild a coroutine the coroutine `promise_type`
variable is not transformed because it's stored in the
EricWF abandoned this revision.
EricWF added a comment.
This is all wrong. Sorry for the noise.
https://reviews.llvm.org/D25303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Oct 6 16:23:38 2016
New Revision: 283495
URL: http://llvm.org/viewvc/llvm-project?rev=283495&view=rev
Log:
[coroutines] Fix co_return statement for initializer list arguments
Summary:
Previously the statement `co_return {42}` would be transformed into
`P.return_void()`,
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov, majnemer.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch adds semantic checking and building of the fall-through `co_return;`
statement as well as the `p.set_exception(std::curre
EricWF updated this revision to Diff 73862.
EricWF added a comment.
- Remove useless line of code.
https://reviews.llvm.org/D25349
Files:
include/clang/AST/StmtCXX.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/AnalysisBasedWarnings.cpp
lib/Sema/SemaCoroutine.cpp
lib/Sema/TreeT
EricWF updated this revision to Diff 73866.
EricWF marked 2 inline comments as done.
EricWF added a comment.
Address review comments.
https://reviews.llvm.org/D25349
Files:
include/clang/AST/StmtCXX.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/AnalysisBasedWarnings.cpp
lib/Sema
EricWF added inline comments.
> GorNishanov wrote in coreturn.cpp:36
> No need to hve yield_value here, unless you want to use co_yield expression
> in the coroutine. In this file, we are using co_await only. (Same comment
> for promise_float and promise_int)
Ack. I'll add them back if I need
Author: ericwf
Date: Fri Oct 7 13:51:33 2016
New Revision: 283580
URL: http://llvm.org/viewvc/llvm-project?rev=283580&view=rev
Log:
Remove MSVC workarounds. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/support/test_allocator.h
Modified: libcxx/trunk/test/support/test_allocator.
EricWF closed this revision.
EricWF added a comment.
r283580.
https://reviews.llvm.org/D25141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Fri Oct 7 16:27:45 2016
New Revision: 283606
URL: http://llvm.org/viewvc/llvm-project?rev=283606&view=rev
Log:
Fix various issues in std::any and the related tests.
* Fix self-swap. Patch from Casey Carter.
* Remove workarounds and tests for types with deleted move construc
EricWF added a comment.
@CaseyCarter Thank you for the patch. I fixed most of your issues in r283606
{as well as a bunch of libc++ bugs).
I'm still deciding what to do about the `in_place` SFINAE tests, but I'll
follow up on that shortly. As for this patch please update it if there are any
fix
EricWF added a comment.
Why do you want to build `libc++.so` with hidden visibility? What's wrong with
the existing way we build `libc++.so`?
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
EricWF added a comment.
> Why does test_stack_allocator.pass.cpp line 11 have a commented-out path?
Typically tests name the header they test in a comment.
> Why is
> test/std/containers/sequences/deque/deque.cons/size_value_alloc.pass.cpp
> 84-85 gaining totally empty braces?
Mass-translatio
EricWF updated this revision to Diff 73995.
EricWF added a comment.
Address @STL_MSFT's comments.
https://reviews.llvm.org/D25154
Files:
test/std/containers/container.adaptors/priority.queue/priqueue.cons/ctor_comp.pass.cpp
test/std/containers/container.adaptors/priority.queue/priqueue.co
EricWF added a comment.
In https://reviews.llvm.org/D25154#564980, @STL_MSFT wrote:
> Seems plausible to me. I haven't tested this against MSVC yet, but at most I
> expect to have minor issues with space consumption (as we allocate helper
> objects and sentinel nodes, so any exactly-sized buffe
Author: ericwf
Date: Fri Oct 7 17:10:35 2016
New Revision: 283618
URL: http://llvm.org/viewvc/llvm-project?rev=283618&view=rev
Log:
Fix shadow warnings. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/utilities/utility/forward/move.pass.cpp
Modified: libcxx/trunk/test/std/util
EricWF closed this revision.
EricWF added a comment.
r283618.
https://reviews.llvm.org/D25248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Fri Oct 7 18:07:59 2016
New Revision: 283620
URL: http://llvm.org/viewvc/llvm-project?rev=283620&view=rev
Log:
Fix PR30642 - libc++ leaks always-visible symbols into programs
This was caused by r281673, specifically changing
`_LIBCPP_EXTERN_TEMPLATE_TYPE_VIS`
from `__attri
EricWF added a comment.
Addressed the issues about `in_place` SFINAE constraints in an inline comment.
Comment at: test/libcxx/utilities/any/any.class/any.assign/value.pass.cpp:25
+// Test that any& operator=(ValueType&&) is *never* selected for:
+// * std::in_place type.
+
EricWF added inline comments.
Comment at: lib/CMakeLists.txt:41
+else()
+ list(APPEND LIBCXX_LIBRARIES_PUBLIC "${LIBCXX_CXX_ABI_LIBRARY}")
+endif()
Please handle the special case for Apple here, where it manually re-exports the
ABI lib.
Comme
EricWF added a comment.
@rsmith ping. Any more comments on this patch?
Repository:
rL LLVM
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF updated this revision to Diff 74006.
EricWF added a comment.
Rewrite the patch entirely. Instead of using an actual "stack buffer" I've
transformed `stack_allocator` into `limited_allocator` which allows at
most `N` elements to be allocated from it. This resolves the issues about stack
u
Author: ericwf
Date: Fri Oct 7 19:56:22 2016
New Revision: 283631
URL: http://llvm.org/viewvc/llvm-project?rev=283631&view=rev
Log:
[libc++] Fix stack_allocator
Summary:
To quote STL the problems with stack allocator are"
>"stack_allocator is seriously nonconformant to N4582 17.6.3.5
>[allocat
Author: ericwf
Date: Fri Oct 7 19:57:56 2016
New Revision: 283632
URL: http://llvm.org/viewvc/llvm-project?rev=283632&view=rev
Log:
Add missing include in test_allocator.h
Modified:
libcxx/trunk/test/support/test_allocator.h
Modified: libcxx/trunk/test/support/test_allocator.h
URL:
http://
Author: ericwf
Date: Fri Oct 7 19:59:16 2016
New Revision: 283633
URL: http://llvm.org/viewvc/llvm-project?rev=283633&view=rev
Log:
Add missing include in test
Modified:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.assign/copy.pass.cpp
Modified:
libcxx/trunk/test/std/utilities/
Author: ericwf
Date: Fri Oct 7 20:25:23 2016
New Revision: 283643
URL: http://llvm.org/viewvc/llvm-project?rev=283643&view=rev
Log:
Purge all usages of _LIBCPP_STD_VER under test/std/algorithm
Modified:
libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp
libcxx/tr
Author: ericwf
Date: Fri Oct 7 20:32:56 2016
New Revision: 283644
URL: http://llvm.org/viewvc/llvm-project?rev=283644&view=rev
Log:
Remove all _LIBCPP_VERSION tests from under test/std
Added:
libcxx/trunk/test/libcxx/depr/depr.c.headers/ciso646.pass.cpp
libcxx/trunk/test/libcxx/depr/depr
EricWF created this revision.
EricWF added reviewers: emaste, dim, theraven, rsmith.
EricWF added a subscriber: cfe-commits.
FreeBSD ships an old ABI for std::pair which requires that it have non-trivial
copy/move constructors. Currently the non-trivial copy/move is achieved by
providing explici
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
One concern I have is being able to specify libraries in the correct order when
we have two different lists. However I'm not concerned enough not to try it.
LGTM.
Comment a
Author: ericwf
Date: Sun Oct 9 15:44:48 2016
New Revision: 283699
URL: http://llvm.org/viewvc/llvm-project?rev=283699&view=rev
Log:
[libc++abi] Fix bug which cased the static libunwind to always be chosen
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modified: libcxxabi/trunk/src/CMakeLists.
Author: ericwf
Date: Sun Oct 9 16:34:03 2016
New Revision: 283700
URL: http://llvm.org/viewvc/llvm-project?rev=283700&view=rev
Log:
Fix linker script generation for in-tree builds
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/cmake/Modules/HandleLibcxxFlags.cmake
libcxx/trunk/li
Hi Renato, Hal,
I've hopefully fixed this in r283700. I'll be watching the bots to ensure
everything works.
Sorry about the breakage.
/Eric
On Sun, Oct 9, 2016 at 6:05 AM, Renato Golin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 9 October 2016 at 03:59, Hal Finkel via cfe-commits
Author: ericwf
Date: Sun Oct 9 16:43:30 2016
New Revision: 283701
URL: http://llvm.org/viewvc/llvm-project?rev=283701&view=rev
Log:
Remove debug output from gen_linker_script.py
Modified:
libcxx/trunk/utils/gen_link_script/gen_link_script.py
Modified: libcxx/trunk/utils/gen_link_script/gen_
Author: ericwf
Date: Sun Oct 9 23:22:58 2016
New Revision: 283712
URL: http://llvm.org/viewvc/llvm-project?rev=283712&view=rev
Log:
Remove use of int128_t inside the filesystem implementation
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experi
EricWF created this revision.
EricWF added reviewers: mclow.lists, danalbert, jroelofs, compnerd.
EricWF added a subscriber: cfe-commits.
In 32 bit builds on a 64 bit system `std::malloc` does not return correctly
aligned memory. This leads to undefined behavior.
This patch switches to using `p
Author: ericwf
Date: Mon Oct 10 00:19:59 2016
New Revision: 283714
URL: http://llvm.org/viewvc/llvm-project?rev=283714&view=rev
Log:
Workaround missing C++14 constexpr semantics in filesystem
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experim
Author: ericwf
Date: Mon Oct 10 00:34:18 2016
New Revision: 283715
URL: http://llvm.org/viewvc/llvm-project?rev=283715&view=rev
Log:
Provide a constexpr addressof with GCC 7.
__builtin_addressof was added to the GCC trunk in the past week. This patch
teaches libc++ about it so it can correctly pr
EricWF added a comment.
In https://reviews.llvm.org/D24991#565715, @mclow.lists wrote:
> How does this play with existing binaries? Applications that expect these
> functions to exist in the dylib?
This patch is majorly ABI breaking, although we could probably find a
formulation that wasn't.
Author: ericwf
Date: Mon Oct 10 01:31:00 2016
New Revision: 283721
URL: http://llvm.org/viewvc/llvm-project?rev=283721&view=rev
Log:
Cleanup CMake status output
Modified:
libcxx/trunk/benchmarks/CMakeLists.txt
libcxx/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake
Modified: libcxx/trunk/be
EricWF added a comment.
Is this *all* that's needed to get libc++ working?
Repository:
rL LLVM
https://reviews.llvm.org/D25414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Cool! This patch LGTM then.
> we're slowly diverging from the upstream version so it might be better to
> stop relying on that option. I'd have to copy include/support/musl/xlocale.h
> to inc
EricWF added a comment.
PS. If your not already locked into an ABI you'll want to look into enabling
the most recent ABI breaking changes. See the `_LIBCPP_ABI_VERSION`
configuration at the top of `__config` for more info.
Repository:
rL LLVM
https://reviews.llvm.org/D25414
_
EricWF created this revision.
EricWF added reviewers: rsmith, majnemer, aaron.ballman.
EricWF added a subscriber: cfe-commits.
Once a base class has been made invalid (by a static_assert for example) all
using-member declarations in the derived classes will result in a "not a base
class" diagnos
EricWF added a comment.
In https://reviews.llvm.org/D25414#565956, @phosek wrote:
> > That sounds fine.
>
> Shall I send it as a separate patch or update this one?
I would send a separate patch. This one is already good to go so you might as
well commit it.
>
>
>> PS. If your not already lo
EricWF updated this revision to Diff 74112.
EricWF added a comment.
Simplify test case.
https://reviews.llvm.org/D25430
Files:
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/using-decl-templates.cpp
Index: test/SemaCXX/using-decl-templates.cpp
==
EricWF added a comment.
In https://reviews.llvm.org/D24991#566140, @sebpop wrote:
> In https://reviews.llvm.org/D24991#565861, @EricWF wrote:
>
> > Please provide benchmark tests which demonstrate that these benefits are
> > concrete and not just "potential". Moving methods out of the dylib is
Author: ericwf
Date: Mon Oct 10 09:26:40 2016
New Revision: 283755
URL: http://llvm.org/viewvc/llvm-project?rev=283755&view=rev
Log:
[Sema] Prevent using member declaration diagnostic if the base class is invalid.
Summary:
Once a base class has been made invalid (by a static_assert for example) a
EricWF added a comment.
Thanks @aaron.ballman!
https://reviews.llvm.org/D25430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon Oct 10 09:45:06 2016
New Revision: 283759
URL: http://llvm.org/viewvc/llvm-project?rev=283759&view=rev
Log:
Fix documentation mis-spelling.
I promise to stop misspelling things when the English language gains a program
that does strict semantic checking.
Modified:
li
Thanks. I should have done that a while ago.
On Mon, Oct 10, 2016 at 8:37 AM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Oct 10 09:37:18 2016
> New Revision: 283757
>
> URL: http://llvm.org/viewvc/llvm-project?rev=283757&view=rev
> Log:
> Add
Author: ericwf
Date: Tue Oct 11 16:13:44 2016
New Revision: 283941
URL: http://llvm.org/viewvc/llvm-project?rev=283941&view=rev
Log:
Fix incorrect exception handling behavior in the uninitialized algorithms
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilities/memory/spec
Author: ericwf
Date: Tue Oct 11 16:22:21 2016
New Revision: 283944
URL: http://llvm.org/viewvc/llvm-project?rev=283944&view=rev
Log:
Fix std::pair on FreeBSD
Summary:
FreeBSD ships an old ABI for std::pair which requires that it have non-trivial
copy/move constructors. Currently the non-trivial
EricWF added inline comments.
Comment at: include/__threading_support:25
// redundancy is intentional.
#if defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
#if !defined(__clang__) && (_GNUC_VER < 500)
If `_LIBCPP_HAS_THREAD_API_EXTERNAL` is defined can't we just assum
Author: ericwf
Date: Tue Oct 11 17:18:09 2016
New Revision: 283951
URL: http://llvm.org/viewvc/llvm-project?rev=283951&view=rev
Log:
Fix LWG2683 - filesystem::copy() should always clear the user-provided
error_code
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
libcxx
Author: ericwf
Date: Tue Oct 11 19:00:37 2016
New Revision: 283958
URL: http://llvm.org/viewvc/llvm-project?rev=283958&view=rev
Log:
Make it easier to run the libc++ test suite against libstdc++
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
libcxx/trunk/test/libcxx/test/config.py
libc
Author: ericwf
Date: Tue Oct 11 19:28:14 2016
New Revision: 283960
URL: http://llvm.org/viewvc/llvm-project?rev=283960&view=rev
Log:
Add mork workarounds for running the test suite against libstdc++
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/lit.cfg
libcxx/tru
Author: ericwf
Date: Tue Oct 11 20:19:16 2016
New Revision: 283962
URL: http://llvm.org/viewvc/llvm-project?rev=283962&view=rev
Log:
Fix libc++abi test config after recent libc++ changes
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
Modified: libcxxabi/trunk/test/libcxxabi/test/con
EricWF added a comment.
> musl's pthread implementations use volatile types in their structs which is
> not being constexpr in C++11 but is in C++14.
This means that libc++'s std::mutex is unsafe to use during dynamic
initialization in C++11 with MUSL, which would really suck except that Clang
Author: ericwf
Date: Tue Oct 11 23:29:50 2016
New Revision: 283975
URL: http://llvm.org/viewvc/llvm-project?rev=283975&view=rev
Log:
Prevent the test suite from hanging when run against libstdc++
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/std/thread/thread.mutex/
EricWF added inline comments.
Comment at: CMakeLists.txt:327
# Required flags ==
set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build
dialect")
add_compile_flags_if_supported(-std=${LIBCXX_ST
Author: ericwf
Date: Tue Oct 11 23:56:23 2016
New Revision: 283976
URL: http://llvm.org/viewvc/llvm-project?rev=283976&view=rev
Log:
Fix two more tests that hang when testing against libstdc++
Modified:
libcxx/trunk/test/std/utilities/intseq/intseq.make/make_integer_seq.fail.cpp
libcxx/t
Author: ericwf
Date: Wed Oct 12 01:48:31 2016
New Revision: 283978
URL: http://llvm.org/viewvc/llvm-project?rev=283978&view=rev
Log:
Revert Add . Will recommit with better commit message
Removed:
libcxx/trunk/include/optional
libcxx/trunk/test/libcxx/utilities/optional/
libcxx/trunk/t
Author: ericwf
Date: Wed Oct 12 03:09:22 2016
New Revision: 283983
URL: http://llvm.org/viewvc/llvm-project?rev=283983&view=rev
Log:
Protect special members of NullBase archetype to avoid exposing them
Modified:
libcxx/trunk/test/support/archetypes.hpp
Modified: libcxx/trunk/test/support/arc
Author: ericwf
Date: Wed Oct 12 03:54:10 2016
New Revision: 283988
URL: http://llvm.org/viewvc/llvm-project?rev=283988&view=rev
Log:
Provide a fallback __cxa_thread_atexit() implementation. Patch from Tavian
Barnes
Added:
libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp
Modified:
EricWF closed this revision.
EricWF added a comment.
Committed as r283988. Thanks for the patch!
https://reviews.llvm.org/D21803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: ericwf
Date: Wed Oct 12 04:06:12 2016
New Revision: 283991
URL: http://llvm.org/viewvc/llvm-project?rev=283991&view=rev
Log:
Remove use of _VSTD::__invoke in the not_fn tests
Modified:
libcxx/trunk/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
Modified:
libcxx/trun
Author: ericwf
Date: Wed Oct 12 04:20:58 2016
New Revision: 283993
URL: http://llvm.org/viewvc/llvm-project?rev=283993&view=rev
Log:
Fix use of C++14 constexpr in C++11
Modified:
libcxx/trunk/test/support/archetypes.ipp
Modified: libcxx/trunk/test/support/archetypes.ipp
URL:
http://llvm.org
Author: ericwf
Date: Wed Oct 12 04:31:26 2016
New Revision: 283994
URL: http://llvm.org/viewvc/llvm-project?rev=283994&view=rev
Log:
Fix nasty_containers.hpp for other stdlibs
Modified:
libcxx/trunk/test/support/nasty_containers.hpp
libcxx/trunk/test/support/test_macros.h
Modified: libcx
Author: ericwf
Date: Wed Oct 12 04:48:44 2016
New Revision: 283996
URL: http://llvm.org/viewvc/llvm-project?rev=283996&view=rev
Log:
Fix more C++11 constexpr issues in the tests
Modified:
libcxx/trunk/test/support/archetypes.hpp
Modified: libcxx/trunk/test/support/archetypes.hpp
URL:
http:/
Author: ericwf
Date: Wed Oct 12 04:53:35 2016
New Revision: 283997
URL: http://llvm.org/viewvc/llvm-project?rev=283997&view=rev
Log:
support --param=std=gnu++XX
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
http://llvm.org/viewvc/ll
Author: ericwf
Date: Wed Oct 12 05:19:48 2016
New Revision: 283999
URL: http://llvm.org/viewvc/llvm-project?rev=283999&view=rev
Log:
Remove usages of _ALIGNAS_TYPE
Modified:
libcxx/trunk/test/std/atomics/atomics.flag/default.pass.cpp
libcxx/trunk/test/std/atomics/atomics.types.generic/add
Author: ericwf
Date: Wed Oct 12 05:28:09 2016
New Revision: 284002
URL: http://llvm.org/viewvc/llvm-project?rev=284002&view=rev
Log:
Remove usages of _LIBCPP_CONSTEXPR under test/std
Modified:
libcxx/trunk/test/std/numerics/rand/rand.adapt/rand.adapt.ibits/eval.pass.cpp
libcxx/trunk/tes
Author: ericwf
Date: Wed Oct 12 06:20:27 2016
New Revision: 284004
URL: http://llvm.org/viewvc/llvm-project?rev=284004&view=rev
Log:
Unbreak C++03 build
Modified:
libcxx/trunk/test/support/test_macros.h
Modified: libcxx/trunk/test/support/test_macros.h
URL:
http://llvm.org/viewvc/llvm-proje
Author: ericwf
Date: Wed Oct 12 06:29:18 2016
New Revision: 284005
URL: http://llvm.org/viewvc/llvm-project?rev=284005&view=rev
Log:
Remove incorrect XFAILS
Modified:
libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp
libcxx/trunk/test/libcx
Author: ericwf
Date: Wed Oct 12 06:35:37 2016
New Revision: 284006
URL: http://llvm.org/viewvc/llvm-project?rev=284006&view=rev
Log:
Correctly grant rebound limited_allocators friendship.
Modified:
libcxx/trunk/test/support/test_allocator.h
Modified: libcxx/trunk/test/support/test_allocator.
Asiri
>
> On Wed, Oct 12, 2016 at 12:29 PM, Eric Fiselier via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ericwf
>> Date: Wed Oct 12 06:29:18 2016
>> New Revision: 284005
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=284005&a
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
@BillyONeal Do you have commit access?
https://reviews.llvm.org/D25531
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: ericwf
Date: Wed Oct 12 23:07:58 2016
New Revision: 284101
URL: http://llvm.org/viewvc/llvm-project?rev=284101&view=rev
Log:
Revert r282345 - Use __attribute__((internal_linkage)) when available.
Modified:
libcxx/trunk/include/__config
libcxx/trunk/src/string.cpp
Modified: libcxx
llvm.org/
> pipermail/cfe-dev/2016-July/049985.html
>
> I think we should reach a consensus on the right course of actions about
> this first.
>
> —
> Mehdi
>
>
>
>
> On Sep 24, 2016, at 8:14 PM, Eric Fiselier via cfe-commits <
> cfe-commits@lists.llvm.or
EricWF added a comment.
Ping.
https://reviews.llvm.org/D25292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo inline comments.
Comment at: include/iterator:95
+template constexpr reverse_iterator(const reverse_iterator&
u);
+template constexpr reverse_iterator&
Author: ericwf
Date: Thu Oct 13 21:55:19 2016
New Revision: 284188
URL: http://llvm.org/viewvc/llvm-project?rev=284188&view=rev
Log:
Fix CMake configuration error and add ABI lists for OS X.
The primary reason for this patch is to add the OS X ABI lists for 3.9 and
ToT.
However while working on
Author: ericwf
Date: Thu Oct 13 23:14:24 2016
New Revision: 284193
URL: http://llvm.org/viewvc/llvm-project?rev=284193&view=rev
Log:
Re-export two previously exported std::string functions.
These functions were removed from the dylib sometime between the 3.9 release
and now. This patch manually e
Author: ericwf
Date: Thu Oct 13 23:21:24 2016
New Revision: 284194
URL: http://llvm.org/viewvc/llvm-project?rev=284194&view=rev
Log:
Revert r284193 - it is not correct on OS X
Modified:
libcxx/trunk/lib/abi/x86_64-linux-gnu.abilist
libcxx/trunk/src/string.cpp
Modified: libcxx/trunk/lib/a
EricWF created this revision.
EricWF added reviewers: mclow.lists, rsmith.
EricWF added subscribers: cfe-commits, rsmith.
This patch implements the library side of P0035R4. The implementation is thanks
to @rsmith.
In addition to the C++17 implementation, the library implementation can be
explic
EricWF closed this revision.
EricWF added a comment.
I committed this fix a couple days ago when helping the libstdc++ maintainers
setup our test suite.
https://reviews.llvm.org/D25451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: ericwf
Date: Fri Oct 14 00:10:06 2016
New Revision: 284199
URL: http://llvm.org/viewvc/llvm-project?rev=284199&view=rev
Log:
Add ABI changelog entry for
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT
URL:
http://llvm.org/viewvc/llvm-projec
Author: ericwf
Date: Fri Oct 14 00:29:46 2016
New Revision: 284200
URL: http://llvm.org/viewvc/llvm-project?rev=284200&view=rev
Log:
Remove two ABI symbols added after the 3.9 release
Modified:
libcxx/trunk/include/string
libcxx/trunk/lib/abi/x86_64-linux-gnu.abilist
Modified: libcxx/tru
EricWF created this revision.
EricWF added reviewers: mclow.lists, emaste, dexonsmith, joker-eph, compnerd,
jroelofs, danalbert, dim.
EricWF added a subscriber: cfe-commits.
Herald added subscribers: modocache, mgorny, beanz.
This patch turns on `-fvisibility-inlines-hidden` when building the dy
EricWF updated this revision to Diff 74619.
EricWF added a comment.
Cleanup abi list changes.
https://reviews.llvm.org/D25591
Files:
include/new
lib/abi/CHANGELOG.TXT
lib/abi/x86_64-linux-gnu.abilist
src/new.cpp
test/libcxx/language.support/support.dynamic/new_faligned_allocation.sh.c
Author: ericwf
Date: Fri Oct 14 01:15:27 2016
New Revision: 284205
URL: http://llvm.org/viewvc/llvm-project?rev=284205&view=rev
Log:
Cleanup LIT testing doc
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
Modified: libcxx/trunk/docs/TestingLibcxx.rst
URL:
http://llvm.org/viewvc/llvm-project/l
Author: ericwf
Date: Fri Oct 14 01:46:30 2016
New Revision: 284206
URL: http://llvm.org/viewvc/llvm-project?rev=284206&view=rev
Log:
Implement P0035R4 -- Add C++17 aligned allocation functions
Summary:
This patch implements the library side of P0035R4. The implementation is thanks
to @rsmith.
I
Author: ericwf
Date: Fri Oct 14 01:47:37 2016
New Revision: 284207
URL: http://llvm.org/viewvc/llvm-project?rev=284207&view=rev
Log:
Correct ABI changelog revision number
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT
URL:
http://llvm.org/viewvc/ll
Author: ericwf
Date: Fri Oct 14 01:49:30 2016
New Revision: 284208
URL: http://llvm.org/viewvc/llvm-project?rev=284208&view=rev
Log:
Update OS X ABI list
Modified:
libcxx/trunk/lib/abi/x86_64-apple-darwin16.0.abilist
Modified: libcxx/trunk/lib/abi/x86_64-apple-darwin16.0.abilist
URL:
http:/
Author: ericwf
Date: Fri Oct 14 02:19:52 2016
New Revision: 284209
URL: http://llvm.org/viewvc/llvm-project?rev=284209&view=rev
Log:
Add void_t and invoke feature test macros
Added:
libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke_feature_test_macro.pass.cpp
libcxx/tr
Author: ericwf
Date: Fri Oct 14 02:49:15 2016
New Revision: 284210
URL: http://llvm.org/viewvc/llvm-project?rev=284210&view=rev
Log:
XFAIL aligned allocation test failures with UBSAN
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_va
301 - 400 of 2677 matches
Mail list logo
