Author: ericwf
Date: Fri Feb 10 02:57:35 2017
New Revision: 294730
URL: http://llvm.org/viewvc/llvm-project?rev=294730&view=rev
Log:
Recommit "Split exception.cpp and new.cpp implementation into different files
for different runtimes."
This recommits r294707 with additional fixes. The main diffe
Author: ericwf
Date: Fri Feb 10 03:16:29 2017
New Revision: 294731
URL: http://llvm.org/viewvc/llvm-project?rev=294731&view=rev
Log:
Attempt to fix Apple buildit bots
Modified:
libcxx/trunk/src/new.cpp
Modified: libcxx/trunk/src/new.cpp
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/
Author: ericwf
Date: Fri Feb 10 03:25:15 2017
New Revision: 294732
URL: http://llvm.org/viewvc/llvm-project?rev=294732&view=rev
Log:
Fix yet another Apple buildit bug
Modified:
libcxx/trunk/src/typeinfo.cpp
Modified: libcxx/trunk/src/typeinfo.cpp
URL:
http://llvm.org/viewvc/llvm-project/lib
Author: ericwf
Date: Mon Feb 13 16:44:39 2017
New Revision: 294995
URL: http://llvm.org/viewvc/llvm-project?rev=294995&view=rev
Log:
Add tests for noexcept functions
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.cat/is_function.pass.cpp
libcxx/trunk/test/std/utili
Hi Richard,
The following test triggers an assertion, even after this patch:
#include
#include
template
struct TestAlloc : std::allocator {};
template ,
class Allocator = std::allocator>
struct String {
using size_type = typename Allocator::size_type;
String() = default;
Str
Author: ericwf
Date: Thu Feb 16 19:00:37 2017
New Revision: 295390
URL: http://llvm.org/viewvc/llvm-project?rev=295390&view=rev
Log:
add tests for ENAMETOOLONG
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.exists/exists.pass.cpp
libcxx/trunk/test/std/experime
Author: ericwf
Date: Thu Feb 16 19:17:10 2017
New Revision: 295393
URL: http://llvm.org/viewvc/llvm-project?rev=295393&view=rev
Log:
[libc++] Fix PR 31938 - std::basic_string constructors use non-deductible
parameter types.
Summary:
This patch fixes http://llvm.org/PR31938. The description below
Sorry about the breakage. I'm not sure what else to do.
The hack had been sitting there for more than a month IIRC.
Any advice for next time?
/Eric
On Thu, Feb 16, 2017 at 7:00 PM, Justin Bogner
wrote:
> Eric Fiselier via cfe-commits writes:
> > Author: ericwf
> > Date:
Author: ericwf
Date: Thu Feb 16 19:56:57 2017
New Revision: 295399
URL: http://llvm.org/viewvc/llvm-project?rev=295399&view=rev
Log:
update revision in CHANGELOG.TXT and fix python error
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
libcxx/trunk/utils/libcxx/sym_check/extract.py
Modified:
Author: ericwf
Date: Thu Feb 16 20:31:56 2017
New Revision: 295403
URL: http://llvm.org/viewvc/llvm-project?rev=295403&view=rev
Log:
Mark a couple for basic_string member templates as inline. no ABI change this
time.
Modified:
libcxx/trunk/include/string
Modified: libcxx/trunk/include/strin
Author: ericwf
Date: Thu Feb 16 21:25:08 2017
New Revision: 295406
URL: http://llvm.org/viewvc/llvm-project?rev=295406&view=rev
Log:
[libcxx] Remove unexpected handlers in C++17
Summary:
This patch implements
[P0003R5](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0003r5.html)
which
Author: ericwf
Date: Thu Feb 16 21:30:25 2017
New Revision: 295407
URL: http://llvm.org/viewvc/llvm-project?rev=295407&view=rev
Log:
Add doc for _LIBCPP_ENABLE_CXX17_DISABLED_AUTO_PTR and make it work under
_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES
Modified:
libcxx/trunk/docs/UsingLibcxx.rst
Author: ericwf
Date: Thu Feb 16 22:26:22 2017
New Revision: 295411
URL: http://llvm.org/viewvc/llvm-project?rev=295411&view=rev
Log:
Fix test_exception_storage.pass.cpp in C++17 my re-enabling the unexpected
handlers
Modified:
libcxxabi/trunk/test/test_exception_storage.pass.cpp
Modified: l
Author: ericwf
Date: Thu Feb 16 23:04:09 2017
New Revision: 295417
URL: http://llvm.org/viewvc/llvm-project?rev=295417&view=rev
Log:
Work around Clang assertion when testing C++17 deduction guides with '-g'.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/implicit_deduction
Hi Richard,
One more issue. When compiling with `-g` the following code hits a
`llvm_unreachable` in CGDebugInfo::CreateTypeNode.
template struct S { S(T) {} };
S s(42);
/Eric
On Thu, Feb 16, 2017 at 2:29 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
I put my attempt to fix this up for review:
https://reviews.llvm.org/D30082
On Thu, Feb 16, 2017 at 10:17 PM, Eric Fiselier wrote:
> Hi Richard,
>
> One more issue. When compiling with `-g` the following code hits a
> `llvm_unreachable` in CGDebugInfo::CreateTypeNode.
>
> template struct S { S
Author: ericwf
Date: Fri Feb 17 00:59:11 2017
New Revision: 295422
URL: http://llvm.org/viewvc/llvm-project?rev=295422&view=rev
Log:
add implicit deduction guide tests for string_view
Added:
libcxx/trunk/test/std/strings/string.view/string.view.cons/implicit_deduction_guides.pass.cpp
Added:
Author: ericwf
Date: Fri Feb 17 01:00:04 2017
New Revision: 295423
URL: http://llvm.org/viewvc/llvm-project?rev=295423&view=rev
Log:
Remove dead code in test
Modified:
libcxx/trunk/test/std/strings/string.view/string.view.cons/implicit_deduction_guides.pass.cpp
Modified:
libcxx/trunk/test/
Author: ericwf
Date: Fri Feb 17 01:31:38 2017
New Revision: 295428
URL: http://llvm.org/viewvc/llvm-project?rev=295428&view=rev
Log:
Use inline namespaces with GCC instead of __attribute__((__strong__)).
GCC 7.0.1 started warning that __attribute__((__strong__)) is depricated.
This patch switches
Author: ericwf
Date: Fri Feb 17 02:37:03 2017
New Revision: 295434
URL: http://llvm.org/viewvc/llvm-project?rev=295434&view=rev
Log:
Update all bug URL's to point to https://bugs.llvm.org/...
Modified:
libcxx/trunk/docs/index.rst
libcxx/trunk/include/memory
libcxx/trunk/test/std/cont
Inserting arbitrary feature macros into CMake should not be a supported
scenario because it results is macros, such as this one, which are
seemingly dead.
/Eric
On Fri, Feb 24, 2017 at 1:44 PM, Jonathan Roelofs wrote:
>
>
> On 2/24/17 1:30 PM, Eric Fiselier via Phabricator wrote:
>
>> EricWF ad
Author: ericwf
Date: Tue Feb 28 19:27:14 2017
New Revision: 296561
URL: http://llvm.org/viewvc/llvm-project?rev=296561&view=rev
Log:
Fix PR32097 - is_abstract doesn't work on class templates.
This patch fixes llvm.org/PR32097 by using the __is_abstract
builtin type-trait instead of the previous l
Author: ericwf
Date: Tue Feb 28 20:02:28 2017
New Revision: 296565
URL: http://llvm.org/viewvc/llvm-project?rev=296565&view=rev
Log:
Improve diagnostics when an invalid hash is used in an unordered container.
This patch adds a static assertion that the specified hash meets
the requirements of an
Author: ericwf
Date: Tue Feb 28 20:23:54 2017
New Revision: 296567
URL: http://llvm.org/viewvc/llvm-project?rev=296567&view=rev
Log:
Fix non-reserved macro names LIBCXXABI_NORETURN and LIBCXXABI_ARM_EHABI.
This patch adds the required leading underscore to those macros.
Modified:
libcxxabi/t
Author: ericwf
Date: Tue Feb 28 20:34:27 2017
New Revision: 296568
URL: http://llvm.org/viewvc/llvm-project?rev=296568&view=rev
Log:
Fix test failures due to bad test hasher
Modified:
libcxx/trunk/test/std/containers/unord/unord.map/unord.map.cnstr/default_noexcept.pass.cpp
libcxx/trunk
Author: ericwf
Date: Tue Feb 28 20:52:04 2017
New Revision: 296571
URL: http://llvm.org/viewvc/llvm-project?rev=296571&view=rev
Log:
Mark test as unsupported in C++11
Modified:
libcxx/trunk/test/libcxx/containers/unord/unord.set/missing_hash_specialization.fail.cpp
Modified:
libcxx/trunk/t
n Tue, Feb 28, 2017 at 6:27 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Tue Feb 28 19:27:14 2017
> New Revision: 296561
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296561&view=rev
> Log:
> Fix PR32097 - is
; Although it's not a regression, it is a significant bug. This patch fixes
> > the bug by
> > forwarding to a compiler builtin, which is strictly better than what we
> > have. I'm
> > confident this patch is safe.
> >
> > /Eric
> >
> > On Tu
Author: ericwf
Date: Wed Mar 1 15:53:30 2017
New Revision: 296685
URL: http://llvm.org/viewvc/llvm-project?rev=296685&view=rev
Log:
Generate the test configuration even when LIBCXX_INCLUDE_TESTS=OFF.
This patch changes the CMake configuration so that it always
generates the test/lit.site.cfg fil
Author: ericwf
Date: Wed Mar 1 17:59:34 2017
New Revision: 296715
URL: http://llvm.org/viewvc/llvm-project?rev=296715&view=rev
Log:
Cleanup new/delete definitions
This patch cleans up how libc++abi handles the definitions for new/delete.
It is in preperation for upcoming changes to fix how both
Author: ericwf
Date: Wed Mar 1 18:03:01 2017
New Revision: 296716
URL: http://llvm.org/viewvc/llvm-project?rev=296716&view=rev
Log:
Fix python 3 syntax error in sym_diff
Modified:
libcxx/trunk/utils/libcxx/sym_check/diff.py
Modified: libcxx/trunk/utils/libcxx/sym_check/diff.py
URL:
http://
Author: ericwf
Date: Wed Mar 1 20:04:49 2017
New Revision: 296727
URL: http://llvm.org/viewvc/llvm-project?rev=296727&view=rev
Log:
Remove more usages of REQUIRES-ANY in the test-suite
Modified:
libcxx/trunk/test/std/depr/depr.auto.ptr/auto.ptr/auto.ptr.cons/assignment.pass.cpp
libcxx/
Author: ericwf
Date: Thu Mar 2 13:25:53 2017
New Revision: 296787
URL: http://llvm.org/viewvc/llvm-project?rev=296787&view=rev
Log:
[libc++abi] Update new/delete definitions to match libc++
Summary:
Currently both libc++ and libc++abi provide definitions for new/delete. However
libc++abi's defi
Author: ericwf
Date: Thu Mar 2 13:34:35 2017
New Revision: 296801
URL: http://llvm.org/viewvc/llvm-project?rev=296801&view=rev
Log:
[libc++abi] Add option to enable definitions for the new/delete overloads.
Summary:
Currently both libc++ and libc++abi provide definitions for operator
new/delete
Author: ericwf
Date: Thu Mar 2 13:35:33 2017
New Revision: 296802
URL: http://llvm.org/viewvc/llvm-project?rev=296802&view=rev
Log:
[libc++] Add option to disable new/delete overloads when libc++abi provides
them.
Summary:
Currently both libc++ and libc++abi provide definitions for operator
ne
Author: ericwf
Date: Thu Mar 2 15:16:35 2017
New Revision: 296813
URL: http://llvm.org/viewvc/llvm-project?rev=296813&view=rev
Log:
Fix test failures caused by new/delete calls getting optimized away
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.arra
Author: ericwf
Date: Thu Mar 2 15:55:17 2017
New Revision: 296823
URL: http://llvm.org/viewvc/llvm-project?rev=296823&view=rev
Log:
Work around GCC linking errors within libc++abi due to missing new/delete
definitions
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMake
Author: ericwf
Date: Thu Mar 2 15:55:03 2017
New Revision: 296822
URL: http://llvm.org/viewvc/llvm-project?rev=296822&view=rev
Log:
Work around GCC linking errors within libc++abi due to missing new/delete
definitions
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.
Author: ericwf
Date: Thu Mar 2 16:10:14 2017
New Revision: 296831
URL: http://llvm.org/viewvc/llvm-project?rev=296831&view=rev
Log:
remove max_size() extension from polymorphic_allocator. It is unneeded
Removed:
libcxx/trunk/test/libcxx/experimental/memory/memory.polymorphic.allocator.class
Author: ericwf
Date: Thu Mar 2 17:18:40 2017
New Revision: 296840
URL: http://llvm.org/viewvc/llvm-project?rev=296840&view=rev
Log:
Work around test failure on 32 bit OS X
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_replace/size_size_T_size_size.pass.cpp
Mo
Author: ericwf
Date: Thu Mar 2 20:02:07 2017
New Revision: 296851
URL: http://llvm.org/viewvc/llvm-project?rev=296851&view=rev
Log:
Fix sign-compare warning in test; Oddly this only appears on OS X
Modified:
libcxx/trunk/test/std/containers/sequences/forwardlist/forwardlist.cons/move_alloc.
Author: ericwf
Date: Thu Mar 2 21:43:25 2017
New Revision: 296854
URL: http://llvm.org/viewvc/llvm-project?rev=296854&view=rev
Log:
Clean up more usages of _LIBCPP_HAS_NO_RVALUE_REFERENCES
Modified:
libcxx/trunk/test/std/iterators/predef.iterators/insert.iterators/back.insert.iter.ops/back.
Author: ericwf
Date: Fri Mar 3 16:35:58 2017
New Revision: 296919
URL: http://llvm.org/viewvc/llvm-project?rev=296919&view=rev
Log:
Fix hash requirements check in __hash_table.
r296565 attempted to add better diagnostics when an unordered container
is instantiated with a hash that doesn't meet t
Author: ericwf
Date: Fri Mar 3 16:47:45 2017
New Revision: 296922
URL: http://llvm.org/viewvc/llvm-project?rev=296922&view=rev
Log:
Remove the buildit and testit scripts; they haven't been supported in years
Removed:
libcxx/trunk/lib/buildit
libcxx/trunk/test/testit
Removed: libcxx/trun
eir code compiling until they have time to fix it.
Of course patches are always welcome :-P
/Eric
> Is it possible to use some warning text that lets people know what they
> need to do to make the compiler happy, instead of just telling them that
> the compiler is unhappy?
>
> On F
Author: ericwf
Date: Fri Mar 3 19:02:35 2017
New Revision: 296936
URL: http://llvm.org/viewvc/llvm-project?rev=296936&view=rev
Log:
Turn on -Wunused-function and cleanup occurances
Modified:
libcxxabi/trunk/CMakeLists.txt
libcxxabi/trunk/cmake/config-ix.cmake
libcxxabi/trunk/src/cxa_
Author: ericwf
Date: Fri Mar 3 19:26:41 2017
New Revision: 296940
URL: http://llvm.org/viewvc/llvm-project?rev=296940&view=rev
Log:
Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp
Modified:
libcxxabi/trunk/test/CMakeLists.txt
libcxxabi/trunk/test/cxa_thread_ate
Author: ericwf
Date: Fri Mar 3 19:29:51 2017
New Revision: 296942
URL: http://llvm.org/viewvc/llvm-project?rev=296942&view=rev
Log:
teach LIT how to detect the glibc version
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://ll
Author: ericwf
Date: Fri Mar 3 20:04:45 2017
New Revision: 296952
URL: http://llvm.org/viewvc/llvm-project?rev=296952&view=rev
Log:
[libcxxabi] Fix alignment of allocated exceptions in 32 bit builds
Summary:
In 32 bit builds on a 64 bit system `std::malloc` does not return correctly
aligned mem
Author: ericwf
Date: Fri Mar 3 20:15:37 2017
New Revision: 296954
URL: http://llvm.org/viewvc/llvm-project?rev=296954&view=rev
Log:
Fix CMake configuration errors on OS X
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-proj
Author: ericwf
Date: Fri Mar 3 20:29:25 2017
New Revision: 296955
URL: http://llvm.org/viewvc/llvm-project?rev=296955&view=rev
Log:
Attempt to suppress test failures on OS X
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
libcxxabi/trunk/test/test_exception_address_alignment.pass
LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL should be set by
`check_library_exists` at the bottom of `config-ix.cmake`.
On Fri, Mar 3, 2017 at 7:22 PM, Jonathan Roelofs
wrote:
>
>
> On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote:
>
>> Author: ericwf
>> Date: Fri Mar
Author: ericwf
Date: Fri Mar 3 21:03:27 2017
New Revision: 296957
URL: http://llvm.org/viewvc/llvm-project?rev=296957&view=rev
Log:
Add missing UNSUPPORTED for -fno-exception mode
Modified:
libcxxabi/trunk/test/test_exception_address_alignment.pass.cpp
Modified: libcxxabi/trunk/test/test_ex
Author: ericwf
Date: Fri Mar 3 21:23:15 2017
New Revision: 296960
URL: http://llvm.org/viewvc/llvm-project?rev=296960&view=rev
Log:
Fully Reformat fallback_malloc.cpp
This patch fully reformats fallback_malloc.cpp. Previously the test
was a mess of different styles and indentations. This made it
Author: ericwf
Date: Sat Mar 4 06:28:12 2017
New Revision: 296965
URL: http://llvm.org/viewvc/llvm-project?rev=296965&view=rev
Log:
Fix nonsense comment
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://llvm.org/viewvc/llvm-pr
Author: ericwf
Date: Mon Mar 6 14:49:42 2017
New Revision: 297066
URL: http://llvm.org/viewvc/llvm-project?rev=297066&view=rev
Log:
Mark two any_cast issues as complete
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llv
Author: ericwf
Date: Mon Mar 6 14:56:13 2017
New Revision: 297069
URL: http://llvm.org/viewvc/llvm-project?rev=297069&view=rev
Log:
Mark LWG 2781 as complete. No changes required
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/
Author: ericwf
Date: Mon Mar 6 15:02:06 2017
New Revision: 297071
URL: http://llvm.org/viewvc/llvm-project?rev=297071&view=rev
Log:
Implement LWG 2787 - [file_status.cons] is inconsistent
Modified:
libcxx/trunk/include/experimental/filesystem
libcxx/trunk/test/std/experimental/filesyste
Author: ericwf
Date: Mon Mar 6 15:07:18 2017
New Revision: 297073
URL: http://llvm.org/viewvc/llvm-project?rev=297073&view=rev
Log:
Mark LWG 2789 as complete. No changes required
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/
Author: ericwf
Date: Mon Mar 6 15:09:02 2017
New Revision: 297074
URL: http://llvm.org/viewvc/llvm-project?rev=297074&view=rev
Log:
Mark LWG 2806 as complete. Libc++ speculatively shiped this change in 4.0
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.
Author: ericwf
Date: Mon Mar 6 15:23:36 2017
New Revision: 297079
URL: http://llvm.org/viewvc/llvm-project?rev=297079&view=rev
Log:
Add list of filesystem NB comments to TODO.TXT so they can be tracked separately
Modified:
libcxx/trunk/TODO.TXT
Modified: libcxx/trunk/TODO.TXT
URL:
http://l
Author: ericwf
Date: Mon Mar 6 16:52:28 2017
New Revision: 297089
URL: http://llvm.org/viewvc/llvm-project?rev=297089&view=rev
Log:
[coroutines] Improve diagnostics when building implicit constructs.
Previously when a coroutine was building the implicit setup/destroy
constructs it would emit dia
Author: ericwf
Date: Mon Mar 6 17:38:15 2017
New Revision: 297093
URL: http://llvm.org/viewvc/llvm-project?rev=297093&view=rev
Log:
[coroutines] Add DependentCoawaitExpr and fix re-building CoroutineBodyStmt.
Summary:
The changes contained in this patch are:
1. Defines a new AST node `CoawaitDe
Author: ericwf
Date: Mon Mar 6 18:01:13 2017
New Revision: 297105
URL: http://llvm.org/viewvc/llvm-project?rev=297105&view=rev
Log:
Fix unused variable in SemaCoroutine.cpp
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp
URL:
http://llvm.org/vi
Author: ericwf
Date: Mon Mar 6 18:15:18 2017
New Revision: 297106
URL: http://llvm.org/viewvc/llvm-project?rev=297106&view=rev
Log:
Define LLVM_ENABLE_WARNINGS when building standalone clang to ensure warnings
get enabled
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.tx
Author: ericwf
Date: Wed Mar 8 14:06:01 2017
New Revision: 297306
URL: http://llvm.org/viewvc/llvm-project?rev=297306&view=rev
Log:
Fix PR32183 - Wrap GCC exception implementation in missing namespace std
Modified:
libcxx/trunk/src/support/runtime/exception_glibcxx.ipp
libcxx/trunk/src/s
Author: ericwf
Date: Wed Mar 8 19:54:13 2017
New Revision: 297355
URL: http://llvm.org/viewvc/llvm-project?rev=297355&view=rev
Log:
Disable unsigned integer sanitizer for basic_string::replace(). Patch from
tomche...@google.com
basic_string::replace() has the below line
__sz += __n2 - __n1;
w
Author: ericwf
Date: Wed Mar 8 23:01:31 2017
New Revision: 297358
URL: http://llvm.org/viewvc/llvm-project?rev=297358&view=rev
Log:
[coroutines] Fix assertion in DependentCoawaitExpr when the argument is
non-dependent.
Summary:
A `co_await arg` expression has a dependent type whenever the promi
Author: ericwf
Date: Fri Mar 10 18:07:08 2017
New Revision: 297532
URL: http://llvm.org/viewvc/llvm-project?rev=297532&view=rev
Log:
Fix DoNotOptimize on MSVC
Modified:
libcxx/trunk/test/support/test_macros.h
Modified: libcxx/trunk/test/support/test_macros.h
URL:
http://llvm.org/viewvc/llvm
Author: ericwf
Date: Fri Mar 10 20:35:37 2017
New Revision: 297547
URL: http://llvm.org/viewvc/llvm-project?rev=297547&view=rev
Log:
[coroutines] Fix diagnostics depending on the first coroutine statement.
Summary:
Some coroutine diagnostics need to point to the location of the first coroutine
k
Author: ericwf
Date: Fri Mar 10 21:24:18 2017
New Revision: 297553
URL: http://llvm.org/viewvc/llvm-project?rev=297553&view=rev
Log:
Change test coverage generation to use llvm-cov instead of gcov.
Clang doesn't produce gcov compatible coverage files. This
causes lcov to break because it uses gco
On Thu, Mar 9, 2017 at 9:36 AM, Nico Weber wrote:
> Consider landing the obvious bits (print function, mostly) separately and
> use this only for the interesting bits.
>
Sounds good. I just wanted to make sure I got the simple bits right as well.
If this doesn't get reviewed in the next week I'
Author: ericwf
Date: Fri Mar 10 23:28:09 2017
New Revision: 297555
URL: http://llvm.org/viewvc/llvm-project?rev=297555&view=rev
Log:
fix test coverage capture dirs
Modified:
libcxx/trunk/test/CMakeLists.txt
Modified: libcxx/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/
Hi Bruno,
Thank you for the fix. I couldn't get to it today. I'll watch the sanitizer
bots more carefully in future.
On Mar 13, 2017 10:26 PM, "Bruno Cardoso Lopes"
wrote:
> Hi Eric,
>
> I fixed the build for darwin in r297703, let me know if you have any
> comments.
>
> Thanks,
>
> On Mon, Mar
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include
Does GCC offer these as contexpr? If not t
EricWF added inline comments.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:22
+
+#ifndef _LIBCPP_VERSION
+#error _LIBCPP_VERSION not defined
jlebar wrote:
> EricWF wrote:
> > You don't need this `_LIBCPP_VERSION` check here.
> Hm, there a
EricWF added inline comments.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include
jlebar wrote:
> EricWF wrote:
> > Does GCC offer these as contexpr? If not this needs a `// XFAIL: gcc`
> Looks like the r
Author: ericwf
Date: Tue Nov 15 14:21:30 2016
New Revision: 287020
URL: http://llvm.org/viewvc/llvm-project?rev=287020&view=rev
Log:
Add .clang-format to libc++
Adding a Clang Format file to libc++ and which style it should use has been
discussed a couple of times. This patch finally adds a .clan
Author: ericwf
Date: Tue Nov 15 22:45:32 2016
New Revision: 287080
URL: http://llvm.org/viewvc/llvm-project?rev=287080&view=rev
Log:
Fix non-reserved name usage
Modified:
libcxx/trunk/include/limits
Modified: libcxx/trunk/include/limits
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/
EricWF created this revision.
EricWF added reviewers: alexfh, hokein, aaron.ballman.
EricWF added a subscriber: cfe-commits.
This patch adds handling for member initializers in a constructors initializer
list. Previously we only handled base-class and delegating initializers, which
are transform
Author: ericwf
Date: Wed Nov 16 08:48:42 2016
New Revision: 287109
URL: http://llvm.org/viewvc/llvm-project?rev=287109&view=rev
Log:
Fix -verify tests for older ccache versions
Modified:
libcxx/trunk/test/libcxx/test/format.py
Modified: libcxx/trunk/test/libcxx/test/format.py
URL:
http://ll
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: src/new.cpp:163
-_LIBCPP_WEAK _LIBCPP_NEW_DELETE_VIS
void*
You should be able to remove the macro on the definitions since they're
redund
EricWF added a comment.
What happens on windows when `operator new` isn't overridden and has to be
imported from the DLL? Does that work?
https://reviews.llvm.org/D26702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: test/clang-tidy/readability-identifier-naming.cpp:155
// CHECK-FIXES: {{^}}class CMyClass {{{$}}
+public:
my_class();
aaron.ballman wrote:
> Why set the access specifier here
EricWF updated this revision to Diff 78252.
EricWF added a comment.
Fix `auto` usage.
https://reviews.llvm.org/D26744
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifier-naming.cpp
Author: ericwf
Date: Wed Nov 16 15:15:58 2016
New Revision: 287153
URL: http://llvm.org/viewvc/llvm-project?rev=287153&view=rev
Log:
[clang-tidy] Fix identifier naming for initializer list member initializers.
Summary:
This patch adds handling for member initializers in a constructors initializer
EricWF added a comment.
@rsmith ping. This is kind-of blocking making libc++'s tag types not
constructible from `{}`.
https://reviews.llvm.org/D25654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. This patch misses `any.modifiers/emplace.pass.cpp` but I'll fix that up
and commit with the libc++ changes!
https://reviews.llvm.org/D26782
__
Author: ericwf
Date: Thu Nov 17 13:23:35 2016
New Revision: 287249
URL: http://llvm.org/viewvc/llvm-project?rev=287249&view=rev
Log:
Test changes for P0504R0 "Revisiting in-place tag types for
any/optional/variant". Patch from Casey Carter
Modified:
libcxx/trunk/test/std/utilities/any/any.c
Author: ericwf
Date: Thu Nov 17 13:24:04 2016
New Revision: 287250
URL: http://llvm.org/viewvc/llvm-project?rev=287250&view=rev
Log:
Implement P0504R0: Revisiting in-place tag types for any/optional/variant
Modified:
libcxx/trunk/include/any
libcxx/trunk/include/utility
Modified: libcxx/
Author: ericwf
Date: Thu Nov 17 13:24:34 2016
New Revision: 287251
URL: http://llvm.org/viewvc/llvm-project?rev=287251&view=rev
Log:
Remove files missed in r287250
Removed:
libcxx/trunk/test/libcxx/utilities/utility/utility.inplace/
___
cfe-commits
EricWF closed this revision.
EricWF added a comment.
r287249. Thanks again!
https://reviews.llvm.org/D26782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Nov 17 14:08:43 2016
New Revision: 287255
URL: http://llvm.org/viewvc/llvm-project?rev=287255&view=rev
Log:
Workaround compilers w/o C++1z inline variables
Modified:
libcxx/trunk/include/__config
libcxx/trunk/include/utility
Modified: libcxx/trunk/include/__confi
EricWF updated this revision to Diff 78410.
EricWF added a comment.
OK, I've applied the fix to C++11 and C++14. Although the
inheriting-constructor part still only matters in C++1z since it requires
having base classes.
I also fixed aggregate initialization for types with non-aggregate base
c
EricWF created this revision.
EricWF added reviewers: mclow.lists, rsmith.
EricWF added a subscriber: cfe-commits.
Because `locale.h` isn't part of the libc++ modules the class definitions it
provides are exported as part of `__locale` (since it happens to be build
first). This breaks `` which e
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D26825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
EricWF updated this revision to Diff 78459.
EricWF added a comment.
Add tests that explicit default constructors are still allowed outside of
copy-initialization.
https://reviews.llvm.org/D25654
Files:
lib/AST/DeclCXX.cpp
test/CXX/dcl.decl/dcl.init/dcl.init.aggr/p1.cpp
test/CXX/dcl.decl/
EricWF added a comment.
Which paper is this implementing?
Also please update the synopsis comment at the top of the header.
Comment at: include/string_view:749
+inline namespace literals
+{
If this is new to C++17 then the new declarations should be guarded
Author: ericwf
Date: Fri Nov 18 00:42:17 2016
New Revision: 287321
URL: http://llvm.org/viewvc/llvm-project?rev=287321&view=rev
Log:
Remove _LIBCPP_HAS_NO_DEFAULTED_FUNCTIONS
libc++ no longer supports C++11 compilers that don't implement `= default`.
This patch removes all instances of the featur
EricWF added a comment.
Please add tests to `cxx1y-user-defined-literals.cpp` (and probably rename it).
Other than that this LGTM, but I don't feel comfortable approving clang patches.
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cf
1001 - 1100 of 2677 matches
Mail list logo
