EricWF added inline comments.
================ Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:22 + +#ifndef _LIBCPP_VERSION +#error _LIBCPP_VERSION not defined ---------------- jlebar wrote: > EricWF wrote: > > You don't need this `_LIBCPP_VERSION` check here. > Hm, there are lots of tests that have this, and since this test will not > compile with libstdc++, if it's not appropriate here, I am confused as to > when we should and shouldn't have this check. When should it be used? Every header has a test that including it provides `_LIBCPP_VERSION`, but that's the only time this needs to appear. https://reviews.llvm.org/D25403 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
