Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

I have some benchmarks, but none of them moved when I added the support that I could see. It wouldn't catch small regressions though. -eric On Wed, Jan 20, 2016 at 3:17 PM Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > I see. I was hoping that if you were, I could have used the

Re: [PATCH] D16372: [CUDA] Make printf work.

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. Looks reasonable to me. -eric http://reviews.llvm.org/D16372 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D16495: [CUDA] Use Triple::isNVPTX() instead of enumerating nvptx && nvptx64.

echristo added a comment. Probably qualifies as obvious. Also can you add some text to the assert while you're there? http://reviews.llvm.org/D16495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D16495: [CUDA] Use Triple::isNVPTX() instead of enumerating nvptx && nvptx64.

Probably qualifies as obvious. Also can you add some text to the assert while you're there? On Fri, Jan 22, 2016, 5:07 PM Justin Lebar wrote: > jlebar created this revision. > jlebar added a reviewer: tra. > jlebar added subscribers: cfe-commits, jhen, echristo. > > No functional changes. > > ht

Re: [PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

OK. -eric On Fri, Jan 22, 2016 at 5:56 PM Justin Lebar wrote: > jlebar created this revision. > jlebar added a reviewer: tra. > jlebar added subscribers: echristo, jhen, cfe-commits. > > CUDA (well, strictly speaking, NVPTX) doesn't support aliases. > > http://reviews.llvm.org/D16502 > > Files:

Re: [PATCH] D16502: [CUDA] Reject the alias attribute in CUDA device code.

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. OK. One question inline, but feel free to commit after answering one way or the other :) -eric Comment at: test/SemaCUDA/alias.cu:1-

Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

echristo added a comment. Honestly if they've been reviewed like that internally I'm ok with you just committing them - especially if they look like this. The only concerns I'd have are in the case of "This intrinsic corresponds to the instruction" (side note, use the "the"? I commented on a c

Re: [PATCH] D16538: [cc1as] Add MCTargetOptions argument to createAsmBackend

echristo added a comment. Hi Joel, Since you're likely going to need to start filling in the Options there anyhow, can you lift the one from the TODO and start filling it in? -eric http://reviews.llvm.org/D16538 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

echristo added inline comments. Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109 @@ -106,1 +108,3 @@ +// stacksave/stackrestore intrinsics, which cause ptxas to choke. +auto *Alloca = new llvm::AllocaInst( llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::get(Int32Ty, B

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

I'm also just curious how we got all the way to here without having the error emitted and compilation stopped? -eric On Thu, Jan 28, 2016 at 9:53 AM Justin Bogner wrote: > Manman Ren via cfe-commits writes: > > manmanren created this revision. > > manmanren added reviewers: echristo, rafael, a

Re: [PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

echristo added inline comments. Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109 @@ -106,1 +108,3 @@ +// stacksave/stackrestore intrinsics, which cause our nvvm backend to choke. +auto *Alloca = new llvm::AllocaInst( llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::ge

Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. Yep. As I said, I expect to be on the losing side of that argument - just too much prior art :) -eric http://reviews.llvm.org/D15999 _

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

echristo added a comment. In general it feels like keeping 2 errors might make the most sense: (Using a multiarch build rather than a cuda command line, but it should still be the same behavior for consistency) t.c: #if _NOT_ARCH4_ #error "aiee!" #endif clang -arch arch1 -arch arch2 -arch arc

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems like a weird place to handle this, but it's been there for a long time. That said, I see how we can get there now, thanks! -eric http://reviews.llvm.org/D16564 _

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

echristo added a comment. > The other reason, which is less important, is that when you have one arch and > ptxas fails -- which, it shouldn't, but we're not good enough to catch > everything yet, and likely won't be for some time -- the error you get is > > ptxas: foo is not defined >

Re: [PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. One inline nit then LGTM. -eric Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87 @@ +86,3 @@ + // Construct and fill the args buffer tha

Re: [PATCH] D16664: [CUDA] Generate CUDA's printf alloca in its function's entry block.

echristo added inline comments. Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87 @@ +86,3 @@ + // Construct and fill the args buffer that we'll pass to vprintf. + llvm::Value* BufferPtr; + if (Args.size() <= 1) { jlebar wrote: > echristo wrote: > > * on the wrong s

r259138 - Add the clang debug info test directory to .gitignore as it's managed separately.

Author: echristo Date: Thu Jan 28 19:35:55 2016 New Revision: 259138 URL: http://llvm.org/viewvc/llvm-project?rev=259138&view=rev Log: Add the clang debug info test directory to .gitignore as it's managed separately. Modified: cfe/trunk/.gitignore Modified: cfe/trunk/.gitignore URL: http:/

r259137 - Use a consistent spelling for vtables.

Author: echristo Date: Thu Jan 28 19:35:53 2016 New Revision: 259137 URL: http://llvm.org/viewvc/llvm-project?rev=259137&view=rev Log: Use a consistent spelling for vtables. Modified: cfe/trunk/include/clang/Basic/TargetCXXABI.h cfe/trunk/lib/CodeGen/CGClass.cpp cfe/trunk/lib/CodeGen/

Re: [PATCH] D16562: Adding doxygen comments to the LLVM intrinsics (part 3, __wmmintrin_aes.h)

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. Yep. :) Repository: rL LLVM http://reviews.llvm.org/D16562 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D16705: Avoid overly large SmallPtrSet/SmallSet

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric Repository: rL LLVM http://reviews.llvm.org/D16705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D14556: [CUDA] Detect and link with CUDA's libdevice bitcode library.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. A couple of inline comments, but this is fine for now. We need a command line option to select CUDA version as well. -eric Comment at: lib/Driver/ToolChains.cpp:1635 @@

Re: [PATCH] D13170: [CUDA] Driver changes to pass flags needed to use detected CUDA installation.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This needs a very long commit message describing exactly what's going on and why since it's not documented anywhere. Possibly in the code as well at AddPreprocessingOptions and other place

Re: [PATCH] D13144: [CUDA] propagate to CUDA sub-compilations target triple of opposite side.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. One inline comment then OK for now. -eric Comment at: lib/Driver/Tools.cpp:3227-3240 @@ -3226,2 +3226,16 @@ + if (IsCuda) { +const ToolChain *AuxToolChain; +if

Re: [PATCH] D13834: Produce a better diagnostic for global register variables

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! -eric http://reviews.llvm.org/D13834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r253117 - Clarify and elaborate the conditions on which we're checking target

Author: echristo Date: Fri Nov 13 19:56:04 2015 New Revision: 253117 URL: http://llvm.org/viewvc/llvm-project?rev=253117&view=rev Log: Clarify and elaborate the conditions on which we're checking target features for calls. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp Modified: cfe/trunk/lib/Co

Re: r252834 - Provide a frontend based error for always_inline functions that require

ility to give reasons out of the always inline pass when faced with >> cost analysis. >> >> -eric >> >> >>> On Wed, Nov 11, 2015 at 4:48 PM, Eric Christopher >>> wrote: >>> >>>> FWIW we should also have the backend avoid inlining and

Re: r252834 - Provide a frontend based error for always_inline functions that require

On Thu, Nov 12, 2015 at 11:55 AM Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Eric Christopher via cfe-commits > > Sen

r253121 - Add support for the always_inline + target feature diagnostic to print

Author: echristo Date: Fri Nov 13 20:38:37 2015 New Revision: 253121 URL: http://llvm.org/viewvc/llvm-project?rev=253121&view=rev Log: Add support for the always_inline + target feature diagnostic to print out the first missing target feature that's required and reword the diagnostic accordingly.

Re: r252834 - Provide a frontend based error for always_inline functions that require

On Wed, Nov 11, 2015 at 5:38 PM Richard Smith wrote: > On Wed, Nov 11, 2015 at 5:25 PM, Eric Christopher > wrote: > >> On Wed, Nov 11, 2015 at 5:03 PM Richard Smith >> wrote: >> >>> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <

Re: r252834 - Provide a frontend based error for always_inline functions that require

27; > V0 = _mm_mul_ps(V6,V3); > > We could annotate cfft2 with 'fsgsbase' in the tests, but it seems odd > to me that we would need to care about any function that use x86 > intrinsics when compiling for x86_64h. Any thoughts on that? > > > On Wed,

r253242 - When producing error messages for always_inline functions with the

Author: echristo Date: Mon Nov 16 12:29:59 2015 New Revision: 253242 URL: http://llvm.org/viewvc/llvm-project?rev=253242&view=rev Log: When producing error messages for always_inline functions with the target attribute, don't include "negative" subtarget features in the list of required features.

Re: r252834 - Provide a frontend based error for always_inline functions that require

Fixed thusly: dzur:~/sources/llvm/tools/clang> git svn dcommit Committing to https://llvm.org/svn/llvm-project/cfe/trunk ... A test/CodeGen/target-features-no-error.c M lib/CodeGen/CodeGenFunction.cpp Committed r253242 Thanks! -eric On Mon, Nov 16, 2015 at 9:48 AM Bruno Cardoso Lopes wrote: >

Re: r253202 - clang-format: Enable #include sorting by default.

!!! Awesome :) -eric On Mon, Nov 16, 2015 at 4:41 AM Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Mon Nov 16 06:38:56 2015 > New Revision: 253202 > > URL: http://llvm.org/viewvc/llvm-project?rev=253202&view=rev > Log: > clang-format: Enable #i

Re: [PATCH] D14748: bmiintrin.h: Allow using the tzcnt intrinsics for non-BMI targets

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sounds good to me. Weird, but fine :) -eric http://reviews.llvm.org/D14748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D13980: Add "x87" in x86 target feature map

echristo added a subscriber: echristo. echristo added a comment. Are there any of the intrinsics in the headers that also depend on x87? One inline comment. -eric Comment at: lib/Basic/Targets.cpp:2538-2539 @@ -2537,1 +2537,4 @@ + // All X86 processors but i386 have X87. +

Re: [PATCH] D14887: Make tbm-builtins.c as X86 specific unit test

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This is fine. One inline comment. -eric Comment at: test/CodeGen/tbm-builtins.c:2-3 @@ -1,3 +1,4 @@ // RUN: %clang_cc1 %s -O3 -triple=x86_64-unknown-unknown -target-feat

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

This is amazing... And entirely the wrong place for the asm tests. :) Would you mind splitting this test case in two with an IR test for clang and an asm test for llvm? Thanks! On Sun, Nov 29, 2015, 12:25 PM Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon >

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

Hi, This is entirely the wrong way to do these tests. They shouldn't depend on assembly output or optimization. Please split them onto frontend IR tests and backend assembly tests. Thanks! On Sun, Nov 29, 2015, 2:56 AM Alexandros Lamprineas via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

There's no reason a split set of tests would fail at doing this. You can test that the IR is what you expect and then that the backend tests it as well. It's very simple to do. On Sun, Nov 29, 2015, 2:08 PM Simon Pilgrim wrote: > So the problem we’re trying to solve is it make sure that in debug

Re: r254262 - [X86][SSE2] Added SSE2 IR + assembly codegen builtin tests

s not a guarantee but it certainly should help. --paulr *From:* cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] *On Behalf Of *Eric Christopher via cfe-commits *Sent:* Sunday, November 29, 2015 2:21 PM *To:* Simon Pilgrim; cfe-commits@lists.llvm.org *Subject:* Re: r254262 - [X86][SSE2]

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

, James On Sun, 29 Nov 2015 at 20:40 Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: Hi, This is entirely the wrong way to do these tests. They shouldn't depend on assembly output or optimization. Please split them onto frontend IR tests and backend assembly

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

we need tests for both Clang and LLVM >> separately. However I also think the full-trip tests add significant value >> and wouldn't like to see them removed, and there's significant prior art in >> this area so if we did decide they needed to be gone, we'd need a good

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

On Tue, Dec 1, 2015 at 10:43 AM James Molloy via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > > That would sort of defeat the point of having the testing and projects > separated though - it would tie the tests together and produce most of the > undesirable outcomes of having single

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

Could you provide an example proving this? I answered your question with exactly how to split it up. On Tue, Dec 1, 2015, 10:54 AM James Molloy wrote: > You cannot test the intrinsic emission with the same quality when > splitting the test in two. You miss testing the producer consumer > relatio

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

On Tue, Dec 1, 2015 at 10:45 AM Eric Christopher wrote: > On Tue, Dec 1, 2015 at 10:43 AM James Molloy via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi, >> >> > That would sort of defeat the point of having the testing and projects >> separated though - it would tie the tests togeth

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. Please remove the asm tests here. As I stated in the original review thread there's no reason for them to be here. Thanks. -eric http://reviews.llvm.org/D15223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. One inline comment, thanks! -eric Comment at: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c:4 @@ -3,4 +3,3 @@ // RUN: %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \ -// RUN: -target-feature +v8.1a -O3 -S -o - %s \ -// RUN: | FileCheck %

r254958 - 80-col and whitespace fixups.

Author: echristo Date: Mon Dec 7 16:43:05 2015 New Revision: 254958 URL: http://llvm.org/viewvc/llvm-project?rev=254958&view=rev Log: 80-col and whitespace fixups. Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/lib/Driver/ToolChains.cpp URL: http://llvm.org/viewvc/llvm-p

r254973 - 80-column fixup.

Author: echristo Date: Mon Dec 7 18:10:13 2015 New Revision: 254973 URL: http://llvm.org/viewvc/llvm-project?rev=254973&view=rev Log: 80-column fixup. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Dr

r254972 - Update comment.

Author: echristo Date: Mon Dec 7 18:10:10 2015 New Revision: 254972 URL: http://llvm.org/viewvc/llvm-project?rev=254972&view=rev Log: Update comment. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Dri

r254984 - Update comment to reflect that we use other tools via the toolchain to

Author: echristo Date: Mon Dec 7 19:59:47 2015 New Revision: 254984 URL: http://llvm.org/viewvc/llvm-project?rev=254984&view=rev Log: Update comment to reflect that we use other tools via the toolchain to handle more than just C. Modified: cfe/trunk/include/clang/Driver/ToolChain.h Modified

r254985 - Remove name from FIXME.

Author: echristo Date: Mon Dec 7 19:59:51 2015 New Revision: 254985 URL: http://llvm.org/viewvc/llvm-project?rev=254985&view=rev Log: Remove name from FIXME. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

r254986 - Replace a bunch of duplicate conditions with the call from types::.

Author: echristo Date: Mon Dec 7 20:10:19 2015 New Revision: 254986 URL: http://llvm.org/viewvc/llvm-project?rev=254986&view=rev Log: Replace a bunch of duplicate conditions with the call from types::. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: h

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. Should be pretty easy to either use CHECK-DAG or pick out the particular instructions you want to check here. Otherwise you're just checking how the optimizer runs. That, in particular, also sounds like a good backend check. http://reviews.llvm.org/D15223 _

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. I understand the conflicting priorities here for sure. You'd like a test that's as minimal as possible, without having to depend on external (to clang) libraries here. I really would appreciate it if you'd make the test not rely on mem2reg etc so we can be sure that cl

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

On Mon, Dec 14, 2015 at 10:44 AM Tim Northover wrote: > On 14 December 2015 at 09:20, Eric Christopher via cfe-commits > wrote: > > I understand the conflicting priorities here for sure. You'd like a test > that's as minimal as possible, without having to depen

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

On Mon, Dec 14, 2015 at 11:05 AM Tim Northover wrote: > > I don't think it's going to be even vaguely that bad here and that you're > > blowing it a bit out of proportion. [...] It does make the tests a > little harder > > to write, but having done a bunch of them it's not that bad. > > I've also

r255840 - Fix funciton->function typo.

Author: echristo Date: Wed Dec 16 17:10:46 2015 New Revision: 255840 URL: http://llvm.org/viewvc/llvm-project?rev=255840&view=rev Log: Fix funciton->function typo. Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp cfe/trunk/lib/AST/MicrosoftMangle.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h

Re: [PATCH] D15524: [GCC] Attribute ifunc support in clang

echristo added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2758 @@ +2757,3 @@ +GA->setIFunc(true); +GA->setLinkage(llvm::GlobalValue::LinkOnceAnyLinkage); + } rjmccall wrote: > DmitryPolukhin wrote: > > rjmccall wrote: > > > Can you explain

Re: [PATCH] D15613: Fix ARM __cxa_end_cleanup() and gc-sections.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This works for me as a workaround, a comment about what's going on here would probably be good. -eric http://reviews.llvm.org/D15613 ___ cf

Re: [PATCH] D15651: Driver part of debugger tuning

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! -eric http://reviews.llvm.org/D15651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D15650: CC1 part of debugger tuning; pass through setting from driver to LLVM.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sadly, isn't really a way to test this part. Thanks! -eric http://reviews.llvm.org/D15650 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D15598: [Driver] Make AddCXXStdlibLibArgs responsible for handling -static-libstdc++.

echristo added a comment. What's "expected" here? Do we know which of the options are overriding? IIRC shared and the static options aren't necessarily last one wins with gcc. -eric http://reviews.llvm.org/D15598 ___ cfe-commits mailing list cfe-c

r256076 - Use a command line alias to remove the need to rewrite a subtarget

Author: echristo Date: Fri Dec 18 19:48:43 2015 New Revision: 256076 URL: http://llvm.org/viewvc/llvm-project?rev=256076&view=rev Log: Use a command line alias to remove the need to rewrite a subtarget feature for command line compatibility. Modified: cfe/trunk/include/clang/Driver/Options.td

Re: [PATCH] D15613: Fix ARM __cxa_end_cleanup() and gc-sections.

echristo added a comment. Sure, I don't care enough either way :) -eric http://reviews.llvm.org/D15613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256228 - Use -no-canonical-prefixes to make sure binaries names are easier to match.

Author: echristo Date: Mon Dec 21 19:45:45 2015 New Revision: 256228 URL: http://llvm.org/viewvc/llvm-project?rev=256228&view=rev Log: Use -no-canonical-prefixes to make sure binaries names are easier to match. Modified: cfe/trunk/test/Driver/wasm-toolchain.c Modified: cfe/trunk/test/Driver/

r256230 - Pull out a bunch of duplicated option handling code into its own

Author: echristo Date: Mon Dec 21 21:12:34 2015 New Revision: 256230 URL: http://llvm.org/viewvc/llvm-project?rev=256230&view=rev Log: Pull out a bunch of duplicated option handling code into its own function and use for the targets that can easily support it. Modified: cfe/trunk/lib/Driver/T

Re: [PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

On Tue, Apr 27, 2021 at 8:01 AM Melanie Blower via Phabricator < revi...@reviews.llvm.org> wrote: > mibintc abandoned this revision. > mibintc added a comment. > > There was no resolution about what option name would be acceptable > Oh no, I'm sorry that you felt that way. I saw Vitaly's comment

Re: [PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

Sounds good. It's a soft objection, mostly because if nothing else it puts us back where we were subject to some latent bugs, but perhaps not as bad as before (though I don't find having to use an assert build reassuring ;) Anyhow, go ahead and we'll figure out something else. On Tue, Apr 27, 202

[clang] [clang] fix uefi target for aarch64 & x86_64 (PR #120632)

@@ -790,7 +790,9 @@ template class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo { protected: void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple, -MacroBuilder &Builder) const override {} +MacroBuilder

<    1   2   3   4   5   6