r312232 - docs: don't say that data flow tracing interface is unstable

2017-08-31 Thread Dmitry Vyukov via cfe-commits
Author: dvyukov Date: Thu Aug 31 04:02:44 2017 New Revision: 312232 URL: http://llvm.org/viewvc/llvm-project?rev=312232&view=rev Log: docs: don't say that data flow tracing interface is unstable We are starting to use data flow tracing in kernel. The interface is not subject to change anymore. R

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-19 Thread Dmitry Vyukov via cfe-commits
dvyukov added a comment. We need a test that passes non-NULL to these arguments and shows how to use the returned values. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199 @@ -164,7 +175,26 @@ ret += Run(argc - 1, 0, stack); +// CHECK: Child stack

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-27 Thread Dmitry Vyukov via cfe-commits
dvyukov added a comment. LGTM Any other comments? Or I will submit it tomorrow. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:7 @@ +6,3 @@ +// RUN: %clangxx_asan -std=c++11 -lpthread -O3 %s -o %t && %run %t 2>&1 | FileCheck %s +// RUN: %clangxx_asan -std=c++1

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-28 Thread Dmitry Vyukov via cfe-commits
dvyukov accepted this revision. dvyukov added a comment. This revision is now accepted and ready to land. Submitted in 282582. https://reviews.llvm.org/D24628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[clang] a1255dc - Use-after-return sanitizer binary metadata

2022-11-29 Thread Dmitry Vyukov via cfe-commits
Author: Dmitry Vyukov Date: 2022-11-29T17:37:36+01:00 New Revision: a1255dc467f7ce57a966efa764ee91d9115a URL: https://github.com/llvm/llvm-project/commit/a1255dc467f7ce57a966efa764ee91d9115a DIFF: https://github.com/llvm/llvm-project/commit/a1255dc467f7ce57a966efa764ee91d9115a.diff

[clang] e6aea4a - Use-after-return sanitizer binary metadata

2022-11-30 Thread Dmitry Vyukov via cfe-commits
Author: Dmitry Vyukov Date: 2022-11-30T09:14:19+01:00 New Revision: e6aea4a5db09c845276ece92737a6aac97794100 URL: https://github.com/llvm/llvm-project/commit/e6aea4a5db09c845276ece92737a6aac97794100 DIFF: https://github.com/llvm/llvm-project/commit/e6aea4a5db09c845276ece92737a6aac97794100.diff

[clang] 0aedf9d - Revert "Use-after-return sanitizer binary metadata"

2022-11-30 Thread Dmitry Vyukov via cfe-commits
Author: Dmitry Vyukov Date: 2022-11-30T09:38:56+01:00 New Revision: 0aedf9d7141fcae75956c651f1c2474db6862350 URL: https://github.com/llvm/llvm-project/commit/0aedf9d7141fcae75956c651f1c2474db6862350 DIFF: https://github.com/llvm/llvm-project/commit/0aedf9d7141fcae75956c651f1c2474db6862350.diff

[clang] d3c851d - Use-after-return sanitizer binary metadata

2022-11-30 Thread Dmitry Vyukov via cfe-commits
Author: Dmitry Vyukov Date: 2022-11-30T14:50:22+01:00 New Revision: d3c851d3fc8b69dda70bf5f999c5b39dc314dd73 URL: https://github.com/llvm/llvm-project/commit/d3c851d3fc8b69dda70bf5f999c5b39dc314dd73 DIFF: https://github.com/llvm/llvm-project/commit/d3c851d3fc8b69dda70bf5f999c5b39dc314dd73.diff

[clang] dbe8c2c - Use-after-return sanitizer binary metadata

2022-12-05 Thread Dmitry Vyukov via cfe-commits
Author: Dmitry Vyukov Date: 2022-12-05T14:40:31+01:00 New Revision: dbe8c2c316c40b25a0a37b91f1a1a02a55182378 URL: https://github.com/llvm/llvm-project/commit/dbe8c2c316c40b25a0a37b91f1a1a02a55182378 DIFF: https://github.com/llvm/llvm-project/commit/dbe8c2c316c40b25a0a37b91f1a1a02a55182378.diff

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

2016-09-16 Thread Dmitry Vyukov via cfe-commits
dvyukov added a comment. We need a test that passes non-NULL to these arguments and shows how to use the returned values. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:47 @@ -46,3 +46,3 @@ CallNoReturn(); - __sanitizer_finish_switch_fiber(); + __sanitizer

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

2017-02-27 Thread Dmitry Vyukov via cfe-commits
Does not seem to be related to tsan. It's just that somebody called a directory with compiler tsan_release_build, but that seems to be the only relation to tsan. Otherwise looks like a violated assertion in clang. On Mon, Feb 27, 2017 at 9:46 PM, Ivan Krasin wrote: > Hi Vedant, > > not on top of

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

2017-02-27 Thread Dmitry Vyukov via cfe-commits
Ivan, you are listed as admin of http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf Please issue a clobber for it. If it does not help, the bot runs the following script: https://github.com/llvm-mirror/zorg/blob/master/zorg/buildbot/builders/sanitizers/buildbot_standard.sh It builds

[PATCH] D23835: [compiler-rt] tsan/tests: Add missing -I for top-level include directory

2016-11-22 Thread Dmitry Vyukov via cfe-commits
dvyukov added a comment. What is standalone build? And how does it fail? https://reviews.llvm.org/D23835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25857: [tsan][clang] Introduce a function attribute to disable TSan checking at run time

2016-10-30 Thread Dmitry Vyukov via cfe-commits
dvyukov added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:717 + // Ignore TSan memory acesses from within dealloc and all of its calees at + // run time. This is unpleasant. We had recursive ignores in the old Valgrind-based tsan, but manage

[PATCH] D25857: [tsan][clang] Introduce a function attribute to disable TSan checking at run time

2016-11-06 Thread Dmitry Vyukov via cfe-commits
dvyukov added inline comments. Comment at: test/CodeGen/sanitize-thread-no-checking-at-run-time.m:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -x objective-c++ -emit-llvm -o - %s | FileCheck -check-prefix=WITHOUT %s +// RUN: %clang_cc1 -triple x86_64-apple-darwin -x objecti

[PATCH] D26461: Tread TSan LLVM flags to driver: add TSan controlling flags to clang.

2016-11-09 Thread Dmitry Vyukov via cfe-commits
dvyukov added inline comments. Comment at: include/clang/Driver/Options.td:733 + Group, Flags<[CC1Option]>, + HelpText<"Enable data race detection in ThreadSanitizer">; +def fno_sanitize_thread_data_races : Flag<[

[PATCH] D25857: [tsan][clang] Introduce a function attribute to disable TSan checking at run time

2016-11-10 Thread Dmitry Vyukov via cfe-commits
dvyukov accepted this revision. dvyukov added a comment. This revision is now accepted and ready to land. > Alternatively, I could drop this aspect of the test altogether since I have > an assert in the llvm pass. Dropping the check is fine in this case. https://reviews.llvm.org/D25857

Re: [PATCH] D14858: Support building tsan on android.

2015-11-20 Thread Dmitry Vyukov via cfe-commits
dvyukov added a comment. > Yes, we should use shared runtime library on Android. Note that tsan is different from all of asan/msan/ubsan in that it does zillions of calls into runtime, so the indirection will have non-zero runtime cost. Is it possible to statically link it into something that

[clang] [llvm] [SanitizerBinaryMetadata] Fix multi-version sanitizer metadata (PR #97848)

2024-07-07 Thread Dmitry Vyukov via cfe-commits
https://github.com/dvyukov approved this pull request. https://github.com/llvm/llvm-project/pull/97848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits