DmitryPolukhin added a comment.
Sorry, I was out for couple days.
It seems that there are no real objections so I'm committing this patch and I'm
going to keep working on this topic to support target attribute with dynamic
dispatching on x86 so if you think that something is missing, please let
Author: dpolukhin
Date: Mon Apr 11 02:48:59 2016
New Revision: 265917
URL: http://llvm.org/viewvc/llvm-project?rev=265917&view=rev
Log:
[GCC] Attribute ifunc support in clang
This patch add support for GCC attribute((ifunc("resolver"))) for
targets that use ELF as object file format. In general i
DmitryPolukhin added a comment.
The patch itself looks good to me but the main question do we want to support
VLA in C++ in GNU extension mode.
http://reviews.llvm.org/D18823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
DmitryPolukhin added inline comments.
Comment at: llvm/tools/clang/test/SemaCXX/c99-variable-length-array.cpp:1
@@ -1,1 +1,2 @@
-// RUN: %clang_cc1 -fsyntax-only -verify -Wvla-extension %s
+// RUN: %clang_cc1 -fsyntax-only -std=c++98 -DCPP98 -verify -Wvla-extension %s
+// RUN: %cl
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rnk.
DmitryPolukhin added a subscriber: cfe-commits.
The example below should work identically with and without compiler native
wchar_t support.
void foo(wchar_t * t = L"");
http://reviews.llvm.org/D19056
Files:
lib/Sema/
Author: dpolukhin
Date: Thu Apr 14 04:52:06 2016
New Revision: 266287
URL: http://llvm.org/viewvc/llvm-project?rev=266287&view=rev
Log:
[MSVC] Fix check for wchar_t type in case of -fno-wchar
The example below should work identically with and without compiler native
wchar_t support.
void foo(wch
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
I added few more negative tests. Thank you for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D19056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DmitryPolukhin added a comment.
Richard, this is just weekly friendly ping about abi_tag support.
Please let me know if you think if something in this patch needs improvements
or you are waiting for something specific before committing this patch.
http://reviews.llvm.org/D18035
DmitryPolukhin added a comment.
Weekly friendly ping, PTAL!
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rnk.
DmitryPolukhin added a subscriber: cfe-commits.
MSVC doesn't report even warning for cast from private base class to derived.
http://reviews.llvm.org/D19477
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/
Author: dpolukhin
Date: Tue Apr 26 04:21:17 2016
New Revision: 267534
URL: http://llvm.org/viewvc/llvm-project?rev=267534&view=rev
Log:
[MSVC] PR27337: allow static_cast from private base to derived for WTL
MSVC doesn't report even warning for cast from private base class to
derived.
Differentia
DmitryPolukhin added a comment.
Thank you for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D19477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin added a comment.
Richard, friendly ping, PTAL!
http://reviews.llvm.org/D18641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin updated this revision to Diff 58076.
DmitryPolukhin added a comment.
Fix test/PCH/attrs.c failure due to warning about unsupported abi_tag attribute
(committed in http://reviews.llvm.org/rL269869).
This patch implements abi_tag so the warning is not expected with this patch.
http
DmitryPolukhin updated this revision to Diff 58088.
DmitryPolukhin added a comment.
- drop dllexport for trivial defaulted x-tors for compatibility with MSVC2015
- move checks to CheckCompletedCXXClass because completed class definition is
required to detect if x-tor is trivial
http://reviews.l
DmitryPolukhin added a comment.
PTAL
Comment at: lib/Sema/SemaDeclCXX.cpp:13113-13114
@@ -13065,28 +13112,4 @@
-if (MD->isInvalidDecl())
- return;
-
-switch (Member) {
-case CXXDefaultConstructor:
- DefineImplicitDefaultConstructor(DefaultLoc,
-
Author: dpolukhin
Date: Tue May 24 01:37:14 2016
New Revision: 270535
URL: http://llvm.org/viewvc/llvm-project?rev=270535&view=rev
Log:
[MSVC2015] dllexport for defaulted special class members
Clang doesn't dllexport defaulted special member function defaulted
inside class but does it if they def
On Thu, May 26, 2016 at 12:41 AM, David Majnemer
wrote:
> In http://reviews.llvm.org/D18035#434095, @DmitryPolukhin wrote:
>
> > One more friendly ping.. :(
>
> I think the best way to make progress on this is to refactor this patch
> along the lines @rsmith suggested back on May 3.
>
To be
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: majnemer.
DmitryPolukhin added subscribers: cfe-commits, rnk.
It seems that suffix '@4HA' was omitted for unknown reason. It is non-const
non-volatile 'int' type of normal variable TSS.
http://reviews.llvm.org/D20683
Files:
DmitryPolukhin abandoned this revision.
DmitryPolukhin added a comment.
It seems that there is no interest in this patch, abandon.
http://reviews.llvm.org/D18641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: dpolukhin
Date: Fri May 27 03:52:34 2016
New Revision: 270974
URL: http://llvm.org/viewvc/llvm-project?rev=270974&view=rev
Log:
[MSVC2015] Fix mangling for static variables initialization guards
It seems that suffix '@4HA' was omitted for unknown reason. It is
non-cont non-volatile 'int'
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D18035#447473, @hfinkel wrote:
> FYI: There is now a specification, see:
> http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html
For the records, this patch implements GCC 6 abi_tag semantic and to the best
of my knowle
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D18035#450258, @rsmith wrote:
> Yes, I definitely want us to implement this for GCC compatibility. And now
> that we have a specification for this feature, we can evaluate whether this
> is doing the right thing. On that basis:
>
> I st
DmitryPolukhin updated this revision to Diff 61352.
DmitryPolukhin added a comment.
- removed wrong asserts that I used for an experiment
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/PCH/attrs.c
test/
DmitryPolukhin updated this revision to Diff 61350.
DmitryPolukhin added a comment.
This patch set contains serious refactoring to make it closer to what Richard
suggested. Unfortunately there is no way to fully implement Richard's idea
because we have to mangle twice name of functions and varia
DmitryPolukhin updated the summary for this revision.
DmitryPolukhin updated this revision to Diff 61642.
DmitryPolukhin added a comment.
Fixed issue with substitution from function name used in bare type encoding and
added test. With this patch Clang passes self build with GCC 5.3.1 headers and
DmitryPolukhin updated this revision to Diff 62213.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Use SmallVector instead of SmallSetVector and sort the vector when needed.
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAt
Author: dpolukhin
Date: Thu Jun 30 04:40:38 2016
New Revision: 274222
URL: http://llvm.org/viewvc/llvm-project?rev=274222&view=rev
Log:
[GCC] PR23529 Mangler part of attrbute abi_tag support
Original patch by Stefan Bühler http://reviews.llvm.org/D12834
Difference between original and this one:
Author: dpolukhin
Date: Thu Jun 30 06:15:52 2016
New Revision: 274223
URL: http://llvm.org/viewvc/llvm-project?rev=274223&view=rev
Log:
Fix CodeGenCXX/mangle-abi-tag.cpp on clang-ppc64le-linux bot
Modified:
cfe/trunk/test/CodeGenCXX/mangle-abi-tag.cpp
Modified: cfe/trunk/test/CodeGenCXX/mang
DmitryPolukhin added a comment.
Richard, thank you for the review!
I decided to commit this patch without waiting for GCC response to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71712 (that is last compatibility
issues in comparison with GCC6) so more people could test Clang implementation
of
DmitryPolukhin created this revision.
DmitryPolukhin added reviewers: hans, rsmith.
DmitryPolukhin added a subscriber: cfe-commits.
http://reviews.llvm.org/D21970
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- d
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rnk.
DmitryPolukhin added a subscriber: cfe-commits.
MSVC uses non-local mangling for vftable if class with dllexport attribute has
no virtual destructor. I checked all examples that I fixed with MSVC and it
uses '_7' in all
DmitryPolukhin added a comment.
David, do you know real programs that relay on constexpr and dllexport semantic
that doesn't work on MSVC? If not, I think we might want to report error
message instead of miss-compile it as MSVC does. Anyway current implementation
is not compatible with MSVC in
DmitryPolukhin added a comment.
I found the patch that prevents using imported vftable,
http://llvm.org/viewvc/llvm-project?view=revision&revision=260548 but the patch
has no examples of constexpr + dllimport.
http://reviews.llvm.org/D22034
___
cf
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#474985, @majnemer wrote:
> In http://reviews.llvm.org/D22034#474937, @DmitryPolukhin wrote:
>
> > David, do you know real programs that relay on constexpr and dllexport
> > semantic that doesn't work on MSVC?
>
>
> Yes, Chrome rel
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#475331, @majnemer wrote:
> Wait, can you give an example of MSVC exporting a vftable but not all the
> virtual methods (other than the deleting destructor)? I don't believe I've
> ever come across an example of this.
It is pos
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#475551, @majnemer wrote:
> In http://reviews.llvm.org/D22034#475540, @DmitryPolukhin wrote:
>
> > Here is B::foo is not exported but required to build vftable for D.
>
>
> What happens if D also had a virtual destructor?
It seems
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#475603, @majnemer wrote:
> Thinking about this some more, it is possible for clang to emit code that
> will make everybody happy:
>
> If a class is being constructed in a constexpr context and all the vftable
> entries it referen
DmitryPolukhin added a comment.
Friendly ping, PTAL!
http://reviews.llvm.org/D21970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin updated this revision to Diff 63793.
DmitryPolukhin added a comment.
Sorry for delay with patch rework, PTAL!
- added local vftable for constexpr
- added use of imported vftable
http://reviews.llvm.org/D22034
Files:
include/clang/AST/DeclCXX.h
lib/AST/DeclCXX.cpp
lib/AST/E
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#482925, @majnemer wrote:
> A flag on CXXRecordDecl which is sensitive to the most recent expression
> evaluation might not be the best way to go.
> Perhaps we should be able to use the VFTableBuilder to build imported and
> loca
DmitryPolukhin updated this revision to Diff 63950.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
- defer var generation if their type is class with dllimport.
http://reviews.llvm.org/D22034
Files:
include/clang/AST/DeclCXX.h
lib/AST/DeclCXX.cpp
lib/AST/
DmitryPolukhin added a comment.
Aaron, friendly ping, please take a look!
http://reviews.llvm.org/D17567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin updated this revision to Diff 49617.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Rebase
http://reviews.llvm.org/D17567
Files:
docs/ItaniumMangleAbiTags.rst
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic
DmitryPolukhin updated this revision to Diff 50113.
DmitryPolukhin marked 17 inline comments as done.
DmitryPolukhin added a comment.
- fixed comments
- rebase with resolving conflicts
http://reviews.llvm.org/D17567
Files:
docs/ItaniumMangleAbiTags.rst
include/clang/Basic/Attr.td
include/
DmitryPolukhin added a comment.
Thank you for the comments!
Comment at: docs/ItaniumMangleAbiTags.rst:83
@@ +82,3 @@
+For s all active tags used in the local part () are available, but not implicit tags which were not active!
+
aaron.ballman wrote:
> Replace the
Author: dpolukhin
Date: Wed Mar 9 09:30:53 2016
New Revision: 263015
URL: http://llvm.org/viewvc/llvm-project?rev=263015&view=rev
Log:
[GCC] PR23529 Sema part of attrbute abi_tag support
Original patch by Stefan Bühler http://reviews.llvm.org/D12834
Difference between original and this one:
- f
Author: dpolukhin
Date: Wed Mar 9 10:19:04 2016
New Revision: 263023
URL: http://llvm.org/viewvc/llvm-project?rev=263023&view=rev
Log:
NFC fix documentation build by rL263015
Modified:
cfe/trunk/docs/ItaniumMangleAbiTags.rst
Modified: cfe/trunk/docs/ItaniumMangleAbiTags.rst
URL:
http://llv
Author: dpolukhin
Date: Wed Mar 9 13:39:16 2016
New Revision: 263052
URL: http://llvm.org/viewvc/llvm-project?rev=263052&view=rev
Log:
NFC fix documentation build by rL263015
This time I hope it will fix the build for real.
Modified:
cfe/trunk/docs/ItaniumMangleAbiTags.rst
cfe/trunk/doc
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: majnemer.
DmitryPolukhin added subscribers: cfe-commits, aaron.ballman, stbuehler.
Original patch by Stefan Bühler http://reviews.llvm.org/D12834
Difference between original and this one:
- fixed all failing tests
- fixed man
Aaron, thank you for fixing this!
On Thu, Mar 10, 2016 at 4:08 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Thu Mar 10 07:08:22 2016
> New Revision: 263109
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263109&view=rev
> Log:
> Correcting
Author: dpolukhin
Date: Fri Mar 11 01:58:34 2016
New Revision: 263202
URL: http://llvm.org/viewvc/llvm-project?rev=263202&view=rev
Log:
[OpenMP] NFC fix compilation warning about unused variable
lib/Sema/SemaOpenMP.cpp:9243:13: warning: variable ‘IsRightMostExpression’ set
but not used
Modified
DmitryPolukhin updated this revision to Diff 50416.
DmitryPolukhin added a comment.
Re-base to resolve merge conflicts with r263109.
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/SemaCXX/attr-abi-tag-syn
Hi Pavel,
Code review is not a good place to discuss such type of things. There is no
really good workaround for this issue if you already have libraries built
with C++ 11 and GCC configured to use abi_tag. But if you are doing it only
for testing and you are willing to build Clang yourself, you c
DmitryPolukhin added a comment.
Hi Pavel,
Code review is not a good place to discuss such type of things. There is no
really good workaround for this issue if you already have libraries built
with C++ 11 and GCC configured to use abi_tag. But if you are doing it only
for testing and you are willi
DmitryPolukhin added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:268-290
@@ -265,1 +267,25 @@
+ // abi_tag is a gcc attribute, taking one or more strings called "tags".
+ //
+ // The goal is to annotate against which version of a library an object was
+ // build a
DmitryPolukhin updated this revision to Diff 50699.
DmitryPolukhin marked 14 inline comments as done.
DmitryPolukhin added a comment.
All comments resolved.
PTAL
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
DmitryPolukhin added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:321-323
@@ +320,5 @@
+ // track.
+ //
+ // FIXME: how to handle substituted names? They should add the tags used in
+ // the substitution to the list of available tags.
+ class AbiTagState final {
---
DmitryPolukhin updated this revision to Diff 51403.
DmitryPolukhin marked 4 inline comments as done.
DmitryPolukhin added a comment.
Fixed comments.
PTAL
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/Se
DmitryPolukhin created this revision.
DmitryPolukhin added reviewers: ABataev, aaron.ballman.
DmitryPolukhin added subscribers: cfe-commits, fraggamuffin.
Add parsing, sema analysis for 'declare target' construct for OpenMP 4.0
(4.5 support will be added in separate patch).
The declare target dir
DmitryPolukhin added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:2700
@@ -2685,3 +2699,3 @@
return;
Aliases.push_back(GD);
rjmccall wrote:
> Please diagnose that the resolver function has the appropriate type here.
> Given the constraint
DmitryPolukhin updated this revision to Diff 43721.
DmitryPolukhin marked 17 inline comments as done.
DmitryPolukhin added a comment.
Comments resolved + this patch uses new GlobalIFunc representation in llvm.
http://reviews.llvm.org/D15524
Files:
include/clang/AST/DeclBase.h
include/clang/
DmitryPolukhin updated this revision to Diff 43775.
DmitryPolukhin marked 8 inline comments as done.
DmitryPolukhin added a comment.
Fixed comments.
http://reviews.llvm.org/D15524
Files:
include/clang/AST/DeclBase.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/cla
DmitryPolukhin added a comment.
Thank you for the review!
I'm waiting for llvm part of ifunc support because it has to be committed first.
http://reviews.llvm.org/D15524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
DmitryPolukhin added a comment.
John and Richard,
I would like to proceed with this patch one way or another. If this patch
cannot be accepted in upstream, I'll discard it. On the other hand I'm ready to
improve this patch further if it is OK in principle but needs more work. Please
let me kno
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rsmith.
DmitryPolukhin added subscribers: cfe-commits, kcc.
Fix for a case found by fuzzing PR23057 (comment #25
https://llvm.org/bugs/show_bug.cgi?id=23057#c25).
http://reviews.llvm.org/D16065
Files:
lib/AST/Decl.cpp
te
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rjmccall.
DmitryPolukhin added a subscriber: cfe-commits.
To completely eliminate use-after-free in this place I had to copy tokens into
new array and pass ownership. As far as I understand the code it is not
possible to guar
DmitryPolukhin added a comment.
I didn't introduce a leak because I pass ownership of the Buffer to
EnterTokenStream (i.e. pass true as the last argument OwnsTokens). ASan also
doesn't report a leak with my patch. Original code didn't have double free
because it used call EnterTokenStream with
DmitryPolukhin added a comment.
LGTM
http://reviews.llvm.org/D16607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: aaron.ballman.
DmitryPolukhin added a subscriber: cfe-commits.
Add support for vector mode attributes like "__attribute__((mode(V4SF)))". Also
add warning about deprecated vector modes like GCC does.
http://reviews.llvm.org/D
DmitryPolukhin added a comment.
Thank you for prompt response!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2765
@@ +2764,3 @@
+def warn_vector_mode_deprecated : Warning<
+ "specifying vector types with __attribute__ ((mode)) is deprecated, "
+ "use __attribute__ ((v
DmitryPolukhin updated this revision to Diff 40489.
DmitryPolukhin added a comment.
Added new warning group as suggested.
I see thousands of vector types in headers on GitHub
https://github.com/search?p=1&q=%22__attribute__+mode+v4sf%22+extension%3Ah&ref=searchresults&type=Code&utf8=%E2%9C%93
l
DmitryPolukhin added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:3315
@@ +3314,3 @@
+ llvm::APInt VectorSize(64, 0);
+ if (Str.size() >= 4 && Str[0] == 'V') {
+// Minimal length of vector mode is 4: 'V' + NUMBER(>=1) + TYPE(>=2).
aaron.ballman wro
DmitryPolukhin updated this revision to Diff 40506.
DmitryPolukhin marked 3 inline comments as done.
http://reviews.llvm.org/D14744
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/attr-mode-vector-types.c
Index
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: aaron.ballman.
DmitryPolukhin added a subscriber: cfe-commits.
This CL is for discussion how to better fix bit-filed layout compatibility
issue with GCC (see PR25575 for test case and more details). Current clang
behavior is
DmitryPolukhin added a comment.
It seems that check for type alignment <= 8 was there practically forever
http://llvm.org/viewvc/llvm-project/cfe/trunk/Sema/SemaDecl.cpp?r1=47197&r2=47196&pathrev=47197
and there is no good explanation why it was implemented. Subsequent changes
only add more con
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rjmccall.
DmitryPolukhin added a subscriber: cfe-commits.
Fix binary compatibility issue with GCC.
http://reviews.llvm.org/D14980
Files:
lib/AST/RecordLayoutBuilder.cpp
test/Sema/bitfield-layout.c
Index: test/Sema/bitfie
DmitryPolukhin updated this revision to Diff 41131.
DmitryPolukhin added a comment.
Added warning about semantic change + uploaded context. PTAL
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/struct-packed-align.c
Inde
DmitryPolukhin updated this revision to Diff 41222.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Changed note text message + fixed outdated comment.
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
DmitryPolukhin added a comment.
Friendly ping, any comments about this patch?
http://reviews.llvm.org/D14980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin updated this revision to Diff 41481.
DmitryPolukhin added a comment.
Added more testcases to cover combination of explicit alignment of bit-filed
with packed attribute. Also added testing on ARM for bit-filed layout test.
http://reviews.llvm.org/D14980
Files:
lib/AST/RecordLay
DmitryPolukhin added a comment.
I added more testcases and they all pass identically on GCC and clang with my
patch. Please let me know if you think, that some cases are not covered or
doesn't work with my patch. Perhaps we can reduce number of test-cases because
some of them almost duplicates
DmitryPolukhin added a comment.
This is another GCC ABI compatibility issue. If there is no more comments,
could someone please approve this CL?
http://reviews.llvm.org/D14872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
DmitryPolukhin updated this revision to Diff 41510.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Don't call getDeclName() that it is not required. PTAL
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.
DmitryPolukhin updated this revision to Diff 41597.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Warning text updated, PTAL.
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/struct-pack
DmitryPolukhin updated this revision to Diff 41611.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
Fixed logic for warning calculation and added even more test-cases.
http://reviews.llvm.org/D14980
Files:
lib/AST/RecordLayoutBuilder.cpp
test/Sema/bitfield-l
DmitryPolukhin added a comment.
This CL doesn't changes anything for ms_struct cases and ms_struct seems to be
broken for bit-fields even for very simple cases so filed separate bug
https://llvm.org/bugs/show_bug.cgi?id=25707
PTAL
Comment at: lib/AST/RecordLayoutBuilder.cpp:1
DmitryPolukhin updated this revision to Diff 41648.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Fixed warning and comment.
http://reviews.llvm.org/D14872
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/Sema/struct-packe
DmitryPolukhin updated this revision to Diff 41748.
http://reviews.llvm.org/D14980
Files:
lib/AST/RecordLayoutBuilder.cpp
test/Sema/bitfield-layout.c
Index: test/Sema/bitfield-layout.c
===
--- test/Sema/bitfield-layout.c
+++ tes
DmitryPolukhin added inline comments.
Comment at: lib/AST/RecordLayoutBuilder.cpp:1606
@@ -1605,1 +1605,3 @@
+} else if (ExplicitFieldAlign)
+ FieldOffset = llvm::RoundUpToAlignment(FieldOffset, ExplicitFieldAlign);
rjmccall wrote:
> Be sure to test spe
DmitryPolukhin added inline comments.
Comment at: lib/AST/RecordLayoutBuilder.cpp:1606
@@ +1605,3 @@
+} else if (ExplicitFieldAlign &&
+ Context.getTargetInfo().useBitFieldTypeAlignment())
+ FieldOffset = llvm::RoundUpToAlignment(FieldOffset, ExplicitFieldAl
DmitryPolukhin updated this revision to Diff 41866.
DmitryPolukhin added a comment.
Added TODO.
http://reviews.llvm.org/D14980
Files:
lib/AST/RecordLayoutBuilder.cpp
test/Sema/bitfield-layout.c
Index: test/Sema/bitfield-layout.c
=
DmitryPolukhin added a comment.
Added TODO, any other comments or suggestions?
http://reviews.llvm.org/D14980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin added a comment.
John and Richard,
I think this patch fixes important ABI compatibility issue with GCC and if
there are no more comments, I think it makes sense to commit it. Could you
please approve this CL?
Thanks,
Dmitry
http://reviews.llvm.org/D14980
___
DmitryPolukhin created this revision.
DmitryPolukhin added reviewers: aaron.ballman, rjmccall.
DmitryPolukhin added a subscriber: cfe-commits.
This patch add support for GCC __attribute__((ifunc("resolver"))) for targets
that use ELF as object file format. In general ifunc is a special kind of
f
DmitryPolukhin added a comment.
John, I'm still working on new patch but meanwhile I would like to clarify few
things in your comments.
Comment at: include/clang/Basic/AttrDocs.td:1866
@@ +1865,3 @@
+ let Content = [{
+The attribute ``__attribute__((ifunc("resolver")))`` is us
DmitryPolukhin added a comment.
Friendly ping.
I don't think this change makes APCS mode worse. As an alternative I could
return to the variant that doesn't change anything for APCS case. Please let me
know if APCS case must be resolved and TODO is not enough for committing this
change.
http
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/81985
Summary:
Some build systems create symlinks in a temporary build directory for headers
in the source tree for isolation purposes. These symlinks prevent
`readability-identifier-naming` detecting issues and ap
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/81985
>From ddafb4672e1a481d4a9556ebe31ca9a07e1f3569 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Fri, 16 Feb 2024 03:51:07 -0800
Subject: [PATCH 1/2] [clang-tidy][readability-identifier-naming] Resolve
sym
dmpolukhin wrote:
> This problem seems like it should be handled globally, not in a single
> specific check. IIUC any check that reads options from the .clang-tidy file
> is affected.
Yes, but the majority of checks ignores the problem but
`readability-identifier-naming` handles styles per fi
101 - 200 of 375 matches
Mail list logo
