[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11292 +} + +/// Argument's value might be modified, so update the info. riccibruno wrote: > Hmm, I don't think that this will work. Suppose that you have

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro created this revision. djtodoro added reviewers: shuaiwang, lebedev.ri. Herald added subscribers: Charusso, jdoerfert, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. We should track mutation of a variable within a comma operator expressi

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro added a comment. @lebedev.ri Thanks for your comment! > Is there any way to model this more generically? > I.e don't duplicate every naive matcher (ignoring possible presence of , op) > with an variant that does not ignore ,. > E.g. will this handle (a,b)+=1 ? Hmm, I am not sure if the

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro added a comment. @lebedev.ri I agree, thank you! I needed to be more precise in my previous reply, sorry for that. I thought it will be (somehow) overhead if I change existing, very basic, matchers. I already implemented a static function that skips comma operands, and extended this t

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro updated this revision to Diff 189461. djtodoro added a comment. -add AST matcher that skips operands in comma expression -add unit tests for extended support CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58894/new/ https://reviews.llvm.org/D58894 Files: include/clang/AST/Exp

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro added a comment. >> @lebedev.ri I agree, thank you! I needed to be more precise in my previous >> reply, sorry for that. I thought it will be (somehow) overhead if I change >> existing, very basic, matchers. > > I indeed don't think the existing matchers should be changed to ignore the

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro marked an inline comment as done. djtodoro added a comment. > Nice, i like this! > I think the test coverage is good. @lebedev.ri Thanks! > But what about other equalsNode() that you didn't change? > Do some of them need this change too? For sure some of them (maybe all of them) needs

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:27 +AST_MATCHER_P(Expr, skipCommaOps, + ast_matchers::internal::Matcher, InnerMatcher) { lebedev.ri wrote: > djtodoro wrote:

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro marked an inline comment as done. djtodoro added a comment. > Anyways, this looks good in this state. > Thank you for working on this! Thanks! > If you don't intend to immediately work on fixing the rest of , cases here, > *please* do file a bug so it won't get lost. (and link it here)

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro updated this revision to Diff 189661. djtodoro added a comment. -add support for the rest of direct mutation cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58894/new/ https://reviews.llvm.org/D58894 Files: include/clang/AST/Expr.h lib/Analysis/ExprMutationAnalyzer.cpp

[PATCH] D58033: Add option for emitting dbg info for call sites

djtodoro updated this revision to Diff 195188. djtodoro edited the summary of this revision. djtodoro added a comment. -Rebase -Add all_call_sites flag in the case of GNU extensions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: includ

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 195192. djtodoro added a comment. -Rebase -Use `ExprMutationAnalyzer` for parameter's modification check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CG

[PATCH] D58043: Add experimental options for call site related dbg info

djtodoro updated this revision to Diff 195198. djtodoro retitled this revision from "Add option for emitting DW_OP_entry_values" to "Add experimental options for call site related dbg info". djtodoro edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58043

[PATCH] D58033: Add option for emitting dbg info for call sites

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: include/clang/Driver/Options.td:919 HelpText<"Do not use jump tables for lowering switches">; +def emit_param_entry_values : Joined<["-"], "femit-param-entry-values">, +

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked 3 inline comments as done. djtodoro added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4537 + CGM.getLangOpts().Optimize) { +for (auto &SP : DeclCache) { + auto *D = SP.first; aprantl wrote: > Just looking at the type dec

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 195359. djtodoro added a comment. -Run clang-format -Use `cast` instead of '`dyn_cast`' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h Ind

[PATCH] D58033: Add option for emitting dbg info for call sites

djtodoro marked 2 inline comments as done. djtodoro added a comment. @probinson @aprantl Thanks a lot for your comments! Let's clarify some things. I'm sorry about the confusion. Initial patch for the functionality can be restricted by this option (like we pushed here), since **LLDB** doesn't r

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 195568. djtodoro retitled this revision from "Add option for emitting dbg info for call sites" to "Add option for emitting dbg info for call site parameters". djtodoro added a comment. -Refactor -Remove `CC1` def CHANGES SINCE LAST ACTION https://reviews

[PATCH] D58043: Add experimental options for call site related dbg info

djtodoro updated this revision to Diff 195569. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58043/new/ https://reviews.llvm.org/D58043 Files: lib/Driver/ToolChains/Clang.cpp Index: lib/Driver/ToolChains/Clang.cpp ==

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 195571. djtodoro added a comment. -Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/Options.td lib/CodeGen/CGDebugInfo.cp

[PATCH] D58043: Add experimental options for call site related dbg info

djtodoro updated this revision to Diff 195572. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58043/new/ https://reviews.llvm.org/D58043 Files: lib/Driver/ToolChains/Clang.cpp Index: lib/Driver/ToolChains/Clang.cpp ==

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 196053. djtodoro added a comment. -Add only cc1 option -Set up back end CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro added a comment. > Is there some kind of testcase? @aprantl Usage of the option is tested within following patches from the stack. I am not sure if we need some additional test here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 _

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro marked 2 inline comments as done. djtodoro added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3402 +CmdArgs.push_back("-femit-param-entry-values"); + RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); probinson wrote: > If this

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 196595. djtodoro marked an inline comment as done. djtodoro edited the summary of this revision. djtodoro added a comment. -Remove unneeded code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: incl

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro added a comment. @probinson @aprantl Thanks! @vsk Thanks for the comment! Sure, we will add that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 186611. djtodoro added a comment. - Rename: `VariableNotChanged `===> `ArgumentNotModified` - Refactor a test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: include/clang/AST/Decl.h lib/Cod

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked 2 inline comments as done. djtodoro added a comment. > I was under the impression that space inside VarDecl was quite constrained. > Pardon the likely naive question, but: is there any way to make the > representation more compact (maybe sneak a bit into ParmVarDeclBitfields)? @

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added a comment. @riccibruno Thanks for your comments! > Oh and I think that you will also have to update the serialization > code/de-serialization code in ASTReaderDecl.cpp / ASTWriterDecl.cpp. You > might also have to update TreeTransform bu

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 187931. djtodoro added a comment. - Add a field in `ParmVarDecl` instead of `VarDecl` - Use a bit in `ParmVarDeclBitfields` to indicate parameter modification - Add support for the bit in `ASTReaderDecl.cpp` / `ASTWriterDecl.cpp` - Add test case for template

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added a comment. > I'm not quite sure what this differential is about, but i feel like > mentioning ExprMutationAnalyzer lib in clang-tidy / clang-tools-extra. >> Alternatively perhaps you could re-use getMemoryLocation() from D57660 >>

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 188110. djtodoro added a comment. Herald added a subscriber: jdoerfert. - Handle all kinds of expressions when mark a param's modification CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: include/cl

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 203335. djtodoro added a comment. -Explicitly enable the option only in the case of X86 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:755 + (Arch == llvm::Triple::x86 || Arch == llvm::Triple::x86_64)) +Opts.EnableDebugEntryValues = Args.hasArg(OPT_femit_debug_entry_values); + -

[PATCH] D58033: Add option for emitting dbg info for call site parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL364399: [CC1Option] Add the option to enable the debug entry values (authored by djtodoro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

This revision was automatically updated to reflect the committed changes. Closed by commit rL364424: [clang/DIVar] Emit the flag for params that have unmodified value (authored by djtodoro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. LGTM! Thanks @vsk! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64540/new/ https://reviews.llvm.org/D64540 ___ cfe-commits mailing

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 199213. djtodoro edited the summary of this revision. djtodoro added a comment. -Add an input in test/CodeGenCXX/dbg-info-all-calls-described.cpp -Rename the option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 199214. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h Index: lib/CodeGen/CGDebugInfo.h

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3885 + if (ArgNo) { +auto *PD = dyn_cast(VD); +ParmCache[PD].reset(D); aprantl wrote: > A `dyn_cast` followed by an unconditional use seems

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 199788. djtodoro added a comment. -Careful use of `dyn_cast` -Fill the `ParamCache` only in the case of `EnableDebugEntryValues` option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/C

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked 3 inline comments as done. djtodoro added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4537 + CGM.getLangOpts().Optimize) { +for (auto &SP : DeclCache) { + auto *D = SP.first; aprantl wrote: > djtodoro wrote: > > aprantl

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 200485. djtodoro added a comment. -Set `EnableDebugEntryValues` only for a higher level of optimizations (-O1 and higher) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGe

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 200486. djtodoro added a comment. -Use `SPCache` instead of `DeclCache` -Refactor the code by addressing suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp li

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 200943. djtodoro added a comment. -Add a negative test for -O0 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td lib/Code

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 200950. djtodoro added a comment. -Add `SPDefCache` to speed up the process -Add additional assertions that will improve quality of the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/Code

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro updated this revision to Diff 201503. djtodoro added a comment. -Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: include/clang/Basic/CodeGenOptions.def include/clang/Driver/CC1Options.td lib/CodeGen/BackendUtil.cpp

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 201505. djtodoro added a comment. -Rebase -Add a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGen/debug-info-param-modific

[PATCH] D80369: [DebugInfo] Remove decl subprograms from 'retainedTypes:'

djtodoro created this revision. djtodoro added reviewers: dblaikie, aprantl, vsk. djtodoro added projects: LLVM, debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. After the D70350 , the `retainedTypes:` isn't being used for the pur

[PATCH] D80369: WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 265481. djtodoro retitled this revision from "[DebugInfo] Remove decl subprograms from 'retainedTypes:'" to "WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'". djtodoro added a comment. Still have test failing: Clang :: Modules/DebugInfoTra

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 265722. djtodoro retitled this revision from "WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'" to "[DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'". djtodoro added a comment. -Remove the decls only in the case of call-sit

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. In D80369#2050022 , @dblaikie wrote: > In D80369#2048932 , @djtodoro wrote: > > > Still have test failing: > > > > Clang :: Modules/DebugInfoTransitiveImport.m > > Clang :: Modules/Modu

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. >> @dblaikie wrote: > > ... At least for the C++ test, this change makes it pass: > > diff --git clang/test/Modules/ModuleDebugInfo.cpp > clang/test/Modules/ModuleDebugInfo.cpp > index 26369c89605..b1ffe27ec22 100644 > --- clang/test/Modules/ModuleDebugInfo.cpp >

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. In D80369#2057866 , @dblaikie wrote: > Not sure I follow - why was it a problem that there was no DISubprogram at > all? Actually, since the DISubprograms from the retained types don't affect the final DWARF, it's not a proble

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 266776. djtodoro added a comment. -Tests clean up CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-extern-call.c clang/test/Module

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/Modules/ModuleDebugInfo.m:46-47 -// The forward declaration should not be in the module scope. -// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "OpaqueData", file - --

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

This revision was automatically updated to reflect the committed changes. Closed by commit rG40a3fcb05c83: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:' (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8036

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. Thanks for the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

djtodoro added a comment. Please add a test case for the Driver option (you can take a look into existing ones within `clang/test/Driver/`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83048/new/ https://reviews.llvm.org/D83048 __

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked 2 inline comments as done. djtodoro added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: vsk wrote: > Please factor out OptCustomPassManager from opt and g

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: djtodoro wrote: > vsk wrote: > > Please factor out OptCustomPassMa

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 276398. djtodoro added a comment. - Rebase on top of D83391 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 277781. djtodoro added a comment. Herald added a subscriber: dang. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro created this revision. djtodoro added reviewers: vsk, aprantl, dblaikie, probinson. djtodoro added projects: debug-info, LLVM. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. djtodoro added a parent revision: D82546: [Debugify][OriginalMode] Export the

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS aprantl wrote: > ap

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274054. djtodoro added a comment. -Update the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:16 +// CHECK: Force set function attributes: {{.*}} +// CHECK-NEXT: Infer set function attributes: {{.*}} +// CHECK-NEXT: Interprocedural Sparse Co

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274433. djtodoro added a comment. - Add the Driver test - Remove the old high level test in order to avoid troubles when someone updates an LLVM pass with the impact on Debugify output (e.g. a new debug info bugs) - clang-formatted CHANGES SINCE LAST ACTI

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274690. djtodoro added a comment. - Remove redundant line from the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/Code

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/Driver/debugify-each-original.c:9 + +// RUN: rm -rf %t.json +// RUN: %clang -g -Xclang -fenable-debugify-each-original \ aprantl wrote: > I think this is redundant?

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

This revision was automatically updated to reflect the committed changes. Closed by commit rG170ac4be3392: [CSInfo][ISEL] Call site info generation support for Mips (authored by djtodoro). Herald added subscribers: cfe-commits, jrtc27. Herald added a project: clang. Repository: rG LLVM Github M

[PATCH] D79967: Fix debug info for NoDebug attr

djtodoro added a comment. This seems reasonable, so this change looks good to me! @dblaikie Thanks for pointing out to the potential problems of the usage of the func decl !dbg in the purpose of call sites debug info. It is currently being stored into CU's retainedTypes field. > That's why DIS

[PATCH] D115351: [Debugify] Port verify-debuginfo-preserve to NewPM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b6d3a41b4e: [Debugify] Port verify-debuginfo-preserve to NewPM (authored by ntesic, committed by djtodoro). Herald added a project: clang. Herald a

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

djtodoro added a comment. Hmmm... if this should be done within compiler side, I am wondering whether this should be resolved in AsmPrinter/DwarfDebug instead. @aprantl please let me know wyt? However, it looks like that after this hack the `name` here isn't the appropriate one... and it looks

[PATCH] D115622: [Debugify] Optimize debugify original mode

djtodoro updated this revision to Diff 416438. djtodoro added a comment. Herald added a project: All. - Move the skipping into the for-loop since we want to collect metadata for the functions that are not observed in the previous Pass (for example the function wasn't of interest due to having an

[PATCH] D115622: [Debugify] Optimize debugify original mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73777b4c35a3: [Debugify] Optimize debugify original mode (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

djtodoro added a comment. I guess this should be closed? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 292469. djtodoro added a comment. - Rebasing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/includ

[PATCH] D82547: [VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option

djtodoro updated this revision to Diff 294658. djtodoro added a comment. -Rebasing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/include

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. nit included, otherwise lgtm, thanks! Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:45 + ~LiveDebugValues() + { +if (TheImpl) is

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 326005. djtodoro retitled this revision from "[VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option" to "[Debugify] Expose original debug info preservation check as CC1 option". djtodoro added a comment. Herald added subscribers: jans

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 329972. djtodoro added a comment. - rebase on top of trunk - refactor the code ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro added a comment. Thanks for doing this! Can you please update the summary, since it hard to read with the format like this (at least, just try to reformat the debugger output properly with the Phabricator formatters)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro added a comment. This looks reasonable to me (some nits included). Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4513 Scope.addPrivate(Pair.first, [Replacement]() { return Replacement; }); +if (auto *DI = CGF.getDebugInfo()) { + DI->EmitDecla

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114504/new/ https://reviews.llvm.org/D114504 ___ cfe-commits mailing list cfe-commi

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114631/new/ https://reviews.llvm.org/D114631 ___ cfe-commits mailing list

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1934105 , @vsk wrote: > In D73534#1933988 , @djtodoro wrote: > > > In D73534#1933985 , @djtodoro > > wrote: > > > > > Oh sorry, I thought

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1933985 , @djtodoro wrote: > Oh sorry, I thought it all has been fixed, since all the tests pass. > > We should revert the D75036 until we fix > all the issues. @dstenb do you agree?

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Oh sorry, I thought it all has been fixed, since all the tests pass. We should revert the D75036 until we fix all the issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro updated this revision to Diff 245345. djtodoro added a comment. - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've reduced the test `llvm/test/DebugInfo/MIR/ARM/dbgcallsite-noreg-is-imm-check.mir`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1882118 , @dstenb wrote: > In D73534#1881353 , @nickdesaulniers > wrote: > > > As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on > > this change. I see

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1883022 , @nickdesaulniers wrote: > In D73534#1882136 , @djtodoro wrote: > > > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > > reduced the test >

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Reverted again with rG2f215cf36adc . The investigation is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Nice! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. @ostannard Thanks for reporting that! Please share the case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. @vsk Thanks for this! (lgtm) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69743/new/ https://reviews.llvm.org/D69743 ___ cfe-commit

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:803 + if (Tag == dwarf::DW_TAG_typedef && DD->getDwarfVersion() >= 5) { +uint32_t AlignInBytes = DTy->getAlignInBytes(); Please add a comment here. Com

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added a comment. @awpandey Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

djtodoro added a comment. I think that it sounds reasonable to avoid declaration subprograms for functions with reserved names, so that part looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___

  1   2   >