djtodoro marked 3 inline comments as done.
djtodoro added inline comments.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4537
+      CGM.getLangOpts().Optimize) {
+    for (auto &SP : DeclCache) {
+      auto *D = SP.first;
----------------
aprantl wrote:
> Just looking at the type declarations in CGDebugInfo.h: Why not iterate over 
> the `SPCache`  directly? Shouldn't that contain all Function declarations 
> only?
I tried it, but `SPCache` is empty at this point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58035/new/

https://reviews.llvm.org/D58035



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to