dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg.
dim added a comment.
Should be merged together with http://reviews.llvm.org/rL248379,
http://reviews.llvm.org/rL248424, and http://reviews.llvm.org/rL248426.
Together, these add support for linking against OpenMP on FreeBSD and N
dim added a subscriber: dim.
dim added auditors: 3.7-release, cfe-commits, tstellarAMD, hfinkel.
dim added a comment.
This got reported again in PR25397, and occurs during compilation of mpich.
Looks like a good candidate for 3.7.1.
Users:
hfinkel (Author, Auditor)
3.7-release (Auditor)
dim added inline comments.
Comment at: lib/Headers/cpuid.h:114
@@ -109,2 +113,3 @@
#define bit_AVX 0x1000
+#define bit_F16C0x2000
#define bit_RDRND 0x4000
bruno wrote:
> Isn't this one also meant for gcc compat?
Well, we didn't
Author: dim
Date: Sun Jul 31 15:23:23 2016
New Revision: 277307
URL: http://llvm.org/viewvc/llvm-project?rev=277307&view=rev
Log:
Add more gcc compatibility names to clang's cpuid.h
Summary:
Some cpuid bit defines are named slightly different from how gcc's
cpuid.h calls them.
Define a few more
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277307: Add more gcc compatibility names to clang's cpuid.h
(authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D22010?vs=62781&id=66250#toc
Repository:
rL LLVM
https://reviews.llvm
Hi Hans,
I would like to merge this one to release_39, since it fixes a few third party
programs using cpuid.h, and expecting gcc-compatible CPUID bit macros.
-Dimitry
> On 31 Jul 2016, at 22:23, Dimitry Andric via cfe-commits
> wrote:
>
> Author: dim
> Date: Sun Jul 31 15:2
to merge this one to release_39, since it fixes a few third
>> party programs using cpuid.h, and expecting gcc-compatible CPUID bit macros.
>>
>> -Dimitry
>>
>>> On 31 Jul 2016, at 22:23, Dimitry Andric via cfe-commits
>>> wrote:
>>>
>>
dim updated this revision to Diff 47913.
dim added a comment.
Add checks for -lm and -lm_p, when profiling is on.
http://reviews.llvm.org/D16264
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/freebsd.cpp
Index: test/Driver/freebsd.cpp
===
Author: dim
Date: Sun Feb 14 10:08:20 2016
New Revision: 260851
URL: http://llvm.org/viewvc/llvm-project?rev=260851&view=rev
Log:
As reported in https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD,
C++ programs compiled for profiling (using `-pg`) should be linked with
`-lc++_p` (or `-lstdc++_
On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits
wrote:
>
> Author: dim
> Date: Sun Feb 14 10:08:20 2016
> New Revision: 260851
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260851&view=rev
> Log:
> As reported in https://llvm.org/bugs/show_bug.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260851: As reported in
https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD, (authored by dim).
Changed prior to commit:
http://reviews.llvm.org/D16264?vs=47913&id=47930#toc
Repository:
rL LLVM
h
On 16 Feb 2016, at 18:51, Hans Wennborg wrote:
>
> On Sun, Feb 14, 2016 at 8:14 AM, Dimitry Andric wrote:
>> On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits
>> wrote:
>>>
>>> Author: dim
>>> Date: Sun Feb 14 10:08:20 2016
>>> New
On 20 Feb 2016, at 09:31, Roman Divacky via cfe-commits
wrote:
>
> Author: rdivacky
> Date: Sat Feb 20 02:31:24 2016
> New Revision: 261422
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261422&view=rev
> Log:
> Fix handling of vaargs on PPC32 when going from regsave to overflow.
>
> It can
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/Sema/format-strings-freebsd.c:39
@@ -35,1 +38,3 @@
+ freebsd_kernel_printf("%hr", h); // no-warning
+
// %y expects an int
It's nice to a
dim added a subscriber: cfe-commits.
dim added a comment.
Belatedly adding cfe-commits.
http://reviews.llvm.org/D20037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dim
Date: Fri May 20 12:27:22 2016
New Revision: 270240
URL: http://llvm.org/viewvc/llvm-project?rev=270240&view=rev
Log:
Make __FreeBSD_cc_version predefined macro configurable at build time
The `FreeBSDTargetInfo` class has always set the `__FreeBSD_cc_version`
predefined macro to a rat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270240: Make __FreeBSD_cc_version predefined macro
configurable at build time (authored by dim).
Changed prior to commit:
http://reviews.llvm.org/D20037?vs=56476&id=57952#toc
Repository:
rL LLVM
htt
dim abandoned this revision.
dim added a comment.
Yes, this was indeed the wrong include order. During the latter stages of
FreeBSD's buildworld, the compiler is invoked with `-nostdinc++`, but
`/usr/include` was put before the libc++ include directory,
`/usr/include/c++/v1`. So as @rsmith re
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM. Eric, apologies that this took some time to review. I finally dug out
my old test cases for the original problem report in FreeBSD, and re-tested
them against this patch. (These test cases
dim added a comment.
@theraven, do you have any other feedback? :)
http://reviews.llvm.org/D21329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim created this revision.
dim added reviewers: joerg, rsmith.
dim added a subscriber: cfe-commits.
Some cpuid bit defines are named slightly different from how gcc's cpuid.h
calls them.
Define a few more compatibility names to appease software built for gcc:
* `bit_PCLMUL` alias of `bit_PC
dim added a comment.
In http://reviews.llvm.org/D21329#475105, @theraven wrote:
> Looks fine to me, though I wonder if we want to move to the new ABI for
> FreeBSD11 and use the old one for <=10.
For 11 it is certainly too late now, since it is ABI/API frozen now, and we
would still need to f
dim added a comment.
Ping.
http://reviews.llvm.org/D22010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim added subscribers: joerg, dim.
dim added a comment.
LGTM, at least. @emaste, @joerg, OK with you too?
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
dim accepted this commit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
dim (Auditor)
http://reviews.llvm.org/rL244063
___
cf
dim resigned from this audit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
dim (Auditor)
http://reviews.llvm.org/rL244063
__
dim accepted this revision.
dim added a reviewer: dim.
dim added a comment.
This revision is now accepted and ready to land.
If nobody objects, I will commit this.
http://reviews.llvm.org/D17286
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
> On 08 Oct 2015, at 06:24, Douglas Katzman via cfe-commits
> wrote:
>
> Author: dougk
> Date: Wed Oct 7 23:24:12 2015
> New Revision: 249655
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249655&view=rev
> Log:
> Stop messing with the 'g' group of options in CompilerInvocation.
>
> With t
dim created this revision.
dim added reviewers: mclow.lists, EricWF, emaste.
dim added subscribers: cfe-commits, bdrewery.
Herald added a subscriber: emaste.
On FreeBSD, a number of math.h functions are actually defined as macros,
such as `signbit()`, `fpclassify()` and others. Since libc++'s
at
dim added a comment.
Note that these compilation errors came up specifically because @bdrewery is
doing cross-compilation of FreeBSD with recent versions of gcc. Apparently
clang does not give the same errors on these undefined identifiers, but I'm not
entirely sure why not...
http://reviews
dim updated this revision to Diff 43784.
dim added a comment.
Updating this diff for the moving of FindDriverSuffix() to
lib/Driver/ToolChain.cpp.
http://reviews.llvm.org/D7164
Files:
lib/Driver/ToolChain.cpp
Index: lib/Driver/ToolChain.cpp
==
dim abandoned this revision.
dim added a comment.
Abandoning this in favor of a wrapper shell script, which will call
`/usr/bin/c++` instead.
http://reviews.llvm.org/D7164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
dim created this revision.
dim added a reviewer: joerg.
dim added a subscriber: cfe-commits.
There are a number of files in the tree which have been accidentally checked in
with DOS line endings. Convert these to native line endings.
There are also a few files which have DOS line endings on purp
Author: dim
Date: Sun Jan 3 09:55:40 2016
New Revision: 256704
URL: http://llvm.org/viewvc/llvm-project?rev=256704&view=rev
Log:
Fix several accidental DOS line endings in source files
Summary:
There are a number of files in the tree which have been accidentally checked in
with DOS line endings
Author: dim
Date: Mon Jan 4 04:17:48 2016
New Revision: 256742
URL: http://llvm.org/viewvc/llvm-project?rev=256742&view=rev
Log:
Convert test/CXX/lex/lex.literal/lex.string/p4.cpp back to DOS line
endings, since the file is supposed to have them, according to its
comments. Also set its svn:eol-s
dim created this revision.
dim added reviewers: davide, echristo, dexonsmith.
dim added subscribers: emaste, ahatanak, cfe-commits, davide.
Herald added subscribers: rengolin, aemerson.
In rL256641, @davide turned off movt generation by default for FreeBSD.
This was because our ld is very old, and
dim added a comment.
In http://reviews.llvm.org/D15899#319902, @davide wrote:
> I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3
> if backported) -- what about people running <= 10.2 ? Isn't this a problem
> for them?
People running ports-provided or hand-built clan
dim updated this revision to Diff 44059.
dim added a comment.
Rename `-fno-movt` to `-mno-movt`.
http://reviews.llvm.org/D15899
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/arm-no-movt.c
Index: test/Driver/arm-no-movt.c
=
Author: dim
Date: Wed Jan 6 01:42:18 2016
New Revision: 256920
URL: http://llvm.org/viewvc/llvm-project?rev=256920&view=rev
Log:
Add -fno-movt frontend option, to disable movt/movw on ARM
Summary:
In rL256641, @davide turned off movt generation by default for FreeBSD.
This was because our ld is
dim created this revision.
dim added reviewers: emaste, probinson.
dim added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
This is the clang part of D15966. In rL256104, debugger tuning was
added to the clang driver, and again the default for FreeBSD was set to
lldb. The default
Author: dim
Date: Thu Jan 7 16:09:47 2016
New Revision: 257104
URL: http://llvm.org/viewvc/llvm-project?rev=257104&view=rev
Log:
Turn off lldb debug tuning by default for FreeBSD
Summary:
This is the clang part of D15966. In rL256104, debugger tuning was
added to the clang driver, and again the
Author: dim
Date: Tue Jan 12 13:40:55 2016
New Revision: 257509
URL: http://llvm.org/viewvc/llvm-project?rev=257509&view=rev
Log:
Add a clang test for r257376 (Ensure -mcpu=xscale works for arm targets).
Added:
cfe/trunk/test/Driver/arm-xscale.c
Added: cfe/trunk/test/Driver/arm-xscale.c
URL:
>> Of Joerg Sonnenberger via cfe-commits
>> Sent: 27 December 2015 11:59
>> To: cfe-commits@lists.llvm.org
>> Subject: Re: r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need
>> to pass any -G option to the assembler.
>>
>> On Sun, Dec 27, 2015 at 10:
dim added a subscriber: dim.
dim added a comment.
In http://reviews.llvm.org/D16102#324395, @davide wrote:
> I'm fine with this solution but Saleem pointed out there are some changes
> that need to be made before getting this in.
@compnerd, what were these changes to be made?
http://reviews.
dim created this revision.
dim added reviewers: compnerd, davide, dws, emaste.
dim added subscribers: rpokala, cfe-commits.
Herald added a subscriber: emaste.
As reported in https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD,
C++ programs compiled for profiling (using `-pg`) should be linked
dim commandeered this revision.
dim added a reviewer: dws.
dim added a comment.
Going to abandon this review in favor of http://reviews.llvm.org/D16264.
http://reviews.llvm.org/D16102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
On 19 Jan 2016, at 01:50, Marshall Clow via cfe-commits
wrote:
>
> Author: marshall
> Date: Mon Jan 18 18:50:37 2016
> New Revision: 258107
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258107&view=rev
> Log:
> Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as
>
Hi Richard,
I am unsure if you are specifically the code owner of Sema, but can you please
approve this change for the 3.8 branch?
-Dimitry
> On 19 Jan 2016, at 04:58, Faisal Vali via cfe-commits
> wrote:
>
> Author: faisalv
> Date: Mon Jan 18 21:58:55 2016
> New Revision: 258110
>
> URL: h
Author: dim
Date: Wed Jan 20 12:53:44 2016
New Revision: 258327
URL: http://llvm.org/viewvc/llvm-project?rev=258327&view=rev
Log:
Ensure the lit.site.cfg and Unit/lit.site.cfg make targets do not use
the same temporary file, otherwise there is a race condition when using
parallel make jobs.
Modif
Hans,
This change looks pretty trivial, and is required to not crash for the test
cases in PR26134. Can we merge it to release_38, please?
-Dimitry
> On 19 Jan 2016, at 19:28, Dimitry Andric via cfe-commits
> wrote:
>
> Hi Richard,
>
> I am unsure if you are specifically
t 12:38 PM, Dimitry Andric wrote:
>> Hans,
>>
>> This change looks pretty trivial, and is required to not crash for the test
>> cases in PR26134. Can we merge it to release_38, please?
>>
>> -Dimitry
>>
>>> On 19 Jan 2016, at 19:28, Dimitry
dim added a comment.
Ping.
http://reviews.llvm.org/D16264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dim added a comment.
In http://reviews.llvm.org/D16264#340131, @compnerd wrote:
> `-p` or `-pg` also effects the math library. Please adjust the tests and the
> driver to reflect that.
This is already handled in `lib/Driver/Tools.cpp`, in
`freebsd::Linker::ConstructJob()`:
if (!Args.hasAr
dim added a comment.
Note that http://reviews.llvm.org/rL252920 does not apply to 3.7 cleanly, a few
minor modifications are needed.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Au
dim created this revision.
dim added reviewers: joerg, rsmith.
dim added a subscriber: cfe-commits.
[ Copied from https://llvm.org/bugs/show_bug.cgi?id=25597 ]
Clang support for DragonFly BSD is lagging a bit, resulting in poor
support for c++.
DragonFlyBSD is unique in that it has two base comp
Author: dim
Date: Sun Dec 27 00:47:09 2015
New Revision: 256461
URL: http://llvm.org/viewvc/llvm-project?rev=256461&view=rev
Log:
For FreeBSD on mips, pass -G options to the linker
Summary:
On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the
linker. See also:
https:/
dim updated this revision to Diff 43652.
dim added a comment.
Reapplied to the latest trunk.
http://reviews.llvm.org/D10137
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tool
dim commandeered this revision.
dim added a reviewer: brooks.
dim added a comment.
Picking this up, since it needs a minor change to apply.
http://reviews.llvm.org/D10137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
dim added a comment.
Tried this with trunk r256465, but I get the following test failure:
FAIL: Clang :: Driver/dragonfly.c (3997 of 30174)
TEST 'Clang :: Driver/dragonfly.c' FAILED
Script:
--
/home/dim/obj/llvm-256465M-trun
dim updated this revision to Diff 43654.
dim added a comment.
Fix the test to check for --enable-new-dtags.
http://reviews.llvm.org/D15166
Files:
lib/Driver/ToolChains.cpp
lib/Driver/Tools.cpp
lib/Frontend/InitHeaderSearch.cpp
test/Driver/dragonfly.c
Index: test/Driver/dragonfly.c
Author: dim
Date: Sun Dec 27 04:01:44 2015
New Revision: 256467
URL: http://llvm.org/viewvc/llvm-project?rev=256467&view=rev
Log:
Fix C++ support on recent DragonFly BSD releases
Summary:
[ Copied from https://llvm.org/bugs/show_bug.cgi?id=25597 ]
Clang support for DragonFly BSD is lagging a bit
dim updated this revision to Diff 43655.
dim added a comment.
Add a test for passing -G0 to the assembler.
http://reviews.llvm.org/D10137
Files:
lib/Driver/Tools.cpp
test/Driver/freebsd-mips-as.c
Index: test/Driver/freebsd-mips-as.c
=
Author: dim
Date: Sun Dec 27 04:36:44 2015
New Revision: 256468
URL: http://llvm.org/viewvc/llvm-project?rev=256468&view=rev
Log:
On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the
assembler.
Summary:
See also:
https://sourceware.org/binutils/docs/as/MIPS-Options.html
dim added a comment.
In http://reviews.llvm.org/D15791#317175, @emaste wrote:
> > @davide, any idea whether lld will be able to handle movt correctly? If so,
> > we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ?
>
>
> I'm sure lld will handle everything we need eventually (i
https://github.com/DimitryAndric approved this pull request.
Seems reasonable, and it fixes both my minimized test case, and the full
original test case.
https://github.com/llvm/llvm-project/pull/107815
___
cfe-commits mailing list
cfe-commits@lists.l
https://github.com/DimitryAndric approved this pull request.
I don't have any experience with LoongArch, but this diff looks fine to me.
https://github.com/llvm/llvm-project/pull/119191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/DimitryAndric approved this pull request.
https://github.com/llvm/llvm-project/pull/126302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 167 of 167 matches
Mail list logo
