[clang] [clang] fix sema init crash for not checking a ExprResult (PR #98102)

2024-07-09 Thread Davide Italiano via cfe-commits
https://github.com/dcci deleted https://github.com/llvm/llvm-project/pull/98102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix sema init crash for not checking a ExprResult (PR #98102)

2024-07-09 Thread Davide Italiano via cfe-commits
dcci wrote: > You should also add test coverage (clang/test/SemaCXX) for the changes and a > release note (clang/docs/ReleaseNotes.rst). @AaronBallman -- are you OK with a crash-on-invalid (the one in first post)? The original example we had crashed on valid code, but reducing a 35MB file wit

[clang] [clang] fix sema init crash for not checking a ExprResult (PR #98102)

2024-07-09 Thread Davide Italiano via cfe-commits
dcci wrote: > > > You should also add test coverage (clang/test/SemaCXX) for the changes > > > and a release note (clang/docs/ReleaseNotes.rst). > > > > > > @AaronBallman -- are you OK with a crash-on-invalid (the one in first > > post)? The original example we had crashed on valid code, but

[clang] [clang-tools-extra] [clang] Implement CWG2398 provisional TTP matching to class templates (PR #92855)

2024-05-23 Thread Davide Italiano via cfe-commits
dcci wrote: I am seeing something similar in vector (without modules). I'm reducing a test case now. https://github.com/llvm/llvm-project/pull/92855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [clang-tools-extra] [clang] Implement CWG2398 provisional TTP matching to class templates (PR #92855)

2024-05-23 Thread Davide Italiano via cfe-commits
dcci wrote: Example error while I reduce: ``` fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/stl_vector.h:404:21: error: static assertion failed due to requirement 'is_same, std::allocator>, quic::Interval>::value': std::vector must have the same value_type as its al

[clang] Revert "[clang] Implement CWG2398 provisional TTP matching to class templates" (PR #93258)

2024-05-23 Thread Davide Italiano via cfe-commits
dcci wrote: Thanks. I'll try to get a repro (it's reducing from a large codebase so it might take some time) https://github.com/llvm/llvm-project/pull/93258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] 9ddcaed - Revert "[Clang] Interpreter test should not depend on system header (#119903)"

2024-12-14 Thread Davide Italiano via cfe-commits
Author: Davide Italiano Date: 2024-12-14T18:25:02Z New Revision: 9ddcaed3a64c2a187a0cfff4ba8f989c665ae1e5 URL: https://github.com/llvm/llvm-project/commit/9ddcaed3a64c2a187a0cfff4ba8f989c665ae1e5 DIFF: https://github.com/llvm/llvm-project/commit/9ddcaed3a64c2a187a0cfff4ba8f989c665ae1e5.diff LO

[clang] 61ab36a - Revert "[Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (#117475)"

2024-12-14 Thread Davide Italiano via cfe-commits
Author: Davide Italiano Date: 2024-12-14T18:26:32Z New Revision: 61ab36a3e226df32855286dd31a2c3859800475d URL: https://github.com/llvm/llvm-project/commit/61ab36a3e226df32855286dd31a2c3859800475d DIFF: https://github.com/llvm/llvm-project/commit/61ab36a3e226df32855286dd31a2c3859800475d.diff LO

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-14 Thread Davide Italiano via cfe-commits
dcci wrote: Given the fix forward didn't work, I reverted this to unblock ``` commit 61ab36a3e226df32855286dd31a2c3859800475d (HEAD -> main, upstream/main) Author: Davide Italiano Date: Sat Dec 14 18:25:50 2024 + Revert "[Clang-REPL] Fix crash during `__run_exit_handlers` with dynami

[clang] [Clang] Interpreter test should not depend on system header (PR #119903)

2024-12-13 Thread Davide Italiano via cfe-commits
https://github.com/dcci approved this pull request. Thank you for fixing the build https://github.com/llvm/llvm-project/pull/119903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2