[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

daltenty accepted this revision. daltenty added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137986/new/ https://reviews.llvm.org/D137986 ___ cfe-commits mailing list cfe-commit

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

daltenty added a comment. In D130327#3944591 , @vsapsai wrote: > In D130327#3944188 , @NancyWang > wrote: > >> @vsapsai hi Volodymyr Sapsai , test case >> clang/test/Modules/hidden-duplicates.m is failing o

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. In D69356#1726527 , @hubert.reinterpretcast wrote: > In D69356#1726354 , @beanz wrote: > > > If what you say is correct that "no dead strip" is harmful to plugins on > > some platforms it

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. > I'm actually opposed to that happening, on two fronts. > (2) we already have `LLVM_ENABLE_PLUGINS` why do we also need > `LLVM_SUPPORT_PLUGINS` seems like duplication and bad design. As I understand it LLVM_ENABLE_PLUGINS is a user-facing option which indicates whet

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. In D69356#1727581 , @hubert.reinterpretcast wrote: > In D69356#1727484 , @beanz wrote: > > > We should not be adding more variables that are passed around by CMake's > > scope inheritance

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

daltenty created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. daltenty edited the summary of this revision. daltenty added reviewers: hubert.reinterpretcast, beanz, lhames. daltenty added a reverted change: D69356: [NFC] Rename LLVM

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty added a comment. Revised direction in https://reviews.llvm.org/D69638 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.org/D69356 ___ cfe-commits mailing list cfe-

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

daltenty updated this revision to Diff 227461. daltenty added a comment. - Address review comments round 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://reviews.llvm.org/D69638 Files: clang/tools/driver/CMakeLists.txt llvm/c

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

daltenty updated this revision to Diff 227463. daltenty marked an inline comment as done. daltenty added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://reviews.llvm.org/D69638 Files: clang/tools/driver/CMake

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6740a88dc18d: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable() (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://re

[PATCH] D69620: Add AIX assembler support

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:26 + + bool hasIntegratedCPP() const override { return false; } + stevewan wrote: > Xiangling_L wrote: > > I saw a lot of other target also set `hasIntegratedCPP()` as false, but I >

[PATCH] D70675: [AIX] Disable clang python binding tests

daltenty created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. The Python ctypes FFI interface is broken on AIX, it cannot properly pass structures containing arrays ( https://bugs.python.org/issue38628). So disable the clang python binding tests on

[PATCH] D70675: [AIX] Disable clang python binding tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGa38fc6164879: [AIX] Disable clang python binding tests (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70675/new/ https://reviews.llvm

[PATCH] D69620: Add AIX assembler support

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Other than minor nit, LGTM Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input file."); + const

[PATCH] D69620: Add AIX assembler support

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebfab709583: Add AIX assembler support (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/ https://revi

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

daltenty added a comment. On AIX and PPC LE Linux after this change we are seeing invalid accesses when the backend asserts/fatal_errors. Looks like the driver and CC1 now share some global TimerGroup state that points to Timers which got created by CC1 but didn't get cleanup after the assert.

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

daltenty added inline comments. Comment at: clang/include/clang/Basic/TargetCXXABI.h:116 +/// - static initialization is adjusted to use sinit and sterm functions; +XL_Clang, + Why the underscore in the name? This is a bit inconsistent with both the LLV

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty created this revision. daltenty added reviewers: stevewan, sfertile, Xiangling_L. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline XCOFF doe

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/ https://reviews.llvm.org/D74631 Files: clang/test/CodeGen/xcoff-comdat.cpp llvm/include/llv

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty added a comment. In D74631#1876995 , @sfertile wrote: > 1. We should probably update the COMDAT section of the lang ref to mention > XCOFF doesn't support COMDATS. I will update the langref as suggested. > 2. Will we report an error somewhere

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty updated this revision to Diff 245201. daltenty added a comment. Herald added subscribers: aheejin, dschuff. - Update lang doc to indicate XCOFF doesn't support COMDAT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/ https://reviews

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

This revision was automatically updated to reflect the committed changes. Closed by commit rG58817a0783ca: [clang][XCOFF] Indicate that XCOFF does not support COMDATs (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/ h

[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

daltenty added a comment. Reopen since this was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +// Add directory to library search path. +Args.AddAllArgs(CmdArgs, options::OPT_L); +ToolChain.AddFilePathLibArgs(Args, CmdArgs); This mostly looks good, but I'm not

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1696 if (TC.getTriple().isOSAIX()) { + if (Args.hasArg(options::OPT_r)) +break; I think this is redundant, we guard out this whole function call in the block

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added a comment. LGTM, with a small nit about the test that should be addressed before committing Comment at: clang/test/Driver/aix-ld.c:1085 +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN:--unwindlib=libunwind \ +// RUN:-r \ ---

[PATCH] D146459: [clang][PowerPC] Remove remaining Darwin support

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fe49ea0d07d: [clang][PowerPC] Remove remaining Darwin support (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llv

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 __

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6327 } - if (Arg *A = Args.getLastArgNoClaim(options::OPT_p)) { + if (Arg *A = Args.getLastArg(options::OPT_p)) { if (TC.getTriple().isOSAIX()) { Actually, a question here

[PATCH] D145610: [clang][driver][AIX] accept maix32/maix64 gcc compat options

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a733e8a2c58: [clang][driver] accept maix32/maix64 gcc compat options (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6331 + if (Arg *A = Args.getLastArg(options::OPT_K); A && !TC.getTriple().isOSAIX()) +D.Diag(diag::err_drv_unsupported_opt_for_target) Let's not claim here, just in case this

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor fixup as noted Comment at: clang/test/Driver/aix-ld.c:1123 +// CHECK-K-UNUSED: clang: warning: -K: 'linker' input unused [-Wunused-command-line-argument

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2e9fc8553c: [PowerPC] Add function pointer alignment to DataLayout (authored by daltenty). Herald added a project: clang. Herald added a subscriber

[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function

daltenty accepted this revision. daltenty added a comment. New revision LGTM, VisibleNoLinkage is typical reserved for types from inline functions so it doesn't seem sensible to return. Looking at the C++ standard, I'm not even convinced this is guaranteed to be the same object if the function

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

daltenty updated this revision to Diff 402720. daltenty added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117935/new/ https://reviews.llvm.org/D117935 Files: clang/lib/Headers/float.h clang/test/Headers/Inputs/include/float.h clang/test/Header

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

daltenty added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5204 /// Warn if a pointer or reference argument passed to a function points to an /// object that is less aligned than the parameter. This can happen when This function definitely se

[PATCH] D118474: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9939bb668212: [NFC][AIX][clang] un-XFAIL gcc profile flag compat t

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

daltenty accepted this revision. daltenty added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118477/new/ https://reviews.llvm.org/D118477 ___ cfe-commits mailing list cfe-commit

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

daltenty updated this revision to Diff 404083. daltenty added a comment. Use more unique macro name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117935/new/ https://reviews.llvm.org/D117935 Files: clang/lib/Headers/float.h clang/test/Headers/Inputs/include/float.h clang/test/Hea

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ee91162dd3: [AIX][clang] include_next through clang provided float.h (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D101323: [AIX] Avoid use of mtim.tv_nsec member of stat structure on AIX

daltenty accepted this revision as: daltenty. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101323/new/ https://reviews.llvm.org/D101323 _

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

daltenty created this revision. Herald added a subscriber: jfb. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The libc implementation on AIX does not have stdatomic.h and the requisite interfaces for c11 atomics, so for now it's

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, ZarkoCA. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds the system libc++ header location to the driver. As well we defi

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

daltenty added a comment. Hmm, I'm not sure that the limitations you outline in the description are the only problems that cause us to define the macro in the first place (though the lack of libc implementation was part of it). I'll try to dig up the original issues. Repository: rG LLVM Git

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

daltenty added a comment. For the missing library implementation, we may be able to use the implementation in compiler-rt. Seems like some other platforms do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109139/new/ https://reviews.llvm.org/D1

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:240-242 + case ToolChain::CST_Libstdcxx: +llvm::report_fatal_error( +"picking up libstdc++ headers is unimplemented on AIX"); ZarkoCA wrote: > nit: it would be my prefere

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 371078. daltenty added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +// CHECK-INTERNAL-INC

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372566. daltenty added a comment. - Update check patttern to allow windows directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Dr

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372570. daltenty added a comment. - Fix additional test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/li

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f3925e25ae0: [clang][driver][AIX] Add system libc++ header paths to driver (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/

<    1   2