daltenty created this revision.
Herald added subscribers: llvm-commits, cfe-commits, mgorny.
Herald added projects: clang, LLVM.
daltenty edited the summary of this revision.
daltenty added reviewers: hubert.reinterpretcast, beanz, lhames.
daltenty added a reverted change: D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.
this allows us to move logic about when it is appropriate set
LLVM_NO_DEAD_STRIP out of each tool and into add_llvm_executable,
which will enable future platform specific handling.
This is a follow on to the reverted D69356 <https://reviews.llvm.org/D69356>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D69638
Files:
clang/tools/driver/CMakeLists.txt
llvm/cmake/modules/AddLLVM.cmake
llvm/tools/bugpoint/CMakeLists.txt
llvm/tools/llc/CMakeLists.txt
llvm/tools/opt/CMakeLists.txt
Index: llvm/tools/opt/CMakeLists.txt
===================================================================
--- llvm/tools/opt/CMakeLists.txt
+++ llvm/tools/opt/CMakeLists.txt
@@ -24,9 +24,6 @@
Passes
)
-# Support plugins.
-set(LLVM_NO_DEAD_STRIP 1)
-
add_llvm_tool(opt
AnalysisWrappers.cpp
BreakpointPrinter.cpp
@@ -39,6 +36,7 @@
DEPENDS
intrinsics_gen
+ SUPPORT_PLUGINS
)
export_executable_symbols(opt)
Index: llvm/tools/llc/CMakeLists.txt
===================================================================
--- llvm/tools/llc/CMakeLists.txt
+++ llvm/tools/llc/CMakeLists.txt
@@ -19,13 +19,11 @@
Vectorize
)
-# Support plugins.
-set(LLVM_NO_DEAD_STRIP 1)
-
add_llvm_tool(llc
llc.cpp
DEPENDS
intrinsics_gen
+ SUPPORT_PLUGINS
)
export_executable_symbols(llc)
Index: llvm/tools/bugpoint/CMakeLists.txt
===================================================================
--- llvm/tools/bugpoint/CMakeLists.txt
+++ llvm/tools/bugpoint/CMakeLists.txt
@@ -21,9 +21,6 @@
Vectorize
)
-# Support plugins.
-set(LLVM_NO_DEAD_STRIP 1)
-
add_llvm_tool(bugpoint
BugDriver.cpp
CrashDebugger.cpp
@@ -37,6 +34,7 @@
DEPENDS
intrinsics_gen
+ SUPPORT_PLUGINS
)
export_executable_symbols(bugpoint)
Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -732,7 +732,7 @@
macro(add_llvm_executable name)
cmake_parse_arguments(ARG
- "DISABLE_LLVM_LINK_LLVM_DYLIB;IGNORE_EXTERNALIZE_DEBUGINFO;NO_INSTALL_RPATH"
+ "DISABLE_LLVM_LINK_LLVM_DYLIB;IGNORE_EXTERNALIZE_DEBUGINFO;NO_INSTALL_RPATH;SUPPORT_PLUGINS"
"ENTITLEMENTS;BUNDLE_PATH"
"DEPENDS"
${ARGN})
@@ -782,6 +782,11 @@
if(NOT LLVM_ENABLE_OBJLIB)
llvm_update_compile_flags(${name})
endif()
+
+ if (ARG_SUPPORT_PLUGINS)
+ set(LLVM_NO_DEAD_STRIP 1)
+ endif()
+
add_link_opts( ${name} )
# Do not add -Dname_EXPORTS to the command-line when building files in this
Index: clang/tools/driver/CMakeLists.txt
===================================================================
--- clang/tools/driver/CMakeLists.txt
+++ clang/tools/driver/CMakeLists.txt
@@ -19,12 +19,6 @@
option(CLANG_PLUGIN_SUPPORT "Build clang with plugin support" ON)
-# Support plugins. This must be before add_clang_executable as it reads
-# LLVM_NO_DEAD_STRIP.
-if(CLANG_PLUGIN_SUPPORT)
- set(LLVM_NO_DEAD_STRIP 1)
-endif()
-
if(NOT CLANG_BUILT_STANDALONE)
set(tablegen_deps intrinsics_gen)
endif()
@@ -37,6 +31,7 @@
DEPENDS
${tablegen_deps}
+ SUPPORT_PLUGINS
)
clang_target_link_libraries(clang
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
