[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 480524. dgoldman marked 2 inline comments as done. dgoldman added a comment. Use raw string literal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-to

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51f1ae52b0c9: [clangd] Add new IncludeDirective to IncludeHeaderWithReferences (authored by dgoldman). Changed prior to commit: https://reviews.ll

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc46d6e67fab: [clang][Tooling] Add support for generating #import edits (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D139446: [clangd] Add flag to control #import include insertions

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will be

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman created this revision. Herald added subscribers: kadircet, arphaman, javed.absar. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are still disabled by

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 481022. dgoldman added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/ASTSignals.cpp clang-tools-extra/clan

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 482950. dgoldman marked 5 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-ex

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 483205. dgoldman added a comment. Don't pass ASTSignals through ParsedAST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/ASTSignal

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401422. dgoldman marked 18 inline comments as done. dgoldman added a comment. Changes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:295 +if (!R.second && !R.first->second.empty()) { + // Framework has known umbrella spelling, cache it for this header as + // well. sammccall wrote: > Wh

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1052 HFI.IndexHeaderMapHeader = 1; +} else if (CurDir->isFramework()) { + size_t SlashPos = Filename.find('/'); sammccall wrote: > This looks like a separate change, and

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman added a comment. PTAL, let me know what you think regarding the edits, had to make sure it works even if we generate multiple edits in the same file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D1163

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401671. dgoldman marked 4 inline comments as done. dgoldman added a comment. Support private headers + private umbrellas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D1170

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:326 +auto Path = FE->getName(); +auto It = CachePathToFrameworkSpelling.find(Path); +if (It != CachePathToFrameworkSpelling.end()) sammccall wrote: > any re

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added a comment. In D117056#3256538 , @sammccall wrote: > This looks good now, only blocker is dropping the change to LookupFile > somehow. > > Is it valuable to land this before the imminent 14 branch cut? I think it's > OK but as an indexing

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401746. dgoldman added a comment. Split up HeaderSearch change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollecto

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman created this revision. dgoldman added a reviewer: sammccall. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the Framework name was only set if the file came from a header mapped framework; now we'll always set

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman added a comment. Cyndy and Jan, hopefully ya'll are the right reviewers here? We're using this Framework information to know to compute framework style includes in https://reviews.llvm.org/D117056 for clangd, please LMK if this is a bad idea and we should do something else. Repositor

[PATCH] D118063: [DONOTSUBMIT] work on prototyping bracket fix its

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118063 Fil

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman added a comment. In D117830#3267404 , @cishida wrote: > My understanding for the header map restriction is because headermaps are > generally emitted once for a framework build and only consumed to build such > framework and this struct informa

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman updated this revision to Diff 403340. dgoldman added a comment. Update comment + run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117830/new/ https://reviews.llvm.org/D117830 Files: clang/lib/Lex/HeaderSearch.cpp clang/u

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1043 // If this file is found in a header map and uses the framework style of // includes, then this header is part of a framework we're building. ---

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 403361. dgoldman marked an inline comment as done. dgoldman added a comment. Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-ex

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG805f7a4fa4ce: [clang] Add `ObjCProtocolLoc` to represent protocol references (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

This revision was automatically updated to reflect the committed changes. Closed by commit rG54a962bbfee8: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1193

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman added a comment. Herald added a project: All. friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman added a comment. Herald added a subscriber: cfe-commits. Friendly ping, not sure if there's something in here and https://reviews.llvm.org/D99975 that I'm missing to properly support the one decl/type loc to multiple references here Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313 +// FIXME: visiting this here allows us to hover on UIColor in +// `UIColor.blackColor` but then `blackColor` no longer refers to the +// method. +// if (OP

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman updated this revision to Diff 340619. dgoldman marked 4 inline comments as done. dgoldman added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 Files: clang-t

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:152 // // TODO: Make previous parameters part of the signature for Objective-C // methods. sammccall wrote: > is this TODO handled now? No, t

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340653. dgoldman marked 2 inline comments as done. dgoldman added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files: clang-too

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman marked 3 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:1048 )cpp", - "0: targets = {global}\n" - "1: targets = {param}\n" sammccall wrote: > there

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340659. dgoldman marked an inline comment as done. dgoldman added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files: clang-tools-extra/clangd/F

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Addressing comments in https://reviews.llvm.org/D98984 Re

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman updated this revision to Diff 340665. dgoldman added a comment. Actually fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101328/new/ https://reviews.llvm.org/D101328 Files: clang-tools-extra/clangd/unittests/FindTargetTests

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman updated this revision to Diff 340666. dgoldman added a comment. Remove temporary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101328/new/ https://reviews.llvm.org/D101328 Files: clang-tools-extra/clangd/unittests/FindTargetTest

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG53e1cb88f280: [clangd] run clang-format on FindTargetTests.cpp's FindExplicitReferencesTest (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340834. dgoldman added a comment. Rebase on top of formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc20e4fbfa6d1: [clangd] Improve handling of Objective-C protocols in types (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman updated this revision to Diff 340840. dgoldman added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99975/new/ https://reviews.llvm.org/D99975 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman updated this revision to Diff 340885. dgoldman marked 2 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99975/new/ https://reviews.llvm.org/D99975 Files: clang-tools-extr

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313 +// FIXME: visiting this here allows us to hover on UIColor in +// `UIColor.blackColor` but then `blackColor` no longer refers to

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG39866d249a21: [clangd][ObjC] Improve support for class properties (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, jfb, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This allows us to

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341683. dgoldman added a comment. Fix casing warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:413 + /// different heuristics may be used in the future (e.g. sysroot paths). + bool inDefaultLibrary(SourceLocation Loc) const { +if (!Loc.isValid()) kadircet wr

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

dgoldman created this revision. dgoldman added reviewers: sammccall, benlangmuir. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. We now make

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341947. dgoldman marked an inline comment as done. dgoldman added a comment. Split defaultLibrary check to separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman marked 5 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:433 +scopeModifier(const NamedDecl *D, const HighlightingsBuilder &HB) { + if (!D) +return llvm::None; kadircet wrote: >

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 341953. dgoldman marked 2 inline comments as done. dgoldman added a comment. Remove unnecessary null check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: c

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 342391. dgoldman added a comment. Remove unnecessary scope modifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: clang-tools-extra/clangd/SemanticHighlig

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:470 + if (auto *OT = dyn_cast(T)) +return scopeModifier(OT->getInterface()); return llvm::None; kadircet wrote: > is t

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, jfb, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Treat them just l

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 342734. dgoldman added a comment. Fix test broken on non-macOS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp cla

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343087. dgoldman added a comment. Another attempt... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-e

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman updated this revision to Diff 343409. dgoldman added a comment. Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm.org/D101785 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tool

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

dgoldman added a comment. In D101785#2741535 , @kadircet wrote: > Thanks! Can you also add a test to `FindExplicitReferencesTest.All` ? as > that's where the underlying change lies. > > To disambiguate properties and ivars, what if we used modifiers? I s

[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG159dd447fe98: [clangd][ObjC] Highlight Objc Ivar refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101785/new/ https://reviews.llvm

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 396676. dgoldman added a comment. Minor change to how we get the loc of `@end` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-tools-extra/clangd/refa

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman created this revision. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We suggest inserting the method with an empty body at the end of the implementation decl. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman updated this revision to Diff 396690. dgoldman added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116417/new/ https://reviews.llvm.org/D116417 Files: clang/lib/Sema/SemaDeclObjC.cpp clang/test/FixIt/fixit-objc-m

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 396706. dgoldman added a comment. Add another minor test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-tools-extra/clangd/refactor/tweaks/CMake

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 397321. dgoldman marked 11 inline comments as done. dgoldman added a comment. Some review fixes, still need to rebase for new changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.l

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman marked 3 inline comments as not done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:113 +if (MD->getMethodFamily() == OMF_init) { + Loc = effectiveEndLoc(MD, SM).getLocWithOffset(1); +} el

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 397329. dgoldman marked 3 inline comments as done. dgoldman added a comment. Rebase + use new helpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:91 + +struct LocationWithPadding { + SourceLocation Loc; sammccall wrote: > We try not to spend complex

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman updated this revision to Diff 397336. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116417/new/ https://reviews.llvm.org/D116417 Files: clang/lib/Sema

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:2241 +method->print(Out, Policy); +Str.append(" {\n\n}\n\n"); + sammccall wrote: > sammccall wrote: > > nit: mixing string & output stre

[PATCH] D116417: [clang][ObjC] Add fix it for missing methods in impl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGdd72ae3dcc68: [clang][ObjC] Add fix it for missing methods in impl (authored by dgoldman). Repository:

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 397733. dgoldman marked 4 inline comments as done. dgoldman added a comment. Herald added a subscriber: ormris. Fixes for review - update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:782 if (IsIncludeeInFramework) { - NewInclude += ToFramework.str().drop_back(10); // drop .framework - NewInclude += "/"; + NewInclude += ToIncludeSpelling; + NewInclude += ">"; --

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 397882. dgoldman added a comment. Improve double-quotes.m test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h clan

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 397956. dgoldman marked an inline comment as done. dgoldman added a comment. Support generating interface and impl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Fi

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman marked 3 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:265 + // Insert before the first non-init instance method. + std::vector Anchors = { + {[](const Decl *D) { --

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 398178. dgoldman added a comment. Don't suggest umbrella headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h cl

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cf7e61a42c7: [clang][HeaderSearch] Support framework includes in suggestPath... (authored by dgoldman). Changed prior to commit: https://reviews.

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. With this chang

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 399336. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clan

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman created this revision. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang will now search through the framework includes to identify the framework include path to a file, and then suggest a framework style include spell

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392176. dgoldman added a comment. Fix IncludeSpelling issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/lib/Lex/HeaderSearch.cpp Index: clang/lib

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392180. dgoldman added a comment. Use consistent IsSystem detection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/lib/Lex/HeaderSearch.cpp Index: c

[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

dgoldman updated this revision to Diff 392477. dgoldman added a comment. Add HeaderSearch tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115183/new/ https://reviews.llvm.org/D115183 Files: clang/include/clang/Lex/HeaderSearch.h clang/lib/

[PATCH] D115679: [clang] Add ability to suggest #import instead of #include.

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This currently isn't used by anything, but will be used by cla

[PATCH] D115679: [clang] Add ability to suggest #import instead of #include.

dgoldman updated this revision to Diff 394065. dgoldman added a comment. Minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115679/new/ https://reviews.llvm.org/D115679 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extr

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The code action creates an initializer for the sele

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman updated this revision to Diff 396569. dgoldman added a comment. Remove debug log statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeL

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Even though they're implemented

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman created this revision. dgoldman added reviewers: kadircet, sammccall. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This helps improve the

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. LMK if you can think of a better approach to decide which language to use here. Likely will send a follow up diff to include more context in the Objective-C decl printing so they highlight properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. In D108584#2962271 , @sammccall wrote: >> Likely will send a follow up diff to include more context in the Objective-C >> decl printing so they highlight properly. > > This might make sense if it provides useful context to human

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman added a comment. In D108556#2962008 , @kadircet wrote: > thanks, it looks good as a contained fix. but it feels like we probably don't > want these to be treated as decls in other places too (e.g. can we really > provide any useful goto/hover o

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 368395. dgoldman added a comment. Simplify setting the definition language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files: clang-tools-extra/clangd/Hover.cp

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

dgoldman added a comment. Does this change the behavior of TypePrinter or DeclPrinter - not sure if there are existing tests for those with ObjC code? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

dgoldman added a comment. > I put a case for it in the declprinter so it is handled appropriately so it > would get the pointee type, whereas before this was neglected. > > Other than that, there should be no difference. It looks like DeclPrinter only uses that method here

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman updated this revision to Diff 370590. dgoldman added a comment. Remove unnecessary build flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108584/new/ https://reviews.llvm.org/D108584 Files: clang-tools-extra/clangd/Hover.cpp clang-t

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2982bd9e9b58: [clangd] Use the active file's language for hover code blocks (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman updated this revision to Diff 370609. dgoldman added a comment. Swap to ignore in FindTarget Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 Files: clang-tools-extra/clangd/FindTarget.cpp cla

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman added a comment. In D108556#2981712 , @kadircet wrote: > Hmm, it sounds like you want them to be treated one way during semantic > highlighting and another during other features, which is fine but somewhat > confusing. (e.g. we want to surface

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

dgoldman updated this revision to Diff 371103. dgoldman added a comment. Update comment + remove un-needed code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/ https://reviews.llvm.org/D108556 Files: clang-tools-extra/clangd/FindTarget

<    1   2   3   4   5   6   >