dgoldman added a comment. In D117056#3256538 <https://reviews.llvm.org/D117056#3256538>, @sammccall wrote:
> This looks good now, only blocker is dropping the change to LookupFile > somehow. > > Is it valuable to land this before the imminent 14 branch cut? I think it's > OK but as an indexing change a crash has the possibility to be really > disruptive, and most of the rest of us aren't regularly dogfooding this on > Mac. > I'd suggest we only land it before the branch if you feel like you can test > this on a reasonable variety of code in the next few weeks. WDYT? SGTM to wait until after, the cut is in 2 weeks right? That should be fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
