[PATCH] D105368: Lex: add a callback for `#pragma mark`

dgoldman added inline comments. Comment at: clang/unittests/Lex/PPCallbacksTest.cpp:119 +SourceLocation Location; +StringRef Trivia; + }; should this be an std::string? not sure of the lifetime guarantees here Repository: rG LLVM Github Monorepo CHA

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8340 } + // Bail out if we didn't make any correction progress on the checking + // TypoExpr TE, otherwise we risk running the loop forever. sammccall wrote: >

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8340 } + // Bail out if we didn't make any correction progress on the checking + // TypoExpr TE, otherwise we risk running the loop forever. dgoldman wrote: >

[PATCH] D105533: [clang] Fix an infinite loop during typo-correction

dgoldman accepted this revision. dgoldman added a comment. Thanks! Just to confirm, the non-simplified example is also fixed, right? struct a { int xxx; }; int g_107; int g_108; int g_109; struct a g_999; void b() { (g_910.xxx = g_910.xxx1); } Repository: rG LLVM Gi

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, kbarton, mgorny, nemanjai. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Xcode uses `#pragma mark

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 358307. dgoldman added a comment. Minor TODO change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ex

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 358606. dgoldman added a comment. Fix clang tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CMakeLists.txt clang-to

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. In D105904#2877184 , @kadircet wrote: > So first of all, it is not clear to me if this is a useful enough improvement > to justify all the new code, but looking at your investment I'll assume this > is really common in ObjC lan

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 326719. dgoldman marked an inline comment as done. dgoldman added a comment. Limit changes to document symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files:

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 327146. dgoldman added a comment. Add comment and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-too

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2141e3a08c: [clangd] Improve document symbols support for Objective-C categories and methods (authored by dgoldman). Repository: rG LLVM Github

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

dgoldman added a comment. In D97617#2592424 , @sammccall wrote: > (not really sure why this suddenly seemed important to me, but if you don't > have semantic highlighting on, you're missing out!) Thanks! Comment at: clang-tools-extra/

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 470868. dgoldman added a comment. Change IncludeTypes to be a bitset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/index/Merge.cp

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 486111. dgoldman marked 7 inline comments as done. dgoldman added a comment. Minor fixes for review, moving stuff around Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D1394

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:88 /// (These should be const, but RecursiveASTVisitor requires Decl*). - ArrayRef getLocalTopLevelDecls(); + ArrayRef getLocalTopLevelDecls() const; kadircet wrote: > can you

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 486291. dgoldman marked 4 inline comments as done. dgoldman added a comment. Update comment + test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-too

[PATCH] D139446: [clangd] Add flag to control #import include insertions

dgoldman updated this revision to Diff 486700. dgoldman marked 2 inline comments as done. dgoldman added a comment. Update comment + default value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139446/new/ https://reviews.llvm.org/D139446 Files:

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 486706. dgoldman added a comment. Respect ImportInsertions flag in IncludeFixer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/AST

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:572 + // case where a header file contains ObjC decls but no #imports. + Symbol::IncludeDirective Directive = preferredIncludeDirective( +

[PATCH] D139446: [clangd] Add flag to control #import include insertions

This revision was automatically updated to reflect the committed changes. Closed by commit rG814c0bb31660: [clangd] Add flag to control #import include insertions (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139446/new/ http

[PATCH] D139458: [clangd] Full support for #import insertions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG042dd99484d6: [clangd] Full support for #import insertions (authored by dgoldman). Changed prior to commi

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 473347. dgoldman marked an inline comment as done. dgoldman added a comment. Fixes for review - Swap over IncludeType to IncludeDirective and update the protos accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman marked 4 inline comments as done. dgoldman added a comment. Also LMK if you want more in this change (such as a flag to control it, just not sure where it should live + what it should be called). Comment at: clang-tools-extra/clangd/index/Symbol.h:116 +/// this he

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 474571. dgoldman marked an inline comment as done. dgoldman added a comment. Fix serialization and isSelfContainedHeader - Keep serialization as a single var uint32 - Keep old imported logic in isSelfContainedHeader in addition to a new check for import lin

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 475180. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-ext

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. IncludeFixer uses this BuildDir stri

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman added a comment. LMK of the best way to add a test for this, maybe I can somehow make a test with relative path arguments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/ https://reviews.llvm.org/D138047 ___

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman updated this revision to Diff 475850. dgoldman added a comment. Fix in ParsedAST.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/ https://reviews.llvm.org/D138047 Files: clang-tools-extra/clangd/ParsedAST.cpp Index: clang

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman added a comment. In D138047#3930211 , @kadircet wrote: > yeah unfortunately testing this is hard, but bug&fix are obvious so it's fine > to land without a test. > > but i think we should rather fix the broken call site at > clang-tools-extra/cl

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d5c4b8f6e04: Fix use of dangling stack allocated string in IncludeFixer (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/ h

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 476220. dgoldman marked 10 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-e

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:37 +//* @param bar +//* @return +//*/ sammccall wrote: > I'm a bit concerned about people generating these `@param bar` and `@return` > and lea

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) Do we need sim

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) ckandeler wrot

[PATCH] D127125: [clangd] Improve ObjC protocol suggestions from the index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc1f24332af3: [clangd] Improve ObjC protocol suggestions from the index (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: wenlei, usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ext

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > dgoldman wrote: >

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

This revision was automatically updated to reflect the committed changes. Closed by commit rGae67984ca6d8: [clangd] ExtractVariable support for C and Objective-C (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D124486?vs=425914&id=433089#toc Repository: rG LLVM Gith

[PATCH] D127116: [clangd] Add flags to symbol requests to restrict to ObjC symbols

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. clangd will set this flag for

[PATCH] D127125: [clangd] Improve ObjC protocol suggestions from the index

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When querying the index during

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. All callers will

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 546017. dgoldman added a comment. run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clan

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 546927. dgoldman added a comment. Rename IsSystem to IsAngled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files: clang-tools-extra/clang-include-fixer/IncludeF

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 547011. dgoldman added a comment. run clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files: clang-tools-extra/clang-include-fixer/IncludeFixer.

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fe632ba18f1: [clang][HeaderSearch] Treat framework headers as Angled for suggestPath (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 479024. dgoldman marked 6 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-ex

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 479066. dgoldman added a comment. Herald added a project: clang. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/CodeComplet

[PATCH] D128677: [clangd] Support #import insertions

dgoldman updated this revision to Diff 479342. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clang

[PATCH] D128677: [clangd] Support #import insertions

dgoldman updated this revision to Diff 479343. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-e

[PATCH] D128677: [clangd] Add support for generating #import edits

dgoldman updated this revision to Diff 479659. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-ex

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 479664. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clang

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 479665. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clang

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245415. dgoldman added a comment. - Fixes for Sam's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman added a comment. In D73916#1881396 , @nridge wrote: > Which client(s) use or plan to use this extension? SourceKit-LSP https://github.com/apple/sourcekit-lsp/pull/242 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman marked 3 inline comments as done. dgoldman added a comment. In D74790#1881827 , @sammccall wrote: > Thanks! I can't see this being a performance problem (famous last words...) Technically it is capped at 2500 symlinks =) fingers crossed Reposi

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

This revision was automatically updated to reflect the committed changes. Closed by commit rGf50fe5eb6d2e: [Sema][CodeComplete] Handle symlinks for include code completion (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/ne

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman added a comment. In D74790#1883466 , @dyung wrote: > `The test you added in this change seems to be failing on Windows, can you > take a look? > > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14409 > > FAIL: Clang :: CodeComp

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman added a comment. Submitted https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 __

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman marked 3 inline comments as done. dgoldman added a comment. Will revisit this once more critical fixes are in (crash fixes), I'm still not sure where this sort of stuff should belong Comment at: clangd/XRefs.cpp:461 + + OS << (Method->isInstanceMethod() ? '-' : '+')

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman added a comment. We'll also want to do something similar for `DocumentSymbols`, see here , which will lead to Objective-C categories showing up as either `(anonymous

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. - This option forces a preamble rebuild to handle the odd case of a missing

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 242155. dgoldman added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-ext

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 243251. dgoldman marked 5 inline comments as done. dgoldman added a comment. - Refactor to use `forceRebuild` and `ParseOptions` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.or

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:653 - Server->addDocument(File, *Contents, WantDiags); + Server->addDocument(File, *Contents, WantDiags, ForceReload); } sammc

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 243272. dgoldman added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 243595. dgoldman marked 3 inline comments as done. dgoldman added a comment. - Fixes for tests and InputFiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files:

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 243619. dgoldman added a comment. - Minor test fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tool

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:630 + + auto DoUpdate = [&](std::string Contents, bool ForceRebuild, + llvm::unique_function)> CB) { --

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG6ff0228c6df3: [clang] Add `forceReload` clangd extension to 'textDocument/didChange' (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman created this revision. dgoldman added reviewers: erik.pilkington, jkorous. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. - This assertion will fire when functions are marked with `objc_externally_

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman added a comment. In D74417#1873287 , @erik.pilkington wrote: > This looks good, but please add a testcase. Added but it's still failing due to a different assertion failure, do you think this could be because the abbreviation is different for

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman updated this revision to Diff 244467. dgoldman added a comment. - Add test (fails due to different assertion) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files: clang/lib/Serialization/ASTWri

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman updated this revision to Diff 244728. dgoldman added a comment. - Fix parameter abbreviation for ParamVarDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files: clang/lib/Serialization/ASTWri

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman added a comment. In D74417#1874826 , @erik.pilkington wrote: > In D74417#1874747 , @dgoldman wrote: > > > Added but it's still failing due to a different assertion failure, do you > > think this could be

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously any symlinks would be ignored since the directory traversal doesn't follow them. With this change we now follow symlinks (via a `stat` call in or

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245256. dgoldman added a comment. - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeComplet

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman added a comment. In D72647#1833203 , @sammccall wrote: > Let's make the minimal change here and land this. Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://reviews.llvm.org/D

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman updated this revision to Diff 239907. dgoldman added a comment. - Swap to stringset and simpler way of tracking modified files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://reviews.llvm.org/D72647 Files: clang-tools-e

[PATCH] D72647: [clangd] Only re-open files if their flags changed

This revision was automatically updated to reflect the committed changes. Closed by commit rG60249c2c3b9e: [clangd] Only re-open files if their flags changed (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://re

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. Herald added a subscriber: ChuanqiXu. Hey, are you still planning to work on this? Otherwise, is it okay if I take over this patch to implement this feature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/ https

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:131 return HighlightingKind::Interface; - if (isa(D)) + if (isa(D)) return HighlightingKind::Namespace; kadircet wrote: > let's do this in a separate change,

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533640. dgoldman added a comment. Disable renaming categories Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-extra/clangd/FindTarget.cpp clan

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533769. dgoldman marked an inline comment as done. dgoldman added a comment. Add more FindTarget tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:716 +void VisitObjCImplementationDecl(const ObjCImplementationDecl *OIMD) { + if (const auto *CI = OIMD->getClassInterface()) +Refs.push

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman updated this revision to Diff 533969. dgoldman marked an inline comment as done. dgoldman added a comment. Add a contextAllowsHeaderInsertion helper to clangd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150978/new/ https://reviews.llvm.o

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533993. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-ex

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:787 + // names like class and protocol names. + if (const auto *CD = dyn_cast(&RenameDecl)) +if (CD->getName() != IdentifierToken->text(SM)) kadircet wrote: > this spec

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 534618. dgoldman marked an inline comment as done. dgoldman added a comment. Fixes for review + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b66840f7103: [clangd][ObjC] Support ObjC class rename from implementation decls (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman updated this revision to Diff 534714. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150978/new/ https://reviews.llvm.org/D150978 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clang

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa42ce094d903: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. - Use this new c

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. In D140275#4203456 , @tupos wrote: > Could you please also advice me what else need to be done for the ObjC, since > there were many years since I wrote ObjC last time I'm not sure what else > need to be done there. > > Thanks.

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 530665. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ext

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 531439. dgoldman added a comment. - Implement discussed fixes + category support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-extra/clangd/Fi

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 480465. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes + hopefully proper diffbase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files:

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 480482. dgoldman marked 9 inline comments as done. dgoldman added a comment. Fixes for review + fix diffbase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files:

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman added inline comments. Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:65 +TEST_F(HeaderIncludesTest, InsertImportWithSameInclude) { + std::string Code = "#include \"a.h\"\n"; kadircet wrote: > can you also add a removal test? > > i know w

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 480513. dgoldman marked 2 inline comments as done. dgoldman added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/c

<    1   2   3   4   5   6   >