dgoldman added inline comments.
================ Comment at: clang/unittests/Lex/PPCallbacksTest.cpp:119 + SourceLocation Location; + StringRef Trivia; + }; ---------------- should this be an std::string? not sure of the lifetime guarantees here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105368/new/ https://reviews.llvm.org/D105368 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
