Author: dblaikie
Date: Thu Aug 13 17:58:37 2015
New Revision: 244979
URL: http://llvm.org/viewvc/llvm-project?rev=244979&view=rev
Log:
Wdeprecated: BugReporterVisitors are copied for cloning
(BugReporterVisitorImpl), make sure such copies are safe
Make the copy/move ctors defaulted in the base c
Author: dblaikie
Date: Thu Aug 13 17:58:35 2015
New Revision: 244978
URL: http://llvm.org/viewvc/llvm-project?rev=244978&view=rev
Log:
Follow up r244975: The ctors of an abstract class don't need to be protected -
the object isn't directly constructible/doesn't present a slicing risk
Modified:
Author: dblaikie
Date: Thu Aug 13 18:05:58 2015
New Revision: 244980
URL: http://llvm.org/viewvc/llvm-project?rev=244980&view=rev
Log:
Fix the MSVC build which cannot manifest default move ops
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h
Modified:
c
Author: dblaikie
Date: Thu Aug 13 18:09:18 2015
New Revision: 244981
URL: http://llvm.org/viewvc/llvm-project?rev=244981&view=rev
Log:
Wdeprecated: Make the SecKeychainBugVisitor copyable (for the clone support in
the CRTP base) my removing the user-declared dtor
The implicit dtor is just as goo
Author: dblaikie
Date: Thu Aug 13 18:15:20 2015
New Revision: 244983
URL: http://llvm.org/viewvc/llvm-project?rev=244983&view=rev
Log:
Wdeprecated: Make Filter safely move constructible.
makeFilter returns Filters by value which seems to be only safe when the
copy doesn't occur and RVO kicks in.
Author: dblaikie
Date: Thu Aug 13 18:38:46 2015
New Revision: 244986
URL: http://llvm.org/viewvc/llvm-project?rev=244986&view=rev
Log:
Wdeprecated: Ensure CheckNames are copy assignable (used in
setCurrentCheckName) by removing the unnecessary copy ctor
Modified:
cfe/trunk/include/clang/Stat
Author: dblaikie
Date: Thu Aug 13 18:53:09 2015
New Revision: 244990
URL: http://llvm.org/viewvc/llvm-project?rev=244990&view=rev
Log:
Wdeprecated: ByrefHelpers are copy constructed by the ::buildByrefHelpers
helper, make sure they're safely copyable
Make the copy/move ctors protected and defaul
Author: dblaikie
Date: Thu Aug 13 20:26:19 2015
New Revision: 244998
URL: http://llvm.org/viewvc/llvm-project?rev=244998&view=rev
Log:
unique_ptrify ConsumedBlockInfo analysis to make it move assignable
ConsumedBlockInfo objects were move assigned, but only in a state where
the dtor was a no-op a
Have you tested this? I assume there are strict aliasing violations in
Clang/LLVM if we've had this turned on for a while.
(does strict aliasing still have the special case for enum type punning?
Becaues I've certainly seen (& fixed) that in a few places in Clang/LLVM)
On Fri, Aug 14, 2015 at 10:
On Mon, Aug 17, 2015 at 11:07 AM, Evgeniy Stepanov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> eugenis created this revision.
> eugenis added reviewers: chandlerc, rsmith.
> eugenis added a subscriber: cfe-commits.
> eugenis set the repository for this revision to rL LLVM.
>
> Currently
Author: dblaikie
Date: Tue Aug 18 15:24:06 2015
New Revision: 245339
URL: http://llvm.org/viewvc/llvm-project?rev=245339&view=rev
Log:
Simplify Diagnostic's ctors a bit by using in-class initializers for its members
Modified:
cfe/trunk/include/clang/Basic/Diagnostic.h
Modified: cfe/trunk/inc
Author: dblaikie
Date: Tue Aug 18 15:54:26 2015
New Revision: 245352
URL: http://llvm.org/viewvc/llvm-project?rev=245352&view=rev
Log:
Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Se
ref, and in the
second case, passed an rvalue, they return the same). But that seems
painful.
On Tue, Aug 18, 2015 at 1:54 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dblaikie
> Date: Tue Aug 18 15:54:26 2015
> New Revision: 245352
>
> URL:
Author: dblaikie
Date: Tue Aug 18 17:09:28 2015
New Revision: 245367
URL: http://llvm.org/viewvc/llvm-project?rev=245367&view=rev
Log:
Wdeprecated: Support movability of EHScopeStack::Cleanup objects as they are
move constructed in ConditionalCleanup::restore
Modified:
cfe/trunk/lib/CodeGen/
Author: dblaikie
Date: Tue Aug 18 17:10:49 2015
New Revision: 245368
URL: http://llvm.org/viewvc/llvm-project?rev=245368&view=rev
Log:
Fix for MSVC
Modified:
cfe/trunk/lib/CodeGen/EHScopeStack.h
Modified: cfe/trunk/lib/CodeGen/EHScopeStack.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
Author: dblaikie
Date: Tue Aug 18 17:40:54 2015
New Revision: 245378
URL: http://llvm.org/viewvc/llvm-project?rev=245378&view=rev
Log:
Devirtualize EHScopeStack::Cleanup's dtor because it's never destroyed
polymorphically
Modified:
cfe/trunk/lib/CodeGen/CGBlocks.cpp
cfe/trunk/lib/CodeGen
Author: dblaikie
Date: Tue Aug 18 18:56:00 2015
New Revision: 245392
URL: http://llvm.org/viewvc/llvm-project?rev=245392&view=rev
Log:
unique_ptrify CXXBasePaths::DeclsFound & remove the then-unnecessary
user-defined dtor
Maybe this and the NumDeclsFound member should just be a std::vector
inste
dblaikie created this revision.
dblaikie added a reviewer: rsmith.
dblaikie added a subscriber: cfe-commits.
While there wasn't much use of "return Diag(...) << x" outside Sema (one
each in ARCMigrate, Lex, Parse, and 5 in ClangTidy - which were all just
changed to use named local variables, then
>> second case, passed an rvalue, they return the same). But that seems
>> painful.
>>
>
> It seems tricky to form an unambiguous overload set for this that
> preserves the value category, without duplicating all the operator<
Yep :/
>
>
>> On Tue, Aug
dblaikie updated this revision to Diff 32495.
dblaikie marked 2 inline comments as done.
dblaikie added a comment.
Addressed Richard's code review feedback
http://reviews.llvm.org/D12131
Files:
include/clang/Basic/Diagnostic.h
include/clang/Sema/Sema.h
lib/ARCMigrate/TransformActions.cpp
dblaikie added inline comments.
Comment at: include/clang/Basic/Diagnostic.h:936-937
@@ -935,3 +935,4 @@
public:
/// Copy constructor. When copied, this "takes" the diagnostic info from the
/// input and neuters it.
+ DiagnosticBuilder(DiagnosticBuilder &&D) {
---
On Tue, Aug 18, 2015 at 8:28 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> dblaikie added inline comments.
>
>
> Comment at: include/clang/Basic/Diagnostic.h:936-937
> @@ -935,3 +935,4 @@
> public:
>/// Copy constructor
On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl wrote:
> aprantl created this revision.
> aprantl added reviewers: dblaikie, echristo.
> aprantl added a subscriber: cfe-commits.
> aprantl set the repository for this revision to rL LLVM.
>
> This patch adds a -gmodules option to the driver and a -d
On Wed, Aug 12, 2015 at 5:00 PM, Justin Bogner
wrote:
> On Wed, Aug 12, 2015 at 3:09 PM, David Blaikie wrote:
> > On Tue, Oct 21, 2014 at 10:24 AM, Justin Bogner
> > wrote:
> >> Author: bogner
> >> Date: Tue Oct 21 12:24:44 2014
> >> New Revision: 220305
> >>
> >> URL: http://llvm.org/viewvc/ll
(add the right list)
-- Forwarded message --
From: David Blaikie
Date: Wed, Aug 19, 2015 at 1:20 PM
Subject: Re: [PATCH] Have clang list the imported modules in the debug info
To: Adrian Prantl
Cc: Eric Christopher , Zachary Turner <
ztur...@google.com>, "Robinson, Paul" ,
Richard
On Thu, Aug 20, 2015 at 2:45 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> aprantl added inline comments.
>
>
> Comment at: include/clang/Frontend/CodeGenOptions.def:164-165
> @@ -163,1 +163,4 @@
>
> +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or no
On Mon, Aug 24, 2015 at 7:28 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Mon Aug 24 09:28:08 2015
> New Revision: 245843
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245843&view=rev
> Log:
> clang-format: Make formatting of member function r
On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote:
>
> On Aug 19, 2015, at 1:20 PM, David Blaikie wrote:
>
>
>
> On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl wrote:
>
>>
>> On Jul 24, 2015, at 12:33 PM, David Blaikie wrote:
>>
>> *reads back through the thread*
>>
>>
>> appreciated, it’s
On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl wrote:
>
> On Aug 24, 2015, at 2:01 PM, David Blaikie wrote:
>
>
>
> On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote:
>
>>
>> On Aug 19, 2015, at 1:20 PM, David Blaikie wrote:
>>
>>
>>
>> On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl wrote:
On Mon, Aug 24, 2015 at 5:33 PM, Adrian Prantl wrote:
>
> On Aug 24, 2015, at 4:17 PM, David Blaikie wrote:
>
>
>
> On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl wrote:
>
>>
>> On Aug 24, 2015, at 2:01 PM, David Blaikie wrote:
>>
>>
>>
>> On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote:
Looks like the initial mail didn't hit the mailing list? Does someone want
to restart this review and/or forward that initial mail with the
patch/description/etc?
On Mon, Aug 24, 2015 at 11:00 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> echristo added a comment.
>
Hmm, my mistake, it did - my mail client's just not threaded it together
for some reason. :/
On Tue, Aug 25, 2015 at 8:06 AM, David Blaikie wrote:
> Looks like the initial mail didn't hit the mailing list? Does someone want
> to restart this review and/or forward that initial mail with the
> pat
On Tue, Aug 18, 2015 at 9:05 PM, Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> ABataev created this revision.
> ABataev added reviewers: echristo, rjmccall, rsmith.
> ABataev added a subscriber: cfe-commits.
>
> When variables are implicitly captured in lambdas, debug info g
On Tue, Aug 25, 2015 at 8:18 AM, Bataev, Alexey
wrote:
> I though about this. I think it will be more convenient for user to see
> the diagnostic on the first use of the variable rather than on '=' or '&'
> symbol.
>
Why the difference between the diagnostic & the debug info, then?
>
> Best re
On Tue, Aug 25, 2015 at 8:44 AM, Bataev, Alexey
wrote:
> Debug info points to the real place where it is captured, while
> diagnostics points to the first use of implicitly captured variable.
Right, but I'm trying to understand the justification for why that's the
right thing to do. Why the deb
On Aug 27, 2015 7:38 AM, "Marshall Clow via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: marshall
> Date: Thu Aug 27 09:37:22 2015
> New Revision: 246150
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246150&view=rev
> Log:
> Remove a switch statement, and replace with a bunch of
On Tue, Aug 25, 2015 at 10:50 AM, Bataev, Alexey
wrote:
> Guys, talking about implicitly captured variables we have to deal with 2
> locations: 1) point of real capturing (it is the point of '=' or '&'
> symbols in lambda capture-list);
I'm not sure that's "the point of real capturing" if it's
On Thu, Aug 27, 2015 at 2:21 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Thu Aug 27 16:21:19 2015
> New Revision: 246210
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246210&view=rev
> Log:
> CGDebugInfo: Factor out a getOrCreateStandaloneType
On Thu, Aug 27, 2015 at 2:35 PM, Adrian Prantl wrote:
>
> On Aug 27, 2015, at 2:25 PM, David Blaikie wrote:
>
>
>
> On Thu, Aug 27, 2015 at 2:21 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Thu Aug 27 16:21:19 2015
>> New Revision: 246210
Any chance this would be improved/further simplified by basing it on the
adapter_iterator helper in LLVM's STL Utilities?
On Sun, Aug 30, 2015 at 8:12 AM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Sun Aug 30 10:12:28 2015
> New Revision: 246384
>
>
On Mon, Aug 31, 2015 at 9:48 AM, Benjamin Kramer
wrote:
>
>
> On Mon, Aug 31, 2015 at 5:12 PM, David Blaikie wrote:
>
>> Any chance this would be improved/further simplified by basing it on the
>> adapter_iterator helper in LLVM's STL Utilities?
>>
>
> Fair enough, r246452. I was a bit nervous b
dblaikie added a subscriber: dblaikie.
dblaikie added a comment.
We generally don't do large whitespace changes like this because of issue
with version control (not all told are whitespace ignorant which makes
history work difficult).
I don't mind these changes personally, but it should get sign
We generally don't do large whitespace changes like this because of issue
with version control (not all told are whitespace ignorant which makes
history work difficult).
I don't mind these changes personally, but it should get sign of from Ted
or similar first.
On Sep 7, 2015 5:47 AM, "Honggyu Kim
On Oct 8, 2015 7:19 AM, "Douglas Katzman via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: dougk
> Date: Thu Oct 8 09:18:02 2015
> New Revision: 249692
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249692&view=rev
> Log:
> [Myriad]: default the Dwarf version to 2
Just out of cu
On Fri, Oct 9, 2015 at 2:26 AM, Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> ABataev created this revision.
> ABataev added a reviewer: echristo.
> ABataev added a subscriber: cfe-commits.
>
> Currently debug info for types used in explicit cast only is not emitted.
> It ha
+John, author of the original patch - in case it's an obvious mistake. I
haven't looked at John's change yet & compared it to the intended behavior,
etc. Will do so soon and/or if John doesn't see something at a glance.
On Sun, Oct 11, 2015 at 11:09 PM, Bataev, Alexey
wrote:
> Yes, revision 2469
On Fri, Oct 16, 2015 at 4:43 AM, Angel Garcia Gomez via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: angelgarcia
> Date: Fri Oct 16 06:43:49 2015
> New Revision: 250509
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250509&view=rev
> Log:
> Fix overlapping replacements in clang-tid
On Mon, Oct 19, 2015 at 2:49 PM, Samuel Benzaquen via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sbenza
> Date: Mon Oct 19 16:49:51 2015
> New Revision: 250742
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250742&view=rev
> Log:
> Added check uniqueptr-delete-release to replace
On Tue, Oct 20, 2015 at 12:50 AM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Tue Oct 20 02:50:21 2015
> New Revision: 250803
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250803&view=rev
> Log:
> Put back dead code that's used out-of-tree.
>
Migh
Nevermind, I see this was floated/discussed in the review thread of the
original commit ( 250418 )
On Tue, Oct 20, 2015 at 11:46 AM, David Blaikie wrote:
>
>
> On Tue, Oct 20, 2015 at 12:50 AM, Benjamin Kramer via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: d0k
>> Date: Tue
On Tue, Oct 20, 2015 at 8:39 AM, Samuel Benzaquen wrote:
>
> On Mon, Oct 19, 2015 at 6:00 PM, David Blaikie wrote:
>
>>
>>
>> On Mon, Oct 19, 2015 at 2:49 PM, Samuel Benzaquen via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: sbenza
>>> Date: Mon Oct 19 16:49:51 2015
>>> New
On Tue, Oct 20, 2015 at 2:24 PM, Tobias Grosser via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 10/20/2015 02:56 PM, Angel Garcia Gomez via cfe-commits wrote:
>
>> Author: angelgarcia
>> Date: Tue Oct 20 07:56:27 2015
>> New Revision: 250824
>>
>> URL: http://llvm.org/viewvc/llvm-project
Author: dblaikie
Date: Tue Oct 20 16:45:52 2015
New Revision: 250862
URL: http://llvm.org/viewvc/llvm-project?rev=250862&view=rev
Log:
Revert "Apply modernize-use-default to clang-tools-extra."
Breaks the build in GCC 4.7.2 (see
http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3 for example)
Reverted in r250862
On Tue, Oct 20, 2015 at 2:39 PM, Tobias Grosser wrote:
> On 10/20/2015 11:37 PM, David Blaikie wrote:
>
>>
>>
>> On Tue, Oct 20, 2015 at 2:24 PM, Tobias Grosser via cfe-commits
>> mailto:cfe-commits@lists.llvm.org>> wrote:
>>
>> On 10/20/2015 02:56 PM, Angel Garcia Gomez
On Oct 25, 2015 2:47 PM, "Daniel Jasper via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: djasper
> Date: Sun Oct 25 16:44:55 2015
> New Revision: 251262
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251262&view=rev
> Log:
> [clang-tidy] Add return value for non-assert builds.
>
On Oct 25, 2015 3:05 PM, "Benjamin Kramer via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: d0k
> Date: Sun Oct 25 17:03:00 2015
> New Revision: 251265
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251265&view=rev
> Log:
> assert(false) -> llvm_unreachable.
>
> Modified:
>
clang-
Ah, I see Benjamin got to this in 251265
On Oct 25, 2015 9:54 PM, "David Blaikie" wrote:
>
> On Oct 25, 2015 2:47 PM, "Daniel Jasper via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: djasper
> > Date: Sun Oct 25 16:44:55 2015
> > New Revision: 251262
> >
> > URL: http://llvm
On Mon, Oct 26, 2015 at 6:32 AM, Gabor Horvath via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: xazax
> Date: Mon Oct 26 08:32:26 2015
> New Revision: 251289
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251289&view=rev
> Log:
> [analyzer] Fixed a rare crash when analyzing lambda
On Mon, Oct 26, 2015 at 5:08 AM, Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Mon Oct 26 07:08:47 2015
> New Revision: 251284
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251284&view=rev
> Log:
> clang-format: Fix false positive in cast detection
On Mon, Oct 26, 2015 at 5:06 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Mon Oct 26 19:06:21 2015
> New Revision: 251371
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251371&view=rev
> Log:
> Use early exits to reduce indentation.
>
> Mod
On Mon, Oct 26, 2015 at 9:21 PM, Daniel Jasper wrote:
> I mixed up before and after. Other than that, I don't see a typo.
>
It looks like the test case "+ verifyFormat("std::function< void(int, int)
> fct;", Spaces);" ensures no spaces between the parameters and the () in
the function type ("vo
On Mon, Oct 26, 2015 at 9:43 PM, Daniel Jasper wrote:
> If you look closely, there are multiple tests for different configuration
> options.
>
Ah, I see one that's "( int, int )" now - cool, thanks!
> The before/after is always just one example.
>
> On Tue, Oct 27, 2015 at 5:42 AM, David Blaik
On Tue, Oct 27, 2015 at 9:24 AM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Oct 26, 2015 at 11:02 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h
>> URL:
>> http://llvm.org/viewvc/llv
Test case?
On Wed, Nov 4, 2015 at 3:44 PM, Tamas Berghammer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> tberghammer created this revision.
> tberghammer added a reviewer: echristo.
> tberghammer added a subscriber: cfe-commits.
>
> Add new compiler flag to enable the generation of dwar
On Wed, Nov 4, 2015 at 11:32 PM, Robinson, Paul <
paul_robin...@playstation.sony.com> wrote:
> Would citing PR20455 help? It wasn't actually my primary motivation but
> it's not too far off. Having the template parameters there lets you know
> what's going on in the DWARF, without having to fetc
Or Tamas can write the tuning patch - it seems like it'd be relatively
straightforward. Perhaps you can give an idea of what you think it'd look
like, Paul (what the command line syntax would be, etc)
On Fri, Nov 6, 2015 at 11:16 AM, Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrot
Any chance of a test case here?
(I don't know much about this code, but I am a bit confused about why we'd
ever need to visit a list of mangled names & look them up... )
On Thu, Nov 5, 2015 at 3:18 PM, Keno Fischer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kfischer
> Date: T
On Thu, Nov 5, 2015 at 11:05 AM, Robinson, Paul <
paul_robin...@playstation.sony.com> wrote:
> | What was your primary motivation?
>
> A similar concern to PR20455 from our own debugger. It much helps
> matching up the forward declaration and definition to have the parameters
> properly specified
On Mon, Nov 9, 2015 at 3:55 PM, Robinson, Paul <
paul_robin...@playstation.sony.com> wrote:
> | Why is matching by name insufficient/not correct?
>
> I'm told we look at the mangled names in the ELF symbol table, demangle
> them, and look in the DWARF for the corresponding types.
>
Not quite sure
On Mon, Nov 9, 2015 at 5:08 PM, Robinson, Paul <
paul_robin...@playstation.sony.com> wrote:
> | when/where/why are types acquired from the mangled names of ELF
> symbols, rather than from corresponding DWARF?
>
>
>
> Pete, can you help me out here? David seems to want an ironclad case for
> not b
On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Wed Nov 11 18:44:12 2015
> New Revision: 252834
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252834&view=rev
> Log:
> Provide a frontend based error for always_inli
Author: dblaikie
Date: Wed Nov 11 19:09:58 2015
New Revision: 252840
URL: http://llvm.org/viewvc/llvm-project?rev=252840&view=rev
Log:
Refactor out some common code from r252834
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
URL:
http
On Wed, Nov 11, 2015 at 4:54 PM, David Blaikie wrote:
>
>
> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: echristo
>> Date: Wed Nov 11 18:44:12 2015
>> New Revision: 252834
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=2
On Thu, Aug 6, 2015 at 11:29 AM, Richard Smith wrote:
> On Aug 6, 2015 11:01 AM, "David Blaikie" wrote:
> >
> >
> >
> > On Wed, Aug 5, 2015 at 9:23 PM, Richard Smith <
> richard-l...@metafoo.co.uk> wrote:
> >>
> >> Author: rsmith
> >> Date: Wed Aug 5 23:23:48 2015
> >> New Revision: 244192
> >>
Author: dblaikie
Date: Thu Aug 6 13:29:32 2015
New Revision: 244241
URL: http://llvm.org/viewvc/llvm-project?rev=244241&view=rev
Log:
Fix memory ownership in the NeonEmitter by using values instead of pointers
(smart or otherwise)
Improvement to the memory leak fix in 244196.
Address validity
On Fri, Aug 7, 2015 at 3:15 AM, Yaron Keren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: yrnkrn
> Date: Fri Aug 7 05:15:15 2015
> New Revision: 244312
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244312&view=rev
> Log:
> Silence tools/clang/lib/Tooling/CompilationDatabase.cp
On Mon, Aug 10, 2015 at 10:33 AM, Chih-Hung Hsieh via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chh
> Date: Mon Aug 10 12:33:31 2015
> New Revision: 244468
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244468&view=rev
> Log:
> Correct x86_64 fp128 calling convention
>
> These c
What build problem did this cause? Did this just not compile (it looks as
if ArgList has hasArg and hasFlag, so I'm not sure what the specific
problem might've been)
On Wed, Jul 13, 2016 at 11:45 PM Dean Michael Berris via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dberris
> Date:
It'd be handy to include details of what's different about this commit than
the previous time it was committed - makes review easier by focusing on the
new changes. (for some commits where I've recommitted them a few times I
end up with a bit of a timeline/history in the commit message - "fixed thi
Ping?
On Mon, Jul 18, 2016 at 11:28 AM David Blaikie wrote:
> What build problem did this cause? Did this just not compile (it looks as
> if ArgList has hasArg and hasFlag, so I'm not sure what the specific
> problem might've been)
>
> On Wed, Jul 13, 2016 at 11:45 PM Dean Michael Berris via cfe
Should we fix the diagnostic? Or is the code triggering it just esoteric
enough to not be a good justification for changing the warning?
On Tue, Jul 19, 2016 at 1:42 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Jul 19 15:35:09 2016
> New Revis
+Richard Trieu - worth fixing? If anyone does get
around to fixing this, would be good to remove the workaround committed
here in r276022.
On Mon, Jul 25, 2016 at 10:51 AM Richard Smith
wrote:
> On 25 Jul 2016 6:29 p.m., "David Blaikie via cfe-commits" <
> cfe-commits@li
Ping
On Mon, Jul 25, 2016 at 10:24 AM David Blaikie wrote:
> Ping?
>
> On Mon, Jul 18, 2016 at 11:28 AM David Blaikie wrote:
>
>> What build problem did this cause? Did this just not compile (it looks as
>> if ArgList has hasArg and hasFlag, so I'm not sure what the specific
>> problem might've
On Tue, Jul 26, 2016 at 4:37 PM Laxman Sole via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> laxmansole created this revision.
> laxmansole added reviewers: mclow.lists, howard.hinnant.
> laxmansole added subscribers: cfe-commits, sebpop, hiraditya, evandro,
> flyingforyou.
>
>
> Currently b
Author: dblaikie
Date: Fri Aug 5 14:03:01 2016
New Revision: 277852
URL: http://llvm.org/viewvc/llvm-project?rev=277852&view=rev
Log:
PR26423: Assert on valid use of using declaration of a function with an
undeduced auto return type
For now just disregard the using declaration in this case. Sub
I'm still (as per another similar thread) a bit concerned this is working
around a compiler optimizer bug - I'd love to see a standalone example of
this behavior (that adding the inline keyword to an already
inline/available definition is what's causing the inlining) so we can look
at what the comp
This seems to have a lot of overlap with -Wmissing-prototype, really - what
do you think of the overlap/distinction between the two?
On Wed, Aug 3, 2016 at 1:25 PM Eugene Zelenko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Eugene.Zelenko added a subscriber: Eugene.Zelenko.
> Eugene.Zel
On Wed, Aug 3, 2016 at 4:13 PM Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: alexfh
> Date: Wed Aug 3 18:06:03 2016
> New Revision: 277677
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277677&view=rev
> Log:
> [clang-tidy] Inefficient string operation
>
A
On Mon, Aug 8, 2016 at 8:37 AM Benjamin Kramer wrote:
> -Wmissing-prototype only warns for functions, I want to catch classes
> too.
Ah, fair enough. Yeah, a clang-tidy check for things in the global
namespace that are in a main file rather than a header could be another
pivot there.
> Also f
On Wed, Aug 10, 2016 at 5:39 PM Eric Fiselier wrote:
> On Mon, Aug 8, 2016 at 9:32 AM, David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> I'm still (as per another similar thread) a bit concerned this is working
>> around a compiler o
On Tue, Feb 2, 2016 at 11:11 AM, Rafael Espíndola <
cfe-commits@lists.llvm.org> wrote:
> Out of curiosity, what technique were you using to find out if the
> headers were self-contained? Just "clang -c foo.h"?
>
Building LLVM & Clang with C++ modules enabled
>
> Cheers,
> Rafael
>
>
> On 2 Febr
dblaikie added a comment.
Looks good - though you could do that one further simplification to the test
case, I think. (removing x/if x)
Comment at: test/CodeGenCXX/debug-info-lb.cpp:5
@@ +4,3 @@
+ static int bar = 1;
+ if (x)
+ {
Looks like you could remove
Is this really that useful of a rule? The language does the right thing for
the most part already (you don't need to explicitly delete them - they're
implicitly deleted if you define any others - except for backcompat with
C++98, but those cases are deprecated & we should probably split out the
war
On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe wrote:
> All the C++ compilers I have tried using (GCC,Clang,MSVC) will generate
> assignment operators even if the user defines a copy-constructor. This is
> the behaviour I set out to write a check for.
>
> The cpp core guide lines recommend definin
On Wed, Feb 3, 2016 at 1:03 PM, Jonathan Coe wrote:
>
>
> On 3 February 2016 at 18:44, David Blaikie wrote:
>
>>
>>
>> On Wed, Feb 3, 2016 at 10:23 AM, Jonathan Coe wrote:
>>
>>> All the C++ compilers I have tried using (GCC,Clang,MSVC) will generate
>>> assignment operators even if the user de
On Wed, Feb 3, 2016 at 1:40 PM, Aaron Ballman
wrote:
> On Wed, Feb 3, 2016 at 4:13 PM, David Blaikie wrote:
> >
> >
> > On Wed, Feb 3, 2016 at 1:03 PM, Jonathan Coe wrote:
> >>
> >>
> >>
> >> On 3 February 2016 at 18:44, David Blaikie wrote:
> >>>
> >>>
> >>>
> >>> On Wed, Feb 3, 2016 at 10:23
On Mon, Feb 8, 2016 at 11:14 AM, Xinliang David Li via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: davidxl
> Date: Mon Feb 8 13:14:14 2016
> New Revision: 260126
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260126&view=rev
> Log:
> Simplify test cases
>
It's handy to mention t
This looks like a change to clang - could you test it in clang (& review it
on cfe-commits instead of llvm-commits)?
On Sat, Feb 6, 2016 at 11:57 AM, David Li via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> davidxl created this revision.
> davidxl added a reviewer: vsk.
> davidxl added sub
On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> davidxl updated this revision to Diff 47217.
> davidxl added a comment.
>
> Simplified test case suggested by Vedant.
>
>
> http://reviews.llvm.org/D16947
>
> Files:
> lib/CodeGen/CGClass.cpp
> te
ah, right, sorry about that - gmail didn't render cfe-commits on the to
line in the first email... weird.
Anyway, no need to include llvm-commits on clang-only changes.
On Mon, Feb 8, 2016 at 11:30 AM, Xinliang David Li
wrote:
> Both cfe-commits and llvm-commits are cc'ed.
>
> David
>
> On Mon,
901 - 1000 of 1480 matches
Mail list logo
