Author: dblaikie
Date: Wed Apr 26 15:58:21 2017
New Revision: 301470
URL: http://llvm.org/viewvc/llvm-project?rev=301470&view=rev
Log:
Fix API breaks
Modified:
cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp
cfe/trunk/lib/CodeGen/MacroPPCallbacks.h
Modified: cfe/trunk/lib/CodeGen/MacroPPCallb
ant
>
> > On Apr 26, 2017, at 1:58 PM, David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: dblaikie
> > Date: Wed Apr 26 15:58:21 2017
> > New Revision: 301470
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev
t the time seems fine :)
> Reverted my revert in r301472.
>
Thanks!
>
> vedant
>
> >
> >
> > On Wed, Apr 26, 2017 at 2:14 PM Vedant Kumar wrote:
> > Hi David,
> >
> > It looks like this conflicts with my revert. I will revert my revert,
Author: dblaikie
Date: Fri Apr 28 15:50:25 2017
New Revision: 301684
URL: http://llvm.org/viewvc/llvm-project?rev=301684&view=rev
Log:
Enable -fno-split-dwarf-inlining even when -gsplit-dwarf isn't specified.
Since -gsplit-dwarf is specified on a backend compile (in ThinLTO
parlance) it isn't pas
Author: dblaikie
Date: Sun Apr 30 21:11:39 2017
New Revision: 301786
URL: http://llvm.org/viewvc/llvm-project?rev=301786&view=rev
Log:
Fix line endings (dos -> unix) and clang-format while I'm here
Modified:
cfe/trunk/test/SemaCXX/cxx1z-lambda-star-this.cpp
Modified: cfe/trunk/test/SemaCXX/c
On Mon, Oct 17, 2016 at 4:37 AM Victor Leschuk
wrote:
> vleschuk marked an inline comment as done.
> vleschuk added inline comments.
>
>
>
> Comment at: include/clang/AST/ASTContext.h:83
> uint64_t Width;
> -unsigned Align;
> +llvm::DIAlignment Align;
> bool Ali
Not worth/reasonable to have a test case?
On Thu, Oct 13, 2016 at 7:44 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Oct 13 21:35:11 2016
> New Revision: 284187
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284187&view=rev
> Log:
> Fix bogus
dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2183-2185
+ if (VAT->getSizeExpr()) {
+llvm::APSInt V;
+if (VAT->getSizeExpr()->EvaluateAsInt(V, CGM.getC
If we issue a fixit we should recover as-if the code was written with the
fixit in. Does this code do that? (can we test it? I know we test some
fixits - not sure it's necessary/worthwhile to test them all, but maybe we
have a good idiom for testing that the recovery is correct)
On Thu, Oct 20, 20
On Mon, Aug 29, 2016 at 3:45 PM Tim Shen via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> timshen created this revision.
> timshen added reviewers: rsmith, pirama.
> timshen added a subscriber: cfe-commits.
>
> https://reviews.llvm.org/D24010
>
> Files:
> clang/include/clang/AST/Stmt.h
>
On Fri, Oct 21, 2016 at 3:16 AM Alex Lorenz wrote:
> arphaman updated this revision to Diff 75403.
> arphaman added a comment.
>
> The updated patch improves error handling and adds a test for the fixit.
>
> > If we issue a fixit we should recover as-if the code was written with
> the fixit in. D
Simplify it further by replacing A() with just a function instead of a
class? Or does that break the repro?
bool Foo();
void Bar();
void Baz() {
if (False && Foo())
Bar();
}
On Mon, Oct 24, 2016 at 1:38 PM Tim Shen wrote:
> On Mon, Oct 24, 2016 at 10:33 AM David Blaikie wrote:
>
> On Mon
Ah, right - thanks for reminding/explaining!
On Mon, Oct 24, 2016 at 2:42 PM Tim Shen wrote:
> On Mon, Oct 24, 2016 at 2:38 PM David Blaikie wrote:
>
> Simplify it further by replacing A() with just a function instead of a
> class? Or does that break the repro?
>
> bool Foo();
> void Bar();
> v
How/what output are these producing if they're meant to fail ("not" in the
test line) anyway?
& these tests should probably check the diagnostic result to be more
precise than "Clang exited with a non-zero exit code".
On Thu, Oct 27, 2016 at 1:54 AM Dean Michael Berris via cfe-commits <
cfe-commi
On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Thu Oct 27 08:30:51 2016
> New Revision: 285289
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285289&view=rev
> Log:
> [Sema] -Wunused-variable warning for array variables
On Thu, Oct 27, 2016 at 6:02 AM Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> bkramer accepted this revision.
> bkramer added a comment.
> This revision is now accepted and ready to land.
>
> This makes sense. While variable definitions in a header are weird, the
> warning
On Tue, Nov 1, 2016 at 3:13 AM Alex L wrote:
> On 31 October 2016 at 15:34, David Blaikie wrote:
>
>
>
> On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: arphaman
> Date: Thu Oct 27 08:30:51 2016
> New Revision: 285289
>
> URL: http:/
On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chandlerc
> Date: Thu Nov 3 12:42:32 2016
> New Revision: 285946
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285946&view=rev
> Log:
> Using release to free memory is at best confus
Ah, I see - your follow up in 285950 mentions that this unique_ptr was
always null, so none of it really mattered/did anything.
On Tue, Nov 8, 2016 at 11:42 AM David Blaikie wrote:
> On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Autho
On Sun, Nov 13, 2016 at 1:30 PM Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> EricWF created this revision.
> EricWF added reviewers: mclow.lists, chandlerc.
> EricWF added a subscriber: cfe-commits.
>
> The title says it all.
>
> I just want to check that we agree on the ge
On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rjmccall
> Date: Tue Sep 8 04:18:30 2015
> New Revision: 246991
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246991&view=rev
> Log:
> When building the alloca for a local variable, set i
On Tue, Sep 8, 2015 at 10:26 AM, John McCall wrote:
> On Sep 8, 2015, at 8:25 AM, David Blaikie wrote:
> On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rjmccall
>> Date: Tue Sep 8 04:18:30 2015
>> New Revision: 246991
>>
>> URL: h
or this, or to expose a way to take
> an IR file with debug info and synthesize nice names for as much as we can
> using the debug info?
>
> On Tue, Sep 8, 2015 at 10:47 AM David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Tue, Sep 8, 2015 at
On Tue, Sep 8, 2015 at 3:51 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> rsmith added inline comments.
>
>
> Comment at: lib/CodeGen/CGDebugInfo.cpp:3263-3264
> @@ +3262,4 @@
> + const NamespaceDecl *NSDecl = UD.getNominatedNamespace();
> + if (!NSDec
On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Sep 8 14:20:27 2015
> New Revision: 247049
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247049&view=rev
> Log:
> Module Debugging: Emit debug type information into
On Tue, Sep 8, 2015 at 1:41 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Sep 8 15:41:52 2015
> New Revision: 247068
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247068&view=rev
> Log:
> Module Debugging: Emit debug type information into c
On Wed, Sep 9, 2015 at 9:26 AM, Adrian Prantl wrote:
>
> On Sep 8, 2015, at 8:05 PM, David Blaikie wrote:
>
>
>
> On Tue, Sep 8, 2015 at 12:20 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Tue Sep 8 14:20:27 2015
>> New Revision: 247049
>>
On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mehdi_amini
> Date: Wed Sep 9 15:08:51 2015
> New Revision: 247179
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247179&view=rev
> Log:
> EmitRecordWith* API change: takes an ArrayRef ins
On Wed, Sep 9, 2015 at 1:28 PM, Mehdi Amini wrote:
> Hi David,
>
> Thanks for the review.
>
>
> On Sep 9, 2015, at 1:14 PM, David Blaikie wrote:
>
>
>
> On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: mehdi_amini
>> Date: Wed Sep 9
On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mehdi_amini
> Date: Wed Sep 9 20:46:39 2015
> New Revision: 247233
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247233&view=rev
> Log:
> EmitRecord* API change: accepts ArrayRef instead
On Thu, Sep 10, 2015 at 9:00 AM, Mehdi Amini wrote:
>
> On Sep 9, 2015, at 7:06 PM, David Blaikie wrote:
>
>
>
> On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: mehdi_amini
>> Date: Wed Sep 9 20:46:39 2015
>> New Revision: 247233
>
On Thu, Sep 10, 2015 at 9:07 AM, Mehdi Amini wrote:
>
> On Sep 10, 2015, at 9:02 AM, David Blaikie wrote:
>
>
>
> On Thu, Sep 10, 2015 at 9:00 AM, Mehdi Amini
> wrote:
>
>>
>> On Sep 9, 2015, at 7:06 PM, David Blaikie wrote:
>>
>>
>>
>> On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commi
On Thu, Sep 10, 2015 at 10:13 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Thu Sep 10 12:13:31 2015
> New Revision: 247303
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247303&view=rev
> Log:
> Debug Info: Remove an unnecessary debug type visit
On Thu, Sep 10, 2015 at 10:18 AM, David Blaikie wrote:
>
>
> On Thu, Sep 10, 2015 at 10:13 AM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Thu Sep 10 12:13:31 2015
>> New Revision: 247303
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=2473
On Thu, Sep 10, 2015 at 10:25 AM, Adrian Prantl wrote:
>
> On Sep 10, 2015, at 10:19 AM, David Blaikie wrote:
>
>
>
> On Thu, Sep 10, 2015 at 10:18 AM, David Blaikie
> wrote:
>
>>
>>
>> On Thu, Sep 10, 2015 at 10:13 AM, Adrian Prantl via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>
On Thu, Sep 10, 2015 at 11:39 AM, Richard Smith
wrote:
> On Thu, Sep 10, 2015 at 9:13 AM, David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>>
>>
>> On Thu, Sep 10, 2015 at 9:07 AM, Mehdi Amini
>> wrote:
>>
>>>
On Thu, Sep 10, 2015 at 1:34 PM, Richard Smith
wrote:
> On Thu, Sep 10, 2015 at 11:46 AM, David Blaikie
> wrote:
>
>>
>>
>> On Thu, Sep 10, 2015 at 11:39 AM, Richard Smith
>> wrote:
>>
>>> On Thu, Sep 10, 2015 at 9:13 AM, David Blaikie via cfe
On Thu, Sep 10, 2015 at 11:39 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Thu Sep 10 13:39:45 2015
> New Revision: 247319
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247319&view=rev
> Log:
> Add a getDeclContextDescriptor() helper function t
On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Thu Sep 10 20:03:26 2015
> New Revision: 247369
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247369&view=rev
> Log:
> Module Debugging: Emit forward declarations for typ
On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie wrote:
>
>
> On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Thu Sep 10 20:03:26 2015
>> New Revision: 247369
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=247369
Author: dblaikie
Date: Thu Sep 10 22:22:18 2015
New Revision: 247380
URL: http://llvm.org/viewvc/llvm-project?rev=247380&view=rev
Log:
[opaque pointer type] update test cases for explicit pointee types on global
aliases
Modified:
cfe/trunk/test/CodeGen/alias.c
cfe/trunk/test/CodeGen/attr
On Fri, Sep 11, 2015 at 8:18 AM, Adrian Prantl wrote:
>
> On Sep 10, 2015, at 6:56 PM, David Blaikie wrote:
>
>
>
> On Thu, Sep 10, 2015 at 6:40 PM, David Blaikie wrote:
>
>>
>>
>> On Thu, Sep 10, 2015 at 6:03 PM, Adrian Prantl via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Auth
On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Fri Sep 11 12:23:08 2015
> New Revision: 247432
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247432&view=rev
> Log:
> Module Debugging: Emit forward declarations for ty
On Fri, Sep 11, 2015 at 11:55 AM, Adrian Prantl wrote:
>
> On Sep 11, 2015, at 11:21 AM, David Blaikie wrote:
>
>
>
> On Fri, Sep 11, 2015 at 10:23 AM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Fri Sep 11 12:23:08 2015
>> New Revision: 2474
On Fri, Sep 11, 2015 at 11:54 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Fri Sep 11 13:54:28 2015
> New Revision: 247447
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247447&view=rev
> Log:
> Remove a redundant check from CGDebugInfo::shouldO
Author: dblaikie
Date: Mon Sep 14 13:02:04 2015
New Revision: 247586
URL: http://llvm.org/viewvc/llvm-project?rev=247586&view=rev
Log:
Revert "[opaque pointer type] update for LLVM API change"
This was the wrong direction to take anyway (because ultimately the
GlobalValue needed the pointee type
Author: dblaikie
Date: Mon Sep 14 13:38:22 2015
New Revision: 247593
URL: http://llvm.org/viewvc/llvm-project?rev=247593&view=rev
Log:
[opaque pointer type] Fix a few uses of PointerType::getElementType in favor of
uses of types already available elsewhere
These are a few cleanups I happened to
On Thu, Sep 17, 2015 at 1:25 PM, Douglas Katzman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dougk
> Date: Thu Sep 17 15:25:09 2015
> New Revision: 247932
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247932&view=rev
> Log:
> Try to unbreak windows compiler after r247926.
>
>
On Fri, Sep 18, 2015 at 4:01 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Fri Sep 18 18:01:45 2015
> New Revision: 248062
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248062&view=rev
> Log:
> CGDebugInfo: Make creating a skeleton CU in getOrCr
On Fri, Sep 18, 2015 at 5:10 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Fri Sep 18 19:10:32 2015
> New Revision: 248069
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248069&view=rev
> Log:
> Refactor ASTReader::getSourceDescriptor(const Modul
On Fri, Sep 18, 2015 at 5:45 PM, Adrian Prantl wrote:
>
> On Sep 18, 2015, at 5:11 PM, David Blaikie wrote:
>
>
>
> On Fri, Sep 18, 2015 at 4:01 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Fri Sep 18 18:01:45 2015
>> New Revision: 248062
On Mon, Sep 21, 2015 at 10:48 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Mon Sep 21 12:48:37 2015
> New Revision: 248184
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248184&view=rev
> Log:
> Debug Info: When building a module, emit skeleton
On Mon, Sep 21, 2015 at 11:18 AM, Adrian Prantl wrote:
>
> On Sep 21, 2015, at 10:59 AM, David Blaikie wrote:
>
>
>
> On Mon, Sep 21, 2015 at 10:48 AM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Mon Sep 21 12:48:37 2015
>> New Revision: 2481
On Mon, Sep 21, 2015 at 12:25 PM, Adrian Prantl wrote:
>
> On Sep 21, 2015, at 11:25 AM, David Blaikie wrote:
>
>
>
> On Mon, Sep 21, 2015 at 11:18 AM, Adrian Prantl wrote:
>
>>
>> On Sep 21, 2015, at 10:59 AM, David Blaikie wrote:
>>
>>
>>
>> On Mon, Sep 21, 2015 at 10:48 AM, Adrian Prantl vi
dblaikie added a subscriber: dblaikie.
dblaikie added a comment.
I'd still be curious to see a stronger justification from the standard
about this.
I know you mentioned/quoted the definition of ~unique_ptr in the standard -
but I'm not sure that is meant to imply observable behavior during
destru
On Tue, Sep 22, 2015 at 5:26 PM, Daniel Cheng via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> dcheng added a comment.
>
> In http://reviews.llvm.org/D13080#251324, @dblaikie wrote:
>
> > I'd still be curious to see a stronger justification from the standard
> > about this.
> >
> > I know y
On Sat, Sep 26, 2015 at 8:44 PM, Craig Topper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ctopper
> Date: Sat Sep 26 22:44:08 2015
> New Revision: 248678
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248678&view=rev
> Log:
> Use llvm::makeArrayRef. NFC.
>
> Modified:
> cf
On Sat, Sep 26, 2015 at 11:21 PM, Manuel Klimek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Yep. We'll make it better by limiting the size, but trivially copyable is
> an improvement, as there are orders of magnitude more loops over small
> copyable types than over large ones.
>
We see
Author: dblaikie
Date: Mon Sep 28 18:48:55 2015
New Revision: 248761
URL: http://llvm.org/viewvc/llvm-project?rev=248761&view=rev
Log:
Remove the only use of LookupResult's implicit copy ctor
LookupResult should not be copyable, it's not readily copyable and can
only be copied when it's in specif
Author: dblaikie
Date: Mon Sep 28 18:48:52 2015
New Revision: 248760
URL: http://llvm.org/viewvc/llvm-project?rev=248760&view=rev
Log:
Add an explicitly defaulted copy ctor (and FIXME) to Command since its copy
ctor is currently used (and actually slices derived objects... ) in some
diagnostics
Author: dblaikie
Date: Mon Sep 28 18:48:49 2015
New Revision: 248759
URL: http://llvm.org/viewvc/llvm-project?rev=248759&view=rev
Log:
Remove trivial dtor that was making uses of the copy ctor -Wdeprecated unclean
And also remove an unused variable that's now diagnosed by
-Wunused-variable since
On Tue, Sep 29, 2015 at 1:44 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Tue Sep 29 15:44:46 2015
> New Revision: 248826
>
> URL: http://llvm.org/viewvc/llvm-project?rev=248826&view=rev
> Log:
> CGDebugInfo: Don't reuse a reference into a DenseMa
On Tue, Sep 29, 2015 at 4:01 PM, Adrian Prantl wrote:
>
> On Sep 29, 2015, at 3:52 PM, David Blaikie wrote:
>
>
>
> On Tue, Sep 29, 2015 at 1:44 PM, Adrian Prantl via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: adrian
>> Date: Tue Sep 29 15:44:46 2015
>> New Revision: 248826
On Fri, Oct 2, 2015 at 6:10 AM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Oct 1, 2015 at 5:18 PM, Richard Trieu wrote:
> > I'm in favor of keeping the asserts around. Several times, I've seen
> Clang
> > crashers than languish in the bug tracker with an assert
This seems a little curious, so you'll have code like this:
decl foo
module
def bar
member foo pointer (references the declaration of foo outside the
module, in the CU?)
Why is that preferable to DWARF that looks more like the AST where the
declaration of foo appears in the first m
On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote:
>
> On Oct 2, 2015, at 2:18 PM, David Blaikie wrote:
>
> This seems a little curious, so you'll have code like this:
>
> decl foo
> module
> def bar
>member foo pointer (references the declaration of foo outside the
> module, i
On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote:
>
> On Oct 2, 2015, at 2:58 PM, David Blaikie wrote:
>
>
>
> On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote:
>
>>
>> On Oct 2, 2015, at 2:18 PM, David Blaikie wrote:
>>
>> This seems a little curious, so you'll have code like this:
>>
>
On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote:
>
> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote:
>
>
>
> On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote:
>
>>
>> On Oct 2, 2015, at 2:58 PM, David Blaikie wrote:
>>
>>
>>
>> On Fri, Oct 2, 2015 at 2:40 PM, Adrian Prantl wrote:
>>
>
On Mon, Oct 5, 2015 at 8:37 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> aprantl added a comment.
>
> Some bikeshedding about -di-kind={full|limited|line-tables}:
>
> 1. Is there a good reason not to spell out -debug-info-kind?
> 2. "full" is misleading as it will still
On Mon, Oct 5, 2015 at 8:55 AM, Adrian Prantl wrote:
>
> On Oct 2, 2015, at 3:24 PM, David Blaikie wrote:
>
>
>
> On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote:
>
>>
>> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote:
>>
>>
>>
>> On Fri, Oct 2, 2015 at 3:00 PM, Adrian Prantl wrote:
>>
>
On Mon, Oct 5, 2015 at 11:37 AM, David Blaikie wrote:
>
>
> On Mon, Oct 5, 2015 at 8:55 AM, Adrian Prantl wrote:
>
>>
>> On Oct 2, 2015, at 3:24 PM, David Blaikie wrote:
>>
>>
>>
>> On Fri, Oct 2, 2015 at 3:21 PM, Adrian Prantl wrote:
>>
>>>
>>> On Oct 2, 2015, at 3:01 PM, David Blaikie wrote
On Mon, Oct 5, 2015 at 10:41 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Mon Oct 5 12:41:16 2015
> New Revision: 249328
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249328&view=rev
> Log:
> Undo the unique_ptr'fication of CodeGenABITypes::CG
Oops, forgot to reply-all. Sorry Adrian.
-- Forwarded message --
From: David Blaikie
Date: Mon, Oct 5, 2015 at 11:45 AM
Subject: Re: r249328 - Undo the unique_ptr'fication of CodeGenABITypes::CGM
introduced in r248762.
To: Adrian Prantl
On Mon, Oct 5, 2015 at 11:43 AM, David
On Mon, Oct 5, 2015 at 11:54 AM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Mon Oct 5 13:54:30 2015
> New Revision: 249336
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249336&view=rev
> Log:
> Re-introduce the unique_ptr removed in r249328 and
On Tue, Oct 6, 2015 at 8:04 AM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Tue Oct 6 10:04:13 2015
> New Revision: 249413
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249413&view=rev
> Log:
> [Tooling] Don't run a tool invocation without a FileM
dblaikie added a subscriber: dblaikie.
dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
This revision is now accepted and ready to land.
Comment at: test/Driver/clang-g-opts.c:33
@@ -22,5 +32,3 @@
-// CHECK-WITHOUT-G-NOT: "-g"
-// CHECK-WITH-G: "-g"
-// CHEC
Which compiler do we support that didn't accept this? I thought we'd
already grown a few uses of initializer lists like this...
On Aug 11, 2015 5:13 AM, "Manuel Klimek via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: klimek
> Date: Tue Aug 11 07:13:15 2015
> New Revision: 244596
>
>
Unsupported (which compiler(s)?) or just not preferred?
On Aug 11, 2015 6:00 AM, "Manuel Klimek via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: klimek
> Date: Tue Aug 11 07:59:22 2015
> New Revision: 244597
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244597&view=rev
> Log:
> D
Rightio - good to know. Thanks!
On Tue, Aug 11, 2015 at 8:08 AM, Manuel Klimek wrote:
> Don't remember which bot it was; the message said something about an
> explicit constructor being called for std::map
>
> On Tue, Aug 11, 2015 at 5:00 PM David Blaikie wrote:
>
>> Which compiler do we suppor
On Tue, Aug 11, 2015 at 8:46 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Can't you just change your signature to
>
> virtual void a(int /* x */) {}
>
> in these cases?
>
You could - does it add much value to do that, though? (perhaps it does -
it means you express the
Author: dblaikie
Date: Tue Aug 11 15:21:45 2015
New Revision: 244658
URL: http://llvm.org/viewvc/llvm-project?rev=244658&view=rev
Log:
Revert the diagnostic improvements in r244602 as they introduced a problematic
dependency
Seems we had some internal uses that include ClangTidyTest.h and weren'
On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber wrote:
> On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki <
> daniel.marjam...@evidente.se> wrote:
>
>>
>> ideally there should be no -Wunused-parameter compiler warning when the
>> parameter is used.
>>
>> would it feel better to move the "FP" warni
On Wed, Aug 12, 2015 at 11:12 AM, Nico Weber wrote:
> On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie
> wrote:
>
>>
>>
>> On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber wrote:
>>
>>> On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki <
>>> daniel.marjam...@evidente.se> wrote:
>>>
ideall
On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Wed Aug 12 14:00:39 2015
> New Revision: 244792
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244792&view=rev
> Log:
> RangRangify some more for loops; NFC.
>
> Mo
On Wed, Aug 12, 2015 at 1:03 PM, Aaron Ballman
wrote:
> On Wed, Aug 12, 2015 at 3:37 PM, David Blaikie wrote:
> >
> >
> > On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits
> > wrote:
> >>
> >> Author: aaronballman
> >> Date: Wed Aug 12 14:00:39 2015
> >> New Revision: 244792
> >>
(switching over to the new mailing list)
On Wed, Aug 12, 2015 at 3:09 PM, David Blaikie wrote:
>
>
> On Tue, Oct 21, 2014 at 10:24 AM, Justin Bogner
> wrote:
>
>> Author: bogner
>> Date: Tue Oct 21 12:24:44 2014
>> New Revision: 220305
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=220305&v
On Wed, Aug 12, 2015 at 3:17 PM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Wed, Aug 12, 2015 at 6:07 PM, Naomi Musgrave via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: nmusgrave
>> Date: Wed Aug 12 17:07:24 2015
>> New Revision: 244820
>>
>> U
Author: dblaikie
Date: Wed Aug 12 17:58:10 2015
New Revision: 244826
URL: http://llvm.org/viewvc/llvm-project?rev=244826&view=rev
Log:
-Wdeprecated: SavedInstanceContext is returned by value but isn't really
copyable, but it can be made movable
Modified:
cfe/trunk/lib/Sema/SemaAccess.cpp
Mo
Author: dblaikie
Date: Wed Aug 12 18:09:24 2015
New Revision: 244829
URL: http://llvm.org/viewvc/llvm-project?rev=244829&view=rev
Log:
-Wdeprecated: Job objects are stored in a vector yet are not really copyable,
make them movable instead
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modifie
Author: dblaikie
Date: Wed Aug 12 18:16:55 2015
New Revision: 244831
URL: http://llvm.org/viewvc/llvm-project?rev=244831&view=rev
Log:
Wdeprecated: CGBuilderInserter is copy constructed in some contexts - remove
the unnecessarily disabling copy assignment to enable this
The object has very simpl
Author: dblaikie
Date: Wed Aug 12 18:49:57 2015
New Revision: 244838
URL: http://llvm.org/viewvc/llvm-project?rev=244838&view=rev
Log:
Wdeprecated: ApplyDebugLocation is returned by value yet if it is ever copied
(rather than RVO'd) that would be broken, make it movable instead
Modified:
cfe
Author: dblaikie
Date: Wed Aug 12 18:59:02 2015
New Revision: 244843
URL: http://llvm.org/viewvc/llvm-project?rev=244843&view=rev
Log:
Wdeprecated: LambdaScopeInfos need to be copied, so make the ScopeInfo
hierarchy safely copyable
Making the base class's copy ctor protected and the derived clas
Author: dblaikie
Date: Thu Aug 13 16:15:23 2015
New Revision: 244956
URL: http://llvm.org/viewvc/llvm-project?rev=244956&view=rev
Log:
Wdeprecated: Replace deprecated throw() with LLVM_NOEXCEPT which expands to
'noexcept' where available (and throw() otherwise)
Modified:
cfe/trunk/include/cl
Author: dblaikie
Date: Thu Aug 13 16:23:08 2015
New Revision: 244957
URL: http://llvm.org/viewvc/llvm-project?rev=244957&view=rev
Log:
Wdeprecated: LambdaScopeInfos are copied in TreeTransform, so make sure they're
copyable.
Partly addressed by r244843, but the explicit dtor in LambdaScopeInfo
w
Author: dblaikie
Date: Thu Aug 13 16:24:08 2015
New Revision: 244958
URL: http://llvm.org/viewvc/llvm-project?rev=244958&view=rev
Log:
Wdeprecated: CommentVerifiers are returned by value, make sure they're
correctly copy/moveable
Modified:
cfe/trunk/unittests/Tooling/CommentHandlerTest.cpp
Author: dblaikie
Date: Thu Aug 13 17:12:21 2015
New Revision: 244968
URL: http://llvm.org/viewvc/llvm-project?rev=244968&view=rev
Log:
Wdeprecated: Make BumpVectorContext movable
Turns out the one place that relied on the implicit copy ctor was safe
because it created an object in a state where t
Author: dblaikie
Date: Thu Aug 13 17:20:14 2015
New Revision: 244971
URL: http://llvm.org/viewvc/llvm-project?rev=244971&view=rev
Log:
Wdeprecated: StoredDiagnostics are stored in a SmallVector, so make sure
they're copy/movable
Removing the no-op dtor makes these objects safely implicitly
copya
Author: dblaikie
Date: Thu Aug 13 17:23:53 2015
New Revision: 244973
URL: http://llvm.org/viewvc/llvm-project?rev=244973&view=rev
Log:
Wdeprecated: PathPieces are copied, make them safely implicitly copyable by
removing the unnecessary user declared dtor.
Modified:
cfe/trunk/include/clang/St
Author: dblaikie
Date: Thu Aug 13 17:33:24 2015
New Revision: 244974
URL: http://llvm.org/viewvc/llvm-project?rev=244974&view=rev
Log:
Wdeprecated: RegionBindingsRef are copy constructed, make sure that's safe by
removing the unnecessary user-declared copy assignment operator
The user-defined co
Author: dblaikie
Date: Thu Aug 13 17:50:09 2015
New Revision: 244975
URL: http://llvm.org/viewvc/llvm-project?rev=244975&view=rev
Log:
Wdeprecated: CollectReachableSymbolsCallback are move constructed/returned by
value, so make sure they're copy/moveable
(return by value is in ExprEngine::proces
801 - 900 of 1480 matches
Mail list logo
