xbolva00 added a comment.
Thanks, this warning is really annoying.
Repository:
rC Clang
https://reviews.llvm.org/D50448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 145740.
Herald added a subscriber: cfe-commits.
Repository:
rCXX libc++
https://reviews.llvm.org/D46593
Files:
include/experimental/filesystem
Index: include/experimental/filesystem
===
-
xbolva00 updated this revision to Diff 145742.
Herald added a subscriber: christof.
https://reviews.llvm.org/D46593
Files:
libcxx/trunk/include/experimental/filesystem
Index: libcxx/trunk/include/experimental/filesystem
===
--- l
xbolva00 updated this revision to Diff 145745.
xbolva00 added a comment.
Can anybody give me advice from where to generate patch? I do it from libcxx.
https://reviews.llvm.org/D46593
Files:
include/experimental/filesystem
Index: include/experimental/filesystem
==
xbolva00 added a comment.
In https://reviews.llvm.org/D46593#1091732, @smeenai wrote:
> Generating the patch from libc++ is fine (and this patch looks like it has
> sane paths).
Thank you
https://reviews.llvm.org/D46593
___
cfe-commits mailing l
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX331910: Allow copy elision in path concatenation (authored
by xbolva00, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D46593
Files:
include/experimental/filesystem
Index: incl
xbolva00 added a comment.
Ping @jwakely
Repository:
rCXX libc++
https://reviews.llvm.org/D46593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added inline comments.
Comment at: clang/include/clang/AST/DeclCXX.h:778
+ bool mayBeDynamicClass() const {
+return !isCompleteDefinition() || isDynamicClass();
maybeDynamicClass?
https://github.com/llvm-mirror/llvm/search?utf8=%E2%9C%93&q=maybe&
xbolva00 added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingStringPointerChecker.cpp:29
+
+class DanglingStringPointerChecker : public Checker {
+ CallDescription CStrFn;
george.karpenkov wrote:
> "string" is a bit ambiguous, if this checker
xbolva00 created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
ClangDiagnosticsEmitter.cpp:1047:57: warning: this statement may fall through
[-Wimplicit-fallthrough=]
Builder.PrintFatalError("Unknown modifier type: " + Modifier);
xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
xbolva00 updated this revision to Diff 148523.
xbolva00 added a comment.
Add correct NORETURN attribute
https://reviews.llvm.org/D47340
Files:
utils/TableGen/ClangDiagnosticsEmitter.cpp
Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===
xbolva00 added inline comments.
Comment at: lib/Sema/Scope.cpp:128
- if (getEntity())
-return;
-
- if (NRVO.getInt())
-getParent()->setNoNRVO();
- else if (NRVO.getPointer())
-getParent()->addNRVOCandidate(NRVO.getPointer());
+ if (getParent())
+getParent()-
xbolva00 added a comment.
Ok?
https://reviews.llvm.org/D47340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL40: [ClangDiagnostics] Silence warning about fallthrough
after PrintFatalError (authored by xbolva00, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rC40: [ClangDiagnostics] Silence warning about fallthrough
after PrintFatalError (authored by xbolva00, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47340
Files:
utils/TableGen/Cl
xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Select
xbolva00 added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:33
+public:
+ DanglingInternalBufferChecker() : CStrFn("c_str") {}
+
string.data() support?
https://reviews.llvm.org/D47135
___
xbolva00 added inline comments.
Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:1261
+
+ for (ConstraintRangeTy::iterator I = CR.begin(), E = CR.end(); I != E; ++I) {
+SymbolRef Sym = I.getKey();
for (auto I : CR)?
https://reviews.llvm.org/D455
xbolva00 added inline comments.
Comment at: llvm/include/llvm/Support/Allocator.h:295
+int64_t TotalSlabOffset = 0;
+for (size_t Idx = 0; Idx < Slabs.size(); Idx++) {
+ const char *S = reinterpret_cast(Slabs[Idx]);
for (size_t Idx = 0, e = Slabs.size
xbolva00 added subscribers: hans, xbolva00.
xbolva00 added a comment.
is this fixed in 7.0 release branch too?
@hans
Repository:
rCXX libc++
https://reviews.llvm.org/D50534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
xbolva00 created this revision.
xbolva00 added a reviewer: zturner.
Herald added a subscriber: cfe-commits.
Before:
main.o: main.c ../include/lib\test.h
After:
main.o: main.c ../include/lib/test.h
Repository:
rC Clang
https://reviews.llvm.org/D51847
Files:
lib/Frontend/DependencyFile.cpp
xbolva00 updated this revision to Diff 164620.
xbolva00 added a comment.
Remove some dead code
https://reviews.llvm.org/D51847
Files:
lib/Frontend/DependencyFile.cpp
Index: lib/Frontend/DependencyFile.cpp
===
--- lib/Frontend/D
xbolva00 added a comment.
In https://reviews.llvm.org/D51847#1228927, @zturner wrote:
> What prints this? How do you exercise this codepath?
DFGImpl::OutputDependencyFile() -> for (StringRef File : Files)
https://reviews.llvm.org/D51847
___
cfe-c
xbolva00 added a comment.
Please see PR38877.
https://reviews.llvm.org/D51847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
In https://reviews.llvm.org/D51847#1230766, @zturner wrote:
> Alright I see it. The reason I'm asking is because after your change you're
> now printing `main.o: main.c ../include/lib/test.h`. But I wonder if you
> should instead be printing `main.o: main.c ..\includ
xbolva00 updated this revision to Diff 165012.
xbolva00 added a comment.
Convert paths to platform native paths
https://reviews.llvm.org/D51847
Files:
lib/Frontend/DependencyFile.cpp
Index: lib/Frontend/DependencyFile.cpp
===
-
xbolva00 updated this revision to Diff 165052.
xbolva00 added a comment.
- Fixed failing test
https://reviews.llvm.org/D51847
Files:
lib/Frontend/DependencyFile.cpp
test/Frontend/dependency-gen-escaping.c
Index: test/Frontend/dependency-gen-escaping.c
=
xbolva00 updated this revision to Diff 165204.
xbolva00 added a comment.
Adjusted regexes in two more tests
https://reviews.llvm.org/D51847
Files:
lib/Frontend/DependencyFile.cpp
test/Frontend/dependency-gen-escaping.c
test/Frontend/dependency-gen.c
test/Modules/relative-dep-gen.cpp
In
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342139: Print correctly dependency paths on Windows
(authored by xbolva00, committed by ).
Repository:
rC Clang
https:
xbolva00 added a comment.
Where here, I would love to have a fixint hints for unknown functions.
E.g.
std::forward somewhere in code-> fixit: "try to add #include "
https://reviews.llvm.org/D51333
___
cfe-commits mailing list
cfe-commits@lists.llvm
xbolva00 added a comment.
Yeah, it would be super useful if Clang can add const to all places where
possible :) love this work, great!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
___
cfe-commits mailing list
cfe-commits@li
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338385: [RISCV] Add driver for riscv32-unknown-elf baremetal
target (authored by xbolva00, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46822
Files:
lib/Driver/CMakeLists.txt
lib
xbolva00 added a comment.
In https://reviews.llvm.org/D46822#1183007, @efriedma wrote:
> Please don't commit patches on behalf of someone else if the author hasn't
> specifically requested it. There might be some issue which the author forgot
> to note on the review.
Oh, ok.
Repository:
xbolva00 added a comment.
Nico Webber (cfe-commits)
"I'm getting this warning from the mac linker after this commit:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool:
warning same member name (libclangDriver.RISCV.o) in output file used for
input f
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338971: Fix tests for changed opt remarks format (authored
by xbolva00, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50241
Files:
test/CodeG
xbolva00 added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:28
+ * For now: Only local variables are considered. Globals/namespace variables,
+ * paramters and class members are not analyzed.
+ * Parameters have a check already: readability-non-const-p
xbolva00 added a comment.
Thanks! Happy to see it is more powerful now :)
https://reviews.llvm.org/D45050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
memcpy(crypt_buf, passwd, passwd_len); <--- warning
memcpy(crypt_buf + passwd_len, salt, salt_len);
This is a false warning since it appends strings using memcpy. But no idea what
to do and if it is possible to avoid these false warnings.
https://reviews.llvm.org/D450
xbolva00 added a comment.
In https://reviews.llvm.org/D45050#1116396, @Charusso wrote:
> In https://reviews.llvm.org/D45050#1116361, @xbolva00 wrote:
>
> > memcpy(crypt_buf, passwd, passwd_len); <--- warning
> > memcpy(crypt_buf + passwd_len, salt, salt_len);
> >
> > This is a false warning sinc
xbolva00 added a comment.
Ping
https://reviews.llvm.org/D34796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 accepted this revision.
xbolva00 added a comment.
Looks fine, awesome feature!
https://reviews.llvm.org/D47135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
In https://reviews.llvm.org/D45050#1119973, @Charusso wrote:
> In https://reviews.llvm.org/D45050#1116446, @lebedev.ri wrote:
>
> > I would like to see more negative tests.
> > What does it do if the len/size is a constant?
> > Variable that wasn't just assigned with `
xbolva00 added a comment.
Ping
https://reviews.llvm.org/D47135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
In https://reviews.llvm.org/D47894#1125653, @efriedma wrote:
> The problem would come from propagating nonnull-ness from something which
> isn't inherently nonnull. For example, strlen has a nonnull argument, so
> `strlen(NULL)` is UB, therefore given `int z = strlen(
xbolva00 added a comment.
ping
https://reviews.llvm.org/D52949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
In https://reviews.llvm.org/D52949#1259947, @jfb wrote:
> Can you add tests with arrays?
Yes :)
> The error message doesn't really say what to do instead. What's wrong? What's
> correct instead?
What do you suggest? "division produces the incorrect number of array e
xbolva00 added a comment.
Any comments? Waiting for approval here to move focus on some other patches :)
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10874
+ if (Target->isSpecificBuiltinType(BuiltinType::LongDouble))
+FloatSem = &llvm::APFloat::x87DoubleExtended();
+
efriedma wrote:
> ASTContext::getFloatTypeSemantics. (Your e
xbolva00 updated this revision to Diff 169162.
xbolva00 added a comment.
- Addressed comments
https://reviews.llvm.org/D52835
Files:
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
test/Sema/impcast-integer-float.c
Index: test/Sema/impcast-integer-float.c
=
xbolva00 added a comment.
@Rakete plesse take a look :)
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
Thanks!
But I think I need to change EvaluateForOverflow method to return bool to
indicate overflowing.
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
xbolva00 added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10881-10882
+S.DiagRuntimeBehavior(
+E->getExprLoc(), E,
+S.PDiag(diag::warn_impcast_literal_float_to_integer)
+<< E->getType() << T << PrettySourceValue << Prett
xbolva00 added a comment.
In https://reviews.llvm.org/D52750#1261746, @Rakete wrote:
> Nah, you don't even need to call `EvaluateForOverflow` I believe. :) Have a
> look overflow evaluation is done.
Well..
if (!getLangOpts().CPlusPlus11 && E->isIntegerConstantExpr(Context)) {
if (Re
xbolva00 added a comment.
As noted, this in under LiteralConversion (-Wconversion). GCC has it too under
-Wconversion, so I think it is fine as is, or?
@rsmith
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xbolva00 added a comment.
So any suggestions?
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 169407.
xbolva00 added a comment.
- check for overflow when evaluating
https://reviews.llvm.org/D52750
Files:
include/clang/AST/Expr.h
lib/AST/ExprConstant.cpp
lib/Sema/SemaExpr.cpp
test/Sema/integer-overflow.c
Index: test/Sema/integer-overflow.c
xbolva00 updated this revision to Diff 169408.
https://reviews.llvm.org/D52750
Files:
include/clang/AST/Expr.h
lib/AST/ExprConstant.cpp
lib/Sema/SemaExpr.cpp
test/Sema/integer-overflow.c
Index: test/Sema/integer-overflow.c
xbolva00 updated this revision to Diff 169409.
xbolva00 added a comment.
- Undo extra newline
https://reviews.llvm.org/D52750
Files:
include/clang/AST/Expr.h
lib/AST/ExprConstant.cpp
lib/Sema/SemaExpr.cpp
test/Sema/integer-overflow.c
Index: test/Sema/integer-overflow.c
===
xbolva00 added a comment.
In https://reviews.llvm.org/D52750#1263461, @Rakete wrote:
> This doesn't produce a warning in C++11 and up.
But see Richard's comment: https://reviews.llvm.org/D52750#1251759
https://reviews.llvm.org/D52750
___
cfe-
xbolva00 added a comment.
That's fine :) btw, thanks for review comments!
Hopefully, this solution would be now acceptable :)
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
xbolva00 added a comment.
Thanks. ... So anything else to be done? Or it is ok?
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 169567.
xbolva00 added a comment.
- New diagnostic group
https://reviews.llvm.org/D52835
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
Index: test/S
xbolva00 added a comment.
Libc++ fs works on Windows now?
https://reviews.llvm.org/D51868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 169881.
xbolva00 added a comment.
- Added missing test file
https://reviews.llvm.org/D52835
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
test/Sema
xbolva00 added a comment.
Reping :)
https://reviews.llvm.org/D52750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
Is PrecisionConversion acceptable? If not, any suggestions for name?
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
Second thought, I don't think we should recommend std::size here (maybe it
should be okay for clang static analyzers)
uint32_t data[] = {10, 20, 30, 40};
len = sizeof(data)/sizeof(*data); // "warn" on valid code to recommend
std::size? I dont agree with such behaviour.
xbolva00 added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:241
+ case llvm::Triple::thumbeb:
+IsBigEndian = true;
+ case llvm::Triple::arm:
Gnu.cpp:241:17: warning: this statement may fall through
[-Wimplicit-fallthrough=]
IsBigEndian =
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344759: [Diagnostics] Check for integer overflow in array
size expressions (authored by xbolva00, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
xbolva00 added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:241
+ case llvm::Triple::thumbeb:
+IsBigEndian = true;
+ case llvm::Triple::arm:
peter.smith wrote:
> xbolva00 wrote:
> > Gnu.cpp:241:17: warning: this statement may fall through
> >
xbolva00 added a comment.
Ping
https://reviews.llvm.org/D52949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
Ping
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
No warning for your case.
https://reviews.llvm.org/D52949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 170696.
xbolva00 added a comment.
- Added MTC'c case to test file
https://reviews.llvm.org/D52949
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/div-sizeof-ptr.c
Index: tes
xbolva00 created this revision.
Herald added subscribers: cfe-commits, nhaehnle, jvesely.
Repository:
rC Clang
https://reviews.llvm.org/D53666
Files:
test/CodeGen/tbaa-struct.cpp
test/CodeGenOpenCL/amdgpu-nullptr.cl
Index: test/CodeGenOpenCL/amdgpu-nullptr.cl
xbolva00 added inline comments.
Comment at: test/CodeGenOpenCL/amdgpu-nullptr.cl:513
// CHECK-LABEL: test_memset_private
-// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5)* align 8 {{.*}}, i8
0, i64 40, i1 false)
+// CHECK: call void @llvm.memset.p5i8.i64(i8 addrspace(5
xbolva00 updated this revision to Diff 170963.
https://reviews.llvm.org/D53666
Files:
test/CodeGen/tbaa-struct.cpp
Index: test/CodeGen/tbaa-struct.cpp
===
--- test/CodeGen/tbaa-struct.cpp
+++ test/CodeGen/tbaa-struct.cpp
@@ -17,7
xbolva00 added a comment.
ping
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
Ping @MTC or @rsmith
https://reviews.llvm.org/D52949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
Any ideas for better warning message? Except for the warning text, I see this
patch as ready.
https://reviews.llvm.org/D52949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
xbolva00 updated this revision to Diff 171906.
https://reviews.llvm.org/D53666
Files:
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
test/CodeGen/X86/combine-sdiv.ll
test/CodeGen/X86/combine-srem.ll
test/CodeGen/X86/combine-udiv.ll
test/CodeGen/X86/combine-urem.ll
Index: test/CodeGen/X86/com
xbolva00 updated this revision to Diff 171908.
https://reviews.llvm.org/D53666
Files:
test/CodeGen/tbaa-struct.cpp
Index: test/CodeGen/tbaa-struct.cpp
===
--- test/CodeGen/tbaa-struct.cpp
+++ test/CodeGen/tbaa-struct.cpp
@@ -17,7
xbolva00 updated this revision to Diff 171920.
xbolva00 added a reviewer: MTC.
xbolva00 added a comment.
- New warning text, added another test line
https://reviews.llvm.org/D52949
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.
xbolva00 added a comment.
Ping
Anything else to be done here? I would like to finish this patch to work on
other things.
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
xbolva00 added a comment.
Are you still looking at this?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 172117.
xbolva00 marked 5 inline comments as done.
https://reviews.llvm.org/D52949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/div-sizeof-ptr.cpp
Index: test/Sema/div-sizeof-ptr.cpp
===
xbolva00 added a comment.
- Addressed review comments.
We match the GCC behaviour here, except the case:
int b1 = sizeof(int *) / sizeof(int);
But I think it is ok now.
Comment at: lib/Sema/SemaExpr.cpp:8729
+static void DiagnoseDivisionSizeofPointer(Sema &S, Expr *LHS, Exp
xbolva00 added a comment.
maybe @aaron.ballman wants to take a look too
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345847: [Diagnostics] Implement -Wsizeof-pointer-div
(authored by xbolva00, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52949?vs=172117&i
xbolva00 added a comment.
Since I don't think we have any false positives here, maybe it would be useful
to add it to -Wall or -Wextra?
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
xbolva00 updated this revision to Diff 172509.
https://reviews.llvm.org/D52835
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/ext_vector_casts.c
test/Sema/impcast-integer-float.c
Index: test/Sema/impcast-integer-float.c
=
xbolva00 added a comment.
Ping :)
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
@aaron.ballman
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 added a comment.
Since no futher comments, i think it is ok.
After day or two I will commit it.
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346865: [Diagnostics] Check integer to floating point number
implicit conversions (authored by xbolva00, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52835?vs=172509&id=174030#toc
xbolva00 added a comment.
Ok, I will address your comments soon.
Repository:
rC Clang
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xbolva00 updated this revision to Diff 174505.
xbolva00 added a comment.
Addressed comments, fixed tests
https://reviews.llvm.org/D52835
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp
test/CXX/dcl.decl/dcl.i
xbolva00 added a comment.
I removed _Float16 related tests since some bots may fall with it, i dont know
much about this custom type.
Anyway, It is fine on linux x86 64. I will restore them.
System macro - I will fix it.
https://reviews.llvm.org/D52835
_
1 - 100 of 1043 matches
Mail list logo
