xbolva00 added inline comments.
================
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
const std::string &TypeEncoding);
----------------
theraven wrote:
> xbolva00 wrote:
> > theraven wrote:
> > > xbolva00 wrote:
> > > > This causes
> > > > CGObjCGNU.cpp:589:16: warning: ‘virtual llvm::Value*
> > > > {anonymous}::CGObjCGNU::GetSelector(clang::CodeGen::CodeGenFunction&,
> > > > const clang::ObjCMethodDecl*)’ was hidden [-Woverloaded-virtual]
> > > > llvm::Value *GetSelector(CodeGenFunction &CGF,
> > > >
> > > I can't reproduce this, and I'm not sure what the issue is. The two
> > > lines have different overloads, so one shouldn't be hiding the other.
> > It is a warning from GCC 7.2
> Sounds like it's a spurious one. Any idea how to silence it?
Not sure ..
virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel, const
std::string &TypeEncoding); is here
but base class (CGObjCRuntime) has:
virtual llvm::Value * GetSelector (CodeGenFunction &CGF, Selector Sel)=0
Repository:
rC Clang
https://reviews.llvm.org/D46052
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
