[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. charmitro requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Charalampos Mitrodimas Repository: rG LLVM Github Monorepo

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4386128 , @tbaeder wrote: > Can you add a test case for the change? Looks like there's something similar > already in `clang/test/Frontend/absolute-paths.c` Is it possible to use substitutions inside let's say `NORM

[PATCH] D151990: Test for emitIncludeLocation with "-fdiagnostics-absolute-paths"

charmitro created this revision. Herald added a project: All. charmitro requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151990 Files: clang/test/Frontend/absolute-paths-imp

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index: clang/te

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4390279 , @charmitro wrote: > In D151833#4386128 , @tbaeder wrote: > >> Can you add a test case for the change? Looks like there's something similar >> already in `clang/test

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index: clang/te

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > This checks the same thing in both cases, but in

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > charmitro wrote: > > tbaeder wrote: > > > This c

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 527914. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index: clang/te

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added inline comments. Comment at: clang/test/Frontend/absolute-paths.c:6 +// NORMAL: In file included from [[ROOT_ABSOLUTE]]:4: +// ABSOLUTE: In file included from [[ROOT_ABSOLUTE]]:4: tbaeder wrote: > charmitro wrote: > > tbaeder wrote: > > > charmi

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro updated this revision to Diff 528219. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Frontend/absolute-paths-import.h clang/test/Frontend/absolute-paths.c Index: clang/te

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro marked an inline comment as done. charmitro added a comment. In D151833#4395956 , @aaron.ballman wrote: > Do you need someone to commit on your behalf? If so, what name and email > address would you like used for patch attribution? In D1518

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396244 , @cjdb wrote: > Can the commit message have a description please? It's unclear to me why this > is necessary (although I'm sure there's a good reason). Thanks! Done, also check https://github.com/llvm/llvm-

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396426 , @cjdb wrote: > In D151833#4396399 , @charmitro > wrote: > >> In D151833#4396244 , @cjdb wrote: >> >>> Can the commit messa

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro added a comment. In D151833#4396008 , @charmitro wrote: > In D151833#4395956 , @aaron.ballman > wrote: > >> Do you need someone to commit on your behalf? If so, what name and email >> address would you