charmitro added a comment.

In D151833#4396426 <https://reviews.llvm.org/D151833#4396426>, @cjdb wrote:

> In D151833#4396399 <https://reviews.llvm.org/D151833#4396399>, @charmitro 
> wrote:
>
>> In D151833#4396244 <https://reviews.llvm.org/D151833#4396244>, @cjdb wrote:
>>
>>> Can the commit message have a description please? It's unclear to me why 
>>> this is necessary (although I'm sure there's a good reason).
>>
>> Thanks! Done, also check https://github.com/llvm/llvm-project/issues/63026
>
> Nice, thanks! Would you mind adding `Fixes #63026.` somewhere in the commit 
> message? That will auto-close the issue upon merge.

Thanks for pointing that, done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151833/new/

https://reviews.llvm.org/D151833

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to