[clang-tools-extra] [clang-tidy] Add new performance-use-starts-ends-with check (PR #72385)

carlosgalvezp wrote: Apologies for the late reply, need to fix my mail filter so I don't miss the notifications! IMHO either modernize or readability are suitable categories. Performance can vary/be negligible depending on context I suppose? https://github.com/llvm/llvm-project/pull/72385 ___

[clang-tools-extra] Add new check: do not return 0; at the end of main() in C++ (PR #77586)

carlosgalvezp wrote: I agree with the opinions from Aaron And Piotr above - this check does the opposite of readability: it forces people to waste time digging into the Standard to find the quote that says the return is not needed. Could some argumentation be provided as to why this would be

[clang-tools-extra] Add new check: do not return 0; at the end of main() in C++ (PR #77586)

carlosgalvezp wrote: Thanks for understanding @11happy ! As you say the learning experience is invaluable and will be very useful for the next check. All contributions are greatly appreciated :) I can recommend you look into fairly recent issues - older issues may not have been reviewed throu

[clang-tools-extra] [clang-tidy][NFC] Remove unnecessary nullptr check on cast subexpr (PR #85473)

carlosgalvezp wrote: Shouldn't we simply `return`? As you say, the assert is disabled in Release mode. Even if it's enabled, the author if `getSubExpr` may one day decide to remove the assert without possibly knowing all the places that do rely on that assert, leaving the code unprotected. It

[clang] [llvm] [clang-tools-extra] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/80181 Deprecated since clang-tidy 17. The rule DCL21-CPP has been removed from the CERT guidelines, so it does not make sense to keep the check. Fixes #42788 >From fdb65ef4805152ad143a120e343d696f8b08d3db Mon S

[clang] [llvm] [clang-tools-extra] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

carlosgalvezp wrote: The code formatting job seems to produce incorrect changes. https://github.com/llvm/llvm-project/pull/80181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [clang-tidy] Remove cert-dcl21-cpp check (PR #80181)

https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/80181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/80193 …refer-member-init This functionality already exists in cppcoreguidelines-use-default-member-init. It was deprecated from this check in clang-tidy 17. This allows us to fully decouple this check from the

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

@@ -230,139 +197,99 @@ void PreferMemberInitializerCheck::check( updateAssignmentLevel(Field, InitValue, Ctor, AssignedFields); if (!canAdvanceAssignment(AssignedFields[Field])) continue; -const bool IsInDefaultMemberInitializer = -IsUseDefaultMemberIn

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

carlosgalvezp wrote: Thanks for the review! I agree, check names are not the best. It's a bit of a hassle to change them though :/ I will fix the comment about the release notes tonight :+1: https://github.com/llvm/llvm-project/pull/80193 ___ cfe-c

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p… (PR #80193)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/80193 >From bfa4ea36a2695ec8d6ea92db588f91d5c818968a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Wed, 31 Jan 2024 20:25:27 + Sub

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-prefer-member-init (PR #80330)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/80330 This functionality already exists in cppcoreguidelines-use-default-member-init. It was deprecated from this check in clang-tidy 17. This allows us to f

[clang-tools-extra] [clang-tidy] Remove check-specific HeaderFileExtensions and Implement… (PR #80333)

https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/80333 …ationFileExtensions Deprecated since clang-tidy 17. Use the corresponding global options instead. Fixes #61947 >From fbb0837342a566ff928b211cbb418075a7e744fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carl

[clang-tools-extra] [clang-tidy] Remove check-specific HeaderFileExtensions and Implement… (PR #80333)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/80333 >From fbb0837342a566ff928b211cbb418075a7e744fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Thu, 1 Feb 2024 20:00:45 + Subj

[clang-tools-extra] [clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-prefer-member-init (PR #80330)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/80330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] [clang-tidy] Remove check-specific HeaderFileExtensions and Implement… (PR #80333)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/80333 >From b40347c8025b0d5de83453012a76d412c07f54a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Thu, 1 Feb 2024 20:00:45 + Subj

[clang-tools-extra] [clang-tidy] Remove check-specific HeaderFileExtensions and Implement… (PR #80333)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/80333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] b43a2ae - [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

Author: Carlos Galvez Date: 2021-10-26T05:45:25Z New Revision: b43a2aee4ee946d8897880e824f4b09fe4c46143 URL: https://github.com/llvm/llvm-project/commit/b43a2aee4ee946d8897880e824f4b09fe4c46143 DIFF: https://github.com/llvm/llvm-project/commit/b43a2aee4ee946d8897880e824f4b09fe4c46143.diff LOG:

[clang] 7ecec3f - [CUDA] Bump supported CUDA version to 11.5

Author: Carlos Galvez Date: 2021-11-09T08:20:53Z New Revision: 7ecec3f0f5215c99e45d7000c11230ba2f7e421c URL: https://github.com/llvm/llvm-project/commit/7ecec3f0f5215c99e45d7000c11230ba2f7e421c DIFF: https://github.com/llvm/llvm-project/commit/7ecec3f0f5215c99e45d7000c11230ba2f7e421c.diff LOG:

[clang-tools-extra] c3e3c76 - [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

Author: Fabian Wolff Date: 2021-11-15T07:41:35Z New Revision: c3e3c762098e8d425731bb40f3b8b04dac1013f3 URL: https://github.com/llvm/llvm-project/commit/c3e3c762098e8d425731bb40f3b8b04dac1013f3 DIFF: https://github.com/llvm/llvm-project/commit/c3e3c762098e8d425731bb40f3b8b04dac1013f3.diff LOG:

[clang-tools-extra] 9699c0f - [clang-tidy][NFC] Simplify ClangTidyStats

Author: Carlos Galvez Date: 2021-11-16T07:36:05Z New Revision: 9699c0fea3552f687f8357032199890633d58fe2 URL: https://github.com/llvm/llvm-project/commit/9699c0fea3552f687f8357032199890633d58fe2 DIFF: https://github.com/llvm/llvm-project/commit/9699c0fea3552f687f8357032199890633d58fe2.diff LOG:

[clang-tools-extra] 5bbe501 - [clang-tidy] Warn on functional C-style casts

Author: Carlos Galvez Date: 2021-11-30T07:31:17Z New Revision: 5bbe50148f3b515c170be22209395b72890f5b8c URL: https://github.com/llvm/llvm-project/commit/5bbe50148f3b515c170be22209395b72890f5b8c DIFF: https://github.com/llvm/llvm-project/commit/5bbe50148f3b515c170be22209395b72890f5b8c.diff LOG:

[clang-tools-extra] 946eb7a - [clang-tidy][NFC] Move CachedGlobList to GlobList.h

Author: Carlos Galvez Date: 2021-12-04T08:50:49Z New Revision: 946eb7a037d5f83ea9cdc99bac0f939ddd344e09 URL: https://github.com/llvm/llvm-project/commit/946eb7a037d5f83ea9cdc99bac0f939ddd344e09 DIFF: https://github.com/llvm/llvm-project/commit/946eb7a037d5f83ea9cdc99bac0f939ddd344e09.diff LOG:

[clang-tools-extra] 9ae5896 - [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

Author: Carlos Galvez Date: 2022-08-11T07:46:04Z New Revision: 9ae5896d9673a54f4a6cf656624891bafc192857 URL: https://github.com/llvm/llvm-project/commit/9ae5896d9673a54f4a6cf656624891bafc192857 DIFF: https://github.com/llvm/llvm-project/commit/9ae5896d9673a54f4a6cf656624891bafc192857.diff LOG:

[clang-tools-extra] 3fd4213 - [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

Author: Carlos Galvez Date: 2022-08-19T08:26:34Z New Revision: 3fd4213059a4ea9453809aeccd1bfc7d115d24b2 URL: https://github.com/llvm/llvm-project/commit/3fd4213059a4ea9453809aeccd1bfc7d115d24b2 DIFF: https://github.com/llvm/llvm-project/commit/3fd4213059a4ea9453809aeccd1bfc7d115d24b2.diff LOG:

[clang-tools-extra] 1ae33bf - [clang-tidy] Add cppcoreguidelines-avoid-do-while check

Author: Carlos Galvez Date: 2022-10-10T07:29:17Z New Revision: 1ae33bf42680b156fe0f5cd6163bf24ef45d8cd3 URL: https://github.com/llvm/llvm-project/commit/1ae33bf42680b156fe0f5cd6163bf24ef45d8cd3 DIFF: https://github.com/llvm/llvm-project/commit/1ae33bf42680b156fe0f5cd6163bf24ef45d8cd3.diff LOG:

[clang-tools-extra] bf452f9 - [clang-tidy][NFC] Replace custom isStatic matcher with the existing isStaticStorageClass

Author: Carlos Galvez Date: 2022-12-19T15:23:50Z New Revision: bf452f9b347aa0e1f8f368da925b8e1ca27df0c5 URL: https://github.com/llvm/llvm-project/commit/bf452f9b347aa0e1f8f368da925b8e1ca27df0c5 DIFF: https://github.com/llvm/llvm-project/commit/bf452f9b347aa0e1f8f368da925b8e1ca27df0c5.diff LOG:

[clang] 125ccd3 - [ASTMatchers] Add isInAnonymousNamespace narrowing matcher

Author: Carlos Galvez Date: 2022-12-23T07:39:03Z New Revision: 125ccd3751472a0c709498f83671577ffed394a6 URL: https://github.com/llvm/llvm-project/commit/125ccd3751472a0c709498f83671577ffed394a6 DIFF: https://github.com/llvm/llvm-project/commit/125ccd3751472a0c709498f83671577ffed394a6.diff LOG:

[clang-tools-extra] e82dd5b - [clang-tidy][NFC] Remove custom isInAnonymousNamespace matchers

Author: Carlos Galvez Date: 2022-12-23T08:54:48Z New Revision: e82dd5b37c7d6ccd67c5118fe7400c6006e67d73 URL: https://github.com/llvm/llvm-project/commit/e82dd5b37c7d6ccd67c5118fe7400c6006e67d73 DIFF: https://github.com/llvm/llvm-project/commit/e82dd5b37c7d6ccd67c5118fe7400c6006e67d73.diff LOG:

[clang-tools-extra] b06b248 - [clang-tidy] Implement CppCoreGuideline CP.53

Author: Chris Cotter Date: 2023-01-05T13:57:22Z New Revision: b06b248ad9dc1b50dcf474616c3d586d47270a01 URL: https://github.com/llvm/llvm-project/commit/b06b248ad9dc1b50dcf474616c3d586d47270a01 DIFF: https://github.com/llvm/llvm-project/commit/b06b248ad9dc1b50dcf474616c3d586d47270a01.diff LOG:

[clang-tools-extra] 210b731 - [clang-tidy] Fix minor bug in add_new_check.py

Author: Chris Cotter Date: 2023-01-05T15:28:57Z New Revision: 210b731c01b020693aa8f53231c659ff5f60149e URL: https://github.com/llvm/llvm-project/commit/210b731c01b020693aa8f53231c659ff5f60149e DIFF: https://github.com/llvm/llvm-project/commit/210b731c01b020693aa8f53231c659ff5f60149e.diff LOG:

[clang-tools-extra] c0d0b12 - [clang-tidy][NFC] Remove unused User argument in misc-misleading-bidirectional check

Author: Carlos Galvez Date: 2023-01-08T15:18:13Z New Revision: c0d0b1237a9f9ee992f6775305113738e9374ca0 URL: https://github.com/llvm/llvm-project/commit/c0d0b1237a9f9ee992f6775305113738e9374ca0 DIFF: https://github.com/llvm/llvm-project/commit/c0d0b1237a9f9ee992f6775305113738e9374ca0.diff LOG:

[clang-tools-extra] e432952 - [clang-tidy] Match derived types in in modernize-loop-convert

Author: Chris Cotter Date: 2023-01-10T16:08:25Z New Revision: e43295209bb86e93008363c66c1277c7d8bb148c URL: https://github.com/llvm/llvm-project/commit/e43295209bb86e93008363c66c1277c7d8bb148c DIFF: https://github.com/llvm/llvm-project/commit/e43295209bb86e93008363c66c1277c7d8bb148c.diff LOG:

[clang-tools-extra] 9fff1dd - [NFC] [clang-tools-extra] Alphabetize clang-tidy release notes

Author: Chris Cotter Date: 2023-01-10T17:37:19Z New Revision: 9fff1ddb560cbb14ba661af2c33b768f3071be9a URL: https://github.com/llvm/llvm-project/commit/9fff1ddb560cbb14ba661af2c33b768f3071be9a DIFF: https://github.com/llvm/llvm-project/commit/9fff1ddb560cbb14ba661af2c33b768f3071be9a.diff LOG:

[clang-tools-extra] c7575fc - Revert "[clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options"

Author: Carlos Galvez Date: 2023-01-25T05:17:00Z New Revision: c7575fcb685a15f5384c137c76913e0bb11d1320 URL: https://github.com/llvm/llvm-project/commit/c7575fcb685a15f5384c137c76913e0bb11d1320 DIFF: https://github.com/llvm/llvm-project/commit/c7575fcb685a15f5384c137c76913e0bb11d1320.diff LOG:

[clang-tools-extra] 8a8f77c - [clang-tidy] Implement CppCoreGuideline F.54

Author: Chris Cotter Date: 2023-02-02T07:20:59Z New Revision: 8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa URL: https://github.com/llvm/llvm-project/commit/8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa DIFF: https://github.com/llvm/llvm-project/commit/8a8f77c1b849ff59ef0db457bd74f4adb1de7cfa.diff LOG:

[clang-tools-extra] 0f5eb31 - [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

Author: Carlos Galvez Date: 2023-01-13T07:29:49Z New Revision: 0f5eb3190cfc09796b08648fac7e936ffdcfb8d7 URL: https://github.com/llvm/llvm-project/commit/0f5eb3190cfc09796b08648fac7e936ffdcfb8d7 DIFF: https://github.com/llvm/llvm-project/commit/0f5eb3190cfc09796b08648fac7e936ffdcfb8d7.diff LOG:

[clang-tools-extra] 4240c91 - [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Author: Carlos Galvez Date: 2023-01-23T20:58:34Z New Revision: 4240c9146248ac0a91c45dee421c6ef07709ba74 URL: https://github.com/llvm/llvm-project/commit/4240c9146248ac0a91c45dee421c6ef07709ba74 DIFF: https://github.com/llvm/llvm-project/commit/4240c9146248ac0a91c45dee421c6ef07709ba74.diff LOG:

[clang-tools-extra] 38a9e1d - [clang-tidy][NFC] Fix Release Notes build error

Author: Carlos Galvez Date: 2023-01-23T21:05:08Z New Revision: 38a9e1d41264b551f659a5d9215109a96e74cadd URL: https://github.com/llvm/llvm-project/commit/38a9e1d41264b551f659a5d9215109a96e74cadd DIFF: https://github.com/llvm/llvm-project/commit/38a9e1d41264b551f659a5d9215109a96e74cadd.diff LOG:

[clang-tools-extra] 7718422 - [clang-tidy] Improve rename_check.py

Author: Chris Cotter Date: 2023-01-23T21:24:40Z New Revision: 7718422d3b788a52b751773f464bfa52a6461fb7 URL: https://github.com/llvm/llvm-project/commit/7718422d3b788a52b751773f464bfa52a6461fb7 DIFF: https://github.com/llvm/llvm-project/commit/7718422d3b788a52b751773f464bfa52a6461fb7.diff LOG:

[clang-tools-extra] [clang-tidy] Fix support for typedefs in readability-identifier-naming (PR #66835)

@@ -729,3 +729,21 @@ struct forward_declared_as_struct; class forward_declared_as_struct { }; +namespace pr55156 { + +typedef enum { + VALUE0, + VALUE1, +} ValueType; +// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: invalid case style for typedef 'ValueType' [readability-identi

[clang-tools-extra] [clang-tidy] Fix support for typedefs in readability-identifier-naming (PR #66835)

https://github.com/carlosgalvezp resolved https://github.com/llvm/llvm-project/pull/66835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix support for typedefs in readability-identifier-naming (PR #66835)

@@ -729,3 +729,21 @@ struct forward_declared_as_struct; class forward_declared_as_struct { }; +namespace pr55156 { + +typedef enum { + VALUE0, + VALUE1, +} ValueType; +// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: invalid case style for typedef 'ValueType' [readability-identi

[clang-tools-extra] [clang-tidy] Fix support for typedefs in readability-identifier-naming (PR #66835)

https://github.com/carlosgalvezp approved this pull request. LGTM, thanks for the fix and the great cleanup! https://github.com/llvm/llvm-project/pull/66835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] [clang-tidy] Add recursion protection in ExceptionSpecAnalyzer (PR #66810)

carlosgalvezp wrote: Being totally unfamiliar with the code, I have a feeling that we shouldn't be fixing in the `analyze` function. `analyze` has 1 single responsibility: wrap `analyzeImpl` in order to add cacheability for performance reasons, and it does so simply and well, and it does exact

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/67170 Casting an int into an enum is undefined behavior if the int is outside of the range of the enum. UB is not allowed in constant expressions, therefore the compiler must produce a hard error in that case.

[clang-tools-extra] [clang-tidy] Add recursion protection in ExceptionSpecAnalyzer (PR #66810)

carlosgalvezp wrote: To clarify, I'm not concerned about performance, but with code readability and maintainability. I realize the chain that I wrote above should not lead to recursion due to `SkipMethods::Yes` in the relevant call. I'd like to take a closer look at the problem, would you be

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

carlosgalvezp wrote: Not sure what happens with the failed job in CI, I rebased on latest trunk and ran the entire `ninja check-clang` suite and it passed successfully. Do I need some special CMake configuration flag to enable the failing test? About the patch itself - casting outside of range

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/67170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Turn -Wenum-constexpr-conversion into a hard error (PR #67170)

carlosgalvezp wrote: Thanks @shafik , I wasn't aware! I will then close this PR and continue the discussion on Phab. https://github.com/llvm/llvm-project/pull/67170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/67528 …macros As per review comments on https://reviews.llvm.org/D150226, we should allow for one more release before turning this warning into a hard error, by making it visible in system headers and macros, s

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

@@ -405,7 +405,8 @@ def warn_fixedpoint_constant_overflow : Warning< InGroup>; def warn_constexpr_unscoped_enum_out_of_range : Warning< "integer value %0 is outside the valid range of values [%1, %2] for the " - "enumeration type %3">, DefaultError, InGroup>; + "enumerat

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/67528 >From f9c4fb4e0a5a9017da6214fb0d98f45f89ee16be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Wed, 27 Sep 2023 08:07:01 + Sub

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: @@ -405,7 +405,8 @@ def warn_fixedpoint_constant_overflow : Warning< InGroup>; def warn_constexpr_unscoped_enum_out_of_range : Warning< "integer value %0 is outside the valid range of values [%1, %2] for the " - "enumer

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/67528 >From f9c4fb4e0a5a9017da6214fb0d98f45f89ee16be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Wed, 27

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: carlosgalvezp wrote: I would need some help with the failing pre-merge test, I don't really understand why that failure would be related to this patch... https://github.com/llvm/llvm-project/pull/67528 ___

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp resolved https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/67528 >From 7a70366e08f2c2f1181bb74f7716d8b1e3f1b62e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Wed, 27

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: carlosgalvezp wrote: It seems checks are broken on trunk, I see commits merged with failing pre-merge tests. They seem to be unrelated to this patch though. Is there anything else you'd like fixed before merging?

[clang-tools-extra] b70e6e9 - [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

Author: Carlos Galvez Date: 2023-07-19T12:05:15Z New Revision: b70e6e9681925ad06d9899462b9e43250be53f64 URL: https://github.com/llvm/llvm-project/commit/b70e6e9681925ad06d9899462b9e43250be53f64 DIFF: https://github.com/llvm/llvm-project/commit/b70e6e9681925ad06d9899462b9e43250be53f64.diff LOG:

[clang-tools-extra] b7c6b39 - [clang-tidy] Remove AnalyzeTemporaryDestructors configuration option

Author: Carlos Galvez Date: 2023-07-26T10:26:43Z New Revision: b7c6b39651b3ffdabf0081c45e0455a04a8be992 URL: https://github.com/llvm/llvm-project/commit/b7c6b39651b3ffdabf0081c45e0455a04a8be992 DIFF: https://github.com/llvm/llvm-project/commit/b7c6b39651b3ffdabf0081c45e0455a04a8be992.diff LOG:

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= Message-ID: In-Reply-To: carlosgalvezp wrote: Friendly ping @AaronBallman @shafik https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/67528 >From 08b5c95bea5b7bfceeae6dfc4deac764faff87a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Wed, 27 Sep 2023 08:07:01 + Sub

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] 2992d08 - [clang-tidy] Do not warn on macros starting with underscore and lowercase letter in bugprone-reserved-identifier

Author: Carlos Galvez Date: 2023-07-30T12:10:48Z New Revision: 2992d084774f44e7626a7d640fe6c30163db450e URL: https://github.com/llvm/llvm-project/commit/2992d084774f44e7626a7d640fe6c30163db450e DIFF: https://github.com/llvm/llvm-project/commit/2992d084774f44e7626a7d640fe6c30163db450e.diff LOG:

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,34 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

@@ -0,0 +1,34 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang-tools-extra] [clang-tidy] The first PR our of many PRs for the "Initialized Class Members" check. (PR #65189)

carlosgalvezp wrote: Thanks for the detailed response @adriannistor ! > will soon become a lot of if-then-else blocks. In general the decision as to which checks to have should be based on Coding Guidelines and user-facing experience - not on implementation complexity. In that sense, as a use

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

https://github.com/carlosgalvezp commented: Should this change be reflected in the Release Notes? https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

@@ -1332,6 +1337,17 @@ void testBracedInitTemporaries() { v3.push_back(NonTrivialWithCtor{{}}); v3.push_back({{0}}); v3.push_back({{}}); + + std::vector v4; + + // These should not be noticed or fixed; after the correction, the code won't + // compile. + v4.push_back(

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

@@ -207,11 +211,13 @@ void UseEmplaceCheck::registerMatchers(MatchFinder *Finder) { auto HasConstructExpr = has(ignoringImplicit(SoughtConstructExpr)); // allow for T{} to be replaced, even if no CTOR is declared - auto HasConstructInitListExpr = has(initListExpr(anyOf(

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

@@ -207,11 +211,13 @@ void UseEmplaceCheck::registerMatchers(MatchFinder *Finder) { auto HasConstructExpr = has(ignoringImplicit(SoughtConstructExpr)); // allow for T{} to be replaced, even if no CTOR is declared - auto HasConstructInitListExpr = has(initListExpr(anyOf(

[clang-tools-extra] [clang-tidy] readability-identifier-naming - fix StructCase and UnionCase in C (PR #65202)

https://github.com/carlosgalvezp approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/65202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp created https://github.com/llvm/llvm-project/pull/65231: …-delete So the purpose of the check is more clear. Update examples code to show compliant code. >From 0ffc7aab2f385babd81b57e8116b0433d85cfaf2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lv

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp review_requested https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp review_requested https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp review_requested https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Sun, 3 Sep 2023 18:24:55 + Subject: [PATCH] [clang-tidy][NFC][doc] Improve documenta

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

https://github.com/carlosgalvezp edited https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Sun, 3 Sep 2023 18:24:55 + Subject: [PATCH 1/2] [clang-t

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp resolved https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Sun, 3 Sep 2023 18:24:55 + S

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Sun,

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= @@ -3,22 +3,37 @@ modernize-use-equals-delete === -This check marks unimplemented private special member functions with ``= delete``. -To av

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= carlosgalvezp wrote: Yep, we could certainly change it to C++11 or later, but I think it's out of the scope for this NFC patch. Regarding documentation, I haven't seen that we documen

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= , Carlos =?utf-8?q?G=C3=A1lvez?= carlosgalvezp wrote: Yes good point, will fix! https://github.com/llvm/llvm-project/pull/65231 ___ cfe-commits mailing l

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f23d57d6cb Mon Sep 17 00:00:00

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/65231: >From 9c5fec5e31f31b59262646625b7d34f2

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp resolved https://github.com/llvm/llvm-project/pull/65231 ___

[clang-tools-extra] [clang-tidy][NFC][doc] Improve documentation for modernize-use-equals… (PR #65231)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/65231 _

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang-tools-extra] 7e5c48b - [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder

Author: Carlos Galvez Date: 2023-03-22T18:51:51Z New Revision: 7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d URL: https://github.com/llvm/llvm-project/commit/7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d DIFF: https://github.com/llvm/llvm-project/commit/7e5c48b8bd9ff0ee5de3ba28c833f1225f14e44d.diff LOG:

[clang-tools-extra] b08d35f - [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name

Author: Carlos Galvez Date: 2023-03-23T08:31:12Z New Revision: b08d35f826a6b7696a02f1d811da7a2f951e74a1 URL: https://github.com/llvm/llvm-project/commit/b08d35f826a6b7696a02f1d811da7a2f951e74a1 DIFF: https://github.com/llvm/llvm-project/commit/b08d35f826a6b7696a02f1d811da7a2f951e74a1.diff LOG:

[clang-tools-extra] b767784 - [clang-tidy][NFC] Fix broken link in Release Notes

Author: Carlos Galvez Date: 2023-03-23T10:30:15Z New Revision: b7677846da66fd003a538f87fd8de948cfcc3d6a URL: https://github.com/llvm/llvm-project/commit/b7677846da66fd003a538f87fd8de948cfcc3d6a DIFF: https://github.com/llvm/llvm-project/commit/b7677846da66fd003a538f87fd8de948cfcc3d6a.diff LOG:

[clang-tools-extra] f957b8f - [clang-tidy][NFC] Improve naming convention in google-readability-avoid-underscore-in-googletest-name

Author: Carlos Galvez Date: 2023-03-24T07:22:04Z New Revision: f957b8fe1efe34ac04d1b2e6381e44edcef056b3 URL: https://github.com/llvm/llvm-project/commit/f957b8fe1efe34ac04d1b2e6381e44edcef056b3 DIFF: https://github.com/llvm/llvm-project/commit/f957b8fe1efe34ac04d1b2e6381e44edcef056b3.diff LOG:

[clang-tools-extra] 556600a - [clang-tidy] Add option to ignore user-defined literals in readability-magic-numbers

Author: Carlos Galvez Date: 2023-03-26T16:41:17Z New Revision: 556600af6a8a7f241277f7a22c3e3746e7b09123 URL: https://github.com/llvm/llvm-project/commit/556600af6a8a7f241277f7a22c3e3746e7b09123 DIFF: https://github.com/llvm/llvm-project/commit/556600af6a8a7f241277f7a22c3e3746e7b09123.diff LOG:

[clang-tools-extra] 4d4c0f9 - [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

Author: Carlos Galvez Date: 2023-03-28T20:36:34Z New Revision: 4d4c0f9734607bb0423593b060b8fa73c06fe3d3 URL: https://github.com/llvm/llvm-project/commit/4d4c0f9734607bb0423593b060b8fa73c06fe3d3 DIFF: https://github.com/llvm/llvm-project/commit/4d4c0f9734607bb0423593b060b8fa73c06fe3d3.diff LOG:

[clang-tools-extra] 00a71cb - [clang-tidy] readability-identifier-naming.HungarianNotation: rename CharPrinter to CharPointer

Author: Alexis Murzeau Date: 2023-02-26T08:22:56Z New Revision: 00a71cb47c36984dcd9f51492e1e831aec0e0460 URL: https://github.com/llvm/llvm-project/commit/00a71cb47c36984dcd9f51492e1e831aec0e0460 DIFF: https://github.com/llvm/llvm-project/commit/00a71cb47c36984dcd9f51492e1e831aec0e0460.diff LOG

[clang-tools-extra] c6d195b - clang-tidy altera-id-dependent-backward-branch: print notes after warning

Author: Egor Suvorov Date: 2023-03-05T16:06:55Z New Revision: c6d195b366c8256184ff40c5e46339eed96b4a81 URL: https://github.com/llvm/llvm-project/commit/c6d195b366c8256184ff40c5e46339eed96b4a81 DIFF: https://github.com/llvm/llvm-project/commit/c6d195b366c8256184ff40c5e46339eed96b4a81.diff LOG:

  1   2   3   4   5   >