[PATCH] D120618: [clang-format][docs] Fix a bad comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e51ace4e86d: [clang-format][docs] Fix a bad comment (authored by kuzkry, committed by HazardyKnusperkeks). Herald added a project: All. Repository:

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, cjdb. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a s

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

HazardyKnusperkeks added a comment. In D120398#3353053 , @owenpan wrote: > Can we use `int8_t` instead of `unsigned char` to keep the enum types signed > (and update the changes made in D93758 )? +1 Repository: rG LL

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integral = __is_integral(T);"); + curdeius wrote: > curdeius wrote: > > How about other kinds? > > This doesn'

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks updated this revision to Diff 412664. HazardyKnusperkeks added a comment. More Traits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120774/new/ https://reviews.llvm.org/D120774 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integral = __is_integral(T);"); + HazardyKnusperkeks wrot

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

HazardyKnusperkeks added a comment. Please use the clang-format tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120884/new/ https://reviews.llvm.org/D120884 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

HazardyKnusperkeks added a comment. In D120884#3356751 , @kwk wrote: > In D120884#3356746 , > @HazardyKnusperkeks wrote: > >> Please use the clang-format tag. > > Yes, sorry that I forgot it again. And thank you

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks added inline comments. Comment at: clang/docs/tools/dump_format_style.py:293 state = State.InNestedStruct - field_type, field_name = re.match(r'([<>:\w(,\s)]+)\s+(\w+);', line).groups() + field_type, field_name = re.match(r'([<>:\w

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks added a comment. Only some small things, I think we are nearly done and this is a great change. Comment at: clang/include/clang/Format/Format.h:139-140 + /// + /// They can also be read as a whole for compatibility. The choices + /// are: + /// - None ---

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16800 + Alignment)); +} + sstwcw wrote: > HazardyKnusperkeks wrote: > > Can you test it with `AlignConsecutiveDeclarations`? > Do you mean like the forma

[PATCH] D121069: [clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays

HazardyKnusperkeks added a comment. There should also be a warning or at least note on the option description about the current limitations. Comment at: clang/lib/Format/WhitespaceManager.h:202-203 + +// Determine if the array is "Square" i.e. every row has the same number

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks updated this revision to Diff 413430. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120774/new/ https://reviews.llvm.org/D120774 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.c

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3090-3093 +#define TYPE_TRAIT(N, I, K) case tok::kw_##I: +#define ARRAY_TYPE_TRAIT(I, E, K) case tok::kw_##I: +#define EXPRESSION_TRAIT(I, E, K) case tok::kw_##I: +#include "clang/Basic

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: owenpan wrote: > cjdb wrote: > > owenpan wrote: > > > Do we still n

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Looks okay for me, but please fix the formatting notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. LGTM but please wait for @MyDeveloperDay opinion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ cfe-commits mailing

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good, and I'm always in favor of having a `Leave` Option. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101344/n

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2705 } - if (FormatTok->Tok.is(tok::l_brace)) { + if (FormatTok->Tok.is(tok::equal)) { +nextToken(); MyDeveloperDay wrote: > shouldn't this be > > ```FormatTo

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Jep, that would also confuse myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://reviews.llvm.org/D101628

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:365 + + verifyFormat("test \?\?= ABC;", Style); + verifyFormat("test \?\?= true;", Style); Why do you escape `?`? I've never seen that. Repository: rG LLVM Git

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:135 return; +} } krasimir wrote: > nit: use spaces for indentation, no tabs (Phabricator makes it look this line > starts with a tab character) That's not a

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added a comment. I really like alignment! :) But why is this completely different than the other alignment options? You should also add an entry to the release notes. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:32 +// The notion here is that we

[PATCH] D101878: [git-clang-format] Do not apply clang-format to symlinks

HazardyKnusperkeks added a comment. I have not a great knowledge about python, but it looks okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101878/new/ https://reviews.llvm.org/D101878 ___ cfe-commit

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Looks good, but please wait for others to state their opinion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___ cfe-com

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1404 + isArrayOfStructuresInit(TheLine)); + if (AlignArrayOfStructuresInit) { +Penalty += AlignedArrayOfStructuresInitLineFormatt

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:16465 + "test demo[] = {\n" + "{56, 23,\"hello world i am a very lon

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added a comment. Something which just came to my mind. Since you wrote your own LineFormatter, you have to add test cases for all kinds of indention and wrapping. It seems that the string wrapping does not happen, how about comments? Are classes, namespaces, functions, etc. c

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3104-3105 + /// + ///class C {} + ///}; + /// \endcode Comment at: clang/lib/

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303 + assert(IfRightBrace->MatchingParen == IfLeftBrace); + IfLeftBrace->MatchingParen = nullptr; + IfRightBrace->MatchingParen = nullptr; owenpan wrote

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); rajatbajpai wrote: > MyDeveloperDa

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Only some small changes, then it looks good to me. And I will definitely use it, once it is landed. Comment at: clang/include/clang/Format/

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer &Tokens) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; Better, but I still think we should have

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer &Tokens) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; ksyx wrote: > HazardyKnusperkeks wrote: >

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer &Tokens) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; ksyx wrote: > HazardyKnusperkeks wrote: >

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for adding the parse checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283 _

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks updated this revision to Diff 397131. HazardyKnusperkeks set the repository for this revision to rG LLVM Github Monorepo. HazardyKnusperkeks added a comment. Now with SmallVector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

This revision was automatically updated to reflect the committed changes. Closed by commit rGf014ab933f35: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D115060?vs=391853&id=397135#toc Repository:

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

This revision was automatically updated to reflect the committed changes. Closed by commit rGd48d1f8ee845: [clang-format][NFC] Merge another two calls to isOneOf (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115069/n

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG1188f241acb7: Revert "[clang-format][NFC] Prefer pass by reference" (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D115061?vs=391858&id=397137#toc Repository: rG

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: ksyx, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. the Style's e

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks added a comment. Without the enum documentation I got $ ./clang/docs/tools/dump_format_style.py Traceback (most recent call last): File "/c/GIT/llvm-dev/./clang/docs/tools/dump_format_style.py", line 344, in opts = OptionsReader(f).read_options() File "/c/GI

[PATCH] D116558: [clang-format][NFC] Don't pass member by argument

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And then u

[PATCH] D116559: [clang-format][NFC] Early return in TokenAnnotator::next

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D116560: [clang-format][NFC] TokenAnnotator: Use range based for

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D116561: [clang-format][NFC] Use Prev instead of Current->Previous

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D116562: [clang-format][NFC] Right.Previous is Left

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use that n

[PATCH] D116563: [clang-format][NFC] Put all state change into the for statement

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks updated this revision to Diff 397148. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116557/new/ https://reviews.llvm.org/D116557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h Index: clang/include/clang/Format/Format.h =

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks added a comment. In D116557#3218328 , @ksyx wrote: > Thanks for the fix :) No Problem. Comment at: clang/docs/ReleaseNotes.rst:300 - Option ``SeparateDefinitionBlocks`` has been added to insert or remove empty

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35493b45603f: [clang-format][NFC] Replace deque with vector (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2257fe23672: [clang-format] Fix SeparateDefinitionBlocks docs and ... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D116558: [clang-format][NFC] Don't pass member by argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1db43539027: [clang-format][NFC] Don't pass member by argument (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116559: [clang-format][NFC] Early return in TokenAnnotator::next

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG918c977dc1c8: [clang-format][NFC] Early return in TokenAnnotator::next (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D116560: [clang-format][NFC] TokenAnnotator: Use range based for

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29d8535e2b86: [clang-format][NFC] TokenAnnotator: Use range based for (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D116561: [clang-format][NFC] Use Prev instead of Current->Previous

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ab5d29f556b: [clang-format][NFC] Use Prev instead of Current->Previous (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHA

[PATCH] D116562: [clang-format][NFC] Right.Previous is Left

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1da96f744951: [clang-format][NFC] Right.Previous is Left (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116563: [clang-format][NFC] Put all state change into the for statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6af1d46889: [clang-format][NFC] Put all state change into the for statement (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorep

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks reopened this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D115060#3219116 , @curdeius wrote: > @HazardyKnusperkeks, it *seems* as if this commit (or one of others indicated > on Cha

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 397531. HazardyKnusperkeks added a comment. Option 3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/UnwrappedLineFo

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2827 -**JavaScriptWrapImports** (``Boolean``) :versionbadge:`clang-format 3.9` - Whether to wrap JavaScript import/export statements. + * If ``ColumnWidth`` is 0 (no limit on the numb

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks added a comment. In D115060#3224176 , @owenpan wrote: >> But I suspect it is the Assignment of the `PreviousLine` since this is not >> existent every time. > > Yep! > >> So I see the following solutions: >> >> 1. Only name `NextLine`,

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. In D115060#3227120 , @owenpan wrote: > Maybe option 4 for now So I can get it through. > and the refactoring in

[PATCH] D116806: [clang-format] Ensure we can correctly parse lambda in the template argument list

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2872-2874 + if (FormatTok->is(tok::l_square)) +if (!tryToParseLambda()) + break; Fewer ifs and lines. Repository: rG LLVM Github Monorepo CHA

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\" STRINGIFY(build

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. If the pre merge checks pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 ___

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3059 + /// and ``while``) in C++ according to the LLVM coding style. + /// \warning + /// This option will be renamed and expanded to support other styles! This should b

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks resigned from this revision. HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3059 + /// and ``while``) in C++ according to the LLVM coding style. + /// \warning + /// This option will be renamed and expanded to supp

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:297 + return true; +if (Style.isCpp() && RecordTok->is(tok::kw_union)) + return true; Is union used in another lang

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3475 return false; +if (Left.is(TT_JsTypeOperator) && Right.isTypeOrIdentifier() || +(Left.isTypeOrIdentifier() || Left.is(TT_TemplateCloser)) && Be expli

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. In D109557#3242274 , @fdwr wrote: >> I think no one just had thought about it. :) > > @HazardyKnusperkeks Happy new year. Just in case it gets forgotten, I'm > squeaking on behalf of a few stackoverflowers 😁 (#52158077

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3246838 , @curdeius wrote: > Thanks for having a try on this. > However, I don't like this approach too much. You add many changes and a > single test. That's not sufficient. > Also, handling C++ keywords in

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

HazardyKnusperkeks added a comment. Thanks for fixing this. It hit my quite some times, but never had the time to look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117421/new/ https://reviews.llvm.org/D117421 ___

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. Could you please rebase the patch? I promise I will commit it **very** shortly afterwards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 400400. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Updated, now using a pointer (potential null) for PreviousLine. CHANGES SINCE LAST ACTION https://r

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:288 +// Try to merge a control statement block with left brace unwrapped. +if (TheLine->Last->is(tok::l_brace) && TheLine->First->isOneOf(tok::kw_if, tok::kw_while,

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks marked 5 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto &NextLine = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if (Ne

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 400449. HazardyKnusperkeks marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/Unwrapped

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG966f24e5a62a: [clang-format] Add a BlockIndent option to AlignAfterOpenBracket (authored by csmulhern, committed by HazardyKnusperkeks). Changed pri

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

HazardyKnusperkeks added a comment. In D117421#3249196 , @glotchimo wrote: > In D117421#3247632 , @curdeius > wrote: > >> Could you check if your patch fixes >> https://github.com/llvm/llvm-project/issues/33044

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto &NextLine = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if (Ne

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2598 +// Skip past until we think we we the rawstring literal close. +if (Trimmed.contains("R\"(")) { + FormattingOff = true; curdeius wrote: > This won't be enough for

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2598 +// Skip past until we think we we the rawstring literal close. +if (Trimmed.contains("R\"(")) { + FormattingOff = true; curdeius wrote: > HazardyKnusperkeks wrote

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); curdeius wrote: > curdeius wrote: > > How a

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:1162 + "test.cxx", 0)); +} + You should add a `#undef X`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/ https://reviews.llvm.o

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

HazardyKnusperkeks added a comment. In D115168#3185199 , @MyDeveloperDay wrote: > Add support for | but still can't get [] to work in the regex (checked the > unit tests for Support/Regex and its not clear if its supported) How about `"R\"(([A-Za-z0-9_

[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:59 + // Namespace alias + if (Tok->isOneOf(tok::equal, tok::semi)) +return false; Should only be equal, right? Otherwise please add a test for s

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. Actually no. I think no one just had thought about it. :) I can try to commit it next week, this one I'm rather busy. Maybe someone else might do it before that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1095

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3231 +return Style; + } else if (ParserErrorCode != ParseError::Success) { +return make_string_error("Error reading " + ConfigFile + ": " + else after return But I prefer

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1641 case tok::equal: - // Fat arrows (=>) have tok::TokenKind tok::equal but TokenType - // TT_FatArrow. They always start an expression or a child block if - // fo

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Good that you renamed the method. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967 ___ cfe-commits mailing list cfe-commi

[PATCH] D116183: [clang-format] Fix wrong indentation after trailing requires clause.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I really need to get my requires patch done... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116183/new/ https://reviews

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added a comment. And initialize the value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D116188#3208378 , @yodaldevoid wrote: > Correct commit email Since you only upload a diff, there is no name or email. ;)

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3045 +// parenthesis of a cast we know we are in a cast. +if (!Left.isOneOf(TT_PointerOrReference, tok::l_paren)) + for (const FormatToken *Tok = &Right; What a

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3383 +///true: false: +///void operator++ (int a); vs.void operator++(int +///a); Please put the

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

HazardyKnusperkeks added a comment. Nice change, some small notes from me. Comment at: clang/docs/ClangFormatStyleOptions.rst:4003 +**TemplateArgumentKeyword** (``TemplateArgumentStyle``) :versionbadge:`clang-format 14` + Keyword to use for template arguments (``class`` or

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: > Is there a rea

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3393 if (!ChildFormatTextToApply.empty()) { assert(ChildFormatTextToApply.size() == 1); zwliew wrote: > Is there a reason for this to be limited to 1? I came across this c

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: > HazardyKnusper

<    5   6   7   8   9   10   11   >