[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3315135 , @xbolva00 wrote: > @void It would be cool to mention this new feature in release notes. Good idea! https://reviews.llvm.org/D119592 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D119592: Insert a blurb about the -fzero-call-used-regs feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG86bde99a9027: Insert a blurb about the -fzero-call-used-regs feature (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119592/new/ https://r

[PATCH] D124199: [randstruct] Check final randomized layout ordering

void added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:153 - std::shuffle(std::begin(Buckets), std::end(Buckets), RNG); + llvm::shuffle(std::begin(Buckets), std::end(Buckets), RNG); MaskRay wrote: > This was my original fix and your reland dro

[PATCH] D124199: [randstruct] Check final randomized layout ordering

void updated this revision to Diff 424357. void added a comment. Fixed "std::vector" mishap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199 Files: clang/lib/AST/Randstruct.cpp clang/unittests/AST/Rand

[PATCH] D124199: [randstruct] Check final randomized layout ordering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7815d33bf8f: [randstruct] Check final randomized layout ordering (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D123958: [randstruct] Randomize all elements of a record

void added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D123958: [randstruct] Randomize all elements of a record

void updated this revision to Diff 425593. void marked 2 inline comments as done. void added a comment. Add a few more tests and remove a dead check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 Files:

[PATCH] D123958: [randstruct] Randomize all elements of a record

void added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:201 +dyn_cast(RandomizedFields.back()->getType())) + if (CA->getSize().sle(2) || CA->isIncompleteArrayType()) +FlexibleArray = RandomizedFields.pop_back_val(); aaron.bal

[PATCH] D123958: [randstruct] Randomize all elements of a record

void updated this revision to Diff 425595. void added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/Randstruct.h

[PATCH] D123958: [randstruct] Randomize all elements of a record

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG463790bfc70e: [randstruct] Randomize all elements of a record (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

void updated this revision to Diff 425932. void added a comment. Rebase with top-of-tree. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/new/ https://reviews.llvm.org/D123544 Files: clang/lib/Sema/SemaDecl.cpp clang/unittests/AST/

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f7970083029: [randstruct] Automatically randomize a structure of function pointers (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123544/

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2171 if (Field == FieldEnd) { // We've run out of fields. We're done. stuij wrote: > @void Unfortunately this end of fields check will break the non-designated > initializer check

[PATCH] D124694: [randstruct] Move initializer check to be more effective

void created this revision. void added reviewers: stuij, MaskRay, aaron.ballman. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a randomized structure has an initi

[PATCH] D124694: [randstruct] Move initializer check to be more effective

void added a comment. In D124694#3485585 , @aaron.ballman wrote: > struct t { > int a, b, c, d, e; > } x = { .a = 2, 4, 5, 6 }; > > This situation seems like it should be an error, shouldn't it? The user > specified one designated initializer (

[PATCH] D124694: [randstruct] Move initializer check to be more effective

void added a comment. In D124694#3486547 , @void wrote: > In D124694#3485585 , @aaron.ballman > wrote: > >> struct t { >> int a, b, c, d, e; >> } x = { .a = 2, 4, 5, 6 }; >> >> This situation seems like

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void added a comment. In D123763#3485836 , @sbc100 wrote: > This new test has been failing on the emscripten builders.. seemingly ever > since it landed: > > https://ci.chromium.org/ui/p/emscripten-releases/builders/ci/linux-test-suites/b8815286583388131

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void created this revision. void added reviewers: nickdesaulniers, danielkiss, MaskRay. Herald added subscribers: StephenFan, pengfei, hiraditya, kristof.beyls. Herald added a project: All. void requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-co

[PATCH] D124694: [randstruct] Move initializer check to be more effective

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2639cf3fe46: [randstruct] Move initializer check to be more effective (authored by void). Changed prior to commit: https://reviews.llvm.org/D124694?vs=426149&id=426788#toc Repository: rG LLVM Github

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:776-778 + // For GPRs, we only care to clear out the 64-bit register. + if (MCRegister XReg = getRegisterOrZero(Reg)) +GPRsToZero.set(XReg); nickdesaulniers

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:752 +#undef CASE + } +} kristof.beyls wrote: > Just a drive-by comment: I'm wondering if SVE registers should also be listed > here? I'm not familiar with the SVE registers

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:1398 + (sequence "W%u", 0, 7))>; +def FPR8_ARG : RegisterClass<"AArch64", [untyped], 8, (trunc FPR8, 7)> { + let Size = 8; sdesmalen wrote: > S

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:682 +// The called routine is expected to preserve r19-r28 +// r29 and r30 are used as frame pointer and link register resp. +return 0; nickdesaulniers wrote: > W

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void updated this revision to Diff 427909. void added a comment. - Support SVE registers. - Initial feature to gather argument registers from the *CallingConv.td files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llvm.

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added inline comments. Comment at: llvm/test/CodeGen/AArch64/zero-call-used-regs.ll:233 + +attributes #0 = { mustprogress nofree norecurse nosync nounwind readnone willreturn uwtable "frame-pointer"="non-leaf" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-p

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. @peterwaller-arm @sdesmalen Could you comment on what is considered the canonical way to zero Arm registers? Is `mov x1, #0` the way or `mov x1, xzr` or some other way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void updated this revision to Diff 428218. void added a comment. - Used lists of argument registers generated from AArch64CallingConv.td. - Add more tests for floating point and SVE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https:/

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void updated this revision to Diff 428764. void marked 4 inline comments as done. void added a comment. Fix think-o use of HasSVE. Use `--check-prefixes` in the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llv

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. I'll split off the TableGen changes into a separate patch. It will supersede those changes here, so it shouldn't delay other reviews here. :-) Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:798 + + if (STI.hasSVE()) { +for (MCRegister P

[PATCH] D125420: [AArch64] Add support for -fzero-call-used-regs

void created this revision. void added reviewers: nickdesaulniers, nhaehnle, thakis, jankratochvil. Herald added subscribers: pengfei, hiraditya, kristof.beyls. Herald added a project: All. void requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald

[PATCH] D125420: [AArch64] Add support for -fzero-call-used-regs

void abandoned this revision. void added a comment. Ugh! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125420/new/ https://reviews.llvm.org/D125420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. In D124836#3507354 , @nickdesaulniers wrote: > In D124836#3507268 , @void wrote: > >> I'll split off the TableGen changes into a separate patch. It will supersede >> those changes here, so

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llvm.org/D124836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void updated this revision to Diff 430858. void added a comment. Last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/ https://reviews.llvm.org/D124836 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/C

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e00a34cdb49: [AArch64] Add support for -fzero-call-used-regs (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void added a comment. In D124836#3528521 , @vvereschaka wrote: > got it. Yes, looks like it fixed. The test got passed during the last build: > https://lab.llvm.org/buildbot/#/builders/104/builds/7812 > Thank you. I'm sorry for the failure. I thought I

[PATCH] D69876: Allow output constraints on "asm goto"

void added inline comments. Comment at: clang/lib/AST/Stmt.cpp:646-648 + // Labels are placed after "InOut" operands. Adjust accordingly. + if (IsLabel) +N += getNumPlusOperands(); jyknight wrote: > I'm confused about this part. Why isn't the "N

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 236482. void marked 2 inline comments as done. void added a comment. Reword the extension explanation to be more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876

[PATCH] D69876: Allow output constraints on "asm goto"

This revision was automatically updated to reflect the committed changes. Closed by commit rG52366088a8e4: Allow output constraints on "asm goto" (authored by void). Changed prior to commit: https://reviews.llvm.org/D69876?vs=236683&id=236684#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 236683. void added a comment. Push the correct changes to Phabricator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.rst clang/i

[PATCH] D69868: Allow "callbr" to return non-void values

void marked 5 inline comments as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1115-1116 + if (Succ->hasAddressTaken()) +if (auto *bb = Succ->getBasicBlock()) + if (auto *cbr = dyn_cast(getBasicBlock()->getTerminator())) +i

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 236710. void added a comment. Remove check that the successor may be in the indirect list of a callbr instruction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files:

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 236716. void added a comment. Missed a change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files: llvm/docs/LangRef.rst llvm/include/llvm/CodeGen/MachineBasicBlock

[PATCH] D69876: Allow output constraints on "asm goto"

void marked an inline comment as done. void added a comment. In D69876#1812724 , @jyknight wrote: > Reopening, since this didn't actually land yet. BTW, this review still has > the wrong contents in the latest uploaded-diff (showing llvm changes, not > c

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 237223. void added a comment. Move plus constraints to after the label constraints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 237224. void added a comment. The plus constraints are now at the end of the input/output/label list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 Files: llvm/docs/La

[PATCH] D69868: Allow "callbr" to return non-void values

void marked an inline comment as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that

[PATCH] D69868: Allow "callbr" to return non-void values

void marked 2 inline comments as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that

[PATCH] D69868: Allow "callbr" to return non-void values

void marked an inline comment as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that

[PATCH] D88195: Remove stale assert.

void created this revision. void added reviewers: nickdesaulniers, jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. void requested review of this revision. Remove assert that "asm goto" cannot have outputs. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 293938. void added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/a.h cla

[PATCH] D88195: Remove stale assert.

void added inline comments. Comment at: clang/test/Modules/asm-goto.cpp:1 +// RUN: rm -rf %t +// RUN: %clang_cc1 -fmodules -fno-implicit-modules -x c++ -I%S/Inputs/asm-goto -emit-module %S/Inputs/asm-goto/module.modulemap -fmodule-name=a -o %t/a.pcm jyknight wro

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 294141. void added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/a.h clang/te

[PATCH] D88195: Remove stale assert.

void added a comment. In D88195#2293165 , @nickdesaulniers wrote: > I'm super confused between the commit message and initial hunk, that seem to > make sense and probably should go in clang-11 if it's not too late, and the > additional tests for modules

[PATCH] D88195: Remove stale assert.

void added a comment. In D88195#2293559 , @nickdesaulniers wrote: > In D88195#2293533 , @void wrote: > >> In D88195#2293165 , >> @nickdesaulniers wrote: >> >>> I'm super co

[PATCH] D88195: Remove stale assert.

void updated this revision to Diff 294150. void added a comment. Clarify commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: clang/lib/AST/Stmt.cpp clang/test/Modules/Inputs/asm-goto/

[PATCH] D88195: Remove stale assert.

This revision was automatically updated to reflect the committed changes. Closed by commit rG34ca5b3392ce: Remove stale assert. (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 Files: cla

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 enum GCMode { NonGC, GCOnly, HybridGC }; - enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq }; + enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq, SSPUnspecified }; -

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 enum GCMode { NonGC, GCOnly, HybridGC }; - enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq }; + enum StackProtectorMode { SSPOff, SSPOn, SSPStrong, SSPReq, SSPUnspecified }; -

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

void added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1679 + // Inlining a function the explicitly should not have a stack protector may + // break the code if inlined into a function that does have a stack s/the/that/ ===

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining ssp into nossp

void added inline comments. Comment at: llvm/docs/LangRef.rst:1829 + +If a function with the ``nossp`` attribute calls a callee function that has +a stack protector function attribute, such as ``ssp``, ``sspreq``, or Do we care about the opposite situatio

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

void accepted this revision. void added a comment. This revision is now accepted and ready to land. Only a couple of nits, but I think this looks good. Comment at: llvm/docs/BitCodeFormat.rst:1072 +* code 69: ``byref`` +* code 70: ``mustprogress`` +* code 71: ``nossp``

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

void added a comment. In D87956#2348433 , @nickdesaulniers wrote: > In phab here, it looks like my newly added > clang/test/Frontend/optimization-remark-missed-inline-stack-protectors.c > fails on windows because I redirect stdout to /dev/null. How doe

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void created this revision. void added reviewers: kees, nickdesaulniers, jyknight. Herald added subscribers: dexonsmith, dang, jdoerfert, pengfei, hiraditya. Herald added a reviewer: aaron.ballman. void requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. The way I select the registers to zero out seems rather fragile. Is there a nicer way to do this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 ___

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 376386. void marked 3 inline comments as done. void added a comment. Fixed some spelling and variable names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: cla

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. Hmm...not working on Linux sounds bad. I'll investigate. Comment at: clang/include/clang/Basic/AttrDocs.td:6116 + +- ``skip`` doesn't zero any call-used registers. +- ``used`` only zeros call-used registers used in the function. By ``used``, we ---

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6116 + +- ``skip`` doesn't zero any call-used registers. +- ``used`` only zeros call-used registers used in the function. By ``used``, we void wrote: > nickdesaulniers wrote: > > Might

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

void added a comment. What are your thoughts on adding a `noprofile` function attribute in the FE? @MaskRay suggested filing a bug with gcov (below) to get their take on it. https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=__open__&component=gcov-profile&list_id=304970&product=gcc Reposi

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

void added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1974 +def NoProfileFunction : InheritableAttr { + let Spellings = [GCC<"no_profile">]; + let Subjects = SubjectList<[Function]>; Is this an attribute that exists in GCC? I couldn't find i

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 382155. void added a comment. Count sub/super registers as "uses" in terminating instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/cla

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. In D110869#3087776 , @nathanchance wrote: > `check-llvm` does not pass with this revision nor does it resolve the boot > failure that Nick mentioned, just in case that was the intention of the > revision :) I ran the kernel throug

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 389101. void added a comment. WIP: Move register selection to a platform-generic place. Not ready for review just yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 F

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 389922. void added a comment. WIP: Implement zeroing out registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td clang/in

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void created this revision. void added reviewers: dblaikie, nickdesaulniers. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A series of unary operators and casts may obscure the variable we're trying to analyze. Ignore them for the un

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:594 // If the predecessor's terminator is an "asm goto" that initializes - // the variable, then it won't be counted as "initialized" on the - // non-fallthrough paths.

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

void updated this revision to Diff 391086. void marked an inline comment as done. void added a comment. Pretend that I've spoken English for most of my lyfe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114848/new/ https://reviews.llvm.org/D114848

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added inline comments. Comment at: clang/test/SemaCXX/array-bounds.cpp:240 -((char*)foo)[sizeof(foo)] = '\0'; // expected-warning {{array index 32768 is past the end of the array (which contains 32768 elements)}} +((char*)foo)[sizeof(foo)] = '\0'; // expected-wa

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 468728. void added a comment. Update the error message to remove the reference to bytes, which can be confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files:

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added a comment. In D135920#3868170 , @aaron.ballman wrote: > Can you please add a release note to mention the diagnostic wording was > patched up? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 468997. void added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnost

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added a comment. @shafik PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 469044. void added a comment. Reformatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSe

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb76219b59020: [clang][Sema] Use correct array size for diagnostic (authored by void). Repository: rG LLVM Github Monore

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void updated this revision to Diff 469332. void added a comment. Update testcases to pass tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 Files: clang/lib/AST/Expr.cpp clang/test/CodeGen/bounds

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void added a comment. @kees @serge-sans-paille I think this is ready for another go. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 ___ cfe-commits maili

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void updated this revision to Diff 469355. void added a comment. Update to support SemaCXX tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 Files: clang/lib/AST/Expr.cpp clang/test/CodeGen/bound

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void updated this revision to Diff 469360. void added a comment. Add "real" FAM to testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews.llvm.org/D135727 Files: clang/lib/AST/Expr.cpp clang/test/CodeGen/bounds-che

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

This revision was automatically updated to reflect the committed changes. Closed by commit rG283e0a81ef35: [clang] Correct sanitizer behavior in union FAMs (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135727/new/ https://reviews

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added a comment. In D135920#3872705 , @shafik wrote: > Apologies for the late reply but after the last changes to the diagnostic > messages are much better. Thanks! Sorry I jumped the gun and submitted before your reply... Repository: rG LLVM G

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void updated this revision to Diff 469805. void added a comment. Integrate the new flag level into the FAM predicate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 Files: clang/include/clang/Basic/Lan

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void updated this revision to Diff 469807. void added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/LangOp

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added a comment. This should be ready for review. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 /// static_asserts in Triple.cpp and in clang/Basic/HLSLRuntime.h. enum class ShaderStage { Pixel = 0, serge-sans-paille wrote: > Looks unrelated to this patch :-) I don't se

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void updated this revision to Diff 470561. void added a comment. Update the release notes to something resembling English. Also add a better explanation of what "3" means. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.ll

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added a comment. In D134902#3882255 , @aaron.ballman wrote: > One thing I would appreciate is, once we're getting close to done with the > work around flexible arrays, is to explicitly document our > implementation-defined behaviors around flexibl

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added a comment. Quick ping to @kees and @serge-sans-paille for any comments. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 ___ cfe-commits mailing li

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f93ae808634: [clang] Implement -fstrict-flex-arrays=3 (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.or

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added a comment. It might be easier to see the main changes here if you submit the (very nice) refactoring of `EmitAsmStores` first. Comment at: clang/lib/CodeGen/CGStmt.cpp:2358 +// the expression, do the conversion. +if (ResultRegTypes[i] != ResultTruncRegTypes[

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

void accepted this revision. void added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 ___

<    1   2   3   4   5   6   >