[clang] bb39b52 - Fix conversions in clang and examples

2020-01-28 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T02:48:15+01:00 New Revision: bb39b52950e77e650fbdd86f7d5e4b89ff0aac4d URL: https://github.com/llvm/llvm-project/commit/bb39b52950e77e650fbdd86f7d5e4b89ff0aac4d DIFF: https://github.com/llvm/llvm-project/commit/bb39b52950e77e650fbdd86f7d5e4b89ff0aac4d.dif

[clang] bd31243 - Fix more implicit conversions. Getting closer to having clang working with gcc 5 again

2020-01-28 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T02:57:59+01:00 New Revision: bd31243a34da8a045c642ddc77b27b0a45a9bf1e URL: https://github.com/llvm/llvm-project/commit/bd31243a34da8a045c642ddc77b27b0a45a9bf1e DIFF: https://github.com/llvm/llvm-project/commit/bd31243a34da8a045c642ddc77b27b0a45a9bf1e.dif

[clang] 757bdc6 - Fix clang unnittest build with GCC 5

2020-01-29 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T10:30:36+01:00 New Revision: 757bdc64d33df61467a7122f22ea76cf163c8dca URL: https://github.com/llvm/llvm-project/commit/757bdc64d33df61467a7122f22ea76cf163c8dca DIFF: https://github.com/llvm/llvm-project/commit/757bdc64d33df61467a7122f22ea76cf163c8dca.dif

[clang-tools-extra] 4e3f4f0 - [ASTMatchers] StringRef'ify hasName

2020-01-29 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T10:53:08+01:00 New Revision: 4e3f4f03f3e4dccfac6212a66d54d584fea328a2 URL: https://github.com/llvm/llvm-project/commit/4e3f4f03f3e4dccfac6212a66d54d584fea328a2 DIFF: https://github.com/llvm/llvm-project/commit/4e3f4f03f3e4dccfac6212a66d54d584fea328a2.dif

[clang-tools-extra] 0ee4b02 - Fix an implicit conversion in clang-tidy. GCC 5 complains about it.

2020-01-29 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T12:05:35+01:00 New Revision: 0ee4b027d37e45391bdd872911c61756d0958722 URL: https://github.com/llvm/llvm-project/commit/0ee4b027d37e45391bdd872911c61756d0958722 DIFF: https://github.com/llvm/llvm-project/commit/0ee4b027d37e45391bdd872911c61756d0958722.dif

[clang-tools-extra] 01213f9 - [clang-tidy] Initialize token before handing it to the lexer

2020-01-29 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T16:48:57+01:00 New Revision: 01213f90700dbb98a0dbcc01da8fdb89f6db5617 URL: https://github.com/llvm/llvm-project/commit/01213f90700dbb98a0dbcc01da8fdb89f6db5617 DIFF: https://github.com/llvm/llvm-project/commit/01213f90700dbb98a0dbcc01da8fdb89f6db5617.dif

r328041 - [format] Initialize regex lazily

2018-03-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 20 13:43:12 2018 New Revision: 328041 URL: http://llvm.org/viewvc/llvm-project?rev=328041&view=rev Log: [format] Initialize regex lazily No need to pay for this on program startup, and also no need to destroy it on process end. Modified: cfe/trunk/lib/Format/Namespa

r328047 - [format] Eliminate global destructors.

2018-03-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 20 14:52:19 2018 New Revision: 328047 URL: http://llvm.org/viewvc/llvm-project?rev=328047&view=rev Log: [format] Eliminate global destructors. Modified: cfe/trunk/lib/Format/BreakableToken.cpp cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Breaka

r329170 - Make helpers static. NFC.

2018-04-04 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Apr 4 04:45:11 2018 New Revision: 329170 URL: http://llvm.org/viewvc/llvm-project?rev=329170&view=rev Log: Make helpers static. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp cfe/trunk/lib/StaticAnalyzer/Core/WorkList.cpp Modified: cfe/tru

[clang-tools-extra] r329292 - [clang-tidy] Remove google-runtime-member-string-references

2018-04-05 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Apr 5 07:51:01 2018 New Revision: 329292 URL: http://llvm.org/viewvc/llvm-project?rev=329292&view=rev Log: [clang-tidy] Remove google-runtime-member-string-references This is triggering on a pattern that's both too broad (const std::string& members can be used safely) and t

r316646 - Fix overloaded static functions in SemaCodeComplete

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 01:41:28 2017 New Revision: 316646 URL: http://llvm.org/viewvc/llvm-project?rev=316646&view=rev Log: Fix overloaded static functions in SemaCodeComplete https://bugs.llvm.org/show_bug.cgi?id=33904 Happens when static function is accessed via the class variable. That l

[clang-tools-extra] r316649 - [clangd] Add a simple fuzzer. It crashes a lot :)

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 03:03:11 2017 New Revision: 316649 URL: http://llvm.org/viewvc/llvm-project?rev=316649&view=rev Log: [clangd] Add a simple fuzzer. It crashes a lot :) Added: clang-tools-extra/trunk/clangd/fuzzer/ clang-tools-extra/trunk/clangd/fuzzer/CMakeLists.txt clang-

[clang-tools-extra] r316650 - [clangd] Don't use /// for non-doxygen comments.

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 03:07:04 2017 New Revision: 316650 URL: http://llvm.org/viewvc/llvm-project?rev=316650&view=rev Log: [clangd] Don't use /// for non-doxygen comments. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp clang-tools-extra/trunk/clangd/tool/ClangdMai

[clang-tools-extra] r316652 - [clangd] Don't crash on empty textDocument/didChange.

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 03:36:20 2017 New Revision: 316652 URL: http://llvm.org/viewvc/llvm-project?rev=316652&view=rev Log: [clangd] Don't crash on empty textDocument/didChange. Found by clangd-fuzzer. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp clang-tools-extra/t

[clang-tools-extra] r316659 - [clangd] Report an error on findDefinitions/signatureHelp on an unopened file instead of crashing.

2017-10-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Oct 26 05:28:13 2017 New Revision: 316659 URL: http://llvm.org/viewvc/llvm-project?rev=316659&view=rev Log: [clangd] Report an error on findDefinitions/signatureHelp on an unopened file instead of crashing. Found by clangd-fuzzer. Modified: clang-tools-extra/trunk/clan

Re: [clang-tools-extra] r316650 - [clangd] Don't use /// for non-doxygen comments.

2017-10-26 Thread Benjamin Kramer via cfe-commits
On Thu, Oct 26, 2017 at 3:16 PM, Jonas Hahnfeld wrote: > Am 2017-10-26 06:07, schrieb Benjamin Kramer via cfe-commits: >> >> Author: d0k >> Date: Thu Oct 26 03:07:04 2017 >> New Revision: 316650 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=316650

[clang-tools-extra] r316770 - [clangd] Harden clangd a bit against garbage input.

2017-10-27 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 27 09:33:15 2017 New Revision: 316770 URL: http://llvm.org/viewvc/llvm-project?rev=316770&view=rev Log: [clangd] Harden clangd a bit against garbage input. There can be nullptrs here if the YAML fails to parse. Found by clangd-fuzzer! Modified: clang-tools-extra/tru

[clang-tools-extra] r316774 - [clangd] Don't crash on extremely large JSON messages.

2017-10-27 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Oct 27 10:06:41 2017 New Revision: 316774 URL: http://llvm.org/viewvc/llvm-project?rev=316774&view=rev Log: [clangd] Don't crash on extremely large JSON messages. Found by clangd-fuzzer. Added: clang-tools-extra/trunk/test/clangd/too_large.test Modified: clang-tools

[clang-tools-extra] r316832 - [clangd] Fix clang-tidy warnings.

2017-10-28 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Oct 28 10:32:56 2017 New Revision: 316832 URL: http://llvm.org/viewvc/llvm-project?rev=316832&view=rev Log: [clangd] Fix clang-tidy warnings. No functionality change intended. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.h clang-tools-extra/trunk/clangd/

r317052 - Make helper function static. NFC.

2017-10-31 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Oct 31 16:23:36 2017 New Revision: 317052 URL: http://llvm.org/viewvc/llvm-project?rev=317052&view=rev Log: Make helper function static. NFC. Modified: cfe/trunk/lib/AST/Type.cpp Modified: cfe/trunk/lib/AST/Type.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/li

r318292 - [libclang] Fix cursors for in-class initializer of field declarations

2017-11-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Nov 15 04:20:41 2017 New Revision: 318292 URL: http://llvm.org/viewvc/llvm-project?rev=318292&view=rev Log: [libclang] Fix cursors for in-class initializer of field declarations Fixes PR33745. Patch by Nikolai Kosjar! Differential Revision: https://reviews.llvm.org/D40027

[clang] 8c7c1f1 - Silence unused variable warning in NDEBUG builds

2023-03-23 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2023-03-23T14:41:03+01:00 New Revision: 8c7c1f11ffaacf762e612c65440fd2cbb58ee426 URL: https://github.com/llvm/llvm-project/commit/8c7c1f11ffaacf762e612c65440fd2cbb58ee426 DIFF: https://github.com/llvm/llvm-project/commit/8c7c1f11ffaacf762e612c65440fd2cbb58ee426.dif

[clang] 1f818f6 - [clang-format] assert(false) -> llvm_unreachable

2023-02-15 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2023-02-15T14:10:09+01:00 New Revision: 1f818f63b829f3038a9fd605bf90348ba58cd981 URL: https://github.com/llvm/llvm-project/commit/1f818f63b829f3038a9fd605bf90348ba58cd981 DIFF: https://github.com/llvm/llvm-project/commit/1f818f63b829f3038a9fd605bf90348ba58cd981.dif

[clang] 7ac658a - [WebAssembly] assert(false) -> llvm_unreachable

2023-02-18 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2023-02-18T09:38:18+01:00 New Revision: 7ac658a07b9a2937f1a9319a47a9cec6afae2370 URL: https://github.com/llvm/llvm-project/commit/7ac658a07b9a2937f1a9319a47a9cec6afae2370 DIFF: https://github.com/llvm/llvm-project/commit/7ac658a07b9a2937f1a9319a47a9cec6afae2370.dif

[clang] d526e2e - Add -no-canonical-prefixes to test that matches the binary name

2023-05-10 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2023-05-10T13:17:35+02:00 New Revision: d526e2ec957fc7bc31d7be3670cd1673c2b4389b URL: https://github.com/llvm/llvm-project/commit/d526e2ec957fc7bc31d7be3670cd1673c2b4389b DIFF: https://github.com/llvm/llvm-project/commit/d526e2ec957fc7bc31d7be3670cd1673c2b4389b.dif

[clang] fcf4e36 - Iterate over StringMaps using structured bindings. NFCI.

2022-12-04 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2022-12-04T18:36:41+01:00 New Revision: fcf4e360ba6b5f005d2c478ca79112be7a61dacb URL: https://github.com/llvm/llvm-project/commit/fcf4e360ba6b5f005d2c478ca79112be7a61dacb DIFF: https://github.com/llvm/llvm-project/commit/fcf4e360ba6b5f005d2c478ca79112be7a61dacb.dif

[clang] 8956852 - Undo a bit of fcf4e360ba6b that confuses MSVC

2022-12-04 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2022-12-04T20:33:25+01:00 New Revision: 89568521943b79fe27c6f3c19799a575318b1882 URL: https://github.com/llvm/llvm-project/commit/89568521943b79fe27c6f3c19799a575318b1882 DIFF: https://github.com/llvm/llvm-project/commit/89568521943b79fe27c6f3c19799a575318b1882.dif

[clang-tools-extra] r289952 - [include-fixer] Desugar incomplete types.

2016-12-16 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Dec 16 10:09:06 2016 New Revision: 289952 URL: http://llvm.org/viewvc/llvm-project?rev=289952&view=rev Log: [include-fixer] Desugar incomplete types. This will look through typedefs so include-fixer will look up the target of the typedef instead of the typedef itself (which

r290135 - [Format] Remove dead code.

2016-12-19 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Dec 19 15:10:50 2016 New Revision: 290135 URL: http://llvm.org/viewvc/llvm-project?rev=290135&view=rev Log: [Format] Remove dead code. No functionality change. Modified: cfe/trunk/lib/Format/Encoding.h cfe/trunk/lib/Format/TokenAnalyzer.h cfe/trunk/lib/Format/Wh

r291408 - Use the correct ObjC EH personality

2017-01-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sun Jan 8 16:58:07 2017 New Revision: 291408 URL: http://llvm.org/viewvc/llvm-project?rev=291408&view=rev Log: Use the correct ObjC EH personality This fixes ObjC exceptions on Win64 (which uses SEH), among others. Patch by Jonathan Schleifer! Modified: cfe/trunk/lib/Code

Re: [PATCH] Use the correct ObjC EH personality

2017-01-08 Thread Benjamin Kramer via cfe-commits
Committed r291408. Thanks! On Sun, Jan 8, 2017 at 9:03 PM, Jonathan Schleifer via cfe-commits wrote: > Sorry, it seems the inline patch has been garbled. > > Trying as an attachment this time. > > > -- > Jonathan > > > ___ > cfe-commits mailing list > c

[clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 9 09:18:28 2017 New Revision: 291446 URL: http://llvm.org/viewvc/llvm-project?rev=291446&view=rev Log: [include-fixer] Load symbol index asynchronously. We don't actually need the index until parse time, so fetch it in the background and start parsing. By the time it is

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-10 Thread Benjamin Kramer via cfe-commits
I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to LINK_LIBS of tools/clang/tools/extra/include-fixer/plugin/CMakeLists.txt help? On Tue, Jan 10, 2017 at 8:31 PM, Bill Seurer wrote: > On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote: >> >> Author:

r291681 - Unbreak the clang-fuzzer build after r291184.

2017-01-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 11 10:42:26 2017 New Revision: 291681 URL: http://llvm.org/viewvc/llvm-project?rev=291681&view=rev Log: Unbreak the clang-fuzzer build after r291184. Modified: cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp Modified: cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp URL:

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

2016-08-16 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good, thanks. Do you have commit access? https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

r279374 - [Sema] Don't crash on scanf on forward-declared enums.

2016-08-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Aug 20 11:51:33 2016 New Revision: 279374 URL: http://llvm.org/viewvc/llvm-project?rev=279374&view=rev Log: [Sema] Don't crash on scanf on forward-declared enums. This is valid in GNU C, which allows pointers to incomplete enums. GCC just pretends that the underlying type is

Re: r279374 - [Sema] Don't crash on scanf on forward-declared enums.

2016-08-20 Thread Benjamin Kramer via cfe-commits
It cycled back to green. flake? On Sat, Aug 20, 2016 at 7:27 PM, Vitaly Buka wrote: > msan is not happy about this change > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/15681/steps/check-llvm%20msan/logs/stdio > > On Sat, Aug 20, 2016 at 9:59 AM Benjamin Kr

Re: [PATCH] D23985: [InstructionSelect] NumBlocks isn't defined in DEBUG build.

2016-08-29 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D23985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D23989: Fix -Wunused-but-set-variable warning.

2016-08-29 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg. Feel free to submit trivial changes like this without pre-commit review. https://reviews.llvm.org/D23989 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D24075: [include-fixer] Support finding headers for the symbol under cursor.

2016-09-07 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I can't really comment on the emacs integration with my limited knowledge of elisp. The rest looks good to me. https://reviews.llvm.org/D24075 ___

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

2016-09-12 Thread Benjamin Kramer via cfe-commits
bkramer added a subscriber: bkramer. bkramer added a comment. One round of llvm-API specifics. Comment at: migrate-tool/BuildManager.h:22 @@ +21,3 @@ +public: + virtual bool addHeaderOnlyLibrary(llvm::StringRef HeaderPath) = 0; + These methods could use some do

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

2016-09-15 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. looks good from my side. https://reviews.llvm.org/D18462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r297779 - [clangd] Fix not being able to attach a debugger on macOS

2017-03-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 14 15:41:28 2017 New Revision: 297779 URL: http://llvm.org/viewvc/llvm-project?rev=297779&view=rev Log: [clangd] Fix not being able to attach a debugger on macOS Clangd is often waiting for input on getline as it awaits requests. If the getline is interrupted, it causes

[clang-tools-extra] r298442 - Apply clang-tidy's performance-unnecessary-value-param to clang-tidy.

2017-03-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 21 16:34:58 2017 New Revision: 298442 URL: http://llvm.org/viewvc/llvm-project?rev=298442&view=rev Log: Apply clang-tidy's performance-unnecessary-value-param to clang-tidy. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguide

r298443 - Apply clang-tidy's performance-unnecessary-value-param to parts of clang.

2017-03-21 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Mar 21 16:35:04 2017 New Revision: 298443 URL: http://llvm.org/viewvc/llvm-project?rev=298443&view=rev Log: Apply clang-tidy's performance-unnecessary-value-param to parts of clang. No functionality change intended. Modified: cfe/trunk/include/clang/Driver/ToolChain.h

r299191 - [msan] Turn off lifetime markers even when use after scope checking is on.

2017-03-31 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Mar 31 04:19:25 2017 New Revision: 299191 URL: http://llvm.org/viewvc/llvm-project?rev=299191&view=rev Log: [msan] Turn off lifetime markers even when use after scope checking is on. Since r299174 use after scope checking is on by default. Even though msan doesn't check for

r299306 - [ObjC++] Use the correct EH personality in GNU mode

2017-04-01 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Apr 1 12:59:01 2017 New Revision: 299306 URL: http://llvm.org/viewvc/llvm-project?rev=299306&view=rev Log: [ObjC++] Use the correct EH personality in GNU mode Previously, it would just always use the ObjC DWARF personality, even with SjLj or SEH exceptions. Patch by Jonath

Re: [PATCH] Use the correct ObjC++ personality

2017-04-01 Thread Benjamin Kramer via cfe-commits
Landed in r299306 with a test case. Yes, even one-liners should have a test case. On Thu, Mar 30, 2017 at 10:30 PM, Jonathan Schleifer via cfe-commits wrote: >> Testcase? > > Shouldn't be necessary for such a simple and extremely obvious one-liner. > > -- > Jonathan >

r300006 - Silence unused variable warning in release builds.

2017-04-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Apr 11 18:06:49 2017 New Revision: 36 URL: http://llvm.org/viewvc/llvm-project?rev=36&view=rev Log: Silence unused variable warning in release builds. Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp URL: http:

r300497 - Revert "Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definit

2017-04-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Apr 17 15:57:40 2017 New Revision: 300497 URL: http://llvm.org/viewvc/llvm-project?rev=300497&view=rev Log: Revert "Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

2017-04-17 Thread Benjamin Kramer via cfe-commits
This broke our internal build of libc++ with modules. Reduced test case attached, courtesy of Richard Smith! With your patch it doesn't compiler anymore: While building module 'x': In file included from :2: In file included from ./c.h:1: ./a.h:3:32: error: inline declaration of 'f' follows non-inl

[clang-tools-extra] r291892 - Fix the build of the include-fixer plugin for some shared cmake builds and MSVC.

2017-01-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jan 13 04:14:07 2017 New Revision: 291892 URL: http://llvm.org/viewvc/llvm-project?rev=291892&view=rev Log: Fix the build of the include-fixer plugin for some shared cmake builds and MSVC. - The include fixer plugin does not directly depend on pthread, but can pick up pthrea

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

2017-01-13 Thread Benjamin Kramer via cfe-commits
of tools/clang/tools/extra/include-fixer/plugin/CMakeLists.txt >> help? > > > That does seem to make it work. > > >> On Tue, Jan 10, 2017 at 8:31 PM, Bill Seurer >> wrote: >>> >>> On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote: >

Re: [PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

2017-01-16 Thread Benjamin Kramer via cfe-commits
I got an email where it says that I accepted the revision. Looks like phab didn't add cfe-commits to the list of recipients though :( On Mon, Jan 16, 2017 at 6:43 PM, David Blaikie wrote: > Looks like Ben signed off on this on Phab - but the email didn't go to the > list (making this look like co

Re: [PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

2017-01-17 Thread Benjamin Kramer via cfe-commits
If we add all state transitions it will only create noise. I will teach myself to always write "lg" into the text field when approving a change instead. On Tue, Jan 17, 2017 at 9:57 AM, Manuel Klimek via cfe-commits wrote: > It's by design. Do we want to change this? I always had the impression >

r292402 - [Basic] Remove source manager references from diag state points.

2017-01-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 18 09:50:26 2017 New Revision: 292402 URL: http://llvm.org/viewvc/llvm-project?rev=292402&view=rev Log: [Basic] Remove source manager references from diag state points. This is just wasted space, we don't support state points from multiple source managers. Validate that

r292406 - [ASTUnit] Reset diag state when creating the ASTUnit.

2017-01-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 18 10:25:48 2017 New Revision: 292406 URL: http://llvm.org/viewvc/llvm-project?rev=292406&view=rev Log: [ASTUnit] Reset diag state when creating the ASTUnit. A client could call this with a dirty diagnostic engine, don't crash. Modified: cfe/trunk/lib/Frontend/ASTUn

[clang-tools-extra] r292405 - [include-fixer] Don't return a correction if the header insertion failed.

2017-01-18 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 18 10:22:58 2017 New Revision: 292405 URL: http://llvm.org/viewvc/llvm-project?rev=292405&view=rev Log: [include-fixer] Don't return a correction if the header insertion failed. This is could happen in cases involving macros and we don't want to return an invalid fixit f

r292927 - [Sema] Fix assumption about typo corrections containing no decl.

2017-01-24 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Jan 24 06:49:59 2017 New Revision: 292927 URL: http://llvm.org/viewvc/llvm-project?rev=292927&view=rev Log: [Sema] Fix assumption about typo corrections containing no decl. This can happen when the typo correction is coming from an external sema source. Test case will follow

r293485 - [IRGen] Make header standalone.

2017-01-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 30 09:39:18 2017 New Revision: 293485 URL: http://llvm.org/viewvc/llvm-project?rev=293485&view=rev Log: [IRGen] Make header standalone. Modified: cfe/trunk/lib/CodeGen/ABIInfo.h Modified: cfe/trunk/lib/CodeGen/ABIInfo.h URL: http://llvm.org/viewvc/llvm-project/cfe/

r293488 - [AST] Make header standalone.

2017-01-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 30 10:00:57 2017 New Revision: 293488 URL: http://llvm.org/viewvc/llvm-project?rev=293488&view=rev Log: [AST] Make header standalone. Most implementations get ptrdiff_t transitively, some don't. Explicitly include cstddef. Modified: cfe/trunk/include/clang/AST/ASTVe

r293518 - [ASTMatchers] Sprinkle some constexpr on the global matcher constructors.

2017-01-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 30 12:20:00 2017 New Revision: 293518 URL: http://llvm.org/viewvc/llvm-project?rev=293518&view=rev Log: [ASTMatchers] Sprinkle some constexpr on the global matcher constructors. This dramatically reduces the size of the global constructors we emit for those variables in

r293523 - [AST] Give TemplateArgumentLoc a constexpr ctor.

2017-01-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Jan 30 12:32:46 2017 New Revision: 293523 URL: http://llvm.org/viewvc/llvm-project?rev=293523&view=rev Log: [AST] Give TemplateArgumentLoc a constexpr ctor. This removes the thread-safe static from clang::TemplateTemplateParmDecl::getDefaultArgument() const::None Modified:

[clang-tools-extra] r294291 - Add a prototype for clangd

2017-02-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 7 04:28:20 2017 New Revision: 294291 URL: http://llvm.org/viewvc/llvm-project?rev=294291&view=rev Log: Add a prototype for clangd clangd is a language server protocol implementation based on clang. It's supposed to provide editor integration while not suffering from the

[clang-tools-extra] r294292 - [clangd] Add missing include.

2017-02-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 7 04:47:40 2017 New Revision: 294292 URL: http://llvm.org/viewvc/llvm-project?rev=294292&view=rev Log: [clangd] Add missing include. Modified: clang-tools-extra/trunk/clangd/Protocol.h Modified: clang-tools-extra/trunk/clangd/Protocol.h URL: http://llvm.org/viewvc

[clang-tools-extra] r294294 - [clangd] Harden test against sed implementations that strip \r.

2017-02-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 7 05:49:03 2017 New Revision: 294294 URL: http://llvm.org/viewvc/llvm-project?rev=294294&view=rev Log: [clangd] Harden test against sed implementations that strip \r. Also clean up logging and don't print \0. Modified: clang-tools-extra/trunk/clangd/ClangDMain.cpp

[clang-tools-extra] r294297 - [clangd] Set stdin to binary to fix tests on windows.

2017-02-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 7 06:40:59 2017 New Revision: 294297 URL: http://llvm.org/viewvc/llvm-project?rev=294297&view=rev Log: [clangd] Set stdin to binary to fix tests on windows. Modified: clang-tools-extra/trunk/clangd/ClangDMain.cpp Modified: clang-tools-extra/trunk/clangd/ClangDMain.

[clang-tools-extra] r294309 - [clangd] Fix subtle use after return.

2017-02-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 7 08:35:09 2017 New Revision: 294309 URL: http://llvm.org/viewvc/llvm-project?rev=294309&view=rev Log: [clangd] Fix subtle use after return. I didn't find this because my main development machine still happens to use libstdc++ with the broken C++11 ABI, which has a glob

[clang-tools-extra] r294312 - [clangd] Ignore comments in clangd input, so we can write tests without sed.

2017-02-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 7 09:37:17 2017 New Revision: 294312 URL: http://llvm.org/viewvc/llvm-project?rev=294312&view=rev Log: [clangd] Ignore comments in clangd input, so we can write tests without sed. Another attempt on making this work on windows. Modified: clang-tools-extra/trunk/cla

[clang-tools-extra] r294314 - [clangd] Strip file:// from the URI when calling formatting.

2017-02-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 7 10:10:17 2017 New Revision: 294314 URL: http://llvm.org/viewvc/llvm-project?rev=294314&view=rev Log: [clangd] Strip file:// from the URI when calling formatting. It confuses FileManager on windows. Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp Mo

r306822 - [Driver] Actually report errors during parsing instead of stopping when there's an error somewhere.

2017-06-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 30 06:21:27 2017 New Revision: 306822 URL: http://llvm.org/viewvc/llvm-project?rev=306822&view=rev Log: [Driver] Actually report errors during parsing instead of stopping when there's an error somewhere. This is a more principled version of r303756. That change was both

[clang-tools-extra] r306823 - Revert "Modify test so that it looks for patterns in stderr as well"

2017-06-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 30 06:23:24 2017 New Revision: 306823 URL: http://llvm.org/viewvc/llvm-project?rev=306823&view=rev Log: Revert "Modify test so that it looks for patterns in stderr as well" This reverts commit r303735. No longer needed after r306822 sends the diagnostics to the proper ou

r306873 - [clang-rename] Just return instead of calling exit(3) from main.

2017-06-30 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jun 30 13:24:32 2017 New Revision: 306873 URL: http://llvm.org/viewvc/llvm-project?rev=306873&view=rev Log: [clang-rename] Just return instead of calling exit(3) from main. Modified: cfe/trunk/tools/clang-rename/ClangRename.cpp Modified: cfe/trunk/tools/clang-rename/Cla

r307472 - [CodeGen] Fold variable into assert.

2017-07-08 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jul 8 07:14:57 2017 New Revision: 307472 URL: http://llvm.org/viewvc/llvm-project?rev=307472&view=rev Log: [CodeGen] Fold variable into assert. Avoids warnings in Release builds. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGen

r308604 - [vfs] Assert that the status is known in equivalent().

2017-07-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Jul 20 04:57:02 2017 New Revision: 308604 URL: http://llvm.org/viewvc/llvm-project?rev=308604&view=rev Log: [vfs] Assert that the status is known in equivalent(). Otherwise we'd silently compare uninitialized data. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Mo

r322687 - Update dump_ast_matchers for many recent changes.

2018-01-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 17 08:50:14 2018 New Revision: 322687 URL: http://llvm.org/viewvc/llvm-project?rev=322687&view=rev Log: Update dump_ast_matchers for many recent changes. The html file hasn't been updated in a long time so there are quite a few changes in there. No matchers were removed

r322779 - [Sema] Allow conversion between long double and __float128.

2018-01-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 17 14:56:57 2018 New Revision: 322779 URL: http://llvm.org/viewvc/llvm-project?rev=322779&view=rev Log: [Sema] Allow conversion between long double and __float128. We should only ban this if long double is a double double. x86's 80 bit long double is fine and supported b

r322783 - [ASTMatchers] Support generating docs for single-line matchers

2018-01-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jan 17 15:14:49 2018 New Revision: 322783 URL: http://llvm.org/viewvc/llvm-project?rev=322783&view=rev Log: [ASTMatchers] Support generating docs for single-line matchers clang-format likes this format. PR35989. Modified: cfe/trunk/docs/tools/dump_ast_matchers.py cf

r323435 - Unused diagnostics can occur in tblgen.

2018-01-25 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Jan 25 07:57:22 2018 New Revision: 323435 URL: http://llvm.org/viewvc/llvm-project?rev=323435&view=rev Log: Unused diagnostics can occur in tblgen. Modified: cfe/trunk/utils/find-unused-diagnostics.sh Modified: cfe/trunk/utils/find-unused-diagnostics.sh URL: http://llv

r323528 - [AST] Use bit packing to reduce sizeof(TypedefNameDecl) from 88 to 80.

2018-01-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jan 26 06:14:11 2018 New Revision: 323528 URL: http://llvm.org/viewvc/llvm-project?rev=323528&view=rev Log: [AST] Use bit packing to reduce sizeof(TypedefNameDecl) from 88 to 80. We can stash the cached transparent tag bit in existing pointer padding. Everything coming out o

r323554 - Try to unbreak 32 bit builds after r323528.

2018-01-26 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Jan 26 12:01:13 2018 New Revision: 323554 URL: http://llvm.org/viewvc/llvm-project?rev=323554&view=rev Log: Try to unbreak 32 bit builds after r323528. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc

[clang-tools-extra] r324079 - [clang-tidy] Don't reinvent the wheel, use existing log2 functions.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:23:21 2018 New Revision: 324079 URL: http://llvm.org/viewvc/llvm-project?rev=324079&view=rev Log: [clang-tidy] Don't reinvent the wheel, use existing log2 functions. This also makes the code ready for int128, even though I think it's currently impossible to get an

[clang-tools-extra] r324080 - [clang-tidy] Remove global constructor. No functionality change intended.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:23:24 2018 New Revision: 324080 URL: http://llvm.org/viewvc/llvm-project?rev=324080&view=rev Log: [clang-tidy] Remove global constructor. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy/misc/RedundantExpressionCheck.cpp Modified:

[clang-tools-extra] r324084 - [clang-tidy] Kill marco. No functionality change.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:39:07 2018 New Revision: 324084 URL: http://llvm.org/viewvc/llvm-project?rev=324084&view=rev Log: [clang-tidy] Kill marco. No functionality change. Modified: clang-tools-extra/trunk/clang-tidy/android/CloexecAccept4Check.cpp clang-tools-extra/trunk/clang-ti

[clang-tools-extra] r324083 - [clang-tidy] Widen anonymous namespace.

2018-02-02 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 2 05:39:00 2018 New Revision: 324083 URL: http://llvm.org/viewvc/llvm-project?rev=324083&view=rev Log: [clang-tidy] Widen anonymous namespace. The matchers in this check are prone to create ODR violations otherwise. No functionality change. Modified: clang-tools-ex

[clang-tools-extra] r294747 - [clangd] Refactor stream output into a single thread-safe output object.

2017-02-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 10 08:08:40 2017 New Revision: 294747 URL: http://llvm.org/viewvc/llvm-project?rev=294747&view=rev Log: [clangd] Refactor stream output into a single thread-safe output object. This abstracts away the passing of raw_ostreams everywhere, thread safety will be used soon.

[clang-tools-extra] r294760 - [clangd] Move isDone from the JSONOutput to ShutdownHandler.

2017-02-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 10 11:25:38 2017 New Revision: 294760 URL: http://llvm.org/viewvc/llvm-project?rev=294760&view=rev Log: [clangd] Move isDone from the JSONOutput to ShutdownHandler. This is just as easy to check from main but prevents random code from shutting down the server. Modified:

r294820 - Update XFAIL line after r294781.

2017-02-10 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Feb 10 20:00:03 2017 New Revision: 294820 URL: http://llvm.org/viewvc/llvm-project?rev=294820&view=rev Log: Update XFAIL line after r294781. Modified: cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c Modified: cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c URL: http:

r294838 - Make helpers static. NFC.

2017-02-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Feb 11 06:21:17 2017 New Revision: 294838 URL: http://llvm.org/viewvc/llvm-project?rev=294838&view=rev Log: Make helpers static. NFC. Modified: cfe/trunk/lib/Analysis/OSLog.cpp cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified: cfe/trunk/lib/Analysis/OSLog.cpp U

r294963 - [ASTUnit] Clear out diagnostic state after creating the preamble.

2017-02-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 13 10:16:43 2017 New Revision: 294963 URL: http://llvm.org/viewvc/llvm-project?rev=294963&view=rev Log: [ASTUnit] Clear out diagnostic state after creating the preamble. If the preamble had diagnostic state this would leave behind invalid state in the DiagnosticsEngine a

[clang-tools-extra] r294974 - [clang-tidy] Reduce indentation. NFC.

2017-02-13 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Feb 13 12:03:10 2017 New Revision: 294974 URL: http://llvm.org/viewvc/llvm-project?rev=294974&view=rev Log: [clang-tidy] Reduce indentation. NFC. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Modified: clang-tools-extra/trunk/clang-tidy/Cl

[clang-tools-extra] r295049 - [clang-tidy] Add support for NOLINTNEXTLINE.

2017-02-14 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Feb 14 06:47:56 2017 New Revision: 295049 URL: http://llvm.org/viewvc/llvm-project?rev=295049&view=rev Log: [clang-tidy] Add support for NOLINTNEXTLINE. Reviewers: alexfh Subscribers: JDevlieghere, cfe-commits Differential Revision: https://reviews.llvm.org/D29899 Added:

[clang-tools-extra] r295180 - [clangd] Wire up ASTUnit and publish diagnostics with it.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 09:04:20 2017 New Revision: 295180 URL: http://llvm.org/viewvc/llvm-project?rev=295180&view=rev Log: [clangd] Wire up ASTUnit and publish diagnostics with it. Summary: This requires an accessible compilation database. The parsing is done asynchronously on a separate t

[clang-tools-extra] r295184 - [clangd] Add missing include.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 09:19:13 2017 New Revision: 295184 URL: http://llvm.org/viewvc/llvm-project?rev=295184&view=rev Log: [clangd] Add missing include. Modified: clang-tools-extra/trunk/clangd/DocumentStore.h Modified: clang-tools-extra/trunk/clangd/DocumentStore.h URL: http://llvm.

[clang-tools-extra] r295187 - [clangd] Fix use after free.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 09:56:14 2017 New Revision: 295187 URL: http://llvm.org/viewvc/llvm-project?rev=295187&view=rev Log: [clangd] Fix use after free. Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp URL: htt

[clang-tools-extra] r295193 - [clangd] Initialize the thread after the mutex.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 10:34:58 2017 New Revision: 295193 URL: http://llvm.org/viewvc/llvm-project?rev=295193&view=rev Log: [clangd] Initialize the thread after the mutex. Otherwise locking the mutex yields a racy assertion failure on picky implementations. Modified: clang-tools-extra/

[clang-tools-extra] r295194 - [clangd] Synchronize logs access.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 10:44:11 2017 New Revision: 295194 URL: http://llvm.org/viewvc/llvm-project?rev=295194&view=rev Log: [clangd] Synchronize logs access. I don't think that this is necessary for correctness, but makes tsan much more useful. Modified: clang-tools-extra/trunk/clangd/

[clang-tools-extra] r295196 - [clangd] Silence GCC warning about falling off a fully covered switch.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 10:58:44 2017 New Revision: 295196 URL: http://llvm.org/viewvc/llvm-project?rev=295196&view=rev Log: [clangd] Silence GCC warning about falling off a fully covered switch. Modified: clang-tools-extra/trunk/clangd/ASTManager.cpp Modified: clang-tools-extra/trunk/c

[clang-tools-extra] r295198 - [clangd] Fix another use after free that I missed because COW strings.

2017-02-15 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Feb 15 11:04:57 2017 New Revision: 295198 URL: http://llvm.org/viewvc/llvm-project?rev=295198&view=rev Log: [clangd] Fix another use after free that I missed because COW strings. Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp Modified: clang-tools-extra/t

r295320 - Silence sign compare warning. NFC.

2017-02-16 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu Feb 16 08:08:41 2017 New Revision: 295320 URL: http://llvm.org/viewvc/llvm-project?rev=295320&view=rev Log: Silence sign compare warning. NFC. ExprConstant.cpp:6344:20: warning: comparison of integers of different signs: 'const size_t' (aka 'const unsigned long') and 'typena

<    1   2   3   4   5   6   7   8   9   10   >