r254446 - Avoid picking up system headers in unittest by providing a fake libstdc++ with a ridiculously high version number.

Author: d0k Date: Tue Dec 1 13:42:07 2015 New Revision: 254446 URL: http://llvm.org/viewvc/llvm-project?rev=254446&view=rev Log: Avoid picking up system headers in unittest by providing a fake libstdc++ with a ridiculously high version number. The host libstdc++ may be horribly broken and we wa

[PATCH] D15147: [clang-format] Reflow block comments when they're over the column limit

bkramer created this revision. bkramer added reviewers: djasper, klimek. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. /* a * a*/ Now becomes /* * a a*/ instead of /* * a * a*/ This is implemented by glueing the next line on while f

[PATCH] D15490: [libclang] Add a flag to create the precompiled preamble on the first parse.

bkramer created this revision. bkramer added reviewers: doug.gregor, klimek. bkramer added a subscriber: cfe-commits. The current default is to create the preamble on the first reparse, aka second parse. This is useful for clients that do not want to block when opening a file because serializing t

Re: [PATCH] D15490: [libclang] Add a flag to create the precompiled preamble on the first parse.

bkramer updated this revision to Diff 42749. bkramer added a comment. Add test case. http://reviews.llvm.org/D15490 Files: include/clang-c/Index.h include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp test/Index/complete-preamble.cpp tools/c-index-test/c-index-test.c tools/libcl

r255635 - [libclang] Add a flag to create the precompiled preamble on the first parse.

Author: d0k Date: Tue Dec 15 03:30:31 2015 New Revision: 255635 URL: http://llvm.org/viewvc/llvm-project?rev=255635&view=rev Log: [libclang] Add a flag to create the precompiled preamble on the first parse. Summary: The current default is to create the preamble on the first reparse, aka second pa

r256377 - Replace llvm::utostr calls in Twine context with Twines. NFC.

Author: d0k Date: Thu Dec 24 04:07:37 2015 New Revision: 256377 URL: http://llvm.org/viewvc/llvm-project?rev=256377&view=rev Log: Replace llvm::utostr calls in Twine context with Twines. NFC. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trun

[clang] 242f98c - [Clang][SME] Skip writing output files to the source directory

Author: Benjamin Kramer Date: 2024-02-22T20:22:00+01:00 New Revision: 242f98c7ab7c100d76cac29b555db20205619b38 URL: https://github.com/llvm/llvm-project/commit/242f98c7ab7c100d76cac29b555db20205619b38 DIFF: https://github.com/llvm/llvm-project/commit/242f98c7ab7c100d76cac29b555db20205619b38

[clang] 28a0792 - Fix typo: tyep -> type.

Author: Brian Yahn Date: 2024-07-31T19:02:48+02:00 New Revision: 28a079223dd22f13ca51dfa8f5d51a9cd3514edf URL: https://github.com/llvm/llvm-project/commit/28a079223dd22f13ca51dfa8f5d51a9cd3514edf DIFF: https://github.com/llvm/llvm-project/commit/28a079223dd22f13ca51dfa8f5d51a9cd3514edf.diff LO

[clang-tools-extra] b810244 - [clang-tidy] Avoid binding nullptr to a reference

Author: Benjamin Kramer Date: 2022-01-21T15:55:17+01:00 New Revision: b8102449a72c5144cb75cfca46e78b517d7f6606 URL: https://github.com/llvm/llvm-project/commit/b8102449a72c5144cb75cfca46e78b517d7f6606 DIFF: https://github.com/llvm/llvm-project/commit/b8102449a72c5144cb75cfca46e78b517d7f6606

[clang-tools-extra] e07823a - [clang-tidy] Make header compile standalone. NFC.

Author: Benjamin Kramer Date: 2022-01-31T11:18:00+01:00 New Revision: e07823ad729a16c609e9e234849f56bf9f1d5f00 URL: https://github.com/llvm/llvm-project/commit/e07823ad729a16c609e9e234849f56bf9f1d5f00 DIFF: https://github.com/llvm/llvm-project/commit/e07823ad729a16c609e9e234849f56bf9f1d5f00

[clang] 9a6b0af - Don't rely on clang being named clang in test

Author: Benjamin Kramer Date: 2022-01-31T13:50:57+01:00 New Revision: 9a6b0afbe18d3abdc17d6208daecb8839b994e4a URL: https://github.com/llvm/llvm-project/commit/9a6b0afbe18d3abdc17d6208daecb8839b994e4a DIFF: https://github.com/llvm/llvm-project/commit

[clang] 51c0650 - Unionize clang::DynTypedNodeList. NFC.

Author: Benjamin Kramer Date: 2022-02-20T12:12:39+01:00 New Revision: 51c0650f6ba8128fb07036b4be8512bb5f727c1a URL: https://github.com/llvm/llvm-project/commit/51c0650f6ba8128fb07036b4be8512bb5f727c1a DIFF: https://github.com/llvm/llvm-project/commit

[clang] 52fcdc8 - Prune unused diagnostics. NFC.

Author: Benjamin Kramer Date: 2022-02-20T14:06:58+01:00 New Revision: 52fcdc8d69d20b48fb5266b00f505dc89b19be9b URL: https://github.com/llvm/llvm-project/commit/52fcdc8d69d20b48fb5266b00f505dc89b19be9b DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 3a1d6a3 - [clangd] Remove uuidof warning. Clang never emits this one.

Author: Benjamin Kramer Date: 2022-02-20T14:44:47+01:00 New Revision: 3a1d6a361c822173abd87ff47fd8613892fc747f URL: https://github.com/llvm/llvm-project/commit/3a1d6a361c822173abd87ff47fd8613892fc747f DIFF: https://github.com/llvm/llvm-project/commit

[clang] ce0fdf1 - Put back err_drv_negative_columns/err_drv_small_columns for flang

Author: Benjamin Kramer Date: 2022-02-20T15:42:20+01:00 New Revision: ce0fdf116334506bd5c4609ab86111f8136a1408 URL: https://github.com/llvm/llvm-project/commit/ce0fdf116334506bd5c4609ab86111f8136a1408 DIFF: https://github.com/llvm/llvm-project/commit/ce0fdf116334506bd5c4609ab86111f8136a1408

[clang] b32ead4 - Increase the limit on parser diagnostics

Author: Benjamin Kramer Date: 2022-02-21T11:44:48+01:00 New Revision: b32ead41b16af993918b14b243d08d04dcdcd4c9 URL: https://github.com/llvm/llvm-project/commit/b32ead41b16af993918b14b243d08d04dcdcd4c9 DIFF: https://github.com/llvm/llvm-project/commit/b32ead41b16af993918b14b243d08d04dcdcd4c9

[clang] fb3a2d4 - [Sema] Silence unused variable warning in Release builds. NFC.

Author: Benjamin Kramer Date: 2022-02-24T11:00:52+01:00 New Revision: fb3a2d45cd79d3573dafcb7d26df355266b0228c URL: https://github.com/llvm/llvm-project/commit/fb3a2d45cd79d3573dafcb7d26df355266b0228c DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] dfed8f5 - [clangd] Add a missing include. NFC.

Author: Benjamin Kramer Date: 2022-02-26T13:23:06+01:00 New Revision: dfed8f556d270cec0ac849ce1208671f33454534 URL: https://github.com/llvm/llvm-project/commit/dfed8f556d270cec0ac849ce1208671f33454534 DIFF: https://github.com/llvm/llvm-project/commit/dfed8f556d270cec0ac849ce1208671f33454534

[clang-tools-extra] 6c72a97 - [clangd] Qualify calls to std::move to silence -Wunqualified-std-cast-call. NFC.

Author: Benjamin Kramer Date: 2022-02-26T13:36:14+01:00 New Revision: 6c72a97c0e2d9dd884d67315629be1c219da3b34 URL: https://github.com/llvm/llvm-project/commit/6c72a97c0e2d9dd884d67315629be1c219da3b34 DIFF: https://github.com/llvm/llvm-project/commit/6c72a97c0e2d9dd884d67315629be1c219da3b34

[clang] a887b95 - [clang-format] Turn global COperatorsFollowingVar vector into a switch

Author: Benjamin Kramer Date: 2022-03-05T18:00:16+01:00 New Revision: a887b95edf34117b0274e5c9443ef6afa58b058a URL: https://github.com/llvm/llvm-project/commit/a887b95edf34117b0274e5c9443ef6afa58b058a DIFF: https://github.com/llvm/llvm-project/commit

[clang] 14af99d - [OpenCL] Turn global vector into static array. NFCI.

Author: Benjamin Kramer Date: 2022-03-05T19:16:28+01:00 New Revision: 14af99d375b6c47e4b5ec457fb1f1f02b71a8566 URL: https://github.com/llvm/llvm-project/commit/14af99d375b6c47e4b5ec457fb1f1f02b71a8566 DIFF: https://github.com/llvm/llvm-project/commit/14af99d375b6c47e4b5ec457fb1f1f02b71a8566

[clang] e44bbed - Make ParsedAttrInfo and subclasses use constexpr construction

Author: Benjamin Kramer Date: 2022-03-05T20:37:21+01:00 New Revision: e44bbedb3261e918dcbd77d271dcdf0c89a41ce0 URL: https://github.com/llvm/llvm-project/commit/e44bbedb3261e918dcbd77d271dcdf0c89a41ce0 DIFF: https://github.com/llvm/llvm-project/commit/e44bbedb3261e918dcbd77d271dcdf0c89a41ce0

[clang] afc14a0 - Retire llvm::make_reverse_iterator in favor of std::make_reverse_iterator

Author: Benjamin Kramer Date: 2022-01-05T14:07:08+01:00 New Revision: afc14a0d1767d9f9dc1b9d81a2f76916ba2bab61 URL: https://github.com/llvm/llvm-project/commit/afc14a0d1767d9f9dc1b9d81a2f76916ba2bab61 DIFF: https://github.com/llvm/llvm-project/commit/afc14a0d1767d9f9dc1b9d81a2f76916ba2bab61

[clang] 765dd8b - [CGBuiltin] Simplify code. NFCI.

Author: Benjamin Kramer Date: 2022-01-14T16:02:02+01:00 New Revision: 765dd8b8a44cd9689c87c0433739f421b9871061 URL: https://github.com/llvm/llvm-project/commit/765dd8b8a44cd9689c87c0433739f421b9871061 DIFF: https://github.com/llvm/llvm-project/commit/765dd8b8a44cd9689c87c0433739f421b9871061

[clang] 4c7de4f - Thread safety analysis: Remove unused variable. NFC.

Author: Benjamin Kramer Date: 2021-12-09T18:57:43+01:00 New Revision: 4c7de4fbda03f38514c4aebed34dc2bbfb7e62a5 URL: https://github.com/llvm/llvm-project/commit/4c7de4fbda03f38514c4aebed34dc2bbfb7e62a5 DIFF: https://github.com/llvm/llvm-project/commit/4c7de4fbda03f38514c4aebed34dc2bbfb7e62a5

[clang-tools-extra] cff1927 - [clang-include-fixer] Fix incorrect ranking because of dangling references

Author: Danila Kutenin Date: 2021-12-20T15:56:57+01:00 New Revision: cff192739bb6dd67b2ec58f055af2ae2834c4348 URL: https://github.com/llvm/llvm-project/commit/cff192739bb6dd67b2ec58f055af2ae2834c4348 DIFF: https://github.com/llvm/llvm-project/commit/cff192739bb6dd67b2ec58f055af2ae2834c4348.diff

[clang] 19d2c65 - [CodeGen] Don't crash on for loops with cond variables and no increment

Author: Benjamin Kramer Date: 2021-03-19T20:43:52+01:00 New Revision: 19d2c65ddd757997785163709800f837857f686d URL: https://github.com/llvm/llvm-project/commit/19d2c65ddd757997785163709800f837857f686d DIFF: https://github.com/llvm/llvm-project/commit

[libunwind] 5ece556 - [libunwind] Don't include cet.h/immintrin.h unconditionally

Author: Benjamin Kramer Date: 2021-08-26T11:37:07+02:00 New Revision: 5ece5562719dde1d8e88fdb41ec5ac0cf6f05274 URL: https://github.com/llvm/llvm-project/commit/5ece5562719dde1d8e88fdb41ec5ac0cf6f05274 DIFF: https://github.com/llvm/llvm-project/commit/5ece5562719dde1d8e88fdb41ec5ac0cf6f05274

[clang] b644726 - [PPC][InlineASM] Don't write to source directory in test

Author: Benjamin Kramer Date: 2024-06-24T16:35:07+02:00 New Revision: b6447260748086c0df484ec6609f126ae90e91ea URL: https://github.com/llvm/llvm-project/commit/b6447260748086c0df484ec6609f126ae90e91ea DIFF: https://github.com/llvm/llvm-project/commit

[clang] a1ad988 - [clang] Make header self-contained. NFC.

Author: Benjamin Kramer Date: 2024-06-27T09:21:37+02:00 New Revision: a1ad98813006cefcdf88336db3f81a15b6bf36fb URL: https://github.com/llvm/llvm-project/commit/a1ad98813006cefcdf88336db3f81a15b6bf36fb DIFF: https://github.com/llvm/llvm-project/commit

[clang] 2033b1c - [CodeGen] Don't write coverage to source directory in test

Author: Benjamin Kramer Date: 2024-06-27T11:21:42+02:00 New Revision: 2033b1cf16f040e1369d8efba8439dcd3e36ed31 URL: https://github.com/llvm/llvm-project/commit/2033b1cf16f040e1369d8efba8439dcd3e36ed31 DIFF: https://github.com/llvm/llvm-project/commit/2033b1cf16f040e1369d8efba8439dcd3e36ed31

[clang] afc6da4 - [clang][dataflow] Silence unused variable warning. NFCI

Author: Benjamin Kramer Date: 2024-10-17T01:36:15+02:00 New Revision: afc6da43d5ae068d041728d96b6b6590f94afbb0 URL: https://github.com/llvm/llvm-project/commit/afc6da43d5ae068d041728d96b6b6590f94afbb0 DIFF: https://github.com/llvm/llvm-project/commit/afc6da43d5ae068d041728d96b6b6590f94afbb0

[clang] 32baf29 - Make NoopLattice.h self-contained

Author: Benjamin Kramer Date: 2024-10-25T14:48:38+02:00 New Revision: 32baf2917357b4e5a566ff43c6e0156e5ad10cb8 URL: https://github.com/llvm/llvm-project/commit/32baf2917357b4e5a566ff43c6e0156e5ad10cb8 DIFF: https://github.com/llvm/llvm-project/commit/32baf2917357b4e5a566ff43c6e0156e5ad10cb8

[clang] c23d6df - [AArch64] Don't define reserved macros

Author: Benjamin Kramer Date: 2024-09-17T19:07:36+02:00 New Revision: c23d6df60d62f971d957e730f6fe55ea89541f6b URL: https://github.com/llvm/llvm-project/commit/c23d6df60d62f971d957e730f6fe55ea89541f6b DIFF: https://github.com/llvm/llvm-project/commit

[clang] 647cadb - explicitly specify the -fopenmp lib in spirv-openmp-toolchain.c test

Author: Benjamin Kramer Date: 2025-01-07T12:14:05+01:00 New Revision: 647cadb60af60f9748b0a2f02d7d6421588b099f URL: https://github.com/llvm/llvm-project/commit/647cadb60af60f9748b0a2f02d7d6421588b099f DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 35c5e56 - Clean up -Wdangling-assignment-gsl in clang and mlir

Author: Benjamin Kramer Date: 2025-01-08T14:46:15+01:00 New Revision: 35c5e56b6113b468b521c071ac141b4bb94da1d7 URL: https://github.com/llvm/llvm-project/commit/35c5e56b6113b468b521c071ac141b4bb94da1d7 DIFF: https://github.com/llvm/llvm-project/commit/35c5e56b6113b468b521c071ac141b4bb94da1d7

[clang-tools-extra] a3b4d91 - Fix -Wdangling-assignment-gsl in ClangdLSPServerTests

Author: Benjamin Kramer Date: 2025-01-08T16:16:46+01:00 New Revision: a3b4d9147406cbd90090466a9b2b9bb2e9f6000c URL: https://github.com/llvm/llvm-project/commit/a3b4d9147406cbd90090466a9b2b9bb2e9f6000c DIFF: https://github.com/llvm/llvm-project/commit

[clang] fe162be - Make test more lenient for custom clang version strings

Author: Benjamin Kramer Date: 2025-01-08T16:12:47+01:00 New Revision: fe162bed532b78f606fe3d937ba732787dd7bd64 URL: https://github.com/llvm/llvm-project/commit/fe162bed532b78f606fe3d937ba732787dd7bd64 DIFF: https://github.com/llvm/llvm-project/commit/fe162bed532b78f606fe3d937ba732787dd7bd64

[clang-tools-extra] e1cc5e9 - [clang-tidy] Fix build after 3dc159431be7a8c5f1a26a8bd57794f1c7008969

Author: Benjamin Kramer Date: 2025-02-24T12:40:02+01:00 New Revision: e1cc5e9f9ab628f501bb88488e865c2a039321e4 URL: https://github.com/llvm/llvm-project/commit/e1cc5e9f9ab628f501bb88488e865c2a039321e4 DIFF: https://github.com/llvm/llvm-project/commit/e1cc5e9f9ab628f501bb88488e865c2a039321e4

[clang] 85eb725 - [clang] Fix use-after-scope when diagnosting __attribute__((format_matches))

Author: Benjamin Kramer Date: 2025-02-25T16:41:52+01:00 New Revision: 85eb7259d9e1ab57e9fac248096d73505a60c072 URL: https://github.com/llvm/llvm-project/commit/85eb7259d9e1ab57e9fac248096d73505a60c072 DIFF: https://github.com/llvm/llvm-project/commit/85eb7259d9e1ab57e9fac248096d73505a60c072

[clang] 9e2eb95 - [Coroutines] [CodeGen] Don't actually emit an output file from unit test

Author: Benjamin Kramer Date: 2025-02-28T15:13:27+01:00 New Revision: 9e2eb95c238d5d7b059da766b24e5a01c683bf7a URL: https://github.com/llvm/llvm-project/commit/9e2eb95c238d5d7b059da766b24e5a01c683bf7a DIFF: https://github.com/llvm/llvm-project/commit

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

bkramer added a comment. Test case? Comment at: lib/CodeGen/CGBuiltin.cpp:1563 +Value *Result = Builder.CreateCall(F, {Tmp, Builder.getTrue()}); +if (Result->getType() != ResultType) + Result = Builder.CreateIntCast(Result, ResultType, /*isSigned*/true, ---

[PATCH] D50168: [Builtins] Implement __builtin_clrsb to be compatible with gcc

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D50168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D46942: Add vfs::FileSystem::getRealPath

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Please watch the windows buildbots carefully after landing this. Comment at: lib/Basic/FileManager.cpp:537 -#ifdef LLVM_ON_UNIX - char CanonicalNameBuf[PATH_

[PATCH] D47060: [VFS] Implement getRealPath for OverlayFileSystem.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Basic/VirtualFileSystem.cpp:387 + SmallVectorImpl &Output) const { + // Not using overlays_begin/end because this method i

[PATCH] D47074: [Tooling] Add an overload of runToolOnCodeWithArgs that takes VFS

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D47074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D47262: [VFS] Implement getRealPath in InMemoryFileSystem.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D47262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D38228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D38225: [clangd] Fix missing "message" key when responding with unsupported method

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good. Do you have commit access? https://reviews.llvm.org/D38225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer.

bkramer created this revision. If the variable construction can be constant evaluated it doesn't have side effects, so removing it is always safe. We only try to evaluate variables that are unused, there should be no impact on compile time. https://reviews.llvm.org/D38678 Files: lib/Sema/Sema

[PATCH] D37970: [clangd] Added a command-line arg to mirror clangd input into a file.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks useful, thanks! https://reviews.llvm.org/D37970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D38617: Set PreprocessorOpts.GeneratePreamble=true in PrecompiledPreamble.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. A testcase would be nice, but this can go in to unblock things. https://reviews.llvm.org/D38617 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D51729: [Tooling] JSONCompilationDatabasePlugin infers compile commands for missing files

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I like it Repository: rC Clang https://reviews.llvm.org/D51729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > Backwards-compatibility note

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:135 + // For compatibility with old Status-based API. Prefer using Path directly. + StringRef getName() const { return Path; } +}; sammccall wrote: > sammccall wrote: > > bkramer

[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D51921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D49274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D48873: [AST] Use llvm::TrailingObjects in CXXTryStmt

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D48873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D50156: [test] Fix %hmaptool path for standalone builds

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, thanks Repository: rC Clang https://reviews.llvm.org/D50156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D43371: [clang-include-fixer] Use add_clang_tool instead of add_clang_executable

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D43567: [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D43567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Make sure to watch the windows buildbots after submitting. https://reviews.llvm.org/D33416 ___ cfe-commits mailing list cfe-commits

[PATCH] D33678: [clangd] Mark results of clangd requests with a tag provided by the FileSystemProvider.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D33678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, but I'm wondering if we should also change the default in clang-apply-replacements itself. https://reviews.llvm.org/D33930 ___ cfe

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

bkramer added inline comments. Comment at: include/clang/Format/Format.h:1700 +typedef std::map> +MapType; Why unique_ptr? Comment at: include/clang/Format/Format.h:1706 +// FormatStyleSet. +void Add(FormatStyle Style); +

[PATCH] D41487: [clang-format] Adds a FormatStyleSet

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D41487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added a comment. I'd like to, but I don't know when I find time to rebase this thing after more than a year of waiting for review. https://reviews.llvm.org/D23130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D47864: [python] Fix most Python binding unittests on Windows

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I don't know much about the python bindings, but this is probably fine. Repository: rC Clang https://reviews.llvm.org/D47864 ___ cfe-commits

[PATCH] D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes).

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This makes sense to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56665/new/ https://reviews.llvm.org/D56665 _

[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

bkramer accepted this revision. bkramer added inline comments. Comment at: lib/Lex/HeaderSearch.cpp:313 // check whether we'll have a suggestion for a module. - const FileEntry *File = getFileMgr().getFile(FileName, /*OpenFile=*/true); + const FileEntry *File = getFileMgr().

[PATCH] D57442: [OpenGL] Fix test on PPC after r352540

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57442/new/ https://reviews.llvm.org/D57442 ___ cfe-commits ma

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer added a comment. I'd be interested in hearing how this is used. I added this feature as an experiment a while back but it simply didn't work as I envisioned it to. Some checks do work but the overall latency makes it unusable in an IDE setting. People repeatedly asked me to remove it be

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The performance difference on preprocessing huge files was tiny back then, doesn't surprise me that it disappeared. What did you test this on? Dropping it is fine with me. Repository: rC

[PATCH] D55415: Revert removal of tidy plugin support from libclang

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think that's a fair point for bringing it back for now. It's not supported though and we will get rid of it eventually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55415/new/ h

[PATCH] D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

bkramer created this revision. bkramer added reviewers: saugustine, ilya-biryukov. Herald added a subscriber: jlebar. Herald added a project: clang. We already handle pointers and references, member ptrs are just another special case. Fixes PR40732. Repository: rG LLVM Github Monorepo https:/

[PATCH] D59750: Rename directory housing clang-include-fixer to be eponymous

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg. Is the reference from libclang still around? Might need an update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59750/new/ https://reviews.llvm.org/D59750 __

[PATCH] D60201: Make clangd-fuzzer use the normal add_llvm_fuzzer() machinery

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60201/new/ https://reviews.llvm.org/D60201 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D52264: Deduplicate replacements from diagnostics.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D37382: Fixed a crash in code completion.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D37382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D37564: Update users of llvm::sys::ExecuteAndWait etc.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm too https://reviews.llvm.org/D37564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D45603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D46148: [CUDA] Added -f[no-]cuda-short-ptr option

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D46148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D48845: [Sema] Add fixit for unused lambda captures

bkramer added inline comments. Comment at: test/FixIt/fixit-unused-lambda-capture.cpp:31 + // CHECK: [=,&i] { return i; }; +} This needs tests for: * capture initializers `[c = foo()] {};` * Capturing this `[this] {};` * Capturing *this `[*this] {};` * VLA capt

[PATCH] D49484: [CodeComplete] Allow getDeclaration on RK_Pattern result.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D49484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D49302: [AST] Various micro-optimizations in CXXInheritance

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. cool Repository: rC Clang https://reviews.llvm.org/D49302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1080 + unsigned int r; + asm("vabsdiff2.u32.u32.u32.sat %0,%1,%2,0;" : "=r"(r) : "r"(__a), "r"(__b)); +

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Nice, those relocations have annoyed me for years. I'm worried about whether the way you're accessing StaticDiagInfoDescriptionStringTable might be undefined behavior. I won't block this cha

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77420/new/ https://reviews.llvm.org/D77420 ___

[PATCH] D77420: Also look for devtoolset-9 gcc toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b9c6c16c33d: Also look for devtoolset-9 gcc toolchain (authored by stephan.dollberg, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78213/new/ https://reviews.llvm.org/D78213 ___

[PATCH] D78214: [libclang]: visit C++17 if init statements

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new/ https://reviews.llvm.org/D78214 ___

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG4597e3bd475b: [libclang]: visit BindingDecl in DecompositionDecl (authored by milianw, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D78214: [libclang]: visit C++17 if init statements

This revision was automatically updated to reflect the committed changes. Closed by commit rG08e181264318: [libclang]: visit C++17 if init statements (authored by milianw, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new

[PATCH] D40302: Avoid copying the data of in-memory preambles

bkramer added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:101 /// is accessible. + /// For in-memory preambles, PrecompiledPreamble instance continues to owns + /// the MemoryBuffer with the Preamble after this method returns. The caller ---

[PATCH] D40302: Avoid copying the data of in-memory preambles

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D40435: [clang-format] Deduplicate using declarations

bkramer added inline comments. Comment at: lib/Format/UsingDeclarationsSorter.cpp:115 +bool usingDeclarationsEqual(const UsingDeclaration &a, +const UsingDeclaration &b) { I'd use a lambda instead. https://reviews.llvm.org/D40435

[PATCH] D40435: [clang-format] Deduplicate using declarations

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D40439: [Tooling] Remove file/command enumeration from CompilationDatabase.

bkramer added a comment. There are a few users of the C++ API out there, do we have migration path for them? https://reviews.llvm.org/D40439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

bkramer requested changes to this revision. bkramer added inline comments. This revision now requires changes to proceed. Comment at: clangd/Context.h:79 +/// Otherwise returns an empty Context. +Context &globalCtx(); + This is a giant code smell. If we want the

[PATCH] D40643: [libclang] Add function to get the buffer for a file

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

<    5   6   7   8   9   10   11   12   >