[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 updated this revision to Diff 404244. benshi001 retitled this revision from "[clang][AVR] Fix a crash in AVRTargetCodeGenInfo::getGlobalVarAddressSpace" to "[clang][AVR] Set '-fno-use-cxa-atexit' to default". benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION ht

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 added a comment. This patch fixes https://github.com/llvm/llvm-project/issues/43443 https://github.com/llvm/llvm-project/issues/50631 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___ cf

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 added a comment. AVR is baremetal environment, it does not support __cxa_atexit() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 added a comment. AVR is baremetal environment, it does not support __cxa_atexit(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D118535: [clang] Move XCore specific options from Clang.cpp to XCore.cpp

benshi001 created this revision. benshi001 added reviewers: MaskRay, rsmith. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118535 Files: clang/lib/D

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

benshi001 added a comment. fixes https://github.com/llvm/llvm-project/issues/50631 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118445/new/ https://reviews.llvm.org/D118445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. In D118095#3282039 , @MaskRay wrote: > I do not know whether the complexity is justified. Rejecting some -mmcu= for > C source files looks quite dubious. Does it really help users? > > Bear in mind that all these complexity tra

[PATCH] D118535: [clang] Move XCore specific options from Clang.cpp to XCore.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac3894cf1e09: [Clang] Move XCore specific options from Clang.cpp to XCore.cpp (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118445: [clang][AVR] Set '-fno-use-cxa-atexit' to default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG653836251ac4: [clang][AVR] Set '-fno-use-cxa-atexit' to default (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 404340. benshi001 retitled this revision from "[AVR][clang] Reject non assembly source files for the avr1 family" to "[clang][AVR] Reject non assembly source files for the avr1 family". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ htt

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 added a comment. The other implementation (https://reviews.llvm.org/D117423) is abundoned, since we should not put AVR specified checks in the common code in Clang.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 ___

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 abandoned this revision. benshi001 added a comment. Re-implement in https://reviews.llvm.org/D118095 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117423/new/ https://reviews.llvm.org/D117423 ___ cfe-commits mailing list cfe-commits

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 404344. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

benshi001 created this revision. benshi001 added reviewers: MaskRay, dylanmckay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://re

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

benshi001 added a comment. There are also other AVR tests in the folder clang/test/CodeGen/avr, so it would be better to put them together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120468/new/ https://reviews.llvm.org/D120468 ___

[PATCH] D120475: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. The standard calling convention of AVR is documented at ht

[PATCH] D120475: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 updated this revision to Diff 411090. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120475/new/ https://reviews.llvm.org/D120475 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/argument.c Inde

[PATCH] D120475: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 updated this revision to Diff 411094. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120475/new/ https://reviews.llvm.org/D120475 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/argument.c Inde

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

benshi001 updated this revision to Diff 411107. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120468/new/ https://reviews.llvm.org/D120468 Files: clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/alias-avr.c clang/test/CodeGen/avr-buil

[PATCH] D120468: [clang][NFC] Move all avr CodeGen tests to avr specific directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91c587b3b1d6: [clang][NFC] Move all avr CodeGen tests to avr specific directory (authored by benshi001). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D118095: [clang][AVR] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 412300. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118095/new/ https://reviews.llvm.org/D118095 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/Too

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 added a comment. Herald added a project: All. This patch is a correct implementation against to the abundoned https://reviews.llvm.org/D120475 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120720/new/ https://reviews.llvm.org/D120720 __

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 updated this revision to Diff 412357. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120720/new/ https://reviews.llvm.org/D120720 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/argument.c Inde

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 397279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 added a comment. In D115982#3218124 , @aykevl wrote: > avr-gcc checks whether the device supports the flash bank used. For example: > > $ cat test.c > int d = 5; > const int ro = 5; > __flash const int f = 5; > __flash1 const int f1 =

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 397287. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 added a comment. In D115982#3218124 , @aykevl wrote: > avr-gcc checks whether the device supports the flash bank used. For example: > > $ cat test.c > int d = 5; > const int ro = 5; > __flash const int f = 5; > __flash1 const int f1 =

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 398846. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D116994: [RISCV] Add bfp and bfpw intrinsic in zbf extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16877c5d2cd3: [RISCV] Add bfp and bfpw intrinsic in zbf extension (authored by Lian Wang , committed by benshi001).

[PATCH] D117380: [RISCV] [Clang] Add attra for crc32_d/crc32c_d

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8123e2ed7490: [RISCV][Clang] Add attrs to crc32_d/crc32c_d (authored by Chenbing.Zheng, committed by benshi001). Repository: rG LLVM Github Monore

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay, MaskRay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Devices belongs to the avr1 family do not has SRA

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added a comment. This is GCC's handling on AVR https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/config/avr/avr.c;h=62973927fdc30d502e5d225f83cdde958bf2dad0;hb=refs/heads/master#l10424 around line 10433 / function `static void avr_file_start (void)`, gcc rises an error `architecture %q

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 updated this revision to Diff 400375. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117423/new/ https://reviews.llvm.org/D117423 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Dr

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:419 +StringRef Arg(DriverArgs.getArgString(I)); +if (Arg.equals("assembler-with-cpp")) + return; We need not care about '-x c++' or '-x c', which are excluded by above c

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:417 + // '-x assembler-with-cpp' if it has not a '.S' suffix. + for (unsigned I = 0; I < DriverArgs.size(); I++) { +StringRef Arg(DriverArgs.getArgString(I)); In this for loop,

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D11598

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 395284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 395807. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 395809. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl, MaskRay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to AVR ABI (https://gcc.gnu.org/wiki/avr-gcc), retu

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 updated this revision to Diff 332871. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/struct.c ==

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 added a comment. This patch just fix the wrong return type in ABI. The wrong parameters passing with be fixed in another patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 ___ cfe-commit

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 added a comment. fully fixes https://bugs.llvm.org/show_bug.cgi?id=39251 partially fixes https://bugs.llvm.org/show_bug.cgi?id=46140 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 ___ cfe-co

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. fixes https://bugs.llvm.org/show_bug.cgi?id=31568 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. > I am guessing this will only be supported by 1 target in clang? Then target > address spaces make sense otherwise you can also extend the language address > space enum. Are you also planning to add `__flashN`? > https://gcc.gnu.org/onlinedocs/gcc/Named-Address-Spa

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 333659. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added inline comments. Comment at: clang/test/CodeGen/avr-flash.c:1 +// RUN: %clang_cc1 -triple avr -emit-llvm-only -verify %s + Anastasia wrote: > If you are only checking the diagnostics you should pass: > > `-emit-llvm-only` -> `-syntax-only` > > a

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 334330. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2659266 , @Anastasia wrote: > Btw is any pointer conversion between address space 1 and the default address > space allowed? I.e. is the following code valid: > > __flash static const int var1[] = {111, 222, 333}; >

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2659266 , @Anastasia wrote: > Btw is any pointer conversion between address space 1 and the default address > space allowed? I.e. is the following code valid: > > __flash static const int var1[] = {111, 222, 333}; >

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked 3 inline comments as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/avr-flash.c:1 +// RUN: %clang_cc1 -triple avr -emit-llvm-only -verify %s + benshi001 wrote: > Anastasia wrote: > > If you are only checking the diagnostics

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 334336. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:159 +def err_verify_nonconst_addrspace : Error< + "qualifier 'const' is needed for variables in address space '%0'">;

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 updated this revision to Diff 334885. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/struct.c ==

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked an inline comment as done. benshi001 added a comment. In D97669#2661560 , @Anastasia wrote: > Is `stdio.h` used by anything? No. `stdio.h` is not used. But if I do `#include `, then `-I /usr/lib/avr/include` must be specified in the com

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 marked an inline comment as done. benshi001 added a comment. In D96853#2661168 , @Anastasia wrote: > In D96853#2660443 , @benshi001 wrote: > >> In D96853#2659266 ,

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 updated this revision to Diff 335368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/struct.c ==

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { Anastasia wrote: > benshi

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const

[PATCH] D100022: [clang][NFC] Fix method names not in accordance with coding style requirement

benshi001 created this revision. benshi001 added a reviewer: Anastasia. Herald added subscribers: frasercrmck, phosek, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, mstorsjo, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD

[PATCH] D100022: [clang][NFC] Fix method names not in accordance with coding style requirement

benshi001 added a comment. It seems the class `ToolChain` and its sub classes also have other methods not in accordance with the coding style. But fixing all of them really needs big effort. Can we fix addClangSystemIncludeArgs first, and then let https://reviews.llvm.org/D97669 pass ? Repo

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2676826 , @Anastasia wrote: > In D97669#2665865 , @benshi001 wrote: > >> In D97669#2661560 , @Anastasia >> wrote: >> >>> Is `stdio.h` u

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f173c0c42d0: [clang][AVR] Support variable decorator '__flash' (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D96853?vs=334336&id=336593#toc Repository: rG LLVM Github Mo

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2685698 , @Anastasia wrote: > In D97669#2678460 , @benshi001 wrote: > >> In D97669#2676826 , @Anastasia >> wrote: >> >>> In D97669#26658

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 updated this revision to Diff 337591. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97669/new/ https://reviews.llvm.org/D97669 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/basic_avr_tree/usr/lib/avr/include/.keep

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2688771 , @Anastasia wrote: > In D97669#2687419 , @benshi001 wrote: > >> In D97669#2685698 , @Anastasia >> wrote: >> >>> In D97669#26784

[PATCH] D100616: [clang] Fix a potential assert failure

benshi001 created this revision. benshi001 added a reviewer: MaskRay. Herald added subscribers: s.egerton, simoncook, dschuff. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. The calculation of LargestBuiltinID needs all t

[PATCH] D100616: [clang][NFC] Fix a potential assert failure

benshi001 updated this revision to Diff 338045. benshi001 retitled this revision from "[clang] Fix a potential assert failure" to "[clang][NFC] Fix a potential assert failure". benshi001 added a reviewer: craig.topper. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100616/new/ https://rev

[PATCH] D100616: [clang][NFC] Fix a potential assert failure

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/include/clang/Basic/TargetBuiltins.h:334 static constexpr uint64_t LargestBuiltinID = std::max( {NEON::FirstTSBuiltin, ARM::LastTSBuiltin, SVE::FirstTSBuiltin, AArch64

[PATCH] D100616: [clang][NFC] Fix a potential assert failure

This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rG06995fe256ec: [clang][NFC] Fix a potential assert failure (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D10070

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 added a comment. Some key points, 1. This patch fixes the bug https://bugs.llvm.org/show_bug.cgi?id=31530 . 2. The test builtins.cpp is disabled on AVR, due to uint16_t is defined to unsigned short. The underlying reason is that the system's libc/stdint.h is used instead of avr-libc'

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 added a comment. Though the disabled test builtins.cpp can pass after my another patch https://reviews.llvm.org/D97669, it will still fail on llvm build machines, since there are no avr-libc installed on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D111597: [RISCV][Clang] Fix RISCV vector header comment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG477f5f4fca2b: [RISCV][Clang] Fix RISCV vector header comment. (authored by jacquesguan, committed by benshi001). Repository: rG LLVM Github Monore

[PATCH] D109232: [CUDA][NFC] Fix a wrong assert message

benshi001 created this revision. benshi001 added reviewers: tra, Hahnfeld, fodinabor, yaxunl. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109232 Files: clang/

[PATCH] D109232: [CUDA][NFC] Fix a wrong assert message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12fee64daf57: [CUDA][NFC] Fix wrong assert information (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a reviewer: benshi001. benshi001 added a comment. I though the test clang/test/Misc/target-invalid-cpu-note.c should also be updated. BTW: What info (especially name and email) would like to see in the commit message ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRDevices.td:515 +def : Device<"attiny1614", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny416", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny816", FamilyXMEGA, ELFArchXMEGA3>; --

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRDevices.td:515 +def : Device<"attiny1614", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny416", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny816", FamilyXMEGA, ELFArchXMEGA3>; --

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a comment. Sorry, I happened to find that the list in `lib/Driver/ToolChains/AVR.cpp` also needs update. {"at90s1200", "", "avr1", 0}, {"attiny11", "", "avr1", 0}, {"attiny12", "", "avr1", 0}, {"attiny15", "", "avr1", 0}, {"attiny28", "", "avr1", 0},

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a comment. Please tell me your email address which will be shown in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___ cfe-

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d4d969e22e: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-series (authored by justinlatimer, committed by benshi001). Changed prior to

<    1   2   3   4