[PATCH] D88352: [clang][AVR] Add more devices

This revision was automatically updated to reflect the committed changes. Closed by commit rG5be50d79c0b8: [NFC][clang][AVR] Add more devices (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88352/new/ https://reviews.llvm.org/

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rG892c56eabe25: [clang][AVR] Redefine some types to be compatible with avr-gcc (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100701/ne

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:313 + Builder.defineMacro("__UINT16_TYPE__", "unsigned int"); + Builder.defineMacro("__INT16_TYPE__", "int"); efriedma wrote: > Redefining `__INT16_TYPE__` like this is unusual. The

[PATCH] D102547: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

benshi001 created this revision. benshi001 added a reviewer: efriedma. Herald added subscribers: Jim, jfb, dylanmckay. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:313 + Builder.defineMacro("__UINT16_TYPE__", "unsigned int"); + Builder.defineMacro("__INT16_TYPE__", "int"); efriedma wrote: > benshi001

[PATCH] D102547: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

benshi001 updated this revision to Diff 345611. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102547/new/ https://reviews.llvm.org/D102547 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/TargetInfo.cpp clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h

[PATCH] D102547: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rGb99e2c56166a: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102547/ne

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a reviewer: efriedma. benshi001 added a subscriber: efriedma. benshi001 added a comment. @efriedma Could you please help me review this patch? It relates to the one you have reviewed for me, and is also about wrong mangled function name in c++ on AVR. The previous patch has corr

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1ee4fb5af49: [clang][AVR] Add avr-libc/include to clang system include paths (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 318821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/bin/avr-ld clang/test/Driver/Inputs/basic_avr_tree/lib/avr/lib

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 318881. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/bin/avr-ld clang/test/Driver/Inputs/basic_avr_tree/lib/avr/lib

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 marked an inline comment as done. benshi001 added a comment. In D93579#2518307 , @MaskRay wrote: > If you remove your system GCC avr, does the test still work? This is the > criteria whether the patch is acceptable. Yes. The "make check-clang-d

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 added a comment. committed as https://github.com/llvm/llvm-project/commit/89a5147e5a0c2e886cdf7ffa34799c069d825940 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 ___ cfe-commits mailing lis

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 reopened this revision. benshi001 added a comment. This revision is now accepted and ready to land. It still cases many build failures, due to not enough test. I will redo it with a full test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D

[PATCH] D95529: [AVR][clang] Fix a bug in AVR toolchain search paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b0b435d7931: [AVR][clang] Fix a bug in AVR toolchain search paths (authored by benshi001). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGd38973aa4d6a: [clang][AVR] Improve avr-ld command line options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D93579?vs=318881&id=321035#toc Repository: rG LLVM Github Mon

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96853

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. This patch immitates avr-gcc behavior on `__flash` 1. `__flash` variables are put into `.section .progmem.data` 2. `__flash` non-const variables are rejected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ http

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 added a comment. In D96853#2577133 , @aykevl wrote: > I am not very familiar with Clang so I can't say much about it. Although I > wonder whether a macro is the right way to implement this? Is there something > similar in other targets? (GPUs t

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 325285. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 325286. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 updated this revision to Diff 350755. benshi001 retitled this revision from "[RISCV][clang] Improve deduction of default ABI for some special archs" to "[clang][RISCV][test] Add more tests of the -mabi and -march options". benshi001 edited the summary of this revision. CHANGES SINCE LA

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 added a comment. How to formulate the default abi and arch is still under discussion. https://github.com/riscv/riscv-toolchain-conventions/issues/13 But the tests can be added first, for contrast of future changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103878/new/ ht

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 updated this revision to Diff 350788. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103878/new/ https://reviews.llvm.org/D103878 Files: clang/test/Driver/riscv-abi.c clang/test/Driver/riscv-arch.c Index: clang/test/Driver/riscv-arch.c ==

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/test/Driver/riscv-arch.c:45 + +// CHECK-ILP32: "-target-feature" "+m" +// CHECK-ILP32-SAME: "-target-feature" "+f" MaskRay wrote: > I suggest the style used in lin

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 added a comment. In D103878#2807034 , @MaskRay wrote: > How do the new tests provide additional coverage? For these tests, 1. there is no tests for mabi=ilp32e, and my patch covers that. 2. the tests in riscv-abi.c will show default abi change

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 updated this revision to Diff 350828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103878/new/ https://reviews.llvm.org/D103878 Files: clang/test/Driver/riscv-abi.c clang/test/Driver/riscv-arch.c Index: clang/test/Driver/riscv-arch.c ==

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 added a comment. In D103878#2809033 , @luismarques wrote: > In D103878#2807118 , @benshi001 > wrote: > >> 1. there is no tests for mabi=ilp32e, and my patch covers that. >> 2. the tests in riscv-abi.c

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0eb3919835a: [clang][RISCV][test] Add more tests of the -mabi and -march options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D103878?vs=350828&id=351025#toc Repository:

[PATCH] D104192: [clang][RISCV] Change implicit ARCH for explicitly specified ABI

benshi001 created this revision. benshi001 added reviewers: asb, luismarques, MaskRay, craig.topper. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27

[PATCH] D104192: [clang][RISCV] Change implicit ARCH for explicitly specified ABI

benshi001 added a comment. In D104192#2815757 , @MaskRay wrote: > The thing looks weird. My mental model (ppc) is that `-march` can infer > `-mabi`, not the other way around... The original way in Driver/Toolchains/Arch/RISCV.cpp is if (MABI.equals_l

[PATCH] D107610: [AVR][clang] Pass '-fno-use-init-array' to cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rGdae7adda9499: [AVR][clang] Pass '-fno-use-init-array' to cc1 as default (authored by mhjacobson, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e71067f3fa: [AVR][clang] Add '$SYSROOT/avr' to possible avr-libc locations (authored by mhjacobson, committed by benshi001). Repository: rG LLVM

[PATCH] D107682: [AVR][clang] Search avr-libc installtion path according to avr-gcc's

benshi001 created this revision. benshi001 added reviewers: MaskRay, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1076

[PATCH] D107682: [AVR][clang] Search avr-libc installtion path according to avr-gcc's

benshi001 added a comment. There are already test cases $llvm/clang/test/Driver/avr-ld.c $llvm/clang/test/Driveravr-toolchain.c and fake avr-gcc inside `$llvm/clang/test/Driver/Inputs/basic_avr_tree` to support the above two tests. So there is no need to add new ones. Repository: rG LL

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

benshi001 added a comment. In D107672#2932442 , @mhjacobson wrote: > In D107672#2932413 , @mhjacobson > wrote: > >> At first glance, I think you're right: avr-gcc does expect avr-libc to be >> relative to itsel

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 364938. benshi001 retitled this revision from "[AVR][clang] Search avr-libc installtion path according to avr-gcc's" to "[AVR][clang] Improve search for avr-libc installation path". benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 364940. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/avr-toolchain.c =

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 marked an inline comment as done. benshi001 added a comment. Thanks. I have added some comments about our agreed logic, as discussed in https://reviews.llvm.org/D107672. I think this way is clear enough. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://revie

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 added a comment. @mhjacobson Could you please check if my modification also works as expected on your platform ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 ___ cfe-commits mailing lis

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:9 -// RUN: %clang %s -### -target avr --sysroot %S/Inputs/basic_avr_tree 2>&1 -nostdinc | FileCheck -check-prefix CC1B %s -// CC1B-NOT: "-internal-isystem" {{".*avr/include"}} +// RUN: %clang %s -##

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. We need not add another `basic_avr_tree_opt_local`, since you added `/avr` to possible avr-libc pathes, you can test your change by specifying `--sysroot %S/Inputs/basic_avr_tree/usr/lib/` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. In D107684#2932605 , @mhjacobson wrote: > In D107684#2932603 , @benshi001 > wrote: > >> We need not add another `basic_avr_tree_opt_local`, since you added `/avr` >> to possible avr-l

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. @MaskRay I think this test is OK. What is your opinion ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm.org/D107684 ___ cfe-commits mailing lis

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 364954. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/avr-toolchain.c =

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 added a comment. In D107682#2932607 , @mhjacobson wrote: > For other examples of using four `..`s, look in `Gnu.cpp`, where there are > several places where `getParentLibPath()` is appended with `/../`. > `AddMultilibPaths()`, `PushPPaths()`

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 364955. benshi001 edited the summary of this revision. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/av

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 365089. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/avr-toolchain.c =

[PATCH] D107797: [Driver][test] Improve avr-toolchain.c

benshi001 accepted this revision. benshi001 added a comment. Good! Then I can rebase my patch on your test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107797/new/ https://reviews.llvm.org/D107797 ___

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 365347. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/av

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 added a comment. @MaskRay I have update my patch based on your new test avr-toolchain.c. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 365996. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree_2/opt/local/avr/include/.keep clang/test/Driver/Inputs/basic

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 added a comment. In D107682#2936040 , @MaskRay wrote: > Seems a new RUN line is needed. If having too many mock trees are > inconvenient, consider `clang/unittests/Driver/ToolChainTest.cpp` I am not familiar with the way in `clang/unittests/Dr

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 added a comment. The file/directory structure in basic_avr_tree_2/opt/local is the same as mhjacobson's machine. Here's what my directory tree looks like. My gcc install consists of: /opt/local/bin/avr-gcc-10.3.0 /opt/local/lib/gcc/avr/10.3.0/libgcc.a /opt/local/libexec/gcc/

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

This revision was automatically updated to reflect the committed changes. Closed by commit rGb31199bab486: [AVR][clang] Improve search for avr-libc installation path (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

benshi001 added a comment. It seems we need not adding this test, since a similiar test is added in https://reviews.llvm.org/rGb31199bab4865deef4e778d7a028c8ec64285654 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm.

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

This revision was automatically updated to reflect the committed changes. Closed by commit rGc94c8d8b5d99: [AVR][clang] Fix wrong calling convention in functions return struct type (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D99237?vs=335368&id=355111#toc Reposit

[PATCH] D105626: [RISCV][Clang] Add macro __riscv_zvlsseg for RVV Zvlsseg builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG88326bbce38c: [RISCV][clang] Add macro __riscv_zvlsseg for RVV Zvlsseg builtins (authored by jacquesguan, committed by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D112521: [CUDA][NFC] Fix inexact warning message about lambdas

benshi001 created this revision. benshi001 added reviewers: tra, fodinabor, Hahnfeld, yaxunl. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112521 Files: clang/

[PATCH] D112521: [CUDA][NFC] Fix inexact warning message about lambdas

benshi001 added a comment. Acutally lambdas with CUDA attributes can have non-empty parameter list, and the original warning message is inexact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112521/new/ https://reviews.llvm.org/D112521 __

[PATCH] D112521: [CUDA][NFC] Fix inexact warning message about lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c7ace60aa62: [CUDA][NFC] Fix inexact warning message about lambdas (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112521/new/ https

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 created this revision. benshi001 added reviewers: dylanmckay, MaskRay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. Herald added a subscriber: ormris. The wrong `stdio.h` (usr/include/stdio.h) is included with a simple a.c like #include ... However the expected one is avr-libc's `stdio.h`, and this patch add avr-libc's include/ to clang system include paths. Repository: rG

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. This patch In D97669#2596073 , @aykevl wrote: > Looks reasonable to me. But again, I would like this to be reviewed also by > someone familiar with the internals of Clang (I'm not). Actually this patch is copied from msp430, w

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 327361. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. Although the bug can be avoided via "-I /usr/lib/avr/include" in clang's command line option, I expect clang to have the save behaviour as avr-gcc. And for avr-gcc, `avr-gcc a.c -mmcu=xxx` will automatically include avr-libc's header files and link avr-libc's lib.

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:539 +// Link to compiler-rt. We directly put the libclang.builtins.a +// as input file, other than '-lclang.builtins'. +if (RtLib == ToolChain:

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44a647d21d94: [Driver] Support linking to compiler-rt for target AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. In D128133#3723847 , @phosek wrote: > We started seeing test failures after this change on our bots. Would it be > possible to revert the change and address these issues before relanding? > > In `Clang :: Driver/avr-ld.c`: > >

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. @phosek , I have re-landed my patch, it seems the core reason is compiler-rt is default in Fuchsia environment, other than libgcc. please inform me if it went wrong any longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 added a comment. On 32-bit / 64-bit machines, a function returning lower types (via a register) should an explicit sign/zero extension to full fill the register. But on AVR, a 8-bit register is used to return 8-bit values, so the sign/zero extension is unnecessary, and lead to extra u

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2638a7a34d9: [clang] Do not extend i8 return values to i16 on AVR. (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139908/new/ https

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#4013217 , @aykevl wrote: > I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't > think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is > inherently specific to that particular

[PATCH] D137520: [AVR][Clang] Move family names into MCU list

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137520/new/ https://reviews.llvm.org/D137520 _

[PATCH] D137521: [AVR][Clang] Implement __AVR_ARCH__ macro

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137521/new/ https://reviews.llvm.org/D137521 _

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false); ATxmega16a4 with family code 102 also supports ELPM. Could you please make a c

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false); benshi001 wrote: > ATxmega16a4 with family code 102 also supports ELPM. Could y

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. A scalar which exceeds 4 byte

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:37 +long long fooi64(void) { + return 0xaa5533; +} This file should be renamed to return.c instead of current struct.c, I will do that in another patch, just let you see clearly what I

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 updated this revision to Diff 475808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138125/new/ https://reviews.llvm.org/D138125 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/return-value.c clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/r

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:37 +long long fooi64(void) { + return 0xaa5533; +} aykevl wrote: > benshi001 wrote: > > This file should be renamed to return.c instead of cu

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

This revision was automatically updated to reflect the committed changes. Closed by commit rG84ef72357328: [clang] Fix wrong ABI of AVRTiny. (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138125/new/ https://reviews.llvm.org/

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false);

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, Miss_Grape. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes htt

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 added a comment. In D142595#4088364 , @MaskRay wrote: > This is probably not a good idea. See > https://github.com/llvm/llvm-project/issues/60203#issuecomment-1407532083 I agree with your comment in `https://github.com/llvm/llvm-project/issue

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 updated this revision to Diff 493053. benshi001 edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142595/new/ https://reviews.llvm.org/D142595 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Drive

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:500 - if (SectionAddressData) { -CmdArgs.push_back(Args.MakeArgString( -"-Tdata=0x" + Twine::utohexstr(*SectionAddressData))); - } else { -// We do not have an entry for this CPU

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 added a comment. In D142595#4089124 , @MaskRay wrote: > OK. If this doesn't add `-Tdata=` driver options, I'm fine with it. > But why is default `-Tdata` added in the first place? > > Most linker scripts are added as `-Wl,-T,a.lds` (`-Wl,` value

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 updated this revision to Diff 493179. benshi001 retitled this revision from "[Driver][AVR] Don't emit default '-Tdata' when a linker script is specified" to "[Driver][AVR] Don't emit default '-Tdata' when '-T' is specified". benshi001 edited the summary of this revision. benshi001 remov

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:544 + if (SectionAddressData) { +CmdArgs.push_back(Args.MakeArgString( +"-Tdata=0x" + Twine::utohexstr(*SectionAddressData))); Just moving the default `-T` f

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4091176 , @MaskRay wrote: > In D142595#4089391 , @benshi001 > wrote: > >> In D142595#4089124 , @MaskRay >> wrote: >> >>> OK. If thi

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4092435 , @MaskRay wrote: > How does avr-gcc know whether the user provides a linker script? > > I really don't like adding a default `-Tdata=` when it can interfere with > common uses of specifying a linker script.

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4092435 , @MaskRay wrote: > How does avr-gcc know whether the user provides a linker script? > > I really don't like adding a default `-Tdata=` when it can interfere with > common uses of specifying a linker script.

[PATCH] D141598: [clang] Redefine some AVR specific macros

benshi001 created this revision. benshi001 added reviewers: aykevl, Miss_Grape. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG L

[PATCH] D141647: [clang][test] Remove unnecessary 'REQUIRES'

benshi001 created this revision. benshi001 added reviewers: aaron.ballman, MaskRay. Herald added subscribers: kosarev, tpr. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. The test 'Preproc

[PATCH] D141647: [clang][test] Remove unnecessary 'REQUIRES'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG485ba407a6a9: [clang][test] Remove unnecessary 'REQUIRES' (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141598: [clang] Redefine some AVR specific macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG16f9451b0761: [clang] Redefine some AVR specific macros (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141598/new/ https://reviews.l

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. a gentle ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D126192: [Driver] Improve linking options for target AVR

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7599be9e84f: [Driver] Improve linking options for target AVR (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://rev

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. I will fix it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

<    1   2   3   4   >