benlangmuir wrote:
Failure looks unrelated. Merging.
https://github.com/llvm/llvm-project/pull/125098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,111 @@
+// UNSUPPORTED: target=powerpc64-ibm-aix{{.*}}
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+//--- module.modulemap
+module root { header "root.h" }
+module direct { header "direct.h" }
+module transitive { header "transitive.h" }
+module addition { header "
@@ -0,0 +1,111 @@
+// UNSUPPORTED: target=powerpc64-ibm-aix{{.*}}
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+//--- module.modulemap
+module root { header "root.h" }
+module direct { header "direct.h" }
+module transitive { header "transitive.h" }
+module addition { header "
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/125111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
-darwin.TestCases/Darwin/Generic.exceptions.cpp
ORC-x86_64-darwin.TestCases/Darwin/x86-64.lljit-ehframe.cpp
>From d2cf4b637cc667f2ccd094097828058524c90ec9 Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Thu, 30 Jan 2025 09:48:33 -0800
Subject: [PATCH] Revert "Reapply "[ORC] Enabl
@@ -0,0 +1,141 @@
+//===- ModuleMapFile.h - Parsing and representation -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/119740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3157,25 +2140,18 @@ bool ModuleMap::parseModuleMapFile(FileEntryRef File,
bool IsSystem,
assert((!Offset || *Offset <= Buffer->getBufferSize()) &&
"invalid buffer offset");
- // Parse this module map file.
- Lexer L(SourceMgr.getLocForStartOfFile(ID), MMapLan
@@ -0,0 +1,141 @@
+//===- ModuleMapFile.h - Parsing and representation -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/benlangmuir commented:
I'm happy with the way this split of the code worked out!
> Currently this has no effect other than slightly changing diagnostics.
Can you say more about the ordering changes? I understand we can't always emit
diagnostics in source order, but it's help
-memory module cache rather than
reading it from the pcm file that was written. This broke bootstrapping a
build of clang with modules enabled on Darwin.
rdar://143418834
>From 40879d967ff8b7463f3eb56d437cacde6e2689ef Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Wed, 22 Jan 2025 12:52
benlangmuir wrote:
There's probably a better way, but I just built my first clang normally then
built a second one with
`-DCMAKE_C_COMPILER` and `-DCMAKE_CXX_COMPILER` pointing to the first one, and
`-DLLVM_ENABLE_MODULES=1` to enable modules.
https://github.com/llvm/llvm-project/pull/122726
_
benlangmuir wrote:
I see that this change has already been reverted by @ilya-biryukov , but FYI
before this is re-applied: I am seeing crashes from this change if I attempt to
bootstrap a build of clang with modules enabled on Darwin. I haven't yet
managed to minimize a test case, but compili
ether the submodules involved were
explicitly defined (module X) or implicitly defined from an umbrella (module *).
rdar://136524433
>From 5541ea0e31d35dfd20a3157a52997b1b2f6d3966 Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 14 Jan 2025 10:57:56 -0800
Subject: [PATCH] [clang][modu
@@ -248,39 +236,14 @@ LockFileManager::LockFileManager(StringRef FileName)
// There is a lock file that nobody owns; try to clean it up and get
// ownership.
-if ((EC = sys::fs::remove(LockFileName))) {
- std::string S("failed to remove lockfile ");
- S.a
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/131940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -739,6 +748,12 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module
*M) {
MDC.ScanInstance.getASTReader()->visitInputFileInfos(
*MF, /*IncludeSystem=*/true,
[&](const serialization::InputFileInfo &IFI, bool IsSystem) {
+if (MD.IsInSysroot) {
+
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/131193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/130634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -739,6 +795,12 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module
*M) {
MDC.ScanInstance.getASTReader()->visitInputFileInfos(
*MF, /*IncludeSystem=*/true,
[&](const serialization::InputFileInfo &IFI, bool IsSystem) {
+if (MD.IsShareable) {
+
@@ -157,6 +157,32 @@ static void optimizeCWD(CowCompilerInvocation
&BuildInvocation, StringRef CWD) {
}
}
+/// Check a subset of invocation options to determine whether the current
+/// context can safely be considered as shareable.
+static bool areOptionsInSharedDir(CowCom
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/130634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/132063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -48,7 +48,7 @@ void ASTMergeAction::ExecuteAction() {
/*ShouldOwnClient=*/true));
std::unique_ptr Unit = ASTUnit::LoadFromASTFile(
ASTFiles[I], CI.getPCHContainerReader(), ASTUnit::LoadEverything,
Diags,
-CI.getFileSys
@@ -116,7 +116,7 @@ class ASTUnit {
std::shared_ptr PP;
IntrusiveRefCntPtr Ctx;
std::shared_ptr TargetOpts;
- std::shared_ptrHSOpts;
+ std::unique_ptr HSOpts;
benlangmuir wrote:
Is there still a reason to keep this a poi
https://github.com/benlangmuir approved this pull request.
Sounds great, thanks for explaining!
https://github.com/llvm/llvm-project/pull/133467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
@@ -569,7 +569,7 @@
CrossTranslationUnitContext::ASTLoader::loadFromDump(StringRef ASTDumpPath) {
return ASTUnit::LoadFromASTFile(
ASTDumpPath, CI.getPCHContainerOperations()->getRawReader(),
ASTUnit::LoadEverything, Diags, CI.getFileSystemOpts(),
- CI.getHe
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/132984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir commented:
Basically LGTM but there are two clients that I'm not familiar with.
https://github.com/llvm/llvm-project/pull/132984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
@@ -0,0 +1,44 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/benlangmuir commented:
I have a similar concern to @jansvoboda11 that we probably need to check the
invocation paths as well.
> I would think that if ModuleDepCollector only found dependency inputs that
> resolve to sysroot locations, the command line for building the spec
@@ -835,6 +850,13 @@ void ModuleDepCollectorPP::addAllSubmoduleDeps(
});
}
+void ModuleDepCollectorPP::addClangModule(const Module *M, const ModuleID ID,
benlangmuir wrote:
How about something like "addOneModuleDep"? If find it hard to guess from the
name
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/130634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -157,42 +157,35 @@ class RemoveUniqueLockFileOnSignal {
} // end anonymous namespace
-LockFileManager::LockFileManager(StringRef FileName)
-{
- this->FileName = FileName;
- if (std::error_code EC = sys::fs::make_absolute(this->FileName)) {
-std::string S("failed to o
@@ -739,6 +748,12 @@ ModuleDepCollectorPP::handleTopLevelModule(const Module
*M) {
MDC.ScanInstance.getASTReader()->visitInputFileInfos(
*MF, /*IncludeSystem=*/true,
[&](const serialization::InputFileInfo &IFI, bool IsSystem) {
+if (MD.IsInSysroot) {
+
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/135405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/130627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/130395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir closed
https://github.com/llvm/llvm-project/pull/129774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir closed
https://github.com/llvm/llvm-project/pull/127110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
, or if the command line
contained no scannable actions we would fail to finish(), which would break
some consumers (e.g. serialized diag consumer).
>From c94b7df49f9b92b574c44fddc8b8faee1b7cdce0 Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Thu, 13 Feb 2025 10:50:09 -0800
Subject: [PA
https://github.com/benlangmuir commented:
There's another call to finish() in DependencyScanningWorker that should be
removed if we do this.
https://github.com/llvm/llvm-project/pull/100681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/benlangmuir closed
https://github.com/llvm/llvm-project/pull/122955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -130,11 +130,11 @@ class DependencyScanningWorker {
DependencyActionController &Controller,
StringRef ModuleName);
- bool shouldEagerLoadModules() const { return EagerLoadModules; }
-
llvm::vfs::FileSys
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/128959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/119740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/134404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir wrote:
Are you planning to do the same for LangOpts and HSOpts? What's the ultimate
goal here?
There's also this comment on `CompilerInvocationBase`:
```
/// ... It keeps individual option objects
/// behind reference-counted pointers, which is useful for clients that want to
/// ke
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/134284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/139751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
Nice find, thanks for fixing.
https://github.com/llvm/llvm-project/pull/139751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
@@ -0,0 +1,49 @@
+// This test checks that the module cache gets invalidated when the
SDKSettings.json file changes.
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+//--- AppleTVOS15.0.sdk/SDKSettings-old.json
+{
+ "DisplayName": "tvOS 15.0",
+ "Version": "15.0",
+ "Canonica
benlangmuir wrote:
> I don't think we can ever get rid of that pattern and we will keep relying on
> Clang supporting this.
> We would need to example I shared above to keep working.
> I think the change we want is to always prioritize modular over textual,
> before we look at non-private vs p
benlangmuir wrote:
> I don't think we can ever get rid of that pattern and we will keep relying on
> Clang supporting this.
> We would need to example I shared above to keep working.
I don't have a strong opinion on the best path forward here, but I'm not clear
if you're actually willing to
@@ -1259,6 +1259,7 @@ void ASTDeclWriter::VisitVarDecl(VarDecl *D) {
VarDeclBits.addBit(D->isConstexpr());
VarDeclBits.addBit(D->isInitCapture());
VarDeclBits.addBit(D->isPreviousDeclInSameBlockScope());
+VarDeclBits.addBit(D->hasInitWithSideEffects());
@@ -1081,7 +1084,8 @@ int clang_scan_deps_main(int argc, char **argv, const
llvm::ToolContext &) {
};
DependencyScanningService Service(ScanMode, Format, OptimizeArgs,
-EagerLoadModules, /*TraceVFS=*/Verbose);
+
@@ -1442,6 +1442,10 @@ class ASTReader
const StringRef &operator*() && = delete;
};
+ /// VarDecls with initializers containing side effects must be emitted,
+ /// but DeclMustBeEmitted is not allowed to deserialize the intializer.
+ llvm::SmallPtrSet InitSideEffectVa
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/143739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2434,6 +2434,22 @@ VarDecl *VarDecl::getInitializingDeclaration() {
return Def;
}
+bool VarDecl::hasInitWithSideEffects() const {
+ if (!hasInit())
+return false;
+
+ if (auto *S = dyn_cast(Init)) {
benlangmuir wrote:
The original code in `getInit
@@ -8310,8 +8310,6 @@ Stmt *ASTReader::GetExternalDeclStmt(uint64_t Offset) {
Error(std::move(Err));
return nullptr;
}
- assert(NumCurrentElementsDeserializing == 0 &&
benlangmuir wrote:
Can this assert come back now?
https://github.com/llvm/llvm-p
https://github.com/benlangmuir commented:
I think this new function should be called from
`ASTContext::DeclMustBeEmitted`, no?
https://github.com/llvm/llvm-project/pull/143739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
@@ -1632,6 +1632,10 @@ RedeclarableResult
ASTDeclReader::VisitVarDeclImpl(VarDecl *VD) {
VD->NonParmVarDeclBits.PreviousDeclInSameBlockScope =
VarDeclBits.getNextBit();
+bool hasInitWithSideEffect = VarDeclBits.getNextBit();
benlangmuir wrote:
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/143739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1181,8 +1183,9 @@ class Preprocessor {
public:
Preprocessor(const PreprocessorOptions &PPOpts, DiagnosticsEngine &diags,
- const LangOptions &LangOpts, SourceManager &SM,
- HeaderSearch &Headers, ModuleLoader &TheModuleLoader,
+
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/139504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir wrote:
> Would you have a different opinion if I told you that the next PR in my
> queue re-introduces AFFECTING_*_CODEGENOPT to represent the affecting
> ENUM_LANGOPT(ExceptionHandling, ...?
I think it helps a bit, but the core problem is that we don't have
`BENIGN_CODEGENOPT`.
benlangmuir wrote:
> Ok, so what do you suggest? Change all CODEGENOPT to BENIGN_CODEGENOPT before
> this PR lands?
This would be fine with me.
> (Or alternatively/equivalently go all the way and add an explicit benign
> effect on AST argument to CODEGENOPT, similar to what I linked above for
https://github.com/benlangmuir approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/146422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir created this revision.
benlangmuir added reviewers: yamaguchi, v.g.vassilev, ruiu, teemperor.
Herald added a subscriber: cfe-commits.
We have a regex that needs to match a tab character in the command output, but
on macOS `sed` doesn't support '\t', causing it to split on the 't' char
benlangmuir added a comment.
In https://reviews.llvm.org/D47273#1109934, @ruiu wrote:
> I wonder if you could replace \t with \0x09. At least it works on my machine
> which has GNU sed.
Unfortunately that doesn't work either on mac :-\
Repository:
rC Clang
https://reviews.llvm.org/D47273
benlangmuir added a comment.
In https://reviews.llvm.org/D47273#1109985, @ruiu wrote:
> sed -e "$(echo -e 's/\t.*//')"
Yep, that works! Is there a reason you prefer that over the more succinct
`$'s/\t.*//'`?
Repository:
rC Clang
https://reviews.llvm.org/D47273
__
benlangmuir updated this revision to Diff 148278.
benlangmuir edited the summary of this revision.
benlangmuir added a comment.
Thanks for looking up the supported bash version! Updated diff.
https://reviews.llvm.org/D47273
Files:
utils/bash-autocomplete.sh
Index: utils/bash-autocomplete.
benlangmuir closed this revision.
benlangmuir added a comment.
r333202
https://reviews.llvm.org/D47273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir added a comment.
I agree with not detecting these during PP-only, but there's nothing wrong with
`<#>`. It's either not a placeholder, or it's part of a placeholder like
`<#>#>`, which is a placeholder containing the text ">". Similarly, `<##`
could be the start of an empty placeh
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D34256
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
benlangmuir added a comment.
It would be nice if the doc comment for the single file parse mode flag was
updated to include this new functionality.
Comment at: lib/Lex/PPDirectives.cpp:2709
+CurPPLexer->pushConditionalLevel(IfToken.getLocation(), /*wasskip*/true,
+
benlangmuir added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:2774
+// the directive blocks.
+CurPPLexer->pushConditionalLevel(CI.IfLoc, /*wasskip*/false,
+ /*foundnonskip*/true, /*foundelse*/true);
akyrtzi wrot
benlangmuir added a comment.
Thanks, this looks good to me. I'd appreciate if @klimek could take a quick
look though.
Comment at: include/clang/Lex/PreprocessorOptions.h:102
+ /// in preprocessor directive conditions it causes all blocks to be parsed so
+ /// that the clien
benlangmuir added a comment.
Did you consider just using a different pragma that triggers this behaviour
instead of avoiding the crash? I don't really have a strong preference but I'd
be interested to hear what you think the pros/cons are.
Comment at: lib/Parse/ParseDecl.cpp
benlangmuir created this revision.
benlangmuir added reviewers: bruno, vsapsai.
Herald added a subscriber: cfe-commits.
This make -ivfsoverlay behave more like other fatal errors (e.g. missing
-include file) by skipping the missing file instead of bailing out of
the whole compilation. This makes i
benlangmuir added a comment.
@sammccall RE using USRs: we want to integrate clangd into a larger source
tooling system that is already using USRs extensively to identify symbols. The
most obvious case is that we have an index outside of clangd that uses USRs
from clang-the-compiler, so exposing
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM, although I made a small suggestion for clarity. FYI `InPCH` was used by
PTH, which was removed a couple of months ago.
Comment at: clang/lib/Basic/FileManag
benlangmuir added inline comments.
Comment at: clang/lib/Basic/FileManager.cpp:305
+UFE = &UniqueRealFiles[Status.getUniqueID()];
+Status = llvm::vfs::Status(
+ Status.getName(), Status.getUniqueID(),
harlanhaskins wrote:
> benlangmuir wrote:
> > Why
benlangmuir added a comment.
LGTM, but I'd appreciate someone who has worked on this more recently taking a
look.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60735/new/
https://reviews.llvm.org/D60735
_
benlangmuir added subscribers: akyrtzi, benlangmuir.
benlangmuir added a comment.
@arphaman @akyrtzi could you take a look at this?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57965/new/
https://reviews.llvm.org/D57965
___
benlangmuir added a comment.
> @property(attr, attr2) instead of @property ( attr,attr2 ).
The style I see most often is `@property (attr, attr2)`, which is in between
those two.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57965/new/
https://reviews.llvm.org/
benlangmuir added a comment.
In https://reviews.llvm.org/D34512#856301, @xazax.hun wrote:
> In https://reviews.llvm.org/D34512#856184, @dcoughlin wrote:
>
> > In either case, the important scenario I think we should support is
> > choosing at a call site to a C function the most likely definitio
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
benlangmuir marked 2 inline comments as done.
benlangmuir added inline comments.
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:295
+if (MDC)
+ MDC->applyDiscoveredDependencies(CI);
+LastCC1Arguments = CI.getCC1CommandLine();
-
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf80a0ea76072: [clang][deps] Split translation units into
individual -cc1 or other commands (authored by benlangmuir).
Repository:
rG LLVM Github M
benlangmuir added inline comments.
Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131
+/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this
+/// directive will be ignored.
///
Why would you want to print without this? I
benlangmuir added inline comments.
Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131
+/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this
+/// directive will be ignored.
///
akyrtzi wrote:
> benlangmuir wrote:
> > Why
benlangmuir added inline comments.
Comment at: clang/include/clang/Lex/DependencyDirectivesScanner.h:131
+/// \p dependency_directives_scan::tokens_present_before_eof, otherwise this
+/// directive will be ignored.
///
benlangmuir wrote:
> akyrtzi wrote:
> > ben
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
You forgot to remove the ` \param PrintMarkerForTokensBeforeEOF ...` from the
doc comment. Otherwise LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
Good catch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133611/new/
https://reviews.llvm.org/D133611
__
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
Thanks for catching this!
Comment at: clang/test/ClangScanDeps/multiple-commands.c:11
// RUN: split-file %s %t
-// RUN: sed -e "s|DIR|%/t|g" %t/cdb.json.in > %t/cd
benlangmuir created this revision.
benlangmuir added reviewers: bruno, jansvoboda11, arphaman.
Herald added a subscriber: delcypher.
Herald added a project: All.
benlangmuir requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
benlangmuir added a comment.
Attempting to not do this again: https://reviews.llvm.org/D133622
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133617/new/
https://reviews.llvm.org/D133617
___
cfe-commits m
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd96f526196ac: [clang][test] Disallow using the default
module cache path in lit tests (authored by benlangmuir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
benlangmuir added a comment.
Reverted due to failure on a bot
https://lab.llvm.org/buildbot/#/builders/214/builds/3252
I'm not sure how to deal with missing `env -u`.
- We could do `env CLANG_MODULE_CACHE_PATH=` and change the compiler's
interpretation of empty string for this variable. I'm no
401 - 500 of 822 matches
Mail list logo
