That's a combination of the simplifySVal() mechanism and the new
rearrangement mechanism that causes the regression. I guess that's where
we get when we try to squeeze more stuff into our solver. It seems safe
to reduce simplifySVal() complexity threshold to 10 or 20 but i'm also
curious whethe
Author: dergachev
Date: Thu Apr 19 16:00:22 2018
New Revision: 330375
URL: http://llvm.org/viewvc/llvm-project?rev=330375&view=rev
Log:
[analyzer] RetainCount: Accept more "safe" CFRetain wrappers.
r315736 added support for the misplaced CF_RETURNS_RETAINED annotation on
CFRetain() wrappers. It w
Author: dergachev
Date: Thu Apr 19 16:09:22 2018
New Revision: 330377
URL: http://llvm.org/viewvc/llvm-project?rev=330377&view=rev
Log:
[CFG] [analyzer] Don't treat argument constructors as temporary constructors.
Function argument constructors (that are used for passing objects into functions
by
Author: dergachev
Date: Thu Apr 19 16:24:32 2018
New Revision: 330380
URL: http://llvm.org/viewvc/llvm-project?rev=330380&view=rev
Log:
[analyzer] When we fail to evaluate a pointer cast, escape the pointer.
If a pointer cast fails (evaluates to an UnknownVal, i.e. not implemented in the
analyzer
Author: dergachev
Date: Thu Apr 19 16:30:15 2018
New Revision: 330382
URL: http://llvm.org/viewvc/llvm-project?rev=330382&view=rev
Log:
[CFG] [analyzer] Add construction contexts for loop condition variables.
Loop condition variables, eg.
while (shared_ptr P = getIntPtr()) { ... })
weren't ha
Author: dergachev
Date: Tue Apr 24 13:45:48 2018
New Revision: 330766
URL: http://llvm.org/viewvc/llvm-project?rev=330766&view=rev
Log:
[analyzer] Add support for the note diagnostic pieces to plist output format.
Note diagnostic pieces are an additional way of highlighting code sections to
the u
Author: dergachev
Date: Wed Apr 25 14:51:26 2018
New Revision: 330876
URL: http://llvm.org/viewvc/llvm-project?rev=330876&view=rev
Log:
[analyzer] Enable analysis of WebKit "unified sources".
Normally the analyzer begins path-sensitive analysis from functions within
the main file, even though the
Author: dergachev
Date: Wed Apr 25 16:02:06 2018
New Revision: 330882
URL: http://llvm.org/viewvc/llvm-project?rev=330882&view=rev
Log:
[analyzer] Fix a crash on lifetime extension through aggregate initialization.
If 'A' is a C++ aggregate with a reference field of type 'C', in code like
A a =
Author: dergachev
Date: Thu Apr 26 19:16:03 2018
New Revision: 331014
URL: http://llvm.org/viewvc/llvm-project?rev=331014&view=rev
Log:
[analyzer] Fix operator delete[] array-type-sub-expression handling.
Avoid crash when the sub-expression of operator delete[] is of array type.
This is not the
Author: dergachev
Date: Fri Apr 27 15:00:51 2018
New Revision: 331089
URL: http://llvm.org/viewvc/llvm-project?rev=331089&view=rev
Log:
[analyzer] ObjCAutoreleaseWrite: Support a few more APIs and fix warning text.
API list and improved warning text composed by Devin Coughlin.
Modified:
cfe/
Author: dergachev
Date: Fri Apr 27 16:50:55 2018
New Revision: 331096
URL: http://llvm.org/viewvc/llvm-project?rev=331096&view=rev
Log:
[analyzer] CStringChecker: Add support for BSD strlcpy() and strlcat().
Patch by David Carlier!
Differential Revision: https://reviews.llvm.org/D45177
Modified
Author: dergachev
Date: Wed May 2 13:33:17 2018
New Revision: 331401
URL: http://llvm.org/viewvc/llvm-project?rev=331401&view=rev
Log:
[analyzer] Revert r331096 "CStringChecker: Add support for BSD strlcpy()...".
The return values of the newly supported functions were not handled correctly:
strl
Author: dergachev
Date: Thu May 3 17:53:41 2018
New Revision: 331496
URL: http://llvm.org/viewvc/llvm-project?rev=331496&view=rev
Log:
[analyzer] NFC: Remove unused parameteer of StoreManager::CastRetrievedVal().
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h
Author: dergachev
Date: Fri May 4 13:52:39 2018
New Revision: 331556
URL: http://llvm.org/viewvc/llvm-project?rev=331556&view=rev
Log:
[analyzer] Treat more const variables and fields as known contants.
When loading from a variable or a field that is declared as constant,
the analyzer will try t
Author: dergachev
Date: Fri May 4 14:39:25 2018
New Revision: 331558
URL: http://llvm.org/viewvc/llvm-project?rev=331558&view=rev
Log:
[analyzer] pr37209: Fix casts of glvalues to references.
Many glvalue expressions aren't of their respective reference type -
they are simply glvalues of their v
Author: dergachev
Date: Fri May 4 14:56:51 2018
New Revision: 331561
URL: http://llvm.org/viewvc/llvm-project?rev=331561&view=rev
Log:
[analyzer] pr18953: Split C++ zero-initialization from default initialization.
The bindDefault() API of the ProgramState allows setting a default value
for reads
Author: dergachev
Date: Fri May 4 15:11:12 2018
New Revision: 331562
URL: http://llvm.org/viewvc/llvm-project?rev=331562&view=rev
Log:
[analyzer] pr36458: Fix retrieved value cast for symbolic void pointers.
C allows us to write any bytes into any memory region. When loading weird bytes
from mem
Author: dergachev
Date: Fri May 4 15:19:32 2018
New Revision: 331563
URL: http://llvm.org/viewvc/llvm-project?rev=331563&view=rev
Log:
[analyzer] Invalidate union regions properly. Don't hesitate to load later.
We weren't invalidating our unions correctly. The previous behavior in
invalidateRegi
Author: dergachev
Date: Fri May 4 16:01:10 2018
New Revision: 331565
URL: http://llvm.org/viewvc/llvm-project?rev=331565&view=rev
Log:
[analyzer] Remove untested code in evalLoad.
No functional change intended.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
Modified: cfe/trunk/
Author: dergachev
Date: Mon Jun 25 16:43:45 2018
New Revision: 33
URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev
Log:
[analyzer] Fix invalidation on C++ const methods with arrow syntax.
Conservative evaluation of a C++ method call would invalidate the object,
as long as the meth
Author: dergachev
Date: Mon Jun 25 16:55:07 2018
New Revision: 335559
URL: http://llvm.org/viewvc/llvm-project?rev=335559&view=rev
Log:
[analyzer] Track null and undef values through expressions with cleanups.
ExprWithCleanups wraps full-expressions that require temporary destructors
and highligh
Author: dergachev
Date: Wed Jun 27 17:04:54 2018
New Revision: 335795
URL: http://llvm.org/viewvc/llvm-project?rev=335795&view=rev
Log:
[CFG] [analyzer] Add construction contexts that explain pre-C++17 copy elision.
Before C++17 copy elision was optional, even if the elidable copy/move
constructo
Author: dergachev
Date: Wed Jun 27 17:11:42 2018
New Revision: 335796
URL: http://llvm.org/viewvc/llvm-project?rev=335796&view=rev
Log:
[analyzer] Re-enable lifetime extension for temporaries without destructors.
When an object's class provides no destructor, it's less important to
materialize th
Author: dergachev
Date: Wed Jun 27 17:18:52 2018
New Revision: 335798
URL: http://llvm.org/viewvc/llvm-project?rev=335798&view=rev
Log:
[CFG] [analyzer] Simplify lifetime-extended temporary construction contexts.
When a temporary object is materialized and through that obtain lifetime that
is lon
Author: dergachev
Date: Wed Jun 27 17:30:18 2018
New Revision: 335800
URL: http://llvm.org/viewvc/llvm-project?rev=335800&view=rev
Log:
[analyzer] Add support for pre-C++17 copy elision.
r335795 adds copy elision information to CFG. This commit allows static analyzer
to elide elidable copy constr
Author: dergachev
Date: Wed Jun 27 17:42:11 2018
New Revision: 335803
URL: http://llvm.org/viewvc/llvm-project?rev=335803&view=rev
Log:
[analyzer] Use sufficiently large types for index bounds calculation.
The ProgramState::assumeInBound() API is used by checkers to make an assumption
that a cert
Author: dergachev
Date: Wed Jun 27 19:33:16 2018
New Revision: 335808
URL: http://llvm.org/viewvc/llvm-project?rev=335808&view=rev
Log:
[analyzer] Remove redundant ';'.
Fixes a compiler warning. No functionan change intended.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
Modifi
Author: dergachev
Date: Mon Jul 16 17:22:27 2018
New Revision: 337227
URL: http://llvm.org/viewvc/llvm-project?rev=337227&view=rev
Log:
[analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol.
In the current SVal hierarchy there are multiple ways of representing certain
values
Author: dergachev
Date: Mon Jul 16 17:42:35 2018
New Revision: 337228
URL: http://llvm.org/viewvc/llvm-project?rev=337228&view=rev
Log:
[analyzer] pr37802: Fix symbolic-pointer-to-boolean casts during load.
The canonical representation of pointer &SymRegion{$x} casted to boolean is
"$x != 0", not
Author: dergachev
Date: Mon Jul 16 17:57:57 2018
New Revision: 337229
URL: http://llvm.org/viewvc/llvm-project?rev=337229&view=rev
Log:
[CFG] [analyzer] Allow elidable copies to have more than one arguments.
Copy-constructors and move-constructors may have default arguments. It is
incorrect to as
Author: dergachev
Date: Mon Jul 16 18:39:25 2018
New Revision: 337231
URL: http://llvm.org/viewvc/llvm-project?rev=337231&view=rev
Log:
[analyzer] Fix size_t in tests.
Should fix a buildbot. No functional change intended.
Modified:
cfe/trunk/test/Analysis/pr37802.cpp
Modified: cfe/trunk/t
Author: dergachev
Date: Wed Jul 18 11:44:40 2018
New Revision: 337417
URL: http://llvm.org/viewvc/llvm-project?rev=337417&view=rev
Log:
[analyzer] Remove a debug print that was accidentally left around.
No functional change intended.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cp
Author: dergachev
Date: Thu Oct 17 16:10:05 2019
New Revision: 375185
URL: http://llvm.org/viewvc/llvm-project?rev=375185&view=rev
Log:
[analyzer] Display cast kinds in program point dumps.
Because cast expressions have their own hierarchy, it's extremely useful
to have some information about wha
Author: dergachev
Date: Thu Oct 17 16:10:09 2019
New Revision: 375186
URL: http://llvm.org/viewvc/llvm-project?rev=375186&view=rev
Log:
[analyzer] Assign truly stable identifiers to exploded nodes.
ExplodedGraph nodes will now have a numeric identifier stored in them
which will keep track of the
Author: dergachev
Date: Thu Oct 17 16:10:02 2019
New Revision: 375184
URL: http://llvm.org/viewvc/llvm-project?rev=375184&view=rev
Log:
[analyzer] exploded-graph-rewriter: Make node headers a bit lighter.
The 50% grey color is too dark on some monitors.
Modified:
cfe/trunk/test/Analysis/expl
Author: dergachev
Date: Thu Oct 17 16:27:35 2019
New Revision: 375189
URL: http://llvm.org/viewvc/llvm-project?rev=375189&view=rev
Log:
[analyzer] exploded-graph-rewriter: Fix typo in r375186. Unbreaks tests.
Modified:
cfe/trunk/test/Analysis/dump_egraph.c
Modified: cfe/trunk/test/Analysis/d
Author: dergachev
Date: Fri Oct 18 13:15:29 2019
New Revision: 375278
URL: http://llvm.org/viewvc/llvm-project?rev=375278&view=rev
Log:
[analyzer] Fix hidden node traversal in exploded graph dumps.
The joined nodes now actually have the same state. That was intended
from the start but the origina
Author: dergachev
Date: Fri Oct 18 13:15:35 2019
New Revision: 375280
URL: http://llvm.org/viewvc/llvm-project?rev=375280&view=rev
Log:
[analyzer] Drop the logic for collapsing the state if it's same as in preds.
One of the first attempts to reduce the size of the exploded graph dumps
was to skip
Author: dergachev
Date: Fri Oct 18 13:15:41 2019
New Revision: 375282
URL: http://llvm.org/viewvc/llvm-project?rev=375282&view=rev
Log:
[analyzer] exploded-graph-rewriter: Rename Environment to Expressions.
It's less confusing for newcomers.
Modified:
cfe/trunk/test/Analysis/exploded-graph-r
Author: dergachev
Date: Fri Oct 18 13:15:39 2019
New Revision: 375281
URL: http://llvm.org/viewvc/llvm-project?rev=375281&view=rev
Log:
[analyzer] Fix FieldRegion dumps.
The '->' thing has always been confusing; the actual operation '->'
translates to a pointer dereference together with adding a
Author: dergachev
Date: Fri Oct 18 13:15:32 2019
New Revision: 375279
URL: http://llvm.org/viewvc/llvm-project?rev=375279&view=rev
Log:
[analyzer] exploded-graph-rewriter: Fix dump for state 0.
It shouldn't say "unspecified" when the state is specified to be empty.
Modified:
cfe/trunk/test/A
Author: dergachev
Date: Fri Oct 18 13:48:21 2019
New Revision: 375286
URL: http://llvm.org/viewvc/llvm-project?rev=375286&view=rev
Log:
[analyzer] exploded-graph-rewriter: Unforget to censor stmt_ids in the test.
They're not stable across machines.
Fixes buildbots after r375278.
Modified:
c
Author: dergachev
Date: Fri Oct 18 17:08:17 2019
New Revision: 375308
URL: http://llvm.org/viewvc/llvm-project?rev=375308&view=rev
Log:
[analyzer] Specify the C++ standard in more tests.
Makes life easier for downstream developers with different default standard.
Modified:
cfe/trunk/test/Ana
Author: dergachev
Date: Fri Oct 18 18:50:43 2019
New Revision: 375328
URL: http://llvm.org/viewvc/llvm-project?rev=375328&view=rev
Log:
[analyzer] Fix a crash on tracking Objective-C 'self' as a control dependency.
'self' was previously never tracked, but now it can be tracked
because it may be p
Author: dergachev
Date: Fri Oct 18 18:50:46 2019
New Revision: 375329
URL: http://llvm.org/viewvc/llvm-project?rev=375329&view=rev
Log:
[analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor.
Patch by Kristóf Umann!
Differential Revision: https://reviews.llvm.org/D68591
Modified:
Author: Artem Dergachev
Date: 2019-10-23T08:17:02-07:00
New Revision: be86fdb86e1efd6921c81f25ac0c0a78903c0a2d
URL:
https://github.com/llvm/llvm-project/commit/be86fdb86e1efd6921c81f25ac0c0a78903c0a2d
DIFF:
https://github.com/llvm/llvm-project/commit/be86fdb86e1efd6921c81f25ac0c0a78903c0a2d.dif
Author: Artem Dergachev
Date: 2020-05-20T14:55:56+03:00
New Revision: 3f333e0af7a872a0152b4db972a37947e47e690d
URL:
https://github.com/llvm/llvm-project/commit/3f333e0af7a872a0152b4db972a37947e47e690d
DIFF:
https://github.com/llvm/llvm-project/commit/3f333e0af7a872a0152b4db972a37947e47e690d.dif
Author: Artem Dergachev
Date: 2020-05-22T16:14:48+03:00
New Revision: 99b94f29ac5dbbce0585d16f631359a66f279ea4
URL:
https://github.com/llvm/llvm-project/commit/99b94f29ac5dbbce0585d16f631359a66f279ea4
DIFF:
https://github.com/llvm/llvm-project/commit/99b94f29ac5dbbce0585d16f631359a66f279ea4.dif
Author: Artem Dergachev
Date: 2020-07-18T10:37:00-07:00
New Revision: 0b2a92224630f6e177d091b8391cfa943764aba5
URL:
https://github.com/llvm/llvm-project/commit/0b2a92224630f6e177d091b8391cfa943764aba5
DIFF:
https://github.com/llvm/llvm-project/commit/0b2a92224630f6e177d091b8391cfa943764aba5.dif
Author: Artem Dergachev
Date: 2020-07-27T22:38:53-07:00
New Revision: 8c9241a051fd677cfbfd9c79c6af9d714be7c792
URL:
https://github.com/llvm/llvm-project/commit/8c9241a051fd677cfbfd9c79c6af9d714be7c792
DIFF:
https://github.com/llvm/llvm-project/commit/8c9241a051fd677cfbfd9c79c6af9d714be7c792.dif
Author: Artem Dergachev
Date: 2020-07-28T18:57:11-07:00
New Revision: c26f237cef1b33277f072c609c19192c5213f348
URL:
https://github.com/llvm/llvm-project/commit/c26f237cef1b33277f072c609c19192c5213f348
DIFF:
https://github.com/llvm/llvm-project/commit/c26f237cef1b33277f072c609c19192c5213f348.dif
Author: Artem Dergachev
Date: 2020-07-30T08:52:47-07:00
New Revision: 6a043ecc0cf4d257d06c4fe0c3d5e1d9a8c7ea94
URL:
https://github.com/llvm/llvm-project/commit/6a043ecc0cf4d257d06c4fe0c3d5e1d9a8c7ea94
DIFF:
https://github.com/llvm/llvm-project/commit/6a043ecc0cf4d257d06c4fe0c3d5e1d9a8c7ea94.dif
Author: Artem Dergachev
Date: 2020-04-06T20:33:38+03:00
New Revision: 9b1e4a8218b7fcb8900d0382704fdb4e38b52eb0
URL:
https://github.com/llvm/llvm-project/commit/9b1e4a8218b7fcb8900d0382704fdb4e38b52eb0
DIFF:
https://github.com/llvm/llvm-project/commit/9b1e4a8218b7fcb8900d0382704fdb4e38b52eb0.dif
Author: Artem Dergachev
Date: 2020-04-06T20:33:37+03:00
New Revision: 2ddd3325c4d7ab47b62a9fe72a0d1c1d8ec7f9d7
URL:
https://github.com/llvm/llvm-project/commit/2ddd3325c4d7ab47b62a9fe72a0d1c1d8ec7f9d7
DIFF:
https://github.com/llvm/llvm-project/commit/2ddd3325c4d7ab47b62a9fe72a0d1c1d8ec7f9d7.dif
Author: Denys Petrov
Date: 2020-04-07T15:56:50+03:00
New Revision: cfd388d344ab29ad5e311ac96e382d96bd85d994
URL:
https://github.com/llvm/llvm-project/commit/cfd388d344ab29ad5e311ac96e382d96bd85d994
DIFF:
https://github.com/llvm/llvm-project/commit/cfd388d344ab29ad5e311ac96e382d96bd85d994.diff
Author: Artem Dergachev
Date: 2020-04-07T16:37:42+03:00
New Revision: 6b3353e832940e9484bba7b8017b8ea1f0c63806
URL:
https://github.com/llvm/llvm-project/commit/6b3353e832940e9484bba7b8017b8ea1f0c63806
DIFF:
https://github.com/llvm/llvm-project/commit/6b3353e832940e9484bba7b8017b8ea1f0c63806.dif
Author: Artem Dergachev
Date: 2020-04-07T21:03:16+03:00
New Revision: 0c27fd82e1e62bd57c73b09c7d9dd00c42eb89d1
URL:
https://github.com/llvm/llvm-project/commit/0c27fd82e1e62bd57c73b09c7d9dd00c42eb89d1
DIFF:
https://github.com/llvm/llvm-project/commit/0c27fd82e1e62bd57c73b09c7d9dd00c42eb89d1.dif
Author: Paul Pelzl
Date: 2020-06-03T19:06:04+03:00
New Revision: 7113271528a4c6efc8b57f25ead28f65b5e48757
URL:
https://github.com/llvm/llvm-project/commit/7113271528a4c6efc8b57f25ead28f65b5e48757
DIFF:
https://github.com/llvm/llvm-project/commit/7113271528a4c6efc8b57f25ead28f65b5e48757.diff
LO
Author: Paul Pelzl
Date: 2020-06-03T19:06:04+03:00
New Revision: e94192198f8a949c7880620b06e9ef85d87ad4b3
URL:
https://github.com/llvm/llvm-project/commit/e94192198f8a949c7880620b06e9ef85d87ad4b3
DIFF:
https://github.com/llvm/llvm-project/commit/e94192198f8a949c7880620b06e9ef85d87ad4b3.diff
LO
Author: Artem Dergachev
Date: 2020-07-10T13:25:46-07:00
New Revision: cb6c1106141efa721a3902a98c37a54d135464fd
URL:
https://github.com/llvm/llvm-project/commit/cb6c1106141efa721a3902a98c37a54d135464fd
DIFF:
https://github.com/llvm/llvm-project/commit/cb6c1106141efa721a3902a98c37a54d135464fd.dif
Author: Nithin Vadukkumchery Rajendrakumar
Date: 2020-06-25T09:47:13-07:00
New Revision: 37c1bf21d1da85c164638efc32e8c7cfbf713ac5
URL:
https://github.com/llvm/llvm-project/commit/37c1bf21d1da85c164638efc32e8c7cfbf713ac5
DIFF:
https://github.com/llvm/llvm-project/commit/37c1bf21d1da85c164638efc3
Author: Valeriy Savchenko
Date: 2020-04-20T12:33:01+03:00
New Revision: 1f67508b7fedb3a0c8ea55a1f5674346563e2bf2
URL:
https://github.com/llvm/llvm-project/commit/1f67508b7fedb3a0c8ea55a1f5674346563e2bf2
DIFF:
https://github.com/llvm/llvm-project/commit/1f67508b7fedb3a0c8ea55a1f5674346563e2bf2.d
Author: Valeriy Savchenko
Date: 2020-04-20T12:33:01+03:00
New Revision: 09a1f090509eb5971ade7089330008c6e4024d30
URL:
https://github.com/llvm/llvm-project/commit/09a1f090509eb5971ade7089330008c6e4024d30
DIFF:
https://github.com/llvm/llvm-project/commit/09a1f090509eb5971ade7089330008c6e4024d30.d
Author: Artem Dergachev
Date: 2020-04-20T15:31:43+03:00
New Revision: 878194414107e94600de31a11be09a347fb2598b
URL:
https://github.com/llvm/llvm-project/commit/878194414107e94600de31a11be09a347fb2598b
DIFF:
https://github.com/llvm/llvm-project/commit/878194414107e94600de31a11be09a347fb2598b.dif
Author: Valeriy Savchenko
Date: 2020-04-23T19:52:45+03:00
New Revision: a88025672f89374bfa584e2179a557f44d86da11
URL:
https://github.com/llvm/llvm-project/commit/a88025672f89374bfa584e2179a557f44d86da11
DIFF:
https://github.com/llvm/llvm-project/commit/a88025672f89374bfa584e2179a557f44d86da11.d
Author: Artem Dergachev
Date: 2020-08-07T10:39:28-07:00
New Revision: 47cadd6106c0a9218f653760dd045cbd16df0fd6
URL:
https://github.com/llvm/llvm-project/commit/47cadd6106c0a9218f653760dd045cbd16df0fd6
DIFF:
https://github.com/llvm/llvm-project/commit/47cadd6106c0a9218f653760dd045cbd16df0fd6.dif
Author: Artem Dergachev
Date: 2020-05-11T17:26:37+03:00
New Revision: ec2d93c7d7b00374535cb3d6658abec4b150f6f6
URL:
https://github.com/llvm/llvm-project/commit/ec2d93c7d7b00374535cb3d6658abec4b150f6f6
DIFF:
https://github.com/llvm/llvm-project/commit/ec2d93c7d7b00374535cb3d6658abec4b150f6f6.dif
Author: Artem Dergachev
Date: 2020-05-12T22:43:32+03:00
New Revision: 11c8c2a551c53db5ecf8c1f253b1a49d5e98324f
URL:
https://github.com/llvm/llvm-project/commit/11c8c2a551c53db5ecf8c1f253b1a49d5e98324f
DIFF:
https://github.com/llvm/llvm-project/commit/11c8c2a551c53db5ecf8c1f253b1a49d5e98324f.dif
Author: Artem Dergachev
Date: 2020-05-13T14:13:00+03:00
New Revision: 8cbd3f431a919e3398683bb5b72fdd781798bcc8
URL:
https://github.com/llvm/llvm-project/commit/8cbd3f431a919e3398683bb5b72fdd781798bcc8
DIFF:
https://github.com/llvm/llvm-project/commit/8cbd3f431a919e3398683bb5b72fdd781798bcc8.dif
Author: Artem Dergachev
Date: 2020-05-15T14:27:30+03:00
New Revision: 1a3b801db5afe98718b31ba9a760e06557daccb1
URL:
https://github.com/llvm/llvm-project/commit/1a3b801db5afe98718b31ba9a760e06557daccb1
DIFF:
https://github.com/llvm/llvm-project/commit/1a3b801db5afe98718b31ba9a760e06557daccb1.dif
Author: Artem Dergachev
Date: 2020-05-19T23:05:49+03:00
New Revision: e42e5e4d0fc08fed673b453268606bc9fdf0a7d2
URL:
https://github.com/llvm/llvm-project/commit/e42e5e4d0fc08fed673b453268606bc9fdf0a7d2
DIFF:
https://github.com/llvm/llvm-project/commit/e42e5e4d0fc08fed673b453268606bc9fdf0a7d2.dif
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:3866
@@ -3865,3 +3865,3 @@
if (LCtx->getAnalysisDeclContext()->isBodyAutosynthesized()) {
-assert(LCtx->getParent());
+assert(LCtx->inTopFrame() || LCtx->getParent());
return
NoQ added a comment.
Thanks, this makes a lot more sense to me!
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:691
@@ -690,1 +690,3 @@
+ // Ignore autosynthesized code.
+ if (Mgr->getAnalysisDeclContext(D)->isBodyAutosynthesized())
I think this
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thanks again! LGTM.
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:656
@@ +655,3 @@
+ // Clear the AnalysisManager of old AnalysisDeclContexts.
+ Mgr->ClearContexts(
NoQ retitled this revision from "[analyzer] A checker for macOS-specific
bool-like objects." to "[analyzer] A checker for macOS-specific bool- and
number-like objects.".
NoQ updated the summary for this revision.
NoQ updated this revision to Diff 72392.
NoQ marked 10 inline comments as done.
NoQ
NoQ marked an inline comment as done.
NoQ added a comment.
Ouch, seems inline answers don't automatically post themselves when you update
the diff :o
Comment at: lib/StaticAnalyzer/Checkers/BoolConversionChecker.cpp:62
@@ +61,3 @@
+ << "' to a plain boolean value: probabl
NoQ updated this revision to Diff 72480.
NoQ added a comment.
This diff is a part of the original diff that contains core changes without
checker changes (in particular, without tests). No changes were made, no
comments addressed, just removed checker stuff. Uploading it separately so that
it w
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
This patch applies the bug reporting technique that is being introduced in
D24278 to ObjCDeallocChecker. Extra notes highlight instance variable or
property declarations that are of relevan
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, v.g.vassilev, teemperor.
NoQ added a subscriber: cfe-commits.
This patch applies the bug reporting technique that is being introduced in
D24278 to CloneChecker. Extra notes highlight cloned code sections.
Examples of HTML repo
NoQ updated this revision to Diff 72519.
NoQ marked 10 inline comments as done.
NoQ added a comment.
Addressed inline comments. Renamed extra notes to notes.
https://reviews.llvm.org/D24278
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Core/BugRepor
NoQ updated this revision to Diff 72520.
NoQ added a comment.
Addressed two inline comments by Devin in the original review
https://reviews.llvm.org/D24278. Rebased on top of the updated
https://reviews.llvm.org/D24278.
https://reviews.llvm.org/D24915
Files:
lib/StaticAnalyzer/Checkers/Chec
NoQ updated this revision to Diff 72521.
NoQ added a comment.
Addressed inline comments on the original review
https://reviews.llvm.org/D24278. Rebased on top of the updated
https://reviews.llvm.org/D24278. Changed warning messages completely according
to Anna's comments in https://reviews.llvm
NoQ updated this revision to Diff 72991.
NoQ added a comment.
- Update the commit messages.
- Move a run-away test file to its correct directory.
- Fix a copy-paste error in initialization of the variable field of a clone
pair.
https://reviews.llvm.org/D24916
Files:
include/clang/Analysis/Cl
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added a subscriber: cfe-commits.
Fix clang path event diagnostics around operators `&&` and `||`. Now there's a
separate event for both sides of the operator.
Control flow pieces are unaffected - they
Author: dergachev
Date: Mon Oct 3 02:58:26 2016
New Revision: 283092
URL: http://llvm.org/viewvc/llvm-project?rev=283092&view=rev
Log:
[analyzer] Extend bug reports with extra notes
These diagnostics are separate from the path-sensitive engine's path notes,
and can be added manually on top of pa
Author: dergachev
Date: Mon Oct 3 03:03:51 2016
New Revision: 283093
URL: http://llvm.org/viewvc/llvm-project?rev=283093&view=rev
Log:
[analyzer] Add extra notes to ObjCDeallocChecker
The report is now highlighting instance variables and properties
referenced by the warning message with the help
Author: dergachev
Date: Mon Oct 3 03:11:50 2016
New Revision: 283094
URL: http://llvm.org/viewvc/llvm-project?rev=283094&view=rev
Log:
[analyzer] Improve CloneChecker diagnostics
Highlight code clones referenced by the warning message with the help of
the extra notes feature recently introduced
via cfe-commits пишет:
This patch breaks Windows:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/29769/
On Mon, Oct 3, 2016 at 1:07 AM Artem Dergachev via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: dergachev
Date: Mon Oct 3 02:58:26 2016
New Rev
Author: dergachev
Date: Mon Oct 3 15:12:12 2016
New Revision: 283141
URL: http://llvm.org/viewvc/llvm-project?rev=283141&view=rev
Log:
[analyzer] A blind attempt to fix a buildbot after r283092.
The msvc compiler seems to crash compiling the BugReport class.
Modified:
cfe/trunk/include/clan
this failure. Hope there aren't more
failures.
03/10/2016 21:46, Vitaly Buka via cfe-commits пишет:
This patch breaks Windows:
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/29769/
On Mon, Oct 3, 2016 at 1:07 AM Artem Dergachev via cfe-commits
mai
/29769/
On Mon, Oct 3, 2016 at 1:07 AM Artem Dergachev via
cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote:
Author: dergachev
Date: Mon Oct 3 02:58:26 2016
New Revision: 283092
URL: http://llvm.org/viewvc/llvm-project
NoQ updated this revision to Diff 73472.
NoQ marked 3 inline comments as done.
NoQ added a comment.
Fix review comments.
Correct the order of expected-notes in one of the tests (it doesn't affect how
the test works).
https://reviews.llvm.org/D25092
Files:
lib/StaticAnalyzer/Core/BugReporter
NoQ added inline comments.
> zaks.anna wrote in BugReporterVisitors.cpp:1302
> Is this expected to ever trigger?
Ouch right.
https://reviews.llvm.org/D25092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
NoQ added a comment.
In https://reviews.llvm.org/D24916#561369, @vitalybuka wrote:
> Out of curiosity, how was MSVC crash solved?
It wasn't, unfortunately; phabricator closed this revision by looking at the
commit that was already reverted, with a delay (see
http://lists.llvm.org/pipermail/cf
NoQ added inline comments.
> chapuni wrote in CloneDetection.cpp:113
> You should update \param here. See also r283106.
Thanks!! Will do.
Repository:
rL LLVM
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: dergachev
Date: Wed Oct 5 03:28:25 2016
New Revision: 283302
URL: http://llvm.org/viewvc/llvm-project?rev=283302&view=rev
Log:
[analyzer] Improve "Assuming..." diagnostic pieces for logical operators.
Logical short-circuit operators now act like other branch conditions.
If the symbolic
Author: dergachev
Date: Wed Oct 5 03:47:31 2016
New Revision: 283303
URL: http://llvm.org/viewvc/llvm-project?rev=283303&view=rev
Log:
[analyzer] Squash a compile error in r283301.
The constexpr string literal trick isn't supported in MSVC2013.
Modified:
cfe/trunk/include/clang/StaticAnalyz
NoQ added a comment.
Funny facts about the Environment:
(a) Environment allows taking SVals of ReturnStmt, which is not an expression,
by transparently converting it into its sub-expression. In fact, it only stores
expressions.
Having just noticed (a), i also understand that (a) is not of dire
NoQ updated this revision to Diff 73889.
NoQ added a comment.
- Rename test files for consistency.
- Suppress false positives on `intptr_t`.
- Add a triple to the tests to in order to stop worrying about integer types.
https://reviews.llvm.org/D22968
Files:
include/clang/StaticAnalyzer/Checke
NoQ added a comment.
In https://reviews.llvm.org/D25326#564185, @danielmarjamaki wrote:
> as I understand it the ProgramPoint when CallExitBegin is called is the same
> (in the exit block). do you suggest that we take the ProgramPoint for the
> exit block's predecessor?
CallExitBegin is //**t
301 - 400 of 1254 matches
Mail list logo
