Author: Artem Dergachev Date: 2020-05-19T23:05:49+03:00 New Revision: e42e5e4d0fc08fed673b453268606bc9fdf0a7d2
URL: https://github.com/llvm/llvm-project/commit/e42e5e4d0fc08fed673b453268606bc9fdf0a7d2 DIFF: https://github.com/llvm/llvm-project/commit/e42e5e4d0fc08fed673b453268606bc9fdf0a7d2.diff LOG: [analyzer] Move apiModeling.StdCLibraryFunctionArgs to alpha. It was enabled by default accidentally; still missing some important features. Also it needs a better package because it doesn't boil down to API modeling. Differential Revision: https://reviews.llvm.org/D80213 Added: Modified: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/test/Analysis/analyzer-enabled-checkers.c clang/test/Analysis/std-c-library-functions-arg-constraints.c clang/test/Analysis/std-c-library-functions-arg-constraints.cpp Removed: ################################################################################ diff --git a/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td b/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td index cc6952b55810..d06c64ad118b 100644 --- a/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td +++ b/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td @@ -102,6 +102,8 @@ def LLVMAlpha : Package<"llvm">, ParentPackage<Alpha>; // any diagnostics. These checkers are always turned on; this package is // intended for API modeling that is not controlled by the target triple. def APIModeling : Package<"apiModeling">, Hidden; +def APIModelingAlpha : Package<"apiModeling">, ParentPackage<Alpha>, Hidden; + def GoogleAPIModeling : Package<"google">, ParentPackage<APIModeling>, Hidden; def LLVMAPIModeling : Package<"llvm">, ParentPackage<APIModeling>, Hidden; @@ -304,6 +306,15 @@ def StdCLibraryFunctionsChecker : Checker<"StdCLibraryFunctions">, ]>, Documentation<NotDocumented>; +def TrustNonnullChecker : Checker<"TrustNonnull">, + HelpText<"Trust that returns from framework methods annotated with _Nonnull " + "are not null">, + Documentation<NotDocumented>; + +} // end "apiModeling" + +let ParentPackage = APIModelingAlpha in { + def StdCLibraryFunctionArgsChecker : Checker<"StdCLibraryFunctionArgs">, HelpText<"Check constraints of arguments of C standard library functions, " "such as whether the parameter of isalpha is in the range [0, 255] " @@ -311,12 +322,7 @@ def StdCLibraryFunctionArgsChecker : Checker<"StdCLibraryFunctionArgs">, Dependencies<[StdCLibraryFunctionsChecker]>, Documentation<NotDocumented>; -def TrustNonnullChecker : Checker<"TrustNonnull">, - HelpText<"Trust that returns from framework methods annotated with _Nonnull " - "are not null">, - Documentation<NotDocumented>; - -} // end "apiModeling" +} // end "alpha.apiModeling" //===----------------------------------------------------------------------===// // Evaluate "builtin" functions. diff --git a/clang/test/Analysis/analyzer-enabled-checkers.c b/clang/test/Analysis/analyzer-enabled-checkers.c index 0e44b1147f04..ad195b086d87 100644 --- a/clang/test/Analysis/analyzer-enabled-checkers.c +++ b/clang/test/Analysis/analyzer-enabled-checkers.c @@ -9,7 +9,6 @@ // CHECK-NEXT: core.NonNullParamChecker // CHECK-NEXT: core.CallAndMessage // CHECK-NEXT: apiModeling.StdCLibraryFunctions -// CHECK-NEXT: apiModeling.StdCLibraryFunctionArgs // CHECK-NEXT: apiModeling.TrustNonnull // CHECK-NEXT: apiModeling.llvm.CastValue // CHECK-NEXT: apiModeling.llvm.ReturnValue diff --git a/clang/test/Analysis/std-c-library-functions-arg-constraints.c b/clang/test/Analysis/std-c-library-functions-arg-constraints.c index 62962a398689..00960e42fb55 100644 --- a/clang/test/Analysis/std-c-library-functions-arg-constraints.c +++ b/clang/test/Analysis/std-c-library-functions-arg-constraints.c @@ -2,7 +2,7 @@ // RUN: %clang_analyze_cc1 %s \ // RUN: -analyzer-checker=core \ // RUN: -analyzer-checker=apiModeling.StdCLibraryFunctions \ -// RUN: -analyzer-checker=apiModeling.StdCLibraryFunctionArgs \ +// RUN: -analyzer-checker=alpha.apiModeling.StdCLibraryFunctionArgs \ // RUN: -analyzer-checker=debug.StdCLibraryFunctionsTester \ // RUN: -analyzer-checker=debug.ExprInspection \ // RUN: -triple x86_64-unknown-linux-gnu \ @@ -12,7 +12,7 @@ // RUN: %clang_analyze_cc1 %s \ // RUN: -analyzer-checker=core \ // RUN: -analyzer-checker=apiModeling.StdCLibraryFunctions \ -// RUN: -analyzer-checker=apiModeling.StdCLibraryFunctionArgs \ +// RUN: -analyzer-checker=alpha.apiModeling.StdCLibraryFunctionArgs \ // RUN: -analyzer-checker=debug.StdCLibraryFunctionsTester \ // RUN: -analyzer-checker=debug.ExprInspection \ // RUN: -triple x86_64-unknown-linux-gnu \ diff --git a/clang/test/Analysis/std-c-library-functions-arg-constraints.cpp b/clang/test/Analysis/std-c-library-functions-arg-constraints.cpp index fed815f67a57..ebc841a07fb7 100644 --- a/clang/test/Analysis/std-c-library-functions-arg-constraints.cpp +++ b/clang/test/Analysis/std-c-library-functions-arg-constraints.cpp @@ -1,7 +1,7 @@ // RUN: %clang_analyze_cc1 %s \ // RUN: -analyzer-checker=core \ // RUN: -analyzer-checker=apiModeling.StdCLibraryFunctions \ -// RUN: -analyzer-checker=apiModeling.StdCLibraryFunctionArgs \ +// RUN: -analyzer-checker=alpha.apiModeling.StdCLibraryFunctionArgs \ // RUN: -analyzer-checker=debug.StdCLibraryFunctionsTester \ // RUN: -analyzer-checker=debug.ExprInspection \ // RUN: -analyzer-config eagerly-assume=false \ _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
