[clang] 5c63bf3 - [OpenCL] Add NULL to standards prior to v2.0.

Author: Anastasia Stulova Date: 2021-07-23T11:54:36+01:00 New Revision: 5c63bf3abdc74b02c58c21cb0571eb4ba12b5235 URL: https://github.com/llvm/llvm-project/commit/5c63bf3abdc74b02c58c21cb0571eb4ba12b5235 DIFF: https://github.com/llvm/llvm-project/commit/5c63bf3abdc74b02c58c21cb0571eb4ba12b5235.d

[clang] 8160016 - [OpenCL] Change default standard version to CL1.2

Author: Anastasia Stulova Date: 2021-07-26T15:04:34+01:00 New Revision: 81600160b3f926746d02c52003d81180941fe9d0 URL: https://github.com/llvm/llvm-project/commit/81600160b3f926746d02c52003d81180941fe9d0 DIFF: https://github.com/llvm/llvm-project/commit/81600160b3f926746d02c52003d81180941fe9d0.d

[clang] e5f47ee - [OpenCL] NULL redefined as nullptr in C++ mode.

Author: Anastasia Stulova Date: 2021-07-27T16:33:50+01:00 New Revision: e5f47eedeb02595247e433ad756607e6c1397ae3 URL: https://github.com/llvm/llvm-project/commit/e5f47eedeb02595247e433ad756607e6c1397ae3 DIFF: https://github.com/llvm/llvm-project/commit/e5f47eedeb02595247e433ad756607e6c1397ae3.d

[clang] fdd615d - [Docs][OpenCL] Update OpenCL 3.0 status in docs.

Author: Anastasia Stulova Date: 2022-02-16T12:32:20Z New Revision: fdd615d4f91f7bbbf83e4ea6ca45dafb7abc2fa7 URL: https://github.com/llvm/llvm-project/commit/fdd615d4f91f7bbbf83e4ea6ca45dafb7abc2fa7 DIFF: https://github.com/llvm/llvm-project/commit/fdd615d4f91f7bbbf83e4ea6ca45dafb7abc2fa7.diff

[clang] d61ded1 - [OpenCL] Make -cl-ext a driver option.

Author: Anastasia Stulova Date: 2022-05-24T11:34:19+01:00 New Revision: d61ded1034bb9563c43d048ba0be4eff662e6144 URL: https://github.com/llvm/llvm-project/commit/d61ded1034bb9563c43d048ba0be4eff662e6144 DIFF: https://github.com/llvm/llvm-project/commit/d61ded1034bb9563c43d048ba0be4eff662e6144.d

[clang] [OpenCL] Fix BIenqueue_kernel fallthrough (PR #83238)

https://github.com/AnastasiaStulova approved this pull request. Makes sense, LGTM! Thanks https://github.com/llvm/llvm-project/pull/83238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: r369641 - [OpenCL] Fix declaration of enqueue_marker

Hi Hans, Can this still be merged into the release branch please. Thanks in advance, Anastasia From: cfe-commits on behalf of Yaxun Liu via cfe-commits Sent: 22 August 2019 12:18 To: cfe-commits@lists.llvm.org Subject: r369641 - [OpenCL] Fix declaration o

r369749 - [Docs][OpenCL] Several corrections to C++ for OpenCL

Author: stulova Date: Fri Aug 23 04:43:49 2019 New Revision: 369749 URL: http://llvm.org/viewvc/llvm-project?rev=369749&view=rev Log: [Docs][OpenCL] Several corrections to C++ for OpenCL Differential Revision:https://reviews.llvm.org/D64418 Modified: cfe/trunk/docs/LanguageExtensions.rst

r369779 - [OpenCL] Renamed value of std flag in C++ mode.

Author: stulova Date: Fri Aug 23 10:10:33 2019 New Revision: 369779 URL: http://llvm.org/viewvc/llvm-project?rev=369779&view=rev Log: [OpenCL] Renamed value of std flag in C++ mode. Clang should accept -std=clc++ (not -std=c++!) for OpenCL. This was forgotten in r367008. Modified: cfe/tru

Re: r369749 - [Docs][OpenCL] Several corrections to C++ for OpenCL

Hi Hans, Can this be merged to the release, please? Thank you, Anastasia From: cfe-commits on behalf of Anastasia Stulova via cfe-commits Sent: 23 August 2019 12:43 To: cfe-commits@lists.llvm.org Subject: r369749 - [Docs][OpenCL] Several corrections to C

[clang] 752220e - [OpenCL] Fixed printing of __private in AMDGPU test

Author: Anastasia Stulova Date: 2019-12-27T17:08:42Z New Revision: 752220ea2664c814eb1eb046d755fe63ade9c32e URL: https://github.com/llvm/llvm-project/commit/752220ea2664c814eb1eb046d755fe63ade9c32e DIFF: https://github.com/llvm/llvm-project/commit/752220ea2664c814eb1eb046d755fe63ade9c32e.diff

[clang] e456165 - [OpenCL] Add link to C++ for OpenCL documentation

Author: Anastasia Stulova Date: 2020-01-03T12:01:03Z New Revision: e456165f9fec9148566849f21bc4f7dda2fea034 URL: https://github.com/llvm/llvm-project/commit/e456165f9fec9148566849f21bc4f7dda2fea034 DIFF: https://github.com/llvm/llvm-project/commit/e456165f9fec9148566849f21bc4f7dda2fea034.diff

[clang] a84599f - [OpenCL] Implement extended subgroups fully in headers.

Author: Anastasia Stulova Date: 2020-12-10T16:40:15Z New Revision: a84599f177a67d4a8c1c30ccd96c99fa40af75f7 URL: https://github.com/llvm/llvm-project/commit/a84599f177a67d4a8c1c30ccd96c99fa40af75f7 DIFF: https://github.com/llvm/llvm-project/commit/a84599f177a67d4a8c1c30ccd96c99fa40af75f7.diff

[clang] 71d3b7e - [OpenCL] Add new compilation mode for OpenCL 3.0.

Author: Anastasia Stulova Date: 2020-10-09T15:28:38+01:00 New Revision: 71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f URL: https://github.com/llvm/llvm-project/commit/71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f DIFF: https://github.com/llvm/llvm-project/commit/71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f.d

[clang] 58d18dd - [OpenCL] Remove pragma requirement from Arm dot extension.

Author: Anastasia Stulova Date: 2021-05-12T16:25:33+01:00 New Revision: 58d18dde5cca3417e3d52670775c95d2f6fe9d05 URL: https://github.com/llvm/llvm-project/commit/58d18dde5cca3417e3d52670775c95d2f6fe9d05 DIFF: https://github.com/llvm/llvm-project/commit/58d18dde5cca3417e3d52670775c95d2f6fe9d05.d

[clang] 769cc33 - [OpenCL] Simplify use of C11 atomic types.

Author: Anastasia Stulova Date: 2021-05-14T17:43:00+01:00 New Revision: 769cc335e6e63e5eac0c0ac849de44714326e20b URL: https://github.com/llvm/llvm-project/commit/769cc335e6e63e5eac0c0ac849de44714326e20b DIFF: https://github.com/llvm/llvm-project/commit/769cc335e6e63e5eac0c0ac849de44714326e20b.d

[clang] 3549466 - [OpenCL] Drop pragma handling for extension types/decls.

Author: Anastasia Stulova Date: 2021-05-17T12:09:43+01:00 New Revision: 3549466ac05eda57c9ce13abd7cb6dd365f6d8d6 URL: https://github.com/llvm/llvm-project/commit/3549466ac05eda57c9ce13abd7cb6dd365f6d8d6 DIFF: https://github.com/llvm/llvm-project/commit/3549466ac05eda57c9ce13abd7cb6dd365f6d8d6.d

[clang] 237c692 - [OpenCL] Add clang extension for bit-fields.

Author: Anastasia Stulova Date: 2021-05-24T12:42:17+01:00 New Revision: 237c6924bd46ec0e33da71f9616caf9bf9965b23 URL: https://github.com/llvm/llvm-project/commit/237c6924bd46ec0e33da71f9616caf9bf9965b23 DIFF: https://github.com/llvm/llvm-project/commit/237c6924bd46ec0e33da71f9616caf9bf9965b23.d

[clang] 626e964 - [OpenCL] Fix test by adding SPIR triple

Author: Anastasia Stulova Date: 2021-05-24T13:03:50+01:00 New Revision: 626e9641a2f5fde638b86d4e043f82fc58b908f8 URL: https://github.com/llvm/llvm-project/commit/626e9641a2f5fde638b86d4e043f82fc58b908f8 DIFF: https://github.com/llvm/llvm-project/commit/626e9641a2f5fde638b86d4e043f82fc58b908f8.d

[clang] 5ccc79d - [OpenCL][Docs] Minor update to OpenCL 3.0

Author: Anastasia Stulova Date: 2021-05-24T14:19:22+01:00 New Revision: 5ccc79dc38b2df18cca5a9b4d66dcd4603f948e9 URL: https://github.com/llvm/llvm-project/commit/5ccc79dc38b2df18cca5a9b4d66dcd4603f948e9 DIFF: https://github.com/llvm/llvm-project/commit/5ccc79dc38b2df18cca5a9b4d66dcd4603f948e9.d

[clang] 8fdd578 - [OpenCL][Docs] Describe tablegen BIFs declarations.

Author: Anastasia Stulova Date: 2021-01-25T11:17:03Z New Revision: 8fdd5784f0d30b165602343a96a34611779b007b URL: https://github.com/llvm/llvm-project/commit/8fdd5784f0d30b165602343a96a34611779b007b DIFF: https://github.com/llvm/llvm-project/commit/8fdd5784f0d30b165602343a96a34611779b007b.diff

[clang] 5bbf397 - [OpenCL] Add diagnostics for references to functions

Author: Anastasia Stulova Date: 2021-02-02T15:07:40Z New Revision: 5bbf39704c2b70581d78a463f3c9d20b0eb7dcd5 URL: https://github.com/llvm/llvm-project/commit/5bbf39704c2b70581d78a463f3c9d20b0eb7dcd5 DIFF: https://github.com/llvm/llvm-project/commit/5bbf39704c2b70581d78a463f3c9d20b0eb7dcd5.diff

[clang] 844f01f - Fixed failing OpenCL test

Author: Anastasia Stulova Date: 2021-02-02T16:19:28Z New Revision: 844f01fc9589b25a3427a6cf4ca406e6787ae171 URL: https://github.com/llvm/llvm-project/commit/844f01fc9589b25a3427a6cf4ca406e6787ae171 DIFF: https://github.com/llvm/llvm-project/commit/844f01fc9589b25a3427a6cf4ca406e6787ae171.diff

[clang] e635feb - [OpenCL] Fix address space in binding of initializer lists to referencs

Author: Anastasia Stulova Date: 2021-02-03T12:48:21Z New Revision: e635feb15a91e6eeb77876031be2811e63d542f3 URL: https://github.com/llvm/llvm-project/commit/e635feb15a91e6eeb77876031be2811e63d542f3 DIFF: https://github.com/llvm/llvm-project/commit/e635feb15a91e6eeb77876031be2811e63d542f3.diff

[clang] 7a45f27 - [OpenCL][Docs] Fix command line flag in the example.

Author: Anastasia Stulova Date: 2021-02-03T14:07:46Z New Revision: 7a45f27ba156e311bf1deaa42761ec08d8e34d05 URL: https://github.com/llvm/llvm-project/commit/7a45f27ba156e311bf1deaa42761ec08d8e34d05 DIFF: https://github.com/llvm/llvm-project/commit/7a45f27ba156e311bf1deaa42761ec08d8e34d05.diff

[clang] 0c65993 - [OpenCL] Fix default address space in template argument deduction.

Author: Anastasia Stulova Date: 2021-02-04T13:51:53Z New Revision: 0c65993be186640463ac90415113474d35889dbb URL: https://github.com/llvm/llvm-project/commit/0c65993be186640463ac90415113474d35889dbb DIFF: https://github.com/llvm/llvm-project/commit/0c65993be186640463ac90415113474d35889dbb.diff

[clang] 0fb4341 - [OpenCL][Docs] Link page explaining tooling for offline compilation.

Author: Anastasia Stulova Date: 2021-02-04T14:01:27Z New Revision: 0fb4341519ef3ac06518ba56bb100277d89cdf11 URL: https://github.com/llvm/llvm-project/commit/0fb4341519ef3ac06518ba56bb100277d89cdf11 DIFF: https://github.com/llvm/llvm-project/commit/0fb4341519ef3ac06518ba56bb100277d89cdf11.diff

[clang] 79b222c - [OpenCL] Fix types with signed prefix in arginfo metadata.

Author: Anastasia Stulova Date: 2021-02-09T15:13:19Z New Revision: 79b222c39f0e4377b49191b6aba080b1607f3fa7 URL: https://github.com/llvm/llvm-project/commit/79b222c39f0e4377b49191b6aba080b1607f3fa7 DIFF: https://github.com/llvm/llvm-project/commit/79b222c39f0e4377b49191b6aba080b1607f3fa7.diff

[clang] cf3ef15 - [OpenCL] Add builtin declarations by default.

Author: Anastasia Stulova Date: 2021-02-22T12:24:16Z New Revision: cf3ef15a6ec5e5b45c6c54e8fbe3769255e815ce URL: https://github.com/llvm/llvm-project/commit/cf3ef15a6ec5e5b45c6c54e8fbe3769255e815ce DIFF: https://github.com/llvm/llvm-project/commit/cf3ef15a6ec5e5b45c6c54e8fbe3769255e815ce.diff

[clang-tools-extra] b71add9 - [pp-trace] Fix test for OpenCL pragmas.

Author: Anastasia Stulova Date: 2021-02-22T14:28:45Z New Revision: b71add9777bed67e05206fa1fdb665f3e21a13ab URL: https://github.com/llvm/llvm-project/commit/b71add9777bed67e05206fa1fdb665f3e21a13ab DIFF: https://github.com/llvm/llvm-project/commit/b71add9777bed67e05206fa1fdb665f3e21a13ab.diff

[clang] 90355d6 - [OpenCL][Docs] Change description for the OpenCL standard headers.

Author: Anastasia Stulova Date: 2021-02-23T11:49:05Z New Revision: 90355d6f10765d03af1bfcc1ab3d17e8cae330f1 URL: https://github.com/llvm/llvm-project/commit/90355d6f10765d03af1bfcc1ab3d17e8cae330f1 DIFF: https://github.com/llvm/llvm-project/commit/90355d6f10765d03af1bfcc1ab3d17e8cae330f1.diff

[clang] abbdb56 - [OpenCL] Allow taking address of functions as an extension.

Author: Anastasia Stulova Date: 2021-02-24T12:32:02Z New Revision: abbdb5639c70d167bd66cd62296927330782c3b4 URL: https://github.com/llvm/llvm-project/commit/abbdb5639c70d167bd66cd62296927330782c3b4 DIFF: https://github.com/llvm/llvm-project/commit/abbdb5639c70d167bd66cd62296927330782c3b4.diff

[clang] 577220e - [OpenCL] Add std flag aliases clc++1.0 and CLC++1.0

Author: Anastasia Stulova Date: 2021-07-30T09:19:26+01:00 New Revision: 577220e89866608e0706e3a2b9f8f48215e4e811 URL: https://github.com/llvm/llvm-project/commit/577220e89866608e0706e3a2b9f8f48215e4e811 DIFF: https://github.com/llvm/llvm-project/commit/577220e89866608e0706e3a2b9f8f48215e4e811.d

[clang] a10a69f - [SPIR-V] Add SPIR-V triple and clang target info.

Author: Anastasia Stulova Date: 2021-11-08T13:34:10Z New Revision: a10a69fe9c74bef3630795d9f2f516d7b84e1cd3 URL: https://github.com/llvm/llvm-project/commit/a10a69fe9c74bef3630795d9f2f516d7b84e1cd3 DIFF: https://github.com/llvm/llvm-project/commit/a10a69fe9c74bef3630795d9f2f516d7b84e1cd3.diff

[clang] 25ad188 - [OpenCL] Prevent adding extension pragma by default.

Author: Anastasia Stulova Date: 2021-03-03T15:02:21Z New Revision: 25ad188bfcdb2a85416013c6303f30cbc7775674 URL: https://github.com/llvm/llvm-project/commit/25ad188bfcdb2a85416013c6303f30cbc7775674 DIFF: https://github.com/llvm/llvm-project/commit/25ad188bfcdb2a85416013c6303f30cbc7775674.diff

[clang] bafcb4c - [OpenCL][Docs] Add guidelines for new extensions and features.

Author: Anastasia Stulova Date: 2021-03-11T14:28:48Z New Revision: bafcb4c6841a302d502b14fb93101fb590459935 URL: https://github.com/llvm/llvm-project/commit/bafcb4c6841a302d502b14fb93101fb590459935 DIFF: https://github.com/llvm/llvm-project/commit/bafcb4c6841a302d502b14fb93101fb590459935.diff

[clang] eed88e9 - [OpenCL] Use spir target for CIndex tests for OpenCL.

Author: Anastasia Stulova Date: 2021-03-12T20:11:26Z New Revision: eed88e91f331d158d3d0c91e91fca408c9f1d1e1 URL: https://github.com/llvm/llvm-project/commit/eed88e91f331d158d3d0c91e91fca408c9f1d1e1 DIFF: https://github.com/llvm/llvm-project/commit/eed88e91f331d158d3d0c91e91fca408c9f1d1e1.diff

[clang] f4d3cb4 - [HIPSPV] Add CUDA->SPIR-V address space mapping

Author: Anastasia Stulova Date: 2021-12-02T13:34:27Z New Revision: f4d3cb4ca833d0b165d199e78ed8f1d59a8032eb URL: https://github.com/llvm/llvm-project/commit/f4d3cb4ca833d0b165d199e78ed8f1d59a8032eb DIFF: https://github.com/llvm/llvm-project/commit/f4d3cb4ca833d0b165d199e78ed8f1d59a8032eb.diff

[clang] db664a6 - [Doc][OpenCL] Fixed typos in code examples

Author: Anastasia Stulova Date: 2022-09-22T17:46:47+01:00 New Revision: db664a666c2c0cc144c7827dbdad1b893a63408c URL: https://github.com/llvm/llvm-project/commit/db664a666c2c0cc144c7827dbdad1b893a63408c DIFF: https://github.com/llvm/llvm-project/commit/db664a666c2c0cc144c7827dbdad1b893a63408c.d

[clang] 790cbaa - [OpenCL] Fix diagnostics with templates in kernel args.

Author: Anastasia Stulova Date: 2022-11-10T18:55:12Z New Revision: 790cbaafc9e276aa740373c00849951338056174 URL: https://github.com/llvm/llvm-project/commit/790cbaafc9e276aa740373c00849951338056174 DIFF: https://github.com/llvm/llvm-project/commit/790cbaafc9e276aa740373c00849951338056174.diff

[clang] 380a038 - Updated contact email address.

Author: Anastasia Stulova Date: 2022-11-10T19:50:19Z New Revision: 380a038d147454afb16b97fd9739f4c3d7307401 URL: https://github.com/llvm/llvm-project/commit/380a038d147454afb16b97fd9739f4c3d7307401 DIFF: https://github.com/llvm/llvm-project/commit/380a038d147454afb16b97fd9739f4c3d7307401.diff

[clang] 730dc4e - [Clang] Added options for integrated backend.

Author: Anastasia Stulova Date: 2022-05-25T12:07:33+01:00 New Revision: 730dc4e9bce8189c037a32e520d18b141250d265 URL: https://github.com/llvm/llvm-project/commit/730dc4e9bce8189c037a32e520d18b141250d265 DIFF: https://github.com/llvm/llvm-project/commit/730dc4e9bce8189c037a32e520d18b141250d265.d

[clang] 3087afb - [OpenCL][Doc] Misc improvements related to SPIR-V support.

Author: Anastasia Stulova Date: 2022-05-26T15:54:33+01:00 New Revision: 3087afb421bf4ca4450d8981a1410e1a09f3794a URL: https://github.com/llvm/llvm-project/commit/3087afb421bf4ca4450d8981a1410e1a09f3794a DIFF: https://github.com/llvm/llvm-project/commit/3087afb421bf4ca4450d8981a1410e1a09f3794a.d

[clang] 7df2597 - [Doc][OpenCL] Misc wording improvements for SPIR-V

Author: Anastasia Stulova Date: 2022-05-27T11:13:06+01:00 New Revision: 7df25978ef7882a3d793eecee854ec5d961c02d2 URL: https://github.com/llvm/llvm-project/commit/7df25978ef7882a3d793eecee854ec5d961c02d2 DIFF: https://github.com/llvm/llvm-project/commit/7df25978ef7882a3d793eecee854ec5d961c02d2.d

[clang] fa755d3 - [Sema][C++] Propagate conversion kind to specialize the diagnostics

Author: Anastasia Stulova Date: 2020-02-25T16:05:37Z New Revision: fa755d3e71ed590ac5c62f0e1eff09435c9593fe URL: https://github.com/llvm/llvm-project/commit/fa755d3e71ed590ac5c62f0e1eff09435c9593fe DIFF: https://github.com/llvm/llvm-project/commit/fa755d3e71ed590ac5c62f0e1eff09435c9593fe.diff

[clang] a29aa47 - [OpenCL] Move addr space deduction to Sema.

Author: Anastasia Stulova Date: 2019-11-27T12:44:42Z New Revision: a29aa47106205ec95c12e0ebac4260c5de878a6a URL: https://github.com/llvm/llvm-project/commit/a29aa47106205ec95c12e0ebac4260c5de878a6a DIFF: https://github.com/llvm/llvm-project/commit/a29aa47106205ec95c12e0ebac4260c5de878a6a.diff

[clang] 980133a - [OpenCL] Use generic addr space for lambda call operator

Author: Anastasia Stulova Date: 2019-12-03T16:07:18Z New Revision: 980133a2098cf6159785b8ac0cbe4d8fbf99bfea URL: https://github.com/llvm/llvm-project/commit/980133a2098cf6159785b8ac0cbe4d8fbf99bfea DIFF: https://github.com/llvm/llvm-project/commit/980133a2098cf6159785b8ac0cbe4d8fbf99bfea.diff

[clang] e6522a9 - [OpenCL] Allow addr space qualifiers on lambda call expressions

Author: Anastasia Stulova Date: 2019-12-04T12:25:20Z New Revision: e6522a96f56ce0257ab8cc6fca77bf9ea4462fa6 URL: https://github.com/llvm/llvm-project/commit/e6522a96f56ce0257ab8cc6fca77bf9ea4462fa6 DIFF: https://github.com/llvm/llvm-project/commit/e6522a96f56ce0257ab8cc6fca77bf9ea4462fa6.diff

[clang] ed8dadb - [Sema] Improve diagnostic about addr spaces for overload candidates

Author: Anastasia Stulova Date: 2019-12-13T12:35:18Z New Revision: ed8dadb37c7e1a7f4889d868ac9b19bfe7762237 URL: https://github.com/llvm/llvm-project/commit/ed8dadb37c7e1a7f4889d868ac9b19bfe7762237 DIFF: https://github.com/llvm/llvm-project/commit/ed8dadb37c7e1a7f4889d868ac9b19bfe7762237.diff

[clang] 6064f42 - [OpenCL] Restrict addr space conversions in nested pointers

Author: Anastasia Stulova Date: 2020-02-07T12:04:35Z New Revision: 6064f426a18304e16b51cc79e74c9c2d55ef5a9c URL: https://github.com/llvm/llvm-project/commit/6064f426a18304e16b51cc79e74c9c2d55ef5a9c DIFF: https://github.com/llvm/llvm-project/commit/6064f426a18304e16b51cc79e74c9c2d55ef5a9c.diff

Re: A proposal for adding OpenCL C++ support (Spec v2.2)

There were no objections to this so far. I assume it means nobody is opposing this new feature. Just to give a bit more info and a chance for the last feedback. We don't plan to contribute the whole patch but only around 3K lines + tests. The overall changes will be smaller than OpenCL 2.0. An

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

Anastasia added a comment. In https://reviews.llvm.org/D23086#515590, @yaxunl wrote: > In https://reviews.llvm.org/D23086#515506, @Anastasia wrote: > > > > > > > > > Surely vendors can re-implement all OpenCL types with an implicit typedef. > > For example this would just work: > > > > > > ty

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

Anastasia added a comment. In https://reviews.llvm.org/D23086#516741, @yaxunl wrote: > In https://reviews.llvm.org/D23086#516365, @Anastasia wrote: > > > Why not to just identify the type by the name? It seems much easier and > > also gives flexibility to implement the type in different ways if

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Anastasia added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1513 @@ -1512,2 +1512,3 @@ // extension. -llvm::Type *MiddleTy = CGF.IntPtrTy; +auto DestLLVMTy = ConvertType(DestTy); +llvm::Type *MiddleTy = CGF.CGM.getDataLayout().getIntPtrType(DestLLVMT

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D23361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D23452: [OpenCL] Release 3.9 notes

Anastasia added a comment. @hans, I have committed one minor addition to OpenCL notes (r279224), which is important enough to include Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst (revision 279176) +++ doc

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

Anastasia added a comment. Just to summarize, it seems there are the following options to proceed, each has some benefits and disadvantages: 1. We can check the canonical type. This gives us possibility to accept the type name aliases, but reduces flexibility to implement this type in a custom

Re: [PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

Anastasia added a comment. What would be the use case to override the supported extensions for the end user? The change to set the right extensions based on the target compiled for was to avoid mis-compilations. But adding a user flag to control that could lead to the old problem to reoccur.

Re: [PATCH] D23992: [OpenCL] Augment pipe built-ins with pipe packet size and alignment.

Anastasia added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:97 @@ +96,3 @@ + return llvm::ConstantInt::get(Int32Ty, +TypeSizeInBits / 8, // Size in bytes. +false); Perhaps it's safer

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

Anastasia added a comment. Could we add a CodeGen test as well to check that the constants generated are in the right precision format? https://reviews.llvm.org/D24235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D24136: [OpenCL] Fix pipe built-in functions return type.

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/pipe_builtin.cl:64 @@ +63,3 @@ +void test8(read_only pipe int r, write_only pipe int w, global int *ptr) { + // verify that return type is correctly casted to i1 value + // CHECK: %[[R:[0-9]+]] = call i32 @__read_pi

Re: [PATCH] D23915: [OpenCL] Remove access qualifiers on images in arg info metadata.

Anastasia accepted this revision. Anastasia added a comment. LGTM! https://reviews.llvm.org/D23915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. Have you done any investigation regarding the compilation speed as this change adds expensive container lookups for all OpenCL declarations and function calls. It would be nice

Re: [PATCH] D24136: [OpenCL] Fix pipe built-in functions return type.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D24136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D23992: [OpenCL] Augment pipe built-ins with pipe packet size and alignment.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D23992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

Anastasia added a comment. In https://reviews.llvm.org/D23712#524021, @asavonic wrote: > In https://reviews.llvm.org/D23712#520818, @Anastasia wrote: > > > What would be the use case to override the supported extensions for the end > > user? > > > Some extensions may be supported by the platform

Re: [PATCH] D23953: OpenCL: Defining __ENDIAN_LITTLE__ and fix target endianness

Anastasia added a subscriber: Anastasia. Anastasia accepted this revision. Anastasia added a reviewer: Anastasia. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D23953 ___ cfe-commits maili

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

Anastasia added inline comments. Comment at: lib/Sema/SemaExpr.cpp:832 @@ -831,2 +831,3 @@ BTy->getKind() == BuiltinType::Float)) -E = ImpCastExprToType(E, Context.DoubleTy, CK_FloatingCast).get(); + { +if (getLangOpts().OpenCL && This shou

Re: [PATCH] D24054: Do not validate pch when -fno-validate-pch is set

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D24054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added a comment. In https://reviews.llvm.org/D21698#537156, @yaxunl wrote: > I did profiling with valgrind for the cost of checking disabled types and > declarations. For a typical program, time spent in checking disabled types > and declarations are less than 0.1%, so this cost can b

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D24235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added a comment. I have made an experiment with a simple kernel: void foo1(void); void foo2(void); void foo3(void); void foo4(void); void foo5(void); void foo6(void); void foo7(void); void foo8(void); void foo9(void); void foo10(void); void test(){ foo1();

r298256 - [OpenCL] Fix extension guards for atomic functions

Author: stulova Date: Mon Mar 20 10:02:54 2017 New Revision: 298256 URL: http://llvm.org/viewvc/llvm-project?rev=298256&view=rev Log: [OpenCL] Fix extension guards for atomic functions Review: D30830 Patch by James Price! Modified: cfe/trunk/lib/Headers/opencl-c.h Modified: cfe/trunk/lib/

r298709 - [OpenCL][Bug 10573] Don't set CXXOperatorNames flag

Author: stulova Date: Fri Mar 24 11:43:51 2017 New Revision: 298709 URL: http://llvm.org/viewvc/llvm-project?rev=298709&view=rev Log: [OpenCL][Bug 10573] Don't set CXXOperatorNames flag The flag CXXOperatorNames was overwritten unconditionally after being set for OpenCL. There seems to be no ne

RE: r298976 - [OpenCL] Added parsing for OpenCL vector types.

It seems like the following change causes the failures: diff --git a/lib/Parse/ParseExpr.cpp b/lib/Parse/ParseExpr.cpp index 4dcdfbf..e1439d6 100644 --- a/lib/Parse/ParseExpr.cpp +++ b/lib/Parse/ParseExpr.cpp @@ -2379,10 +2427,13 @@ Parser::ParseParenExpression(ParenParseOption &ExprType, b

r299447 - [Bug 25404] Fix crash on typedef in OpenCL 2.0

Author: stulova Date: Tue Apr 4 11:50:46 2017 New Revision: 299447 URL: http://llvm.org/viewvc/llvm-project?rev=299447&view=rev Log: [Bug 25404] Fix crash on typedef in OpenCL 2.0 Fixed the assertion due to absence of source location for implicitly defined types (using addImplicitTypedef()). Dur

r291780 - [Docs][OpenCL] Added OpenCL feature description to Clang documentation.

Author: stulova Date: Thu Jan 12 11:52:22 2017 New Revision: 291780 URL: http://llvm.org/viewvc/llvm-project?rev=291780&view=rev Log: [Docs][OpenCL] Added OpenCL feature description to Clang documentation. Updated index and UsersManual with OpenCL description. Review: https://reviews.llvm.org/D2

RE: PATCH: re-enable OpenCL extensions

As mentioned on cfe-dev as well, although it doesn't seem too critical it is generally not logical to enable all extensions by default because most of the targets don't even support OpenCL. But I understand your situation with using x86 or ARM backends in a generic way. Do you think this can be

r292804 - [OpenCL] Improved enqueue_kernel diagnostic message

Author: stulova Date: Mon Jan 23 11:12:36 2017 New Revision: 292804 URL: http://llvm.org/viewvc/llvm-project?rev=292804&view=rev Log: [OpenCL] Improved enqueue_kernel diagnostic message - Removed duplicated word typo. - Made coherent across multiple similar diagnostics. Modified: cfe/trunk/

r293050 - [OpenCL] Diagnose write_only image3d when extension is disabled

Author: stulova Date: Wed Jan 25 06:18:50 2017 New Revision: 293050 URL: http://llvm.org/viewvc/llvm-project?rev=293050&view=rev Log: [OpenCL] Diagnose write_only image3d when extension is disabled Prior to OpenCL 2.0, image3d_t can only be used with the write_only access qualifier when the cl_kh

r293286 - [OpenCL] Add missing address spaces in IR generation of blocks

Author: stulova Date: Fri Jan 27 09:11:34 2017 New Revision: 293286 URL: http://llvm.org/viewvc/llvm-project?rev=293286&view=rev Log: [OpenCL] Add missing address spaces in IR generation of blocks Modify ObjC blocks impl wrt address spaces as follows: - keep default private address space for blo

RE: r285733 - clang/test/CodeGenOpenCL/convergent.cl: Satisfy -Asserts with "opt -instnamer".

I don't understand why we need this extra step in testing now? Did anything fail? Thanks, Anastasia -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of NAKAMURA Takumi via cfe-commits Sent: 01 November 2016 20:08 To: cfe-commits@lists.llvm.org S

r294313 - [OpenCL] Accept logical NOT for pointer types in CL1.1

Author: stulova Date: Tue Feb 7 10:09:41 2017 New Revision: 294313 URL: http://llvm.org/viewvc/llvm-project?rev=294313&view=rev Log: [OpenCL] Accept logical NOT for pointer types in CL1.1 Fix for bug 30217 - incorrect error given for logical NOT operation with a pointer type: corrected sema chec

r295307 - [OpenCL] Disallow blocks capture other blocks (v2.0, s6.12.5)

Author: stulova Date: Thu Feb 16 05:13:30 2017 New Revision: 295307 URL: http://llvm.org/viewvc/llvm-project?rev=295307&view=rev Log: [OpenCL] Disallow blocks capture other blocks (v2.0, s6.12.5) Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaExpr.c

r295311 - [OpenCL] Correct ndrange_t implementation

Author: stulova Date: Thu Feb 16 06:27:47 2017 New Revision: 295311 URL: http://llvm.org/viewvc/llvm-project?rev=295311&view=rev Log: [OpenCL] Correct ndrange_t implementation Removed ndrange_t as Clang builtin type and added as a struct type in the OpenCL header. Use type name to do the Sema ch

r295313 - [OpenCL][Doc] Added OpenCL vendor extension description to user manual doc

Author: stulova Date: Thu Feb 16 06:49:29 2017 New Revision: 295313 URL: http://llvm.org/viewvc/llvm-project?rev=295313&view=rev Log: [OpenCL][Doc] Added OpenCL vendor extension description to user manual doc Added description of a new feature that allows to specify vendor extension in flexible w

RE: D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

Hans, could we merge this documentation only change (r295313) in release40 branch. I can commit myself if needed. :) Thanks in advance, Anastasia -Original Message- From: Anastasia Stulova via Phabricator [mailto:revi...@reviews.llvm.org] Sent: 16 February 2017 14:15 To: Anastasia Stulov

RE: D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

Perfect! Thanks! Anastasia -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 16 February 2017 17:22 To: Anastasia Stulova Cc: cfe-commits@lists.llvm.org Subject: Re: D29829: [OpenCL][Doc] Description for adding OpenCL vendor ex

RE: r295843 - [OpenCL] r600 needs OpenCL kernel calling convention

Sure! No objections here! Thanks, Anastasia -Original Message- From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans Wennborg Sent: 22 February 2017 18:10 To: Jan Vesely Cc: cfe-commits; Matt Arsenault; Anastasia Stulova Subject: Re: r295843 - [OpenCL] r600 needs Ope

r297468 - [OpenCL] Fix type compatibility check and generic AS mangling.

Author: stulova Date: Fri Mar 10 09:23:07 2017 New Revision: 297468 URL: http://llvm.org/viewvc/llvm-project?rev=297468&view=rev Log: [OpenCL] Fix type compatibility check and generic AS mangling. 1. Reimplemented conditional operator so that it checks compatibility of unqualified pointees of the

RE: r297468 - [OpenCL] Fix type compatibility check and generic AS mangling.

l/logs/stdio Please have a look at it? Thanks Galina On Fri, Mar 10, 2017 at 7:23 AM, Anastasia Stulova via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: stulova Date: Fri Mar 10 09:23:07 2017 New Revision: 297468 URL: http://llvm.org/viewvc/llvm-project?rev=297468&view=

[PATCH] D26735: [OpenCL] Disable && (address of label) GNU extension for OpenCL

Anastasia added a comment. It seems that this bit is accepted under -std=c99 and the warning is given with the -pedantic flag. I am not sure whether it adds much deviating the implementation from C here. The OpenCL spec doesn't seem to contain anything on this matter? But if we decide to be mor

[PATCH] D26746: [OpenCL] Split PipeType into ReadPipe/WritePipe

Anastasia added a comment. Earlier related discussion: https://reviews.llvm.org/D17821 Repository: rL LLVM https://reviews.llvm.org/D26746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

Anastasia added a comment. I have created a bug to Khronos regarding this, but unfortunately I don't see it being progressed yet. https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15659 The problem here is that I am not sure we should deviate from the ObjC implementation because OpenCL blocks ar

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

Anastasia created this revision. Anastasia added a reviewer: yaxunl. Anastasia added a subscriber: cfe-commits. Clang performs some optimizations/shortcuts for const qualified aggregate variables while generating them on the stack. It bypasses the generation of alloca instructions and their uses

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

Anastasia added a comment. Btw, Spec v2.0 s6.9.p seems to mention other types as well! Comment at: lib/Sema/SemaDecl.cpp:5923 + if (getLangOpts().OpenCL && (NULL == S->getParent())) { +if (R->isReserveIDT()) { - Could we combine with the OpenCL check abo

r288163 - [OpenCL] Prevent generation of globals in non-constant AS for OpenCL.

Author: stulova Date: Tue Nov 29 11:01:19 2016 New Revision: 288163 URL: http://llvm.org/viewvc/llvm-project?rev=288163&view=rev Log: [OpenCL] Prevent generation of globals in non-constant AS for OpenCL. Avoid using shortcut for const qualified non-constant address space aggregate variables while

RE: [PATCH] D27334: [OpenCL] Ambiguous function call.

> Perhaps that is the problem (that there are two modes that do different > things)? Could we make the double overload be present but unselectable to > diagnose this problem in that mode too? If we could resolve the overload candidate to prefer ‘int -> float’ than ‘int->double’, it would work b

RE: [PATCH] D27334: [OpenCL] Ambiguous function call.

I think we can’t avoid deviating from C/C++ implementation completely. But we should certainly try to avoid it in unnecessary situations as much as we can. In this case it seems like the spec enforces the rules for resolving the ambiguity that seems logical to me. Is this possibly a better way

r300988 - [OpenCL] Fix semantic check of ndrange_t for device_side_enqueue.

Author: stulova Date: Fri Apr 21 10:13:24 2017 New Revision: 300988 URL: http://llvm.org/viewvc/llvm-project?rev=300988&view=rev Log: [OpenCL] Fix semantic check of ndrange_t for device_side_enqueue. Check unqualified type for ndrange argument in device_side_enqueue so device_side_enqueue accept

<    1   2   3   4   5   6   7   >