Anastasia added inline comments.

================
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:97
@@ +96,3 @@
+  return llvm::ConstantInt::get(Int32Ty,
+                                TypeSizeInBits / 8, // Size in bytes.
+                                false);
----------------
Perhaps it's safer to use getTypeSizeInChars instead? Even though most of 
architectures should have an 8-bit byte, it will allow us to avoid having 
hard-coded numbers.


https://reviews.llvm.org/D23992



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to