[PATCH] D101052: [OpenCL] allow pipe as a valid identifier prior to OpenCL 2.0

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. pipe has not been a reserved keyword in the earlier OpenCL standards https://www.khronos.org/registry/OpenCL/specs/opencl-1.2.pdf

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

Anastasia added a comment. In D101043#2708358 , @yaxunl wrote: > Did you check whether this patch will cause regression in OpenCL conformance > tests? If not, I am OK with it. This change has no impact on CTS as CTS has never had negative compiler tests

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

This revision was automatically updated to reflect the committed changes. Closed by commit rG362958ac7346: [C++4OpenCL] Add extra diagnostics for kernel argument types (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100471/new/

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || bader wrote: >

[PATCH] D101089: [OpenCL] Document legacy atomics with generic address space

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, jfb, yaxunl. Anastasia requested review of this revision. There were multiple requests from the developers to allow this functionality in OpenCL https://github.com/KhronosGroup/OpenCL-Docs/iss

[PATCH] D101092: [OpenCL][Docs] Misc updates about C++ for OpenCL and offline compilation

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. https://reviews.llvm.org/D101092 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/UsersManual.rst

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia added a comment. Just a few nitpicks otherwise it looks great! Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:364 + +def warn_opencl_not_supported_core_feature : Warning< + "%0 is a core feature in this OpenCL version but not supported on this target

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2711588 , @azabaznov wrote: >> do you think it is valuable to keep this behavior at all? > > As I said, I would be happy too if we remove pragma extension as it will > really simplify the codebase of OpenCL in clang

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2711963 , @azabaznov wrote: >> For cl_khr_fp64 I still want to keep the pragma for the other use case - to >> convert double literal into single-precision >> (https://github.com/KhronosGroup/OpenCL-Docs/issues/578).

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:365 +def warn_opencl_unsupported_core_feature : Warning< + "%0 is a core feature in OpenCL C %1 but not supported on this target">, + InGroup, DefaultIgnore; I would

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2712534 , @azabaznov wrote: >> We could of course keep it just for this particular case of doubles, but >> even half is allowed in certain circumstances without the pragma and it is >> still an extension. https://go

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 __

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 ___ cfe-commits mailing list cfe-commit

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. I have made a minor suggestion to testing that could be addressed in the final commit. Comment at: clang/test/Misc/nvptx.unsupported_core.cl:1 +// RUN:

[PATCH] D101168: [C++4OpenCL] Add clang extension for unsafe kernel parameters

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1804 +``__cl_clang_allow_unsafe_kernel_parameters`` +- How about `__cl_clang_unsafe_kernel_parameters` to match the other extension namin

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. We have discussed testing of headers within OpenCL developer community and wider: https://lists.llvm.org/pipermail/cfe-dev/2021-April/068040.html and the conclusions I have drawn are as follows: - There seem to be no big interest in improving upstream testing of `ope

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

Anastasia added a comment. In D99488#2716768 , @bader wrote: > Rebased patch to unblock commit. > > This patch had a dependency on D99190 , > which adds SYCLSupport.rst document. > To unblock commit of D99488

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2719043 , @azabaznov wrote: >> I am not sure, to be honest I personally think the extension pragma is a >> spec failure as it is not specified properly or to allow reasonable >> implementation > > Unfortunately it's

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2719196 , @azabaznov wrote: >> When the pragma is parsed we can't know why it is in the code to be able to >> issue any warning. > > I mean diagnose once when, for example in your particular case, double type > is p

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a92c19f3bbc: [C++4OpenCL] Add diagnostics for OpenCL types in templates. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100860/new/

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLImageTypes.def:68 IMAGE_WRITE_TYPE(image2d_array_msaa_depth, OCLImage2dArrayMSAADepth, "cl_khr_gl_msaa_sharing") -IMAGE_WRITE_TYPE(image3d, OCLImage3d, "cl_khr_3d_image_writes") +IMAGE_WRITE_TYPE(image

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2722112 , @azabaznov wrote: > In D100980#2719322 , @Anastasia > wrote: > >> In D100980#2719196 , @azabaznov >> wrote: >> When

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia accepted this revision. Anastasia added a comment. Cool! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101087/new/ https://reviews.llvm.org/D101087 ___ cfe-commits mailing list cfe-comm

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2722207 , @azabaznov wrote: >> Not sure what do we want to achieve with this? Do you want to point out that >> the code might be somehow less portable let's say between clang revisions, >> etc? > > My main worry is

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

Anastasia added a comment. If I build docs now I get the following output: llvm-project/build-doc/tools/clang/docs/SYCLSupport.rst:102: WARNING: Error in "code-block" directive: 1 argument(s) required, 0 supplied. .. code-block:: TODO: add support for `__attribute__((opencl_glob

[PATCH] D101089: [OpenCL] Document legacy atomics with generic address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fb0d6df11e4: [OpenCL][Docs] Describe extension for legacy atomics with generic addr space. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to comm

[PATCH] D101092: [OpenCL][Docs] Misc updates about C++ for OpenCL and offline compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ed6e87ab02d: [OpenCL][Docs] Misc updates to C++ for OpenCL and offline compilation (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1808 +With this extension it is possible to enable the use of some restricted types in kernel parameters. +The restrictions can be relaxed using regular OpenCL extension pragma mechanism +detailed in

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

Anastasia added a comment. In D99488#2725501 , @bader wrote: > In D99488#2725435 , @Anastasia wrote: > >> If I build docs now I get the following output: >> >> llvm-project/build-doc/tools/clang/docs/SYCLSupport.r

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia updated this revision to Diff 341833. Anastasia added a comment. - Added a pedantic warning about use of double even if the extension is in disabled state wrt pragma. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100980/new/ https://reviews.llvm.org/D100980 Files: clang/in

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia updated this revision to Diff 341835. Anastasia added a comment. Test all image types as identifiers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100983/new/ https://reviews.llvm.org/D100983 Files: clang/include/clang/Basic/OpenCLImageTypes.def clang/lib/Parse/ParseDecl.

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLImageTypes.def:68 IMAGE_WRITE_TYPE(image2d_array_msaa_depth, OCLImage2dArrayMSAADepth, "cl_khr_gl_msaa_sharing") -IMAGE_WRITE_TYPE(image3d, OCLImage3d, "cl_khr_3d_image_writes") +IMAGE_WRITE_TYPE(image

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia updated this revision to Diff 341842. Anastasia added a comment. Improved negative testing for `cl_khr_gl_msaa_sharing` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100983/new/ https://reviews.llvm.org/D100983 Files: clang/include/clang/Basic/OpenCLImageTypes.def clang/l

[PATCH] D101549: [Doc] Fix sphynx warnings about wrong code-block format

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101549/new/ https://reviews.llvm.org/D101549

[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101168/new/ https://reviews.llvm.org/D101168 ___ cfe-commits mailing lis

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors and types with address spaces

Anastasia added a subscriber: rjmccall. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2352 + if (SrcType == DestType || + (Self.LangOpts.OpenCL && + Self.Context.removeAddrSpaceQualType(SrcType) == I am thinking of whether w

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:489 B == LangAS::opencl_global_host)) || + (A == LangAS::sycl_global && (B == LangAS::sycl_global_device || +

[PATCH] D92244: [OpenCL] Prevent adding vendor extensions for all targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec82e519513: [OpenCL] Prevent adding vendor extensions for all targets (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit: https://review

[PATCH] D101052: [OpenCL] Allow pipe as a valid identifier prior to OpenCL 2.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64911eec75bb: [OpenCL] Allow pipe as a valid identifier prior to OpenCL 2.0. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

Anastasia created this revision. Anastasia added reviewers: svenvh, olestrohm. Herald added subscribers: ebevhan, kerbowa, yaxunl, nhaehnle, jvesely, jholewinski. Anastasia requested review of this revision. Bitfields result in struct/union layout that is implementation dependent and therefore i

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors and types with address spaces

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/reinterpret-cast.clcpp:1 +// RUN: %clang_cc1 %s -pedantic -verify -fsyntax-only + olestrohm wrote: > Anastasia wrote: > > Btw I assume your patch also allows reinterpret_cast between vectors? W

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires %2 support">; +def ext_opencl_double_without_pragma : Extension< + "Clang permits use of type 'double' regardless pragma if 'cl_k

[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

Anastasia closed this revision. Anastasia added a comment. Closed by https://reviews.llvm.org/rGe994e74bca49831eb649e7c67955e9de7a1784b6 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101168/new/ https://reviews.llvm.org/D101168 ___ cfe-commit

[PATCH] D100984: [OpenCL] Remove the need for subgroups extension pragma in enqueue kernel and pipe builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc28a602329a7: [OpenCL] Remove subgroups pragma in enqueue kernel and pipe builtins. (authored by Anastasia). Herald added a subscriber: ldrumm. Heral

[PATCH] D100983: [OpenCL] Fix optional image types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76f1de10f43e: [OpenCL] Fix optional image types. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of undeclared

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of undeclared

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported.cl:11 +#ifndef BITFIELDS_EXT +// expected-error@-2 {{bit-fields are not supported in OpenCL}} +#endif svenvh wrote: > The extension has "bitfields" in the name but most diagnostics (in

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors

Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/reinterpret-cast.clcpp:15 + int4 i4; + auto i4_to_i3 = reinterpret_cast(i4); // expected-error{{reinterpret_cast from vector 'int4' (vector of 4 'int' values) to vector 'int3' (vector of 3 'int' values) of

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:369 +def err_opencl_extension_and_feature_differs : Error< + "Options %0 and %1 are set to different values which is illegal in OpenCL C 3.0">; } We don't normally

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires %2 support">; +def ext_opencl_double_without_pragma : Extension< + "Clang permits use of type 'double' regardless pragma if 'cl_k

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13ea238b1e1d: [OpenCL] Allow use of double type without extension pragma. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

Anastasia updated this revision to Diff 396771. Anastasia added a comment. Added corrections from Justas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116271/new/ https://reviews.llvm.org/D116271 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/User

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30ad1742c083: [Docs] Document C++ for OpenCL 2021 support in clang. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a projec

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia added a comment. RFC to clang dev list: https://lists.llvm.org/pipermail/cfe-dev/2022-January/069658.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116266/new/ https://reviews.llvm.org/D116266 ___ cfe-commits mailing list cfe-c

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbb8d086377b: [SPIR-V] Add linking using spirv-link. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://revi

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia added a comment. Fix is committed to remove unused variable: https://github.com/llvm/llvm-project/commit/0eef65028e8a2f3417fb19e2eb5b0cbf50600c7e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116266/new/ https://reviews.llvm.org/D116266

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia added a comment. In D115523#3237410 , @yaxunl wrote: > It is possible that block kernels are defined and invoked in static > functions, therefore two block kernels in different TU's may have the same > name. Making such kernels external may ca

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I agree according to the OpenCL programming model attributes `internal spir_kernel` together on the same function create a contradiction because kernel functions are expected to ha

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3559 +by the OpenCL driver that support SPIR-V consumption or it can be compiled further +by offline SPIR-V consumer tools. + Btw do we want to say anything about the limitations of translat

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 394353. Anastasia added a comment. Addressed review comments from Sven: - Improved docs and code comments; - Simplified tests; - Added warning in a group. - Aligned with translator PRs after merge. Note, that this change now references documentation from P

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added a comment. > This feature requires support of opencl_c_generic_address_space and opencl_c_program_scope_global_variables so diagnostics for that is provided as well. Do we have a spec issue for it or a PR? It would be good to list it here since it is not yet published in the re

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6853 +if (R->isReserveIDT() || R->isClkEventT() || R->isEventT() || +R.getUnqualifiedType().getAsString() == "ndrange_t" || R->isQueueT()) { Se.Diag(NewVD->getLocation(),

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added a comment. In D112410#3197441 , @linjamaki wrote: > If I understand correctly, the default optimization level is `-O2` for the > OpenCL and OpenCL++ language mode (according to > CompilerInvocation.cpp:getOptimizationLevel()). Since high

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added inline comments. Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21 + // CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to different values Anastasia wrote: > I can't remember if we have discussed this already

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0045d01af96f: [SPIR-V] Add a toolchain for SPIR-V in clang (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added a comment. In D112410#3208353 , @MaskRay wrote: > I slightly adjusted the test in eafc64ed6325eba962096d4a947d7e45e909bfde > :) > > `-no-canonical-prefixes` can usually

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia created this revision. Anastasia added reviewers: svenvh, linjamaki, azabaznov. Herald added subscribers: ThomasRaoux, ebevhan. Anastasia requested review of this revision. Add support of linking files compiled into SPIR-V object files using spirv-link (https://github.com/KhronosGroup/S

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

Anastasia created this revision. Anastasia added reviewers: Topotuna, svenvh. Herald added subscribers: Naghasan, ebevhan, yaxunl. Anastasia requested review of this revision. This patch contains an update of C++ for OpenCL 2021 support status along with other misc updates: - OpenCL 3.0 - Bugzi

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

Anastasia added a comment. In D98411#2626613 , @ldrumm wrote: > Given this fixes a runtime crash bug, should it be backported to the relevant > release branch? Sure, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6268 + auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false); + auto *Call = CGF.Builder.CreateCall( + CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C}); -

[PATCH] D98705: [OpenCL] Prefer CodeGenFunction::EmitRuntimeCall

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98705/new/ https://reviews.llvm.org/D98705 __

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia updated this revision to Diff 331317. Anastasia added a comment. Back to .clcpp! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D96771 Files: clang/include/clang/Basic/LangStandard.h clang/include/clang/Driver/Types.def clang/lib/Drive

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. Thanks, I have changed it to '.clcpp' and also replied in RFC: https://lists.llvm.org/pipermail/cfe-dev/2021-March/067936.html Let's wait a few days for some more feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D96

[PATCH] D98520: [OpenCL] Remove spurious atomic_fetch tablegen builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98520/new/ https://reviews.llvm.org/D98520 __

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. In D97869#2628679 , @azabaznov wrote: > I have one more though. > > I like the idea of turning `opencl-c.h` into the test: as it is already in > the repo and is already being used for quite a while we can assume it as a > mainl

[PATCH] D98855: [OpenCL] Support template parameters for as_type

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaOpenCLCXX/template-astype.cl:5 +auto templated_astype(T x) { + return as_int2(x); + // expected-error@-1{{invalid reinterpretation: siz

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia closed this revision. Anastasia added a comment. Committed to the release branch in https://github.com/llvm/llvm-project/commit/00441b8f4e5b7daa39ac6cbeb45ebfe54662b08d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98076/new/ https://reviews.llvm.org/D98076 _

[PATCH] D98959: [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTH! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98959/new/ https://reviews.llvm.org/D98959 __

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1c8a151df83: [OpenCL] Added distinct file extension for C++ for OpenCL. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a p

[PATCH] D99258: [OpenCL] Fix AST check in address-space-templates test

Anastasia created this revision. Anastasia added a reviewer: bader. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. See comment: https://reviews.llvm.org/D95624#2621226 https://reviews.llvm.org/D99258 Files: clang/test/SemaOpenCLCXX/address-space-templa

[PATCH] D95624: [OpenCL][PR48896] Fix default address space in template argument deduction

Anastasia added inline comments. Herald added a subscriber: ldrumm. Comment at: clang/test/SemaOpenCLCXX/address-space-templates.cl:60 + // Preserve the address space of the type in forwarding reference. + // CHECK: CXXMethodDecl {{.*}} operator() 'void (__private int &__privat

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. I have done some measurements using the test produced from this Tablegen emitter (59K lines). I have used the test it in two files: 1. `SemaOpenCL/all-std-buitins.cl` that has the following RUN line appended 6 times (for every supported OpenCL version v1.0, v1.1, v1.

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. In D96771#2647848 , @gribozavr2 wrote: > Pushed the most minimal fix in > https://github.com/llvm/llvm-project/commit/41454c30f6a38c3e107d857e63da0561610fd141, > please double check. This looks great! Thanks for fixing this!

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. > Having multiple maps is not something new to the clang community. Similar > approach AMDGPU target applies to customize address space mapping for OpenCL > language > (https://github.com/llvm/llvm-project/blob/main/clang/lib/Basic/Targets/AMDGPU.cpp#L354). > > I up

[PATCH] D99258: [OpenCL] Fix AST check in address-space-templates test

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e46f0b62830: [OpenCL] Fix AST check in address-space-templates test (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit: https://reviews.l

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

Anastasia added inline comments. Comment at: clang/docs/SYCLSupport.md:857 +The main address space semantic difference of SYCL mode from OpenCL is that +SYCL doesn't assign OpenCL generic address space to a declaration's type without +explicit address space attribute. Similar to

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2652459 , @bader wrote: > In D89909#2624284 , @aaron.ballman > wrote: > >> Based on the discussion so far, would these be acceptable steps to take? >> >> 0) Complete review on t

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2653454 , @bader wrote: >> Yesterday, we chatted offline and agreed that the main issue is missing >> documentation for Clang extensions being added for SYCL. To address this >> issue we are adding SYCL architecture d

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I would like to hold off committing this for a day or two to see if there is any input from @azabaznov or anyone else. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added a comment. In D96853#2577172 , @benshi001 wrote: > In D96853#2577133 , @aykevl wrote: > >> I am not very familiar with Clang so I can't say much about it. Although I >> wonder whether a macro is the

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia added a comment. Thanks. I am guessing you will address relevant review comments from D99190 in here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 ___

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia added a comment. In D99488#2655342 , @bader wrote: > In D99488#2655326 , @Anastasia wrote: > >> Thanks. I am guessing you will address relevant review comments from D99190 >>

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia added a comment. Do you plan to implement any of the following restriction? > To allocate local memory within a kernel, the user can either pass a > sycl::local_accessor object as a argument to an ND-range kernel (that has a > user-defined work-group size), or can define a variable in

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added a comment. Btw is any pointer conversion between address space 1 and the default address space allowed? I.e. is the following code valid: __flash static const int var1[] = {111, 222, 333}; void foo(int*); foo(var1); or __flash static const int var1[] = {111, 222,

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added a comment. In D96853#2660443 , @benshi001 wrote: > In D96853#2659266 , @Anastasia wrote: > >> Btw is any pointer conversion between address space 1 and the default >> address space allowed? I.e. is

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:159 +def err_verify_nonconst_addrspace : Error< + "qualifier 'const' is needed for variables in address space '%0'">; Ok, do you plan to pass anything other than

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

Anastasia added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:15 +struct s10 a0; +a0.a = c; +a0.b = b; Minor thing - I guess for the purpose of this testing you could skip initialization on struct variables? CHANGES SINCE

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added a comment. Is `stdio.h` used by anything? Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const { --

[PATCH] D99577: [RFC][OpenCL][PoC] Testing TableGen with diffing

Anastasia added a comment. This approach is really great because the testing is so quick! While it is not providing the coverage for invocation through clang, it can still be very valuable in various forms to enhance the testing and improve the coverage at very little cost. Thanks for working o

<    11   12   13   14   15   16   17   18   >