[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.0 and CL1.1

Anastasia updated this revision to Diff 85878. Anastasia edited reviewers, added: arsenm; removed: pekka.jaaskelainen. Anastasia removed a subscriber: arsenm. Anastasia added a comment. Herald added a subscriber: wdng. Added other CL versions to testing (from comment by Matt)! https://reviews.ll

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.0 and CL1.1

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: test/SemaOpenCL/logical-ops.cl:1-3 +// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu +// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu

[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

Anastasia updated this revision to Diff 85888. Anastasia added a comment. Updated NULL ptr generation and added separate CodeGen test for checking amended Block generation behaviour in OpenCL! https://reviews.llvm.org/D28814 Files: lib/AST/Expr.cpp lib/CodeGen/CGBlocks.cpp lib/CodeGen/CG

[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:3 // RUN: %clang_cc1 %s -cl-std=CL2.0 -ffake-address-space-map -O0 -emit-llvm -o - -triple "spir64-unknown-unknown" | FileCheck %s --check-pre

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.1

Anastasia updated this revision to Diff 85890. Anastasia marked an inline comment as done. Anastasia retitled this revision from "[OpenCL] Accept logical NOT for pointer types in CL1.0 and CL1.1" to "[OpenCL] Accept logical NOT for pointer types in CL1.1". https://reviews.llvm.org/D29038 Files:

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.1

Anastasia added inline comments. Comment at: test/SemaOpenCL/logical-ops.cl:1-3 +// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu +// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu + Anastasia wrote: > arsenm

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.1

Anastasia added a comment. @arsenm, do you think you could complete the review? https://reviews.llvm.org/D29038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

Anastasia closed this revision. Anastasia marked an inline comment as done. Anastasia added a comment. Committed in r 293286 https://reviews.llvm.org/D28814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.1

Anastasia added inline comments. Comment at: test/SemaOpenCL/logical-ops.cl:1-3 +// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu +// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu + arsenm wrote: > Anastasia

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.1

Anastasia closed this revision. Anastasia added a comment. Committed in r294313 https://reviews.llvm.org/D29038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29764: [OpenCL] Blocks cannot capture/reference another block

Anastasia created this revision. Herald added a subscriber: yaxunl. Adding the last restriction from s6.12.5 OpenCL C v2.0. "A Block cannot reference or capture another Block variable declared in the outer scope". https://reviews.llvm.org/D29764 Files: include/clang/Basic/DiagnosticSemaKind

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. @Pekka, do you think there is something more to be done here or can I close this revision now? Apparently, I won't be able to pass` -target` in all cases because `-cc` has to be always the first parameter. Also I am preparing additional text and some minor correction

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

Anastasia added a comment. Sure, no problem! We might add some note on this feature to Clang manual. But we can do it later as well. Thanks! https://reviews.llvm.org/D33681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

Anastasia added a comment. In https://reviews.llvm.org/D34342#792350, @bader wrote: > Note: `get_sampler_initializer` from my test case returns integer, not a > sampler, but having function is not relevant to the problem. > Here is a bit simplified test case without function calls that still

[PATCH] D34980: [OpenCL] Test on image access modifiers and image type can only be a type of a function argument.

Anastasia added inline comments. Comment at: test/SemaOpenCL/images.cl:14 +void myReadWrite (read_write image2d_t); +void myIndifferent (image2d_t); // expected-note 2{{passing argument to parameter here}} + Would it be better to rename to make the purpose more

[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

Anastasia added a comment. Btw, is there any reason to add testing specifically for half? Is there anything specific to half in the implementation of this? Comment at: test/CodeGenOpenCL/kernel-arg-info.cl:79 +kernel void foo6_2(global const volatile half * restrict globalcon

[PATCH] D34980: [OpenCL] Test on image access modifiers and image type can only be a type of a function argument.

Anastasia added a comment. LGTM! Thanks! https://reviews.llvm.org/D34980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

Anastasia added a comment. In https://reviews.llvm.org/D35000#799705, @Anastasia wrote: > Btw, is there any reason to add testing specifically for half? Is there > anything specific to half in the implementation of this? Trying to understand the reason for this change though... https://revie

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added inline comments. Comment at: lib/AST/Expr.cpp:3235 +// has non-default address space it is not treated as nullptr. +bool PointeeHasDefaultAS = false; +if (Ctx.getLangOpts().OpenCL) Would we still be accepting the following:

[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

Anastasia added a comment. In https://reviews.llvm.org/D35000#807674, @echuraev wrote: > In https://reviews.llvm.org/D35000#801132, @Anastasia wrote: > > > In https://reviews.llvm.org/D35000#799705, @Anastasia wrote: > > > > > Btw, is there any reason to add testing specifically for half? Is ther

[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D35000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11846 // an address space. if (T.getAddressSpace() != 0) { // OpenCL allows function arguments declared to be an array of a type yaxunl wrote: > Anastasia wrote: > > Could we use `LangA

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11846 // an address space. if (T.getAddressSpace() != 0) { // OpenCL allows function arguments declared to be an array of a type yaxunl wrote: > Anastasia wrote: > > yaxunl wrote: > > >

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! https://reviews.llvm.org/D33945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42307: [OpenCL][6.0.0 Release] Release notes for OpenCL in Clang

Anastasia created this revision. Anastasia added reviewers: yaxunl, bader, hans. https://reviews.llvm.org/D42307 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/ReleaseNotes.rst @@

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

Anastasia added a comment. I am just a bit unclear about the use of this extension in the kernel language. Could you please clarify? Repository: rC Clang https://reviews.llvm.org/D42532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D42532: [OpenCL] Add "cles_khr_int64" extension.

Anastasia accepted this revision. Anastasia added a comment. Oh I guess it can be used to exclude the code with long? LGTM! Repository: rC Clang https://reviews.llvm.org/D42532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D42307: [OpenCL][6.0.0 Release] Release notes for OpenCL in Clang

Anastasia closed this revision. Anastasia added a comment. Committed in r323875 with changes as requested. https://reviews.llvm.org/D42307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41699: [OpenCL] Change sampler representation

Anastasia added a comment. In https://reviews.llvm.org/D41699#990894, @yaxunl wrote: > whereas the old definition may fail to detect (not always, only for certain > combinations). For this reason I think it would be good to fix this. I don't think it's good to report errors inconsistently >

[PATCH] D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

Anastasia created this revision. Adding a description of a new feature that allows to specify vendor extension in flexible way using compiler pragma instead of modifying source code directly. Feature committed in Clang@r289979. https://reviews.llvm.org/D29829 Files: docs/UsersManual.rst I

[PATCH] D29830: [OpenCL][Doc] Relase 4.0 notes for OpenCL

Anastasia created this revision. https://reviews.llvm.org/D29830 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/ReleaseNotes.rst @@ -17,7 +17,7 @@ Introduction -T

[PATCH] D29764: [OpenCL] Blocks cannot capture/reference another block

Anastasia added a comment. In https://reviews.llvm.org/D29764#673679, @yaxunl wrote: > In https://reviews.llvm.org/D29764#673548, @Nicola wrote: > > > Looking at "Example 4" in the standard it looks like this should also be > > illegal. > > > > int (^block1)(void) = ^int {return 1;}; > > int

[PATCH] D29830: [OpenCL][Doc] Relase 4.0 notes for OpenCL

Anastasia closed this revision. Anastasia added a comment. Committed to release40@295315 https://reviews.llvm.org/D29830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28058: [OpenCL] Correct ndrange_t implementation

Anastasia closed this revision. Anastasia added a comment. Committed in 295311 https://reviews.llvm.org/D28058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29829: [OpenCL][Doc] Description for adding OpenCL vendor extension in user manual

Anastasia closed this revision. Anastasia added a comment. Committed in 295313! https://reviews.llvm.org/D29829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29764: [OpenCL] Blocks cannot capture/reference another block

Anastasia closed this revision. Anastasia added a comment. Committed in r295307! https://reviews.llvm.org/D29764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error< ---

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error< ---

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. Could you please add your test here (probably goes to test/CodeGenOpenCL)? Comment at: include/clang/Driver/CC1Options.td:661 +def fpreserve_vec3_type : Flag<["-"], "fpreserve-vec3-type">, + HelpText<"Preserve 3-component vector type operations">; +

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

Anastasia added a comment. In https://reviews.llvm.org/D28136#697673, @echuraev wrote: > In https://reviews.llvm.org/D28136#634356, @Anastasia wrote: > > > This has been discussed during the initial review for the header: > > > > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160425/

[PATCH] D30830: [OpenCL] Fix extension guards for atomic functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! This bit was poorly tested initially as there were simply too many things. I am wondering if we could improve these bits slowly by extending further lib/Headers/opencl-c.h. https

[PATCH] D30816: [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL

Anastasia added inline comments. Comment at: test/SemaOpenCL/overload-scalar-widening.cl:4 + +typedef short short4 __attribute__((ext_vector_type(4))); + I am thinking could this be a CodeGen test instead and we could check that the right overload is selected ba

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation accordingly to make things consistent? https://reviews.llvm.org/D30810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D30743: enable -save-temps with -finclude-defult-header

Anastasia added inline comments. Comment at: lib/Driver/Tools.cpp:5288 // parser. - Args.AddAllArgValues(CmdArgs, options::OPT_Xclang); + if (C.getDriver().isSaveTempsEnabled() && + !isa(JA)) { It would be nice to add a comment around here explaining th

[PATCH] D30643: [OpenCL] Extended diagnostics for atomic initialization

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263 +def err_atomic_init_addressspace : Error< + "initialization of atomic variables is restricted to variables in global address space">; def err_atomic_init_constant : Error< ---

[PATCH] D28136: [OpenCL] Implement as_type operator as alias of __builtin_astype.

Anastasia added a comment. In https://reviews.llvm.org/D28136#697844, @bader wrote: > > Why do you think this is a bug? It seems to follow standard behavior in C > > to promote char to int if required. Just like if you would have a C code: > > > > int as_int(int i); > > void foo() { > >

[PATCH] D30816: [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL

Anastasia added inline comments. Comment at: test/SemaOpenCL/overload_addrspace_resolution.cl:1 -// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple x86_64-unknown-unknown %s | FileCheck %s +// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple spir-unknown-unknown %s |

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. In https://reviews.llvm.org/D30810#699827, @jaykang10 wrote: > In https://reviews.llvm.org/D30810#699695, @bruno wrote: > > > Hi JinGu, > > > > I just read the discussion on cfe-dev, some comments: > > > > > My colleague and I are implementing a transformation pass betw

[PATCH] D30743: enable -save-temps with -finclude-defult-header

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: lib/Driver/Tools.cpp:5290 + !isa(JA)) { +//Args.AddAllArgValues(CmdArgs, options::OPT_Xclang); +for (auto Arg : Args.filtered(opt

[PATCH] D27334: [OpenCL] Ambiguous function call.

Anastasia added a comment. I don't actually. But remembering the follow up discussion: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161205/178846.html and since we have to deviate from the standard C/C++ implementation anyways I am wondering whether modifying overloading resolution i

[PATCH] D30937: [OpenCL] Added diagnostic for checking length of vector

Anastasia added inline comments. Comment at: lib/Sema/SemaExprMember.cpp:287 +// OpenCL spec (Section 6.1.7 Vector Components): +// The component group notation can occur on the left hand side of an expression. To form an lvalue, The format is normally: OpenCL

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5924 - DeclContext *OriginalDC = DC; - bool IsLocalExternDecl = SC == SC_Extern && - adjustContextForLocalExternDecl(DC); +// OpenCL 1.2 spec, p6.9 r: +// The event type canno

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please, address the small nitpick before committing. Comment at: lib/Sema/SemaDecl.cpp:5965 + +// OpenCL 1.2 spec, p6.9 r: +// The event type cann

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

Anastasia updated this revision to Diff 79403. Anastasia added a comment. Merged if statements into one! https://reviews.llvm.org/D27109 Files: lib/CodeGen/CGDecl.cpp test/CodeGenOpenCL/constant-addr-space-globals.cl Index: test/CodeGenOpenCL/constant-addr-space-globals.cl ===

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

Anastasia closed this revision. Anastasia added a comment. Committed in r288163. https://reviews.llvm.org/D27109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/spir_version.cl:22 + // CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]} // CHECK-SPIR-CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]} Could we then use VER here too?

[PATCH] D27334: [OpenCL] Ambiguous function call.

Anastasia added a comment. This change seems to modify normal C behavior again. Is there any strong motivation for doing this and if yes could it be done generically with C? Comment at: lib/Sema/SemaChecking.cpp:2479 +// integer values. +if (FDecl->hasAttr()) {

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D27300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/address-spaces-mangling.cl:36 + +__attribute__((overloadable)) void foo(private char *); +__attribute__((overloadable)) void foo(global char *); Just trying to understand what we are missing in the c

[PATCH] D27334: [OpenCL] Ambiguous function call.

Anastasia added a comment. In https://reviews.llvm.org/D27334#612858, @bader wrote: > In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > > > This change seems to modify normal C behavior again. Is there any strong > > motivation for doing this and if yes could it be done generically

[PATCH] D27453: [OpenCL] Enable unroll hint for OpenCL 1.x.

Anastasia added inline comments. Comment at: lib/Sema/SemaStmtAttr.cpp:232 - if (S.getLangOpts().OpenCLVersion < 200) { -S.Diag(A.getLoc(), diag::err_attribute_requires_opencl_version) The comment above refers to v2.0, could we update it reflecting the fac

[PATCH] D27334: [OpenCL] Ambiguous function call.

Anastasia added a comment. In https://reviews.llvm.org/D27334#614389, @bader wrote: > In https://reviews.llvm.org/D27334#613504, @Anastasia wrote: > > > In https://reviews.llvm.org/D27334#612858, @bader wrote: > > > > > In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > > > > > > > Th

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D27403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D27453: [OpenCL] Enable unroll hint for OpenCL 1.x.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D27453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8127 "invalid prototype, variadic arguments are not allowed in OpenCL">; +def err_requires_extension : Error< + "use of %select{declaration|type }0%1 requires %2 extension to be enabled">;

[PATCH] D27671: [OpenCL] Improve address space diagnostics.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D27671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D27569: [OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand.

Anastasia added inline comments. Comment at: lib/Sema/SemaExpr.cpp:9624 + if (getLangOpts().OpenCL && getLangOpts().OpenCLVersion >= 200) { +if (LHSIsNull && RHSType->isQueueT()) { getLangOpts().OpenCL is redundant because getLangOpts().OpenCLVersion is on

[PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added inline comments. Comment at: include/clang/Sema/Sema.h:8081 + /// \brief Set current OpenCL extensions for a type which can only be used + /// when these OpenCL extensions are enabled. If current OpenCL Extsion is + /// empty, do nothing. Extsi

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

Anastasia added inline comments. Comment at: test/SemaOpenCL/clang-builtin-version.cl:32 + work_group_reserve_write_pipe(tmp, tmp); // expected-error{{implicit declaration of function 'work_group_reserve_write_pipe' is invalid in OpenCL}} + // expected-note@-1{{did you mean 'w

[PATCH] D30805: [OpenCL] Add intel_reqd_sub_group_size attribute support

Anastasia added a comment. Sure! LGTM! https://reviews.llvm.org/D30805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32248: CodeGen: Cast alloca to expected address space

Anastasia added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1105-1119 + // Alloca always returns a pointer in alloca address space, which may + // be different from the type defined by the language. For example, + // in C++ the auto variables are in the default address

[PATCH] D32248: CodeGen: Cast alloca to expected address space

Anastasia added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1115 + if (AddrTy->getAddressSpace() != ExpectedAddrSpace && + Ty.getAddressSpace() != LangAS::opencl_constant) { +address = Address(Builder.CreateAddrSpaceCast(Addr, Do you need to che

[PATCH] D32248: CodeGen: Cast alloca to expected address space

Anastasia added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1105-1119 + // Alloca always returns a pointer in alloca address space, which may + // be different from the type defined by the language. For example, + // in C++ the auto variables are in the default address

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

[PATCH] D32897: [OpenCL] Added checking OpenCL version for cl_khr_mipmap_image built-ins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! It's a pity we are not testing anything here. https://reviews.llvm.org/D32897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32898: [OpenCL] Handle OpenCL specific subelement types

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: test/SemaOpenCL/array-init.cl:4 + +__kernel void k2(queue_t q1, queue_t q2) { + queue_t q[] = {q1, q2}; Minor thing - I would use sequ

[PATCH] D32977: [OpenCL] Emit function-scope variable in constant address space as static variable

Anastasia accepted this revision. Anastasia added a comment. LGTM! Comment at: lib/Sema/SemaDecl.cpp:10286 + // these variables must be a compile time constant. + VDecl->getType().getAddressSpace() == LangAS::opencl_constant) CheckForConstantInitializ

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

[PATCH] D27334: [OpenCL] Ambiguous function call.

Anastasia added a comment. In https://reviews.llvm.org/D27334#751921, @echuraev wrote: > So, I think that we have to do some decision about this patch. @Anastasia, > What do you think about it? Please see my comment above. What should we do > with this patch? I am still not convinced adding t

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12449 // function declaration is going to be treated as an error. - if (Diags.getDiagnosticLevel(diag_id, Loc) >= DiagnosticsEngine::Error) { + if (!getLangOpts().OpenCL && + Diags.getDiagnosticLevel(dia

[PATCH] D32977: [OpenCL] Emit function-scope variable in constant address space as static variable

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10286 + // these variables must be a compile time constant. + VDecl->getType().getAddressSpace() == LangAS::opencl_constant) CheckForConstantInitializer(Init, DclT); yax

[PATCH] D32248: CodeGen: Cast alloca to expected address space

Anastasia added inline comments. Comment at: lib/CodeGen/CodeGenTypes.cpp:95 - /// isRecordLayoutComplete - Return true if the specified type is already Why this change? Comment at: lib/CodeGen/TargetInfo.cpp:411 +CodeGen::CodeGenFunctio

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia added a comment. Herald added a subscriber: Naghasan. In D107769#3064171 , @svenvh wrote: > In D107769#2967565 , @Anastasia > wrote: > >> In D107769#2960441 , @

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added inline comments. Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21 + // CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to different values azabaznov wrote: > Anastasia wrote: > > Anastasia wrote: > > > I can'

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia added a comment. In D107769#3265867 , @svenvh wrote: > In D107769#3265665 , @Anastasia > wrote: > >> The way I understand the spec for OpenCL C 2.0 is that whenever the address >> space of the pointer

[PATCH] D117899: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117899/new/ https://reviews.llvm.org/D117899 _

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia added a comment. Looping in @yaxunl for further feedback regarding OpenCL 2.0 behavior specifically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107769/new/ https://reviews.llvm.org/D107769 ___ cfe-commits mailing list cfe-commit

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia added a comment. In D115523#3240870 , @yaxunl wrote: > In D115523#3237857 , @Anastasia > wrote: > >> In D115523#3237410 , @yaxunl wrote: >> >>> It is possible t

[PATCH] D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM, aside from the name that can be fixed on a final commit! Comment at: clang/lib/Headers/opencl-c-base.h:78 +// space overloads for builtin functions that take a po

[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115640/new/ https://reviews.llvm.org/D115640 _

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM. Thanks for changing this. I have no issues with this patch as it doesn't change the behavior for OpenCL 2.0 but I did create an issue for OpenCL-Docs to fix this problem somehow:

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:88 // '__builtin_' prefix. It will be implemented in compiler-rt or libgcc. +// G -> this function uses generic address space (OpenCL). +// P -> this function uses pipes (OpenCL). ---

[PATCH] D120221: [AST] Fix typos

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM! In D120221#3334412 , @kuzkry wrote: > Can I ask you to deliver this one for me? I don't have permissions. My

[PATCH] D120221: [AST] Fix typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481f6818670a: [AST] Fix typo in assert messages (authored by kuzkry, committed by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7-8 -#ifdef EXT -#pragma OPENCL EXTENSION cl_khr_int64_base_atomics:enable -#pragma OPENCL EXTENSION cl_khr_int64_extended_atomics:enable -#pragma OPENCL EXTENSION cl_khr_fp64:enable -#if __OP

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2708012 , @azabaznov wrote: > Same as for https://reviews.llvm.org/D100984, `cl_khr_fp64` wasn't always > core and thus it requires pragma for OpenCL C < 1.2 versions. > > //9.3 Double Precision Floating-Point, OpenC

[PATCH] D100984: [OpenCL] Remove the need for subgroupd extension pragma in enqueue kernel builtins

Anastasia added a comment. In D100984#2708168 , @azabaznov wrote: >> Btw I am not suggesting removing the pragma. We will still have to parse it >> for backward compatibility. I am only dropping the requirement of using it >> in order to call get_kernel

<    10   11   12   13   14   15   16   17   18   >