[PATCH] D96789: [OpenCL] Move printf declaration to opencl-c-base.h

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96789/new/ https://reviews.llvm.org/D96789 __

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added inline comments. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) svenvh wrote: > mantognini wrote: > > I'm not sure we want that -- I'm actually fine if

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

Anastasia updated this revision to Diff 324591. Anastasia added a comment. Added corrections from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96616/new/ https://reviews.llvm.org/D96616 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/UsersMa

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3016 .. code-block:: console svenvh wrote: > I wonder if we need to keep this example? You're not referring to it from > the text and it's not demonstrating any special flags anymor

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. In D96771#2571582 , @awarzynski wrote: > Hi @Anastasia , thank you for working on this! > > IIUC, this patch introduces: > > - new input types: `TY_CLCXX` and `TY_CLCXXHeader` > - new language: `OpenCLCXX` > > Based on the attach

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3016 .. code-block:: console svenvh wrote: > Anastasia wrote: > > svenvh wrote: > > > I wonder if we need to keep this example? You're not referring to it > > > from the text and it

[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4267 + if (Triple.isSPIR()) +CmdArgs.push_back("-Wspir-compat"); It seems like this should have been in `addClangWarningOptions` but there is no toolchain for SPIR? Could

[PATCH] D96948: [OpenCL] Move remaining defines to opencl-c-base.h

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Btw since we are moving this code anyway, do you think we could fix the formatting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96

[PATCH] D97041: [clang][cli] Pass '-Wspir-compat' to cc1 from driver

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97041/new/ https://reviews.llvm.org/D97041 ___

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:932 +let MinVersion = CL20 in { + def : Builtin<"get_fence", [MemFenceFlags, PointerType]>; + def : Builtin<"get_fence", [MemFenceFlags, PointerType, GenericAS>]>; Btw, I am guessing

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia created this revision. Anastasia added reviewers: azabaznov, svenvh, mantognini. Herald added subscribers: ebevhan, jfb, yaxunl. Anastasia requested review of this revision. Currently, extension pragma is always added when new OpenCL option (extension or feature) is added to the fronten

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) azabaznov wrote: > I think core and optio

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov, yaxunl. Herald added a subscriber: ebevhan. Anastasia requested review of this revision. Add documentation that explains how to extend clang with new extensions/features. The guidelines also detail clang's position ab

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf3ef15a6ec5: [OpenCL] Add builtin declarations by default. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2578629 , @thakis wrote: > Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for pointing this out. I think the follow

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a subscriber: klimek. Anastasia added a comment. In D96515#2578666 , @Anastasia wrote: > In D96515#2578629 , @thakis wrote: > >> Looks like this breaks tests: http://45.33.8.238/linux/39988/step_8.tx

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2578765 , @thakis wrote: > In D96515#2578666 , @Anastasia wrote: > >> In D96515#2578629 , @thakis wrote: >> >>> Looks like this breaks te

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. FYI, I would even be ok if we remove the need for enabling non-core features too but it is also fine to start from just core features. Thanks! Comment at: clang/lib/Sema/Sema.cpp:360 setOpenCLExtensionForType(Context.DoubleTy, "cl_khr_fp64");

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) azabaznov wrote: > Anastasia wrote: > > a

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:932 +let MinVersion = CL20 in { + def : Builtin<"get_fence", [MemFenceFlags, PointerType]>; + def : Builtin<"get_fence", [MemFenceFlags, PointerType, GenericAS>]>; svenvh wrote: > An

[PATCH] D97203: [OpenCL][PR49264] Allow taking address of functions by enabling the extension

Anastasia created this revision. Anastasia added a reviewer: mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. When `__cl_clang_function_pointers` extension is enabled clang should allow obtaining the function address. FYI, taking function addres

[PATCH] D97203: [OpenCL][PR49264] Allow taking address of functions by enabling the extension

Anastasia updated this revision to Diff 325729. Anastasia added a comment. Uploaded full diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97203/new/ https://reviews.llvm.org/D97203 Files: clang/lib/Parse/ParseExpr.cpp clang/test/SemaOpenCL/func.cl Index: clang/test/SemaOpenCL/f

[PATCH] D96616: [OpenCL][Docs] Change decription for the OpenCL standard headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG90355d6f1076: [OpenCL][Docs] Change description for the OpenCL standard headers. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D96616?vs=32459

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia updated this revision to Diff 325734. Anastasia added a comment. Fixed typo and extra space. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/include/clang/Basic/OpenCLOpti

[PATCH] D97060: [OpenCL] Add ndrange builtin functions to TableGen

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97060/new/ https://reviews.llvm.org/D97060 __

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Sema/OpenCLBuiltins.td:933 + // The OpenCL 3.0 specification defines these with a "gentype" argument indicating any builtin + //

[PATCH] D97203: [OpenCL][PR49264] Allow taking address of functions by enabling the extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGabbdb5639c70: [OpenCL] Allow taking address of functions as an extension. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia updated this revision to Diff 326055. Anastasia added a comment. Added suggestions from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97072/new/ https://reviews.llvm.org/D97072 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst =

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:196 +If an extension adds the functionality that does not modify standard language +parsing it should not require clang source code modifications. Most commonly +such extensions add functionality via librar

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Considering that this patch doesn't add anything new to the design, I suggest we go ahead. But we should continue the discussion around -cl-ext etc elsewhere and then perh

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 ___ cfe-commits mailing list

[PATCH] D102689: [C++] Ignore top-level qualifiers in casts

Anastasia added inline comments. Comment at: clang/test/SemaCXX/warn-reinterpret-base-class.cpp:301 - // expected-warning@+2 {{'reinterpret_cast' to class 'L' (aka 'const F *volatile') from its base at non-zero offset 'E *' behaves differently from 'static_cast'}} + // expe

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { Anastasia wrote: > olestrohm wrote: > > Anastasia wrote: > > > olestrohm wrote: >

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

Anastasia added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:405 + const auto &OpenCLFeaturesMap = getSupportedOpenCLOpts(); + Opts.OpenCLGenericAddressSpace = hasFeatureEnabled( + OpenCLFeaturesMap, "__opencl_c_generic_address_space"); -

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s svenvh wrote: > Should we add

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s azabaznov wrote: > Anastasia

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please, amend the comment as suggested in the final commit Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + // Method overloading is handled above, s

[PATCH] D102689: [C++] Ignore top-level qualifiers in casts

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I think the diagnostic wording can be improved separately if it's considered important as it seems this issue already existed. I suggest adding `[Sema]` tag in your final

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

Anastasia accepted this revision. Anastasia added a comment. Do you think we could add any test for this yet? Or do we have to wait until we have other pieces in place for diffing to `opencl-c.h`? We could add a test for parsing the header but it is probably going to be very slow test? Reposit

[PATCH] D103962: [C++4OpenCL] Fix qualifiers check on binding references to temporaries

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Yes it seems the only situation where the check would evaluate to a different value with and without your patch is when we have `RefRelationship == Sema::Ref_Related` as false whil

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/include/clang/Basic/OpenCLOptions.h:80 +return Opts.OpenCLCPlusPlus || Opts.OpenCLVersion == 200 || + (Opts.OpenCLVersion

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 ___ cfe-commits mailing list cfe-comm

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

Anastasia added a comment. LGTM! Thanks I agree we should have the same behavior for both options. Technically `-finclude-default-header` could be added in both steps but it is only effective in parsing the sources and does nothing otherwise. But it seems cleaner to align it with the header in

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG577220e89866: [OpenCL] Add std flag aliases clc++1.0 and CLC++1.0 (authored by Anastasia). Changed prior to commit: https://reviews.llvm.org/D1062

[PATCH] D107154: [OpenCL] Add support of __opencl_c_pipes feature macro.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks We might need to fix the target triple in `clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl` to avoid surprises with testing but it has better coverage if we don't though...

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

Anastasia added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6150 options::OPT_fno_threadsafe_statics, -!IsWindowsMSVC || IsMSVC2015Compatible)) +!types::isOpenCL(InputType) && +

[PATCH] D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107176/new/ https://reviews.llvm.org/D107176

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107163/new/ https://reviews.llvm.org/D107163

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

Anastasia added a comment. Just to make sure you are aware Clang doesn't use this header by default, so the upstream users won't be able to call those functions unless you add them into `OpenCLBuiltins.td`: https://clang.llvm.org/docs/OpenCLSupport.html#opencl-builtins This header is only acces

[PATCH] D107151: [OpenCL] Reduce duplicate defs by using multiclasses; NFC

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Looks very neat! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107151/new/ https://reviews.llvm.org/D107151 ___

[PATCH] D107318: [OpenCL] allow generic address and non-generic defs for CL3.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107318/new/ https://reviews.llvm.org/D107318 _

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1964 +Address space removal +- Topotuna wrote: > Anastasia wrote: > > Anastasia wrote: > > > Maybe we could title it something like: > > > > > > `Address space r

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:24 #define cl_khr_subgroup_clustered_reduce 1 +#define cl_ext_float_atomics +#ifdef cl_khr_fp16 svenvh wrote: > Should this be defined as `1`? > > Should this define be tested in `cl

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 ___ cfe-commits mailing list

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

Anastasia added a subscriber: svenvh. Anastasia added a comment. LGTM! Thanks. CC to @azabaznov for any final feedback. FYI this has not been officially announced but in `clang-14` we would like to transition away from using the huge hard to maintain `opencl-c.h` in favour of a more concise an

[PATCH] D107553: [C++4OpenCL] Initialize temporaries in the private address space

Anastasia added inline comments. Comment at: clang/include/clang/Sema/Initialization.h:341 +QualType Type = TypeInfo->getType(); +if (Context.getLangOpts().OpenCL && !Type.hasAddressSpace()) + Type = Context.getAddrSpaceQualType(Type, LangAS::opencl_private); ---

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:248 def warn_option_invalid_ocl_version : Warning< - "OpenCL version %0 does not support the option '%1'">, InGroup; + "%select{OpenCL C|C++ for OpenCL}0 version %1 does not suppo

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105858/new/ https://reviews.llvm.org/D105858 _

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Btw I think we could also use this helper in another diagnostic (`err_opencl_unknown_type_specifier`) in `include/clang/Basic/DiagnosticCommonKinds.td`. But it can be upda

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Anastasia added a comment. Great! Thanks! The suggested minor test clean-up can be addressed in the final commit! Comment at: clang/test/SemaOpenCL/nosvm.cl:10 +// expected-warning@-2 {{'nosvm' attribute is deprecated and ignored in OpenCL C version 2.0}} +#elif defined(CLCPP

[PATCH] D108034: [SPIR-V] Add SPIR-V builtin functions and types

Anastasia added a comment. Can you elaborate the overall design flow please? Particularly, it is not clear why we need to duplicate OpenCL types and builtins at source level for SPIR-V... Is there any way to avoid this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Let's add a reference to RFC in the description: https://lists.llvm.org/pipermail/cfe-dev/2021-August/068593.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021

Anastasia added a subscriber: svenvh. Anastasia added a comment. @svenvh I would like to discuss it further with Sven whether it is a good direction or not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108113/new/ https://reviews.llvm.org/D108113

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4789 - -if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - Src = createCastsForTypeOfSameSize(Builder, CGF.

[PATCH] D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. In D108113#2949173 , @svenvh wrote: > In D108113#2949141 , @Anastasia > wrote: > >> @svenvh

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 _

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I imagine you will be adding some tests that will check the correctness of diagnostic wording in the subsequent commits? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10106 def err_opencl_invalid_read_write : Error< - "access qualifier %0 can not be used for %1 %select{|prior to OpenCL version 2.0}2">; + "access qualifier %0 can not be used for %1

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia updated this revision to Diff 355166. Anastasia retitled this revision from "[OpenCL][ARM] Fix ICE when compiling a source with the kernel" to "[OpenCL][ARM] Fix ICE when compiling a kernel". Anastasia edited the summary of this revision. Anastasia added reviewers: pekka, svenvh. Anastas

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. @airlied I think this patch is outdated as some features have been committed in the meantime. Are you still interested in working on this change? It might help splitting into smaller independent chunks. It is usually faster to review and test. Repository: rG LLVM

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2849268 , @pekka.jaaskelainen wrote: > Does this break clSetKernelArg() for ARM CPUs in PoCL? I believe so far it > has worked for ARM - just wondering why you decide to drop it now? > > https://github.com/pocl/pocl

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. In D92004#2857511 , @airlied wrote: > I'll have to rebase/rebuild my build env, I'll try and have something > rebasing this cleaner soon. Cool, thanks! If you could split/partition into multiple patches in some way it would be

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2857958 , @pekka.jaaskelainen wrote: >> The reason why we would like to fix it is that upstream clang has a crash >> currently when OpenCL sources are compiled for any Arm CPU: >> https://bugs.llvm.org/show_bug.cgi

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia added a comment. In D104858#2859742 , @pekka.jaaskelainen wrote: >> Ok, thanks for clarification. Does it mean there is something we need to add >> to LLVM somewhere to make it work correctly? Would it be specific to Arm or >> generally for a

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:7341 half8 __ovld fract(half8 x, __private half8 *iptr); half16 __ovld fract(half16 x, __private half16 *iptr); This one is not generic address space pointer though but I think this bit i

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia added a comment. In D105526#2863386 , @airlied wrote: > I've dropped the __SPIR__ change in the base header until things are resolved > for library SPIR users to disable extension defines. Makes sense! But this is not a full diff again. Would

[PATCH] D105601: opencl-c.h: reorder atomic operations

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105601/new/ https://reviews.llvm.org/D105601 _

[PATCH] D105601: opencl-c.h: reorder atomic operations

Anastasia added subscribers: azabaznov, svenvh. Anastasia added a comment. CC to @svenvh and @azabaznov. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105601/new/ https://reviews.llvm.org/D105601 ___ cfe

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104915/new/ https://reviews.llvm.org/D104915 _

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103401/new/ https://reviews.llvm.org/D103401 _

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! PS this patch is straightforward and doesn't seem to affect functionality for older standards provided that we set `__opencl_c_generic_address_space` correctly which is no

[PATCH] D105892: [OpenCL] Add verbosity when checking support of read_write images

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105892/new/ https://reviews.llvm.org/D105892

[PATCH] D105892: [OpenCL] Add verbosity when checking support of read_write images

Anastasia added a comment. In D105892#2873951 , @aaron.ballman wrote: > Note: https://reviews.llvm.org/D105890 that was just landed to touch the same > area. Yeah, I think it fixed the actual warning but we can still simplify the condition. Reposito

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

Anastasia added a subscriber: azabaznov. Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:329 #endif // defined(__opencl_c_atomic_scope_all_devices) -#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) +#if defined(cl_intel_subgroups) || de

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Anastasia added a comment. This seems reasonable. Comment at: clang/test/SemaOpenCL/null_literal.cl:7 #define NULL ((void*)0) I think we should remove this `NULL` definition but instead add `-finclude-default-header -fdeclare-opencl-builtins` to test the

[PATCH] D112404: [SPIR-V] Add translator tool

Anastasia added a comment. This direction of creating a common translator tool makes sense to me! Thanks! Comment at: clang/include/clang/Driver/Options.td:1534 +HelpText<"Specify maximum SPIR-V version which can be emitted">; +def spirv_ext_EQ : CommaJoined<["--"], "spirv-

[PATCH] D112410: [SPIR-V] Add a tool chain for SPIR-V (incomplete)

Anastasia added a comment. Cool. I like the direction... In the end it probably makes sense to separate clang compilation flow into more separate steps. This makes it more suitable to non-LLVM based backends or even MLIR towards Clang Intermediate Language. This looks like a fairly good startin

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6844 // scope. + // OpenCL v2.0 s6.5.1: + // Variables defined at program scope and static variables inside a function To make things concise I would suggest dropping OpenCL v2.0 quote

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. In D109144#3066194 , @linjamaki wrote: >> Thanks for the clarifications. So it seems that you are not expecting that >> the device target triple is being explicitly passed anywhere then and that >> means you pass the device tr

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. linjamaki wrote: > Anastasia wro

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/invalid-types.cl:5 +// Test declare "Other Data Type" variables in program scope. +global queue_t qt; // expected-error {{the '__global queue_t' type cannot be used to declare a program scope variable}} + ---

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anastasia added a comment. In D112230#3078231 , @azabaznov wrote: > @Anastasia, @yaxunl, do you think it's possible to refactor code generation > for blocks such that block literal for global blocks (with no captures) would > be emitted in constant addr

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa10a69fe9c74: [SPIR-V] Add SPIR-V triple and clang target info. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. FYI the original RFC is https://lists.llvm.org/pipermail/cfe-dev/2021-August/068603.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 ___

[PATCH] D110036: [TargetInfo][LangOpts] Refactor target info and language options adjustment.

Anastasia added a comment. Just to elaborate on the problem that is being solved. We have ended up with cycling dependencies between `LangOptions` and `TargetInfo` i.e. some language options became dependent on the target and vice versa. The quick solution has always been to mutate the target a

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

Anastasia added a comment. Ping, @Topotuna do you still plan to commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110184/new/ https://reviews.llvm.org/D110184 ___ cfe-commits mailing list cfe-co

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia updated this revision to Diff 327199. Anastasia added a comment. - Added suggestions from Sven and Marco. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97072/new/ https://reviews.llvm.org/D97072 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst =

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia marked 13 inline comments as done. Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:221 +triggers in the parsing) should not be added to clang. Moreover, the acceptable +behavior of pragmas should provide useful functionality to the user. +

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia updated this revision to Diff 327204. Anastasia added a comment. - Reorder fields, - make constructor parameters explicit - use `insert_or_assign` member of `StringMap`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 Files: clang/in

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added a comment. In D97052#2587043 , @azabaznov wrote: > I see the update regaring this functionality on github issue: > https://github.com/KhronosGroup/OpenCL-Docs/issues/82#issuecomment-785496025. > Is it a right way to reflect this informati

<    6   7   8   9   10   11   12   13   14   15   >