[PATCH] D103899: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44f197e94b83: [OpenMP] Fix C-only clang assert on parsing use_allocator clause of target… (authored by ABataev). Herald added a project: clang. Heral

[PATCH] D104240: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e155608796b: [OPENMP][C++20]Add support for CXXRewrittenBinaryOperator in ranged for loops. (authored by ABataev). Repository: rG LLVM Github Mon

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

ABataev created this revision. ABataev added reviewers: lebedev.ri, jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to capture locals in aligned clauses for the combined direc

[PATCH] D104258: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG45ae766e78e0: [OPENMP]Fix PR50699: capture locals in combine directrives for aligned clause. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. We used this kind of codegen initially but later found out that it causes a large overhead when gathering pointers into a record. What about hybrid scheme where the first args are passed as arguments and others (if any) are gathered into a record? Repository: rG LLV

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2823706 , @jdoerfert wrote: > In D102107#2821976 , @ABataev wrote: > >> We used this kind of codegen initially but later found out that it causes a >> large overhead when gathe

[PATCH] D103793: [Clang][OpenMP] Monotonic does not apply to SIMD

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103793/new/ https://reviews.llvm.org/D103793 ___

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2832286 , @jdoerfert wrote: > In D102107#2824581 , @ABataev wrote: > >> In D102107#2823706 , @jdoerfert >> wrote: >> >>> In D102107#28

[PATCH] D107200: Stop emit incomplete type error for a variable in an omp map clause where should not.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18446 bool FullCheck = true) { - NamedDecl *ND; - if (QTy->isIncompleteType(&ND))

[PATCH] D107385: Fix signal during the call to checkOpenMPLoop.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107385/new/ https://reviews.llvm.org/D107385 ___

[PATCH] D107666: [OpenMP] Fix accidental reuse of VLA size

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107666/new/ https://reviews.llvm.org/D107666 ___

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:2382-2385 +def fopenmp_extensions : Flag<["-"], "fopenmp-extensions">, Group, + Flags<[CC1Option, NoArgumentUnused]>; +def fno_openmp_extensions : Flag<["-"], "fno-openmp-exte

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown; jdenny wrote: > ABataev wro

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:64 + return OMPC_MAP_MODIFIER_unknown; +if (!LangOpts.OpenMPExtensions && Type == OMPC_MAP_MODIFIER_ompx_hold) return OMPC_MAP_MODIFIER_unknown; jdenny wrote: > ABataev wro

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2042-2044 +.. option:: -fopenmp-extensions, -fno-openmp-extensions + +Enable all Clang extensions for OpenMP directives and clauses. Default value? Comment at:

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:2383 +defm openmp_extensions: BoolFOption<"openmp-extensions", + LangOpts<"OpenMPExtensions">, DefaultFalse, + PosFlag ABataev wrote: > > Why do you want to disable it by default? > I thought that'

[PATCH] D106509: [OpenMP][OpenACC] Implement `ompx_hold` map type modifier extension in Clang (1/2)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106509/new/ https://reviews.llvm.org/D106509 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. Why it can not be performed in codegen? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. Also, would be good to see a runtime test, which reveals the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___ cfe-commits mai

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. In D108132#2947053 , @jyu2 wrote: > Hi ABataev, > Thanks for reviedw. > > In D108132#2946927 , @ABataev wrote: > >> Why it can not be performed in codegen? > > I am not sure I can do that

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added a comment. In D108132#2947080 , @jyu2 wrote: >>> I am not sure I can do that. Do you mean when generate map adding coding >>> code to look though reduction clause and generate map for it? > > > >> Yes, exactly. > > We are missing mappable c

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); `isa`. Also, what if this is a `MemberExpr`? Co

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); jyu2 wrote: > ABataev wrote: > > `isa`. Also, what if this is a `M

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:19481-19482 if (VD && DSAS->isThreadPrivate(VD)) { + if (NoDiagnose) +continue; DSAStackTy::DSAVarData DVar = DSAS->getTopDSA(VD, /*FromParent=*/false); jyu2 wrote:

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 ___

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev created this revision. ABataev added reviewers: mikerice, jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a project: clang. Currently the last value of linear is calculated as var = init + num_iters * step. Replaced it with va

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Changed the we handle llvm::Constants in sizes arrays. ConstExprs

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

ABataev created this revision. ABataev added reviewers: jdoerfert, vzakharin, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Current implementation is not compatible with asynchron

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

ABataev updated this revision to Diff 356715. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105375/new/ https://reviews.llvm.org/D105375 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRun

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 356726. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 356737. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 356752. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_code

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 356766. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3c80dd8943a: [OPENMP]Remove const firstprivate allocation as a variable in a constant space. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice, abhinavgaba. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. If the base is used in a map clause and later we have

[PATCH] D105647: [OPENMP]Do no privatize const firstprivates in target regions.

ABataev created this revision. ABataev added reviewers: jdoerfert, jhuber6. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. No need to emit private copyfor firstprivate constants in target re

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

ABataev added a comment. In D105375#2864733 , @jhuber6 wrote: > This revision causes a bug with generic regions. Firstprivate constants now > aren't mapped properly into an internal parallel region and will just be > zero. For example if I run this code

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2803-2808 + bool MaybeParseCXX11Attributes(ParsedAttributesWithRange &Attrs, + SourceLocation *EndLoc = nullptr, bool OuterMightBeMessa

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Another place to make the same comment :D I wonder

[PATCH] D105647: [OPENMP]Do no privatize const firstprivates in target regions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf57d396dcab2: [OPENMP]Do no privatize const firstprivates in target regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added a comment. Looks good, in general, just pre-commit formatting changes. Comment at: clang/lib/Basic/Attributes.cpp:27 + if (LangOpts.OpenMP >= 51 && ScopeName == "omp") +return Name == "directive" || Name == "sequence"; + Better to return int

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWithPragmas, but in + // this case, it came from an *att

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but wait for others' comments/suggestions/etc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 __

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

ABataev updated this revision to Diff 357532. ABataev added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Rebase + added runtime test intended to be fixed by the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2867382 , @jdoerfert wrote: > In D102107#2832740 , @ABataev wrote: > >> In D102107#2832286 , @jdoerfert >> wrote: >> >>> In D102107#28

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2867670 , @josemonsalve2 wrote: > In D102107#2867417 , @ABataev wrote: > >> In D102107#2867382 , @jdoerfert >> wrote: >> >>> In D1021

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab8989ab8710: [OPENMP]Fix overlapped mapping for dereferenced pointer members. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 357608. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 357612. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_code

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 357613. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 357616. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D105876: OMPIRBuilder for Interop directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6310-6311 + int DependClauseCount = 0; + for (const auto *DC : S.getClausesOfKind()) +DependClauseCount++; + assert(DependClauseCount <= 1 && "Multiple OMPDependClause not supported."); -

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2874123 , @jdoerfert wrote: > In D102107#2867693 , @ABataev wrote: > >> In D102107#2867670 , >> @josemonsalve2 wrote: >> >>> In D10210

[PATCH] D105876: OMPIRBuilder for Interop directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6348-6352 + } else if(HaveNowaitClause == true) { +assert("Nowait clause is used separately in OMPInteropDirective."); } else { -llvm_unreachable("Missing Interop clauses."); +assert("Un

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:334 +/// value of 8. +class OMPAlignClause : public OMPClause { + friend class OMPClauseReader; `final` Comment at: clang/include/clang/AST/OpenMPClause.h:362-36

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112577/new/ https://reviews.llvm.org/D112577 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0caf736d7e1d: [OPENMP50]Mapping of the subcomponents with the 'default' mappers. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D97945: [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file.

ABataev created this revision. ABataev added reviewers: jdoerfert, mibintc. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. If the file in line directive does not exist on the system we need,

[PATCH] D97945: [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG711179b5816a: [OPENMP]Fix PR48759: "fatal error" when compile with preprocessed file. (authored by ABataev). Repository: rG LLVM Github Monorepo

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. There is a problem. We actually do not emit `S` here directly, instead, we use `CodeGen` lambdas, which may not be equal to `S`, in some cases `S` is `nullptr` here. It may result in not quite accurate results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. In D98135#2617446 , @lxfind wrote: > In D98135#2617432 , @ABataev wrote: > >> There is a problem. We actually do not emit `S` here directly, instead, we >> use `CodeGen` lambdas, which may

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98135/new/ https://reviews.llvm.org/D98135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

ABataev added a comment. In D102449#3137713 , @carlo.bertolli wrote: > This is already a lot of code with parse+sema. I wonder if we should split > the patch into two, i.e. 1. parse+sema; 2. code gen? @ABataev ? > It should simplify maintenance of the p

[PATCH] D113540: [OpenMP] support depend clause for taskwait directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80256605f8c6: [OpenMP] support depend clause for taskwait directive, by Deepak (authored by ABataev). Herald added projects: clang, OpenMP. Herald ad

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to do the analysis of the captured expressions in the clauses

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to postpone anlysis of the ranged for loops till the actual i

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to postpone analysis for addressable lvalue in a depend claus

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

ABataev updated this revision to Diff 390714. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114560/new/ https://reviews.llvm.org/D114560 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_loop_auto.cpp

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

ABataev updated this revision to Diff 390716. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114546/new/ https://reviews.llvm.org/D114546 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/Analysis/cfg-openmp.cpp

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

ABataev updated this revision to Diff 390718. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114653/new/ https://reviews.llvm.org/D114653 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_enter_data_d

[PATCH] D114776: [clang-offload-bundler] Reuse original file extension for device archive member

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114776/new/ https://reviews.llvm.org/D114776 ___

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG wit a nit Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1567 +} else + AggregatePtr = llvm::Constant::getNullValue(OMPBuilder.VoidPtr); ---

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9036f2eb42d: [OPENMP]Fix error emission for dependent expressions in iterators for depend… (authored by ABataev). Repository: rG LLVM Github Mono

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0839c13fd32: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a… (authored by ABataev). Repository: rG LLVM Github Monore

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a2c7a241099: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6279562dae4: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct. (authored by ABataev). Repository: rG LLVM Github Monor

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9073 SmallVector DeclComponentLists; +if (DevPointersMap.count(VD)) { + // For member fields list in is_device_ptr, store it in If VD is nullptr, why do we need this ch

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9076 +// DeclComponentLists for generating components info. +auto It = DevPointersMap.find(VD); +if (It != DevPointersMap.end()) VD is still nullptr here, why do we need

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9080 +DeclComponentLists.emplace_back( +MCL, OMPC_MAP_to, OMPC_MAP_MODIFIER_unknown, /*IsImpicit = */ true, +nullptr, nullptr); Shall it be `OMP_MAP_L

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

ABataev added inline comments. Comment at: clang/test/OpenMP/target_is_device_ptr_codegen.cpp:296 +// CK2-DAG: [[A8:%.*]] = getelementptr inbounds [[STRUCT_ST]], %struct.ST* [[THIS1]], i32 0, i32 0 +// CK2-DAG: [[B9:%.*]] = getelementptr inbounds [[STRUCT_ST]], %struct.ST* [[TH

[PATCH] D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129608/new/ https://reviews.llvm.org/D129608 ___

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

ABataev added a comment. Add clang unit tests, please Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132209/new/ https://reviews.llvm.org/D132209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132209/new/ https://reviews.llvm.org/D132209 ___

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

ABataev added a comment. In D132209#3741110 , @yutsumi wrote: > @ABataev , could you please commit this patch because I don't have commit > access yet? > My git user name and email address: Yuichiro Utsumi > (utsumi.yuich...@fujitsu.com) > > Thank you f

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e2caea37f4b: [Clang][OpenMP] Make copyin clause on combined and composite construct work… (authored by yutsumi, committed by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134186/new/ https://reviews.llvm.org/D134186 ___

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:19 #include "clang/Basic/LLVM.h" +#include "clang/AST/StmtOpenMP.h" // #include "clang/Basic/OpenMPKinds.h" Remove empty comment Comment at: clang/lib/AST/OpenMPClause.

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8561-8617 for (const auto *Cl : Clauses) { const auto *C = dyn_cast(Cl); if (!C) continue; for (const auto L : C->component_lists()) { OMPClauseMappableExp

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134556/new/ https://reviews.llvm.org/D134556 ___

[PATCH] D135224: [Clang][OpenMP] Only check value if the expression is not instantiation dependent

ABataev added a comment. Test is needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135224/new/ https://reviews.llvm.org/D135224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D135224: [Clang][OpenMP] Only check value if the expression is not instantiation dependent

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135224/new/ https://reviews.llvm.org/D135224 ___

[PATCH] D135236: [Clang][OpenMP] Add one missing form of atomic compare capture

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135236/new/ https://reviews.llvm.org/D135236 ___

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

ABataev accepted this revision. ABataev added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8490 +if (MD) + if (const CXXRecordDecl *RD = dyn_cast(MD->getParent())) +HasBaseClass = RD->getNumBases() > 0; `const auto *RD = dyn_cast(MD->getParent())`. Also, c

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350 ___

[PATCH] D137209: [OPENMP]Initial support for error directive.

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:6229 +/// \endcode +class OMPErrorDirective : public OMPExecutableDirective { + friend class ASTStmtReader; final Comment at: llvm/include/llvm/Frontend/OpenMP/OMP

[PATCH] D137209: [OPENMP]Initial support for error directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137209/new/ https://reviews.llvm.org/D137209 ___

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev added a comment. Whyt it is NFC? I assume it fixes the dereferencing of references, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 ___ cfe-commi

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev added a comment. Do we have a runtime test for this? Would be good to try to test it if the offloading fails and the host version is executed instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D1373

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev added a comment. In D137313#3906527 , @jyu2 wrote: > In D137313#3906487 , @ABataev wrote: > >> Do we have a runtime test for this? Would be good to try to test it if the >> offloading fails and the host v

<    8   9   10   11   12   13   14   15   16   17   >